]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_confirm.php
More "LIMIT 1" removed - and some other SQL improvements.
[friendica.git] / mod / dfrn_confirm.php
index 5a24f00893b493e34ea1fff755375b6126bf3622..8e1fc76e9a76ac9b8d856cbdb6de6fac37ce715f 100644 (file)
@@ -52,7 +52,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                if(! $uid) {
                        notice( t('Permission denied.') . EOL );
                        return;
-               }       
+               }
 
                $user = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1",
                        intval($uid)
@@ -61,7 +61,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                if(! $user) {
                        notice( t('Profile not found.') . EOL );
                        return;
-               }       
+               }
 
 
                // These data elements may come from either the friend request notification form or $handsfree array.
@@ -107,7 +107,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                 *
                 */
 
-               $r = q("SELECT * FROM `contact` WHERE ( ( `issued-id` != '' AND `issued-id` = '%s' ) OR ( `id` = %d AND `id` != 0 ) ) AND `uid` = %d LIMIT 1",
+               $r = q("SELECT * FROM `contact` WHERE ( ( `issued-id` != '' AND `issued-id` = '%s' ) OR ( `id` = %d AND `id` != 0 ) ) AND `uid` = %d AND `duplex` = 0 LIMIT 1",
                        dbesc($dfrn_id),
                        intval($cid),
                        intval($uid)
@@ -116,6 +116,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                if(! count($r)) {
                        logger('dfrn_confirm: Contact not found in DB.'); 
                        notice( t('Contact not found.') . EOL );
+                       notice( t('This may occasionally happen if contact was requested by both persons and it has already been approved.') . EOL );
                        return;
                }
 
@@ -143,23 +144,16 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                         * worried about key leakage than anybody cracking it.  
                         *
                         */
+                       require_once('include/crypto.php');
 
-                       $res = openssl_pkey_new(array(
-                               'digest_alg' => 'sha1',
-                               'private_key_bits' => 4096,
-                               'encrypt_key' => false )
-                       );
-
-                       $private_key = '';
-
-                       openssl_pkey_export($res, $private_key);
+                       $res = new_keypair(4096);
 
-                       $pubkey = openssl_pkey_get_details($res);
-                       $public_key = $pubkey["key"];
+                       $private_key = $res['prvkey'];
+                       $public_key  = $res['pubkey'];
 
                        // Save the private key. Send them the public key.
 
-                       $r = q("UPDATE `contact` SET `prvkey` = '%s' WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                       $r = q("UPDATE `contact` SET `prvkey` = '%s' WHERE `id` = %d AND `uid` = %d",
                                dbesc($private_key),
                                intval($contact_id),
                                intval($uid) 
@@ -206,6 +200,11 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        if($duplex == 1)
                                $params['duplex'] = 1;
 
+                       if($user[0]['page-flags'] == PAGE_COMMUNITY)
+                               $params['page'] = 1;
+                       if($user[0]['page-flags'] == PAGE_PRVGROUP)
+                               $params['page'] = 2;
+
                        logger('dfrn_confirm: Confirm: posting data to ' . $dfrn_confirm . ': ' . print_r($params,true), LOGGER_DATA);
 
                        /**
@@ -259,7 +258,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                case 1:
                                        // birthday paradox - generate new dfrn-id and fall through.
                                        $new_dfrn_id = random_string();
-                                       $r = q("UPDATE contact SET `issued-id` = '%s' WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                                       $r = q("UPDATE contact SET `issued-id` = '%s' WHERE `id` = %d AND `uid` = %d",
                                                dbesc($new_dfrn_id),
                                                intval($contact_id),
                                                intval($uid) 
@@ -280,17 +279,17 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                }
 
                        if(($status == 0) && ($intro_id)) {
-       
+
                                // Success. Delete the notification.
-       
-                               $r = q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d LIMIT 1",
+
+                               $r = q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d",
                                        intval($intro_id),
                                        intval($uid)
                                );
-                               
+
                        }
 
-                       if($status != 0) 
+                       if($status != 0)
                                return;
                }
 
@@ -320,19 +319,19 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        if(($relation == CONTACT_IS_SHARING) && ($duplex))
                                $duplex = 0;
 
-                       $r = q("UPDATE `contact` SET 
-                               `photo` = '%s', 
+                       $r = q("UPDATE `contact` SET
+                               `photo` = '%s',
                                `thumb` = '%s',
-                               `micro` = '%s', 
-                               `rel` = %d, 
-                               `name-date` = '%s', 
-                               `uri-date` = '%s', 
-                               `avatar-date` = '%s', 
-                               `blocked` = 0, 
+                               `micro` = '%s',
+                               `rel` = %d,
+                               `name-date` = '%s',
+                               `uri-date` = '%s',
+                               `avatar-date` = '%s',
+                               `blocked` = 0,
                                `pending` = 0,
                                `duplex` = %d,
                                `hidden` = %d,
-                               `network` = 'dfrn' WHERE `id` = %d LIMIT 1
+                               `network` = 'dfrn' WHERE `id` = %d
                        ",
                                dbesc($photos[0]),
                                dbesc($photos[1]),
@@ -346,7 +345,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                intval($contact_id)
                        );
                }
-               else {  
+               else {
 
                        // $network !== NETWORK_DFRN
 
@@ -379,27 +378,27 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                        $writable = 1;
                        }
 
-                       $r = q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                       $r = q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d",
                                intval($intro_id),
                                intval($uid)
                        );
 
 
-                       $r = q("UPDATE `contact` SET `photo` = '%s', 
+                       $r = q("UPDATE `contact` SET `photo` = '%s',
                                `thumb` = '%s',
-                               `micro` = '%s', 
-                               `name-date` = '%s', 
-                               `uri-date` = '%s', 
-                               `avatar-date` = '%s', 
+                               `micro` = '%s',
+                               `name-date` = '%s',
+                               `uri-date` = '%s',
+                               `avatar-date` = '%s',
                                `notify` = '%s',
                                `poll` = '%s',
-                               `blocked` = 0, 
+                               `blocked` = 0,
                                `pending` = 0,
                                `network` = '%s',
                                `writable` = %d,
                                `hidden` = %d,
                                `rel` = %d
-                               WHERE `id` = %d LIMIT 1
+                               WHERE `id` = %d
                        ",
                                dbesc($photos[0]),
                                dbesc($photos[1]),
@@ -414,7 +413,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                intval($hidden),
                                intval($new_relation),
                                intval($contact_id)
-                       );                      
+                       );
                }
 
                if($r === false)
@@ -430,7 +429,8 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                else
                        $contact = null;
 
-               if(isset($new_relation) && $new_relation == CONTACT_IS_FRIEND) {
+
+               if((isset($new_relation) && $new_relation == CONTACT_IS_FRIEND)) {
 
                        if(($contact) && ($contact['network'] === NETWORK_DIASPORA)) {
                                require_once('include/diaspora.php');
@@ -443,7 +443,8 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        $r = q("SELECT `hide-friends` FROM `profile` WHERE `uid` = %d AND `is-default` = 1 LIMIT 1",
                                intval($uid)
                        );
-                       if((count($r)) && ($activity) && (! $hidden)) {
+
+                       if((count($r)) && ($r[0]['hide-friends'] == 0) && ($activity) && (! $hidden)) {
 
                                require_once('include/items.php');
 
@@ -464,12 +465,15 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                        $arr['author-name'] = $arr['owner-name'] = $self[0]['name'];
                                        $arr['author-link'] = $arr['owner-link'] = $self[0]['url'];
                                        $arr['author-avatar'] = $arr['owner-avatar'] = $self[0]['thumb'];
-                                       $arr['verb'] = ACTIVITY_FRIEND;
-                                       $arr['object-type'] = ACTIVITY_OBJ_PERSON;
-                               
+
                                        $A = '[url=' . $self[0]['url'] . ']' . $self[0]['name'] . '[/url]';
+                                       $APhoto = '[url=' . $self[0]['url'] . ']' . '[img]' . $self[0]['thumb'] . '[/img][/url]';
+
                                        $B = '[url=' . $contact['url'] . ']' . $contact['name'] . '[/url]';
                                        $BPhoto = '[url=' . $contact['url'] . ']' . '[img]' . $contact['thumb'] . '[/img][/url]';
+
+                                       $arr['verb'] = ACTIVITY_FRIEND;
+                                   $arr['object-type'] = ACTIVITY_OBJ_PERSON;
                                        $arr['body'] =  sprintf( t('%1$s is now friends with %2$s'), $A, $B)."\n\n\n".$BPhoto;
 
                                        $arr['object'] = '<object><type>' . ACTIVITY_OBJ_PERSON . '</type><title>' . $contact['name'] . '</title>'
@@ -477,6 +481,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                        $arr['object'] .= '<link>' . xmlify('<link rel="alternate" type="text/html" href="' . $contact['url'] . '" />' . "\n");
                                        $arr['object'] .= xmlify('<link rel="photo" type="image/jpeg" href="' . $contact['thumb'] . '" />' . "\n");
                                        $arr['object'] .= '</link></object>' . "\n";
+
                                        $arr['last-child'] = 1;
 
                                        $arr['allow_cid'] = $user[0]['allow_cid'];
@@ -490,13 +495,23 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                }
                        }
                }
+
+
+               $g = q("select def_gid from user where uid = %d limit 1",
+                       intval($uid)
+               );
+               if($contact && $g && intval($g[0]['def_gid'])) {
+                       require_once('include/group.php');
+                       group_add_member($uid,'',$contact['id'],$g[0]['def_gid']);
+               }
+
                // Let's send our user to the contact editor in case they want to
                // do anything special with this new friend.
 
                if($handsfree === null)
                        goaway($a->get_baseurl() . '/contacts/' . intval($contact_id));
                else
-                       return;  
+                       return;
                //NOTREACHED
        }
 
@@ -521,8 +536,12 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                $source_url = ((x($_POST,'source_url'))   ? hex2bin($_POST['source_url'])  : '');
                $aes_key    = ((x($_POST,'aes_key'))      ? $_POST['aes_key']              : '');
                $duplex     = ((x($_POST,'duplex'))       ? intval($_POST['duplex'])       : 0 );
+               $page       = ((x($_POST,'page'))         ? intval($_POST['page'])         : 0 );
                $version_id = ((x($_POST,'dfrn_version')) ? (float) $_POST['dfrn_version'] : 2.0);
-       
+
+               $forum = (($page == 1) ? 1 : 0);
+               $prv   = (($page == 2) ? 1 : 0);
+
                logger('dfrn_confirm: requestee contacted: ' . $node);
 
                logger('dfrn_confirm: request: POST=' . print_r($_POST,true), LOGGER_DATA);
@@ -621,7 +640,7 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        // NOTREACHED
                }
 
-               $r = q("UPDATE `contact` SET `dfrn-id` = '%s', `pubkey` = '%s' WHERE `id` = %d LIMIT 1",
+               $r = q("UPDATE `contact` SET `dfrn-id` = '%s', `pubkey` = '%s' WHERE `id` = %d",
                        dbesc($decrypted_dfrn_id),
                        dbesc($dfrn_pubkey),
                        intval($dfrn_record)
@@ -631,6 +650,15 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        xml_status(3,$message);
                }
 
+               // It's possible that the other person also requested friendship.
+               // If it is a duplex relationship, ditch the issued-id if one exists.
+
+               if($duplex) {
+                       $r = q("UPDATE `contact` SET `issued-id` = '' WHERE `id` = %d",
+                               intval($dfrn_record)
+                       );
+               }
+
                // We're good but now we have to scrape the profile photo and send notifications.
 
 
@@ -641,9 +669,9 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                if(count($r))
                        $photo = $r[0]['photo'];
                else
-                       $photo = $a->get_baseurl() . '/images/default-profile.jpg';
-                               
-               require_once("Photo.php");
+                       $photo = $a->get_baseurl() . '/images/person-175.jpg';
+
+               require_once("include/Photo.php");
 
                $photos = import_profile_photo($photo,$local_uid,$dfrn_record);
 
@@ -656,18 +684,20 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                if(($relation == CONTACT_IS_FOLLOWER) && ($duplex))
                        $duplex = 0;
 
-               $r = q("UPDATE `contact` SET 
-                       `photo` = '%s', 
-                       `thumb` = '%s', 
+               $r = q("UPDATE `contact` SET
+                       `photo` = '%s',
+                       `thumb` = '%s',
                        `micro` = '%s',
-                       `rel` = %d, 
-                       `name-date` = '%s', 
-                       `uri-date` = '%s', 
-                       `avatar-date` = '%s', 
-                       `blocked` = 0, 
+                       `rel` = %d,
+                       `name-date` = '%s',
+                       `uri-date` = '%s',
+                       `avatar-date` = '%s',
+                       `blocked` = 0,
                        `pending` = 0,
-                       `duplex` = %d, 
-                       `network` = '%s' WHERE `id` = %d LIMIT 1
+                       `duplex` = %d,
+                       `forum` = %d,
+                       `prv` = %d,
+                       `network` = '%s' WHERE `id` = %d
                ",
                        dbesc($photos[0]),
                        dbesc($photos[1]),
@@ -677,6 +707,8 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        dbesc(datetime_convert()),
                        dbesc(datetime_convert()),
                        intval($duplex),
+                       intval($forum),
+                       intval($prv),
                        dbesc(NETWORK_DFRN),
                        intval($dfrn_record)
                );
@@ -694,13 +726,17 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        WHERE `contact`.`id` = %d LIMIT 1",
                        intval($dfrn_record)
                );
+
+               if(count($r))
+                       $combined = $r[0];
+
                if((count($r)) && ($r[0]['notify-flags'] & NOTIFY_CONFIRM)) {
 
                        push_lang($r[0]['language']);
-                       $tpl = (($new_relation == CONTACT_IS_FRIEND) 
+                       $tpl = (($new_relation == CONTACT_IS_FRIEND)
                                ? get_intltext_template('friend_complete_eml.tpl')
                                : get_intltext_template('intro_complete_eml.tpl'));
-               
+
                        $email_tpl = replace_macros($tpl, array(
                                '$sitename' => $a->config['sitename'],
                                '$siteurl' =>  $a->get_baseurl(),
@@ -710,10 +746,11 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                                '$dfrn_url' => $r[0]['url'],
                                '$uid' => $newuid )
                        );
-       
-                       $res = mail($r[0]['email'], sprintf( t("Connection accepted at %s") , $a->config['sitename']),
+                       require_once('include/email.php');
+
+                       $res = mail($r[0]['email'], email_header_encode( sprintf( t("Connection accepted at %s") , $a->config['sitename']),'UTF-8'),
                                $email_tpl,
-                               'From: ' . t('Administrator') . '@' . $_SERVER['SERVER_NAME'] . "\n"
+                               'From: ' . 'Administrator' . '@' . $_SERVER['SERVER_NAME'] . "\n"
                                . 'Content-type: text/plain; charset=UTF-8' . "\n"
                                . 'Content-transfer-encoding: 8bit' );
 
@@ -722,6 +759,65 @@ function dfrn_confirm_post(&$a,$handsfree = null) {
                        }
                        pop_lang();
                }
+
+               // Send a new friend post if we are allowed to...
+
+               if($page && intval(get_pconfig($local_uid,'system','post_joingroup'))) {
+                       $r = q("SELECT `hide-friends` FROM `profile` WHERE `uid` = %d AND `is-default` = 1 LIMIT 1",
+                               intval($local_uid)
+                       );
+
+                       if((count($r)) && ($r[0]['hide-friends'] == 0)) {
+
+                               require_once('include/items.php');
+
+                               $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
+                                       intval($local_uid)
+                               );
+
+                               if(count($self)) {
+
+                                       $arr = array();
+                                       $arr['uri'] = $arr['parent-uri'] = item_new_uri($a->get_hostname(), $local_uid); 
+                                       $arr['uid'] = $local_uid;
+                                       $arr['contact-id'] = $self[0]['id'];
+                                       $arr['wall'] = 1;
+                                       $arr['type'] = 'wall';
+                                       $arr['gravity'] = 0;
+                                       $arr['origin'] = 1;
+                                       $arr['author-name'] = $arr['owner-name'] = $self[0]['name'];
+                                       $arr['author-link'] = $arr['owner-link'] = $self[0]['url'];
+                                       $arr['author-avatar'] = $arr['owner-avatar'] = $self[0]['thumb'];
+
+                                       $A = '[url=' . $self[0]['url'] . ']' . $self[0]['name'] . '[/url]';
+                                       $APhoto = '[url=' . $self[0]['url'] . ']' . '[img]' . $self[0]['thumb'] . '[/img][/url]';
+
+                                       $B = '[url=' . $combined['url'] . ']' . $combined['name'] . '[/url]';
+                                       $BPhoto = '[url=' . $combined['url'] . ']' . '[img]' . $combined['thumb'] . '[/img][/url]';
+
+                                       $arr['verb'] = ACTIVITY_JOIN;
+                                       $arr['object-type'] = ACTIVITY_OBJ_GROUP;
+                                       $arr['body'] =  sprintf( t('%1$s has joined %2$s'), $A, $B)."\n\n\n" .$BPhoto;
+                                       $arr['object'] = '<object><type>' . ACTIVITY_OBJ_GROUP . '</type><title>' . $combined['name'] . '</title>'
+                                               . '<id>' . $combined['url'] . '/' . $combined['name'] . '</id>';
+                                       $arr['object'] .= '<link>' . xmlify('<link rel="alternate" type="text/html" href="' . $combined['url'] . '" />' . "\n");
+                                       $arr['object'] .= xmlify('<link rel="photo" type="image/jpeg" href="' . $combined['thumb'] . '" />' . "\n");
+                                       $arr['object'] .= '</link></object>' . "\n";
+
+                                       $arr['last-child'] = 1;
+
+                                       $arr['allow_cid'] = $user[0]['allow_cid'];
+                                       $arr['allow_gid'] = $user[0]['allow_gid'];
+                                       $arr['deny_cid']  = $user[0]['deny_cid'];
+                                       $arr['deny_gid']  = $user[0]['deny_gid'];
+
+                                       $i = item_store($arr);
+                                       if($i)
+                                       proc_run('php',"include/notifier.php","activity","$i");
+
+                               }
+                       }
+               }
                xml_status(0); // Success
                return; // NOTREACHED