]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_notify.php
Fix spaces around t() and tt()
[friendica.git] / mod / dfrn_notify.php
index e4aabba5a1626af7a7b293e4790e20384b910253..3a75123a52a88f6830bf1c2387ae10dc0cb17f5e 100644 (file)
@@ -2,8 +2,6 @@
 
 require_once('simplepie/simplepie.inc');
 require_once('include/items.php');
-
-
 function dfrn_notify_post(&$a) {
 
        $dfrn_id      = ((x($_POST,'dfrn_id'))      ? notags(trim($_POST['dfrn_id']))   : '');
@@ -11,6 +9,7 @@ function dfrn_notify_post(&$a) {
        $challenge    = ((x($_POST,'challenge'))    ? notags(trim($_POST['challenge'])) : '');
        $data         = ((x($_POST,'data'))         ? $_POST['data']                    : '');
        $key          = ((x($_POST,'key'))          ? $_POST['key']                     : '');
+       $dissolve     = ((x($_POST,'dissolve'))     ? intval($_POST['dissolve'])        :  0);
 
        $direction = (-1);
        if(strpos($dfrn_id,':') == 1) {
@@ -23,7 +22,7 @@ function dfrn_notify_post(&$a) {
                dbesc($challenge)
        );
        if(! count($r)) {
-               logger('dfrn_notify: could not match challenge to dfrn_id ' . $dfrn_id);
+               logger('dfrn_notify: could not match challenge to dfrn_id ' . $dfrn_id . ' challenge=' . $challenge);
                xml_status(3);
        }
 
@@ -51,11 +50,17 @@ function dfrn_notify_post(&$a) {
        }
                 
 
-       $r = q("SELECT `contact`.*, `contact`.`uid` AS `importer_uid`, 
-               `contact`.`pubkey` AS `cpubkey`, `contact`.`prvkey` AS `cprvkey`, `user`.* FROM `contact` 
-               LEFT JOIN `user` ON `contact`.`uid` = `user`.`uid` 
-               WHERE `contact`.`blocked` = 0 AND `contact`.`pending` = 0 
-               AND `user`.`nickname` = '%s' $sql_extra LIMIT 1",
+       $r = q("SELECT  `contact`.*, `contact`.`uid` AS `importer_uid`, 
+                                       `contact`.`pubkey` AS `cpubkey`, 
+                                       `contact`.`prvkey` AS `cprvkey`, 
+                                       `contact`.`thumb` AS `thumb`, 
+                                       `contact`.`url` as `url`,
+                                       `contact`.`name` as `senderName`,
+                                       `user`.* 
+                       FROM `contact` 
+                       LEFT JOIN `user` ON `contact`.`uid` = `user`.`uid` 
+                       WHERE `contact`.`blocked` = 0 AND `contact`.`pending` = 0 
+                               AND `user`.`nickname` = '%s' $sql_extra LIMIT 1",
                dbesc($a->argv[1])
        );
 
@@ -65,17 +70,24 @@ function dfrn_notify_post(&$a) {
                //NOTREACHED
        }
 
+       // $importer in this case contains the contact record for the remote contact joined with the user record of our user. 
+
        $importer = $r[0];
 
        logger('dfrn_notify: received notify from ' . $importer['name'] . ' for ' . $importer['username']);
        logger('dfrn_notify: data: ' . $data, LOGGER_DATA);
 
-       if($importer['readonly']) {
-               // We aren't receiving stuff from this person. But we will quietly ignore them
-               // rather than a blatant "go away" message.
-               logger('dfrn_notify: ignoring');
+       if($dissolve == 1) {
+
+               /**
+                * Relationship is dissolved permanently
+                */
+
+               require_once('include/Contact.php'); 
+               contact_remove($importer['id']);
+               logger('relationship dissolved : ' . $importer['name'] . ' dissolved ' . $importer['username']);
                xml_status(0);
-               //NOTREACHED
+
        }
 
        if(strlen($key)) {
@@ -83,11 +95,21 @@ function dfrn_notify_post(&$a) {
                logger('rino: md5 raw key: ' . md5($rawkey));
                $final_key = '';
 
-               if((($importer['duplex']) && strlen($importer['cpubkey'])) || (! strlen($importer['cprvkey']))) {
-                       openssl_public_decrypt($rawkey,$final_key,$importer['cpubkey']);
+               if($dfrn_version >= 2.1) {
+                       if((($importer['duplex']) && strlen($importer['cprvkey'])) || (! strlen($importer['cpubkey']))) {
+                               openssl_private_decrypt($rawkey,$final_key,$importer['cprvkey']);
+                       }
+                       else {
+                               openssl_public_decrypt($rawkey,$final_key,$importer['cpubkey']);
+                       }
                }
                else {
-                       openssl_private_decrypt($rawkey,$final_key,$importer['cprvkey']);
+                       if((($importer['duplex']) && strlen($importer['cpubkey'])) || (! strlen($importer['cprvkey']))) {
+                               openssl_public_decrypt($rawkey,$final_key,$importer['cpubkey']);
+                       }
+                       else {
+                               openssl_private_decrypt($rawkey,$final_key,$importer['cprvkey']);
+                       }
                }
 
                logger('rino: received key : ' . $final_key);
@@ -95,6 +117,17 @@ function dfrn_notify_post(&$a) {
                logger('rino: decrypted data: ' . $data, LOGGER_DATA);
        }
 
+
+
+
+       if($importer['readonly']) {
+               // We aren't receiving stuff from this person. But we will quietly ignore them
+               // rather than a blatant "go away" message.
+               logger('dfrn_notify: ignoring');
+               xml_status(0);
+               //NOTREACHED
+       }
+
        // Consume notification feed. This may differ from consuming a public feed in several ways
        // - might contain email
        // - might contain remote followup to our message
@@ -140,29 +173,70 @@ function dfrn_notify_post(&$a) {
                require_once('bbcode.php');
                if($importer['notify-flags'] & NOTIFY_MAIL) {
 
-                       $body = html_entity_decode(strip_tags(bbcode(stripslashes($msg['body']))),ENT_QUOTES,'UTF-8');
-
-                       if(function_exists('quoted_printable_encode'))
-                               $body = quoted_printable_encode($body);
-                       else
-                               $body = qp($body);
-
-                       $tpl = load_view_file('view/mail_received_eml.tpl');                    
-                       $email_tpl = replace_macros($tpl, array(
-                               '$sitename' => $a->config['sitename'],
-                               '$siteurl' =>  $a->get_baseurl(),
-                               '$username' => $importer['username'],
-                               '$email' => $importer['email'],
-                               '$from' => $msg['from-name'],
-                               '$title' => stripslashes($msg['title']),
-                               '$body' => $body
+                       // name of the automated email sender
+                       $msg['notificationfromname']    = t('Administrator');
+                       // noreply address to send from
+                       $msg['notificationfromemail']   = t('noreply') . '@' . $a->get_hostname();                              
+
+                       // text version
+                       // process the message body to display properly in text mode
+                       //              1) substitute a \n character for the "\" then "n", so it behaves properly (it doesn't come in as a \n character)
+                       //              2) remove escape slashes
+                       //              3) decode any bbcode from the message editor
+                       //              4) decode any encoded html tags
+                       //              5) remove html tags
+                       $msg['textversion']
+                               = strip_tags(html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r", "\\n"), "\n",$msg['body']))),ENT_QUOTES,'UTF-8'));
+                               
+                       // html version
+                       // process the message body to display properly in text mode
+                       //              1) substitute a <br /> tag for the "\" then "n", so it behaves properly (it doesn't come in as a \n character)
+                       //              2) remove escape slashes
+                       //              3) decode any bbcode from the message editor
+                       //              4) decode any encoded html tags
+                       $msg['htmlversion']     
+                               = html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r","\\n\\n" ,"\\n"), "<br />\n",$msg['body']))));
+
+                       // load the template for private message notifications
+                       $tpl = load_view_file('view/mail_received_html_body_eml.tpl');
+                       $email_html_body_tpl = replace_macros($tpl,array(
+                               '$siteName'             => $a->config['sitename'],                              // name of this site
+                               '$siteurl'              => $a->get_baseurl(),                                   // descriptive url of this site
+                               '$thumb'                => $importer['thumb'],                                  // thumbnail url for sender icon
+                               '$email'                => $importer['email'],                                  // email address to send to
+                               '$url'                  => $importer['url'],                                    // full url for the site
+                               '$from'                 => $msg['from-name'],                                   // name of the person sending the message
+                               '$title'                => stripslashes($msg['title']),                 // subject of the message
+                               '$htmlversion'  => $msg['htmlversion'],                                 // html version of the message
+                               '$mimeboundary' => $msg['mimeboundary'],                                // mime message divider
+                               '$hostname'             => $a->get_hostname()                                   // name of this host
+                       ));
+                       
+                       // load the template for private message notifications
+                       $tpl = load_view_file('view/mail_received_text_body_eml.tpl');
+                       $email_text_body_tpl = replace_macros($tpl,array(
+                               '$siteName'             => $a->config['sitename'],                              // name of this site
+                               '$siteurl'              => $a->get_baseurl(),                                   // descriptive url of this site
+                               '$thumb'                => $importer['thumb'],                                  // thumbnail url for sender icon
+                               '$email'                => $importer['email'],                                  // email address to send to
+                               '$url'                  => $importer['url'],                                    // full url for the site
+                               '$from'                 => $msg['from-name'],                                   // name of the person sending the message
+                               '$title'                => stripslashes($msg['title']),                 // subject of the message
+                               '$textversion'  => $msg['textversion'],                                 // text version of the message
+                               '$mimeboundary' => $msg['mimeboundary'],                                // mime message divider
+                               '$hostname'             => $a->get_hostname()                                   // name of this host
                        ));
 
-                       $res = mail($importer['email'], t('New mail received at ') . $a->config['sitename'],
-                               $email_tpl, 'From: ' . t('Administrator') . '@' . $a->get_hostname() . "\r\n"
-                                       . 'MIME-Version: 1.0' . "\r\n"
-                                       . 'Content-type: text/plain; charset=UTF-8' . "\r\n" 
-                                       . 'Content-transfer-encoding: quoted-printable' . "\r\n"
+                       // use the EmailNotification library to send the message
+                       require_once("include/EmailNotification.php");
+                       EmailNotification::sendTextHtmlEmail(
+                               $msg['notificationfromname'],
+                               $msg['notificationfromemail'],
+                               $msg['notificationfromemail'],
+                               $importer['email'],
+                               t('New mail received at ') . $a->config['sitename'],
+                               $email_html_body_tpl,
+                               $email_text_body_tpl
                        );
                }
                xml_status(0);
@@ -171,68 +245,77 @@ function dfrn_notify_post(&$a) {
        
        logger('dfrn_notify: feed item count = ' . $feed->get_item_quantity());
 
-       foreach($feed->get_items() as $item) {
+       // process any deleted entries
+
+       $del_entries = $feed->get_feed_tags(NAMESPACE_TOMB, 'deleted-entry');
+       if(is_array($del_entries) && count($del_entries)) {
+               foreach($del_entries as $dentry) {
+                       $deleted = false;
+                       if(isset($dentry['attribs']['']['ref'])) {
+                               $uri = $dentry['attribs']['']['ref'];
+                               $deleted = true;
+                               if(isset($dentry['attribs']['']['when'])) {
+                                       $when = $dentry['attribs']['']['when'];
+                                       $when = datetime_convert('UTC','UTC', $when, 'Y-m-d H:i:s');
+                               }
+                               else
+                                       $when = datetime_convert('UTC','UTC','now','Y-m-d H:i:s');
+                       }
+                       if($deleted) {
+                               $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                       dbesc($uri),
+                                       intval($importer['importer_uid'])
+                               );
+                               if(count($r)) {
+                                       $item = $r[0];
 
-               $deleted = false;
+                                       if(! $item['deleted'])
+                                               logger('dfrn_notify: deleting item ' . $item['id'] . ' uri=' . $item['uri'], LOGGER_DEBUG);
 
-               $rawdelete = $item->get_item_tags( NAMESPACE_TOMB , 'deleted-entry');
-               if(isset($rawdelete[0]['attribs']['']['ref'])) {
-                       $uri = $rawthread[0]['attribs']['']['ref'];
-                       $deleted = true;
-                       if(isset($rawdelete[0]['attribs']['']['when'])) {
-                               $when = $rawthread[0]['attribs']['']['when'];
-                               $when = datetime_convert('UTC','UTC', $when, 'Y-m-d H:i:s');
-                       }
-                       else
-                               $when = datetime_convert('UTC','UTC','now','Y-m-d H:i:s');
-               }
-               if($deleted) {
-                       $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                               dbesc($uri),
-                               intval($importer['importer_uid'])
-                       );
-                       if(count($r)) {
-                               $item = $r[0];
-                               if($item['uri'] == $item['parent-uri']) {
-                                       $r = q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s'
-                                               WHERE `parent-uri` = '%s' AND `uid` = %d",
-                                               dbesc($when),
-                                               dbesc(datetime_convert()),
-                                               dbesc($item['uri']),
-                                               intval($importer['importer_uid'])
-                                       );
-                               }
-                               else {
-                                       $r = q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s' 
-                                               WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                                               dbesc($when),
-                                               dbesc(datetime_convert()),
-                                               dbesc($uri),
-                                               intval($importer['importer_uid'])
-                                       );
-                                       if($item['last-child']) {
-                                               // ensure that last-child is set in case the comment that had it just got wiped.
-                                               $q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `parent-uri` = '%s' AND `uid` = %d ",
+                                       if($item['uri'] == $item['parent-uri']) {
+                                               $r = q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s'
+                                                       WHERE `parent-uri` = '%s' AND `uid` = %d",
+                                                       dbesc($when),
                                                        dbesc(datetime_convert()),
-                                                       dbesc($item['parent-uri']),
-                                                       intval($item['uid'])
+                                                       dbesc($item['uri']),
+                                                       intval($importer['importer_uid'])
                                                );
-                                               // who is the last child now? 
-                                               $r = q("SELECT `id` FROM `item` WHERE `parent-uri` = '%s' AND `type` != 'activity' AND `deleted` = 0 AND `uid` = %d
-                                                       ORDER BY `created` DESC LIMIT 1",
-                                                               dbesc($item['parent-uri']),
-                                                               intval($importer['importer_uid'])
+                                       }
+                                       else {
+                                               $r = q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s' 
+                                                       WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                                       dbesc($when),
+                                                       dbesc(datetime_convert()),
+                                                       dbesc($uri),
+                                                       intval($importer['importer_uid'])
                                                );
-                                               if(count($r)) {
-                                                       q("UPDATE `item` SET `last-child` = 1 WHERE `id` = %d LIMIT 1",
-                                                               intval($r[0]['id'])
+                                               if($item['last-child']) {
+                                                       // ensure that last-child is set in case the comment that had it just got wiped.
+                                                       q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `parent-uri` = '%s' AND `uid` = %d ",
+                                                               dbesc(datetime_convert()),
+                                                               dbesc($item['parent-uri']),
+                                                               intval($item['uid'])
                                                        );
-                                               }       
-                                       }
+                                                       // who is the last child now? 
+                                                       $r = q("SELECT `id` FROM `item` WHERE `parent-uri` = '%s' AND `type` != 'activity' AND `deleted` = 0 AND `uid` = %d
+                                                               ORDER BY `created` DESC LIMIT 1",
+                                                                       dbesc($item['parent-uri']),
+                                                                       intval($importer['importer_uid'])
+                                                       );
+                                                       if(count($r)) {
+                                                               q("UPDATE `item` SET `last-child` = 1 WHERE `id` = %d LIMIT 1",
+                                                                       intval($r[0]['id'])
+                                                               );
+                                                       }       
+                                               }
+                                       }       
                                }
-                       }       
-                       continue;
+                       }
                }
+       }
+
+
+       foreach($feed->get_items() as $item) {
 
                $is_reply = false;              
                $item_id = $item->get_id();
@@ -260,69 +343,90 @@ function dfrn_notify_post(&$a) {
                                        $datarray['last-child'] = 0;
                                }
                                $posted_id = item_store($datarray);
+                               $parent = 0;
 
                                if($posted_id) {
+                                       $r = q("SELECT `parent` FROM `item` WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                                               intval($posted_id),
+                                               intval($importer['importer_uid'])
+                                       );
+                                       if(count($r))
+                                               $parent = $r[0]['parent'];
+                       
                                        if(! $is_like) {
-                                               $r = q("SELECT `parent` FROM `item` WHERE `id` = %d AND `uid` = %d LIMIT 1",
-                                                       intval($posted_id),
-                                                       intval($importer['importer_uid'])
+                                               $r1 = q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `uid` = %d AND `parent` = %d",
+                                                       dbesc(datetime_convert()),
+                                                       intval($importer['importer_uid']),
+                                                       intval($r[0]['parent'])
                                                );
-                                               if(count($r)) {
-                                                       $r1 = q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `uid` = %d AND `parent` = %d",
-                                                               dbesc(datetime_convert()),
-                                                               intval($importer['importer_uid']),
-                                                               intval($r[0]['parent'])
-                                                       );
-                                               }
+
                                                $r2 = q("UPDATE `item` SET `last-child` = 1, `changed` = '%s' WHERE `uid` = %d AND `id` = %d LIMIT 1",
-                                                               dbesc(datetime_convert()),
-                                                               intval($importer['importer_uid']),
-                                                               intval($posted_id)
+                                                       dbesc(datetime_convert()),
+                                                       intval($importer['importer_uid']),
+                                                       intval($posted_id)
                                                );
                                        }
 
-                                       $php_path = ((strlen($a->config['php_path'])) ? $a->config['php_path'] : 'php');
-
-                                       proc_close(proc_open("\"$php_path\" \"include/notifier.php\" \"comment-import\" \"$posted_id\" &", 
-                                               array(),$foo));
-
-                                       if((! $is_like) && ($importer['notify-flags'] & NOTIFY_COMMENT) && (! $importer['self'])) {
-                                               require_once('bbcode.php');
-                                               $from = stripslashes($datarray['author-name']);
-                                               $tpl = load_view_file('view/cmnt_received_eml.tpl');                    
-                                               $email_tpl = replace_macros($tpl, array(
-                                                       '$sitename' => $a->config['sitename'],
-                                                       '$siteurl' =>  $a->get_baseurl(),
-                                                       '$username' => $importer['username'],
-                                                       '$email' => $importer['email'],
-                                                       '$display' => $a->get_baseurl() . '/display/' . $importer['nickname'] . '/' . $posted_id, 
-                                                       '$from' => $from,
-                                                       '$body' => strip_tags(bbcode(stripslashes($datarray['body'])))
-                                               ));
+                                       if($posted_id && $parent) {
+                               
+                                               proc_run('php',"include/notifier.php","comment-import","$posted_id");
+                                       
+                                               if((! $is_like) && ($importer['notify-flags'] & NOTIFY_COMMENT) && (! $importer['self'])) {
+                                                       require_once('bbcode.php');
+                                                       $from = stripslashes($datarray['author-name']);
+                                                       $tpl = load_view_file('view/cmnt_received_eml.tpl');                    
+                                                       $email_tpl = replace_macros($tpl, array(
+                                                               '$sitename' => $a->config['sitename'],
+                                                               '$siteurl' =>  $a->get_baseurl(),
+                                                               '$username' => $importer['username'],
+                                                               '$email' => $importer['email'],
+                                                               '$display' => $a->get_baseurl() . '/display/' . $importer['nickname'] . '/' . $posted_id, 
+                                                               '$from' => $from,
+                                                               '$body' => html_entity_decode(strip_tags(bbcode(stripslashes($datarray['body']))), ENT_QUOTES, 'UTF-8')
+                                                       ));
        
-                                               $res = mail($importer['email'], $from . t(' commented on an item at ') . $a->config['sitename'],
-                                                       $email_tpl, "From: " . t('Administrator') . '@' . $a->get_hostname() );
+                                                       $res = mail($importer['email'], sprintf(t('%s commented on an item at %s'), $from , $a->config['sitename']),
+                                                               $email_tpl, "From: " . t('Administrator') . '@' . $a->get_hostname() );
+                                               }
                                        }
+                                       xml_status(0);
+                                       // NOTREACHED
                                }
-
-                               xml_status(0);
-                               // NOTREACHED
-
                        }
                        else {
+
                                // regular comment that is part of this total conversation. Have we seen it? If not, import it.
 
-                               $item_id = $item->get_id();
+                               $item_id  = $item->get_id();
+                               $datarray = get_atom_elements($feed,$item);
 
-                               $r = q("SELECT `uid`, `last-child`, `edited` FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                               $r = q("SELECT `uid`, `last-child`, `edited`, `body` FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
                                        dbesc($item_id),
                                        intval($importer['importer_uid'])
                                );
-                               // FIXME update content if 'updated' changes
+
+                               // Update content if 'updated' changes
+
                                if(count($r)) {
+                                       if((x($datarray,'edited') !== false) && (datetime_convert('UTC','UTC',$datarray['edited']) !== $r[0]['edited'])) {  
+                                               $r = q("UPDATE `item` SET `body` = '%s', `edited` = '%s' WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                                       dbesc($datarray['body']),
+                                                       dbesc(datetime_convert('UTC','UTC',$datarray['edited'])),
+                                                       dbesc($item_id),
+                                                       intval($importer['importer_uid'])
+                                               );
+                                       }
+
+                                       // update last-child if it changes
+
                                        $allow = $item->get_item_tags( NAMESPACE_DFRN, 'comment-allow');
-                                       if($allow && $allow[0]['data'] != $r[0]['last-child']) {
-                                               $r = q("UPDATE `item` SET `last-child` = %d, `changed` = '%s' WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                       if(($allow) && ($allow[0]['data'] != $r[0]['last-child'])) {
+                                               $r = q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `parent-uri` = '%s' AND `uid` = %d",
+                                                       dbesc(datetime_convert()),
+                                                       dbesc($parent_uri),
+                                                       intval($importer['importer_uid'])
+                                               );
+                                               $r = q("UPDATE `item` SET `last-child` = %d , `changed` = '%s'  WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
                                                        intval($allow[0]['data']),
                                                        dbesc(datetime_convert()),
                                                        dbesc($item_id),
@@ -331,7 +435,7 @@ function dfrn_notify_post(&$a) {
                                        }
                                        continue;
                                }
-                               $datarray = get_atom_elements($feed,$item);
+
                                $datarray['parent-uri'] = $parent_uri;
                                $datarray['uid'] = $importer['importer_uid'];
                                $datarray['contact-id'] = $importer['id'];
@@ -339,37 +443,36 @@ function dfrn_notify_post(&$a) {
                                        $datarray['type'] = 'activity';
                                        $datarray['gravity'] = GRAVITY_LIKE;
                                }
-
                                $r = item_store($datarray);
 
                                // find out if our user is involved in this conversation and wants to be notified.
                        
                                if(($datarray['type'] != 'activity') && ($importer['notify-flags'] & NOTIFY_COMMENT)) {
 
-                                       $myconv = q("SELECT `author-link` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d",
+                                       $myconv = q("SELECT `author-link` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d AND `parent` != 0 ",
                                                dbesc($parent_uri),
                                                intval($importer['importer_uid'])
                                        );
                                        if(count($myconv)) {
+                                               $importer_url = $a->get_baseurl() . '/profile/' . $importer['nickname'];
                                                foreach($myconv as $conv) {
-                                                       if($conv['author-link'] != $importer['url'])
+                                                       if(! link_compare($conv['author-link'],$importer_url))
                                                                continue;
                                                        require_once('bbcode.php');
                                                        $from = stripslashes($datarray['author-name']);
-                                                       $tpl = load_view_file('view/cmnt_received_eml.tpl');                    
+                                                       $tpl = load_view_file('view/cmnt_received_eml.tpl');    
                                                        $email_tpl = replace_macros($tpl, array(
                                                                '$sitename' => $a->config['sitename'],
                                                                '$siteurl' =>  $a->get_baseurl(),
                                                                '$username' => $importer['username'],
                                                                '$email' => $importer['email'],
                                                                '$from' => $from,
-                                                               '$display' => $a->get_baseurl() . '/display/' . $r,
-                                                               '$body' => strip_tags(bbcode(stripslashes($datarray['body'])))
+                                                               '$display' => $a->get_baseurl() . '/display/' . $importer['nickname'] . '/' . $r,
+                                                               '$body' => html_entity_decode(strip_tags(bbcode(stripslashes($datarray['body']))), ENT_QUOTES, 'UTF-8')
                                                        ));
 
-                                                       $res = mail($importer['email'], $from . t(" commented on an item at ") 
-                                                               . $a->config['sitename'],
-                                                               $email_tpl,t("From: Administrator@") . $a->get_hostname() );
+                                                       $res = mail($importer['email'], sprintf( t("%s commented on an item at %s") , $from ,$a->config['sitename']),
+                                                               $email_tpl, t("From: Administrator@") . $a->get_hostname() );
                                                        break;
                                                }
                                        }
@@ -377,18 +480,37 @@ function dfrn_notify_post(&$a) {
                                continue;
                        }
                }
+
                else {
+
                        // Head post of a conversation. Have we seen it? If not, import it.
 
-                       $item_id = $item->get_id();
-                       $r = q("SELECT `uid`, `last-child`, `edited` FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+
+                       $item_id  = $item->get_id();
+                       $datarray = get_atom_elements($feed,$item);
+
+                       $r = q("SELECT `uid`, `last-child`, `edited`, `body` FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
                                dbesc($item_id),
                                intval($importer['importer_uid'])
                        );
+
+                       // Update content if 'updated' changes
+
                        if(count($r)) {
+                               if((x($datarray,'edited') !== false) && (datetime_convert('UTC','UTC',$datarray['edited']) !== $r[0]['edited'])) {  
+                                       $r = q("UPDATE `item` SET `body` = '%s', `edited` = '%s' WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                               dbesc($datarray['body']),
+                                               dbesc(datetime_convert('UTC','UTC',$datarray['edited'])),
+                                               dbesc($item_id),
+                                               intval($importer['importer_uid'])
+                                       );
+                               }
+
+                               // update last-child if it changes
+
                                $allow = $item->get_item_tags( NAMESPACE_DFRN, 'comment-allow');
                                if($allow && $allow[0]['data'] != $r[0]['last-child']) {
-                                       $r = q("UPDATE `item` SET `last-child` = %d, `changed` = '%s' WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
+                                       $r = q("UPDATE `item` SET `last-child` = %d , `changed` = '%s' WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
                                                intval($allow[0]['data']),
                                                dbesc(datetime_convert()),
                                                dbesc($item_id),
@@ -398,8 +520,6 @@ function dfrn_notify_post(&$a) {
                                continue;
                        }
 
-
-                       $datarray = get_atom_elements($feed,$item);
                        $datarray['parent-uri'] = $item_id;
                        $datarray['uid'] = $importer['importer_uid'];
                        $datarray['contact-id'] = $importer['id'];
@@ -439,12 +559,13 @@ function dfrn_notify_content(&$a) {
                $r = q("DELETE FROM `challenge` WHERE `expire` < " . intval(time()));
 
                $r = q("INSERT INTO `challenge` ( `challenge`, `dfrn-id`, `expire` )
-                       VALUES( '%s', '%s', '%s') ",
+                       VALUES( '%s', '%s', %d ) ",
                        dbesc($hash),
                        dbesc($dfrn_id),
-                       intval(time() + 60 )
+                       intval(time() + 90 )
                );
 
+               logger('dfrn_notify: challenge=' . $hash );
 
                $sql_extra = '';
                switch($direction) {
@@ -477,14 +598,14 @@ function dfrn_notify_content(&$a) {
                $encrypted_id = '';
                $id_str = $my_id . '.' . mt_rand(1000,9999);
 
-               if((($r[0]['duplex']) && strlen($r[0]['pubkey'])) || (! strlen($r[0]['prvkey']))) {
-                       openssl_public_encrypt($hash,$challenge,$r[0]['pubkey']);
-                       openssl_public_encrypt($id_str,$encrypted_id,$r[0]['pubkey']);
-               }
-               else {
+               if((($r[0]['duplex']) && strlen($r[0]['prvkey'])) || (! strlen($r[0]['pubkey']))) {
                        openssl_private_encrypt($hash,$challenge,$r[0]['prvkey']);
                        openssl_private_encrypt($id_str,$encrypted_id,$r[0]['prvkey']);
                }
+               else {
+                       openssl_public_encrypt($hash,$challenge,$r[0]['pubkey']);
+                       openssl_public_encrypt($id_str,$encrypted_id,$r[0]['pubkey']);
+               }
 
                $challenge    = bin2hex($challenge);
                $encrypted_id = bin2hex($encrypted_id);