]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_poll.php
Merge remote-tracking branch 'upstream/develop' into rewrites/coding-convention
[friendica.git] / mod / dfrn_poll.php
index ab6637607e564b2d71eb2ba1353b6944a6216c65..13d443341dae048e4ff52c01a4c9f753613b69e8 100644 (file)
@@ -4,7 +4,7 @@ require_once('include/auth.php');
 require_once('include/dfrn.php');
 
 
-function dfrn_poll_init(&$a) {
+function dfrn_poll_init(App $a) {
 
 
        $dfrn_id         = ((x($_GET,'dfrn_id'))         ? $_GET['dfrn_id']              : '');
@@ -20,35 +20,38 @@ function dfrn_poll_init(&$a) {
        $direction = (-1);
 
 
-       if(strpos($dfrn_id,':') == 1) {
+       if (strpos($dfrn_id,':') == 1) {
                $direction = intval(substr($dfrn_id,0,1));
                $dfrn_id   = substr($dfrn_id,2);
        }
 
-       if(($dfrn_id === '') && (! x($_POST,'dfrn_id'))) {
-               if((get_config('system','block_public')) && (! local_user()) && (! remote_user())) {
+       $hidewall = false;
+
+       if (($dfrn_id === '') && (! x($_POST,'dfrn_id'))) {
+               if ((get_config('system','block_public')) && (! local_user()) && (! remote_user())) {
                        http_status_exit(403);
                }
 
                $user = '';
-               if($a->argc > 1) {
+               if ($a->argc > 1) {
                        $r = q("SELECT `hidewall`,`nickname` FROM `user` WHERE `user`.`nickname` = '%s' LIMIT 1",
                                dbesc($a->argv[1])
                        );
-                       if(! $r)
+                       if (!$r)
                                http_status_exit(404);
-                       if(($r[0]['hidewall']) && (! local_user()))
-                               http_status_exit(403);
+
+                       $hidewall = ($r[0]['hidewall'] && !local_user());
+
                        $user = $r[0]['nickname'];
                }
 
                logger('dfrn_poll: public feed request from ' . $_SERVER['REMOTE_ADDR'] . ' for ' . $user);
                header("Content-type: application/atom+xml");
-               echo dfrn::feed('', $user,$last_update);
+               echo dfrn::feed('', $user,$last_update, 0, $hidewall);
                killme();
        }
 
-       if(($type === 'profile') && (! strlen($sec))) {
+       if (($type === 'profile') && (! strlen($sec))) {
 
                $sql_extra = '';
                switch($direction) {
@@ -76,19 +79,19 @@ function dfrn_poll_init(&$a) {
                        dbesc($a->argv[1])
                );
 
-               if(count($r)) {
+               if (dbm::is_result($r)) {
 
                        $s = fetch_url($r[0]['poll'] . '?dfrn_id=' . $my_id . '&type=profile-check');
 
                        logger("dfrn_poll: old profile returns " . $s, LOGGER_DATA);
 
-                       if(strlen($s)) {
+                       if (strlen($s)) {
 
                                $xml = parse_xml_string($s);
 
-                               if((int) $xml->status == 1) {
+                               if ((int) $xml->status == 1) {
                                        $_SESSION['authenticated'] = 1;
-                                       if(! x($_SESSION,'remote'))
+                                       if (! x($_SESSION,'remote'))
                                                $_SESSION['remote'] = array();
 
                                        $_SESSION['remote'][] = array('cid' => $r[0]['id'],'uid' => $r[0]['uid'],'url' => $r[0]['url']);
@@ -97,7 +100,7 @@ function dfrn_poll_init(&$a) {
                                        $_SESSION['visitor_home'] = $r[0]['url'];
                                        $_SESSION['visitor_handle'] = $r[0]['addr'];
                                        $_SESSION['visitor_visiting'] = $r[0]['uid'];
-                                       if(!$quiet)
+                                       if (!$quiet)
                                                info( sprintf(t('%1$s welcomes %2$s'), $r[0]['username'] , $r[0]['name']) . EOL);
                                        // Visitors get 1 day session.
                                        $session_id = session_id();
@@ -109,32 +112,32 @@ function dfrn_poll_init(&$a) {
                                }
                        }
                        $profile = $r[0]['nickname'];
-                       goaway((strlen($destination_url)) ? $destination_url : $a->get_baseurl() . '/profile/' . $profile);
+                       goaway((strlen($destination_url)) ? $destination_url : App::get_baseurl() . '/profile/' . $profile);
                }
                goaway(z_root());
 
        }
 
-       if($type === 'profile-check' && $dfrn_version < 2.2 ) {
+       if ($type === 'profile-check' && $dfrn_version < 2.2 ) {
 
-               if((strlen($challenge)) && (strlen($sec))) {
+               if ((strlen($challenge)) && (strlen($sec))) {
 
                        q("DELETE FROM `profile_check` WHERE `expire` < " . intval(time()));
                        $r = q("SELECT * FROM `profile_check` WHERE `sec` = '%s' ORDER BY `expire` DESC LIMIT 1",
                                dbesc($sec)
                        );
-                       if(! count($r)) {
+                       if (! dbm::is_result($r)) {
                                xml_status(3, 'No ticket');
                                // NOTREACHED
                        }
                        $orig_id = $r[0]['dfrn_id'];
-                       if(strpos($orig_id, ':'))
+                       if (strpos($orig_id, ':'))
                                $orig_id = substr($orig_id,2);
 
                        $c = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
                                intval($r[0]['cid'])
                        );
-                       if(! count($c)) {
+                       if (! dbm::is_result($c)) {
                                xml_status(3, 'No profile');
                        }
                        $contact = $c[0];
@@ -144,7 +147,7 @@ function dfrn_poll_init(&$a) {
 
                        $final_dfrn_id = '';
 
-                       if(($contact['duplex']) && strlen($contact['prvkey'])) {
+                       if (($contact['duplex']) && strlen($contact['prvkey'])) {
                                openssl_private_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['prvkey']);
                                openssl_private_decrypt($challenge,$decoded_challenge,$contact['prvkey']);
                        }
@@ -155,12 +158,12 @@ function dfrn_poll_init(&$a) {
 
                        $final_dfrn_id = substr($final_dfrn_id, 0, strpos($final_dfrn_id, '.'));
 
-                       if(strpos($final_dfrn_id,':') == 1)
+                       if (strpos($final_dfrn_id,':') == 1)
                                $final_dfrn_id = substr($final_dfrn_id,2);
 
-                       if($final_dfrn_id != $orig_id) {
+                       if ($final_dfrn_id != $orig_id) {
                                logger('profile_check: ' . $final_dfrn_id . ' != ' . $orig_id, LOGGER_DEBUG);
-                               // did not decode properly - cannot trust this site 
+                               // did not decode properly - cannot trust this site
                                xml_status(3, 'Bad decryption');
                        }
 
@@ -187,7 +190,7 @@ function dfrn_poll_init(&$a) {
                        q("DELETE FROM `profile_check` WHERE `expire` < " . intval(time()));
                        $r = q("SELECT * FROM `profile_check` WHERE `dfrn_id` = '%s' ORDER BY `expire` DESC",
                                dbesc($dfrn_id));
-                       if(count($r)) {
+                       if (dbm::is_result($r)) {
                                xml_status(1);
                                return; // NOTREACHED
                        }
@@ -200,7 +203,7 @@ function dfrn_poll_init(&$a) {
 
 
 
-function dfrn_poll_post(&$a) {
+function dfrn_poll_post(App $a) {
 
        $dfrn_id      = ((x($_POST,'dfrn_id'))      ? $_POST['dfrn_id']              : '');
        $challenge    = ((x($_POST,'challenge'))    ? $_POST['challenge']            : '');
@@ -210,9 +213,9 @@ function dfrn_poll_post(&$a) {
        $dfrn_version = ((x($_POST,'dfrn_version')) ? (float) $_POST['dfrn_version'] : 2.0);
        $perm         = ((x($_POST,'perm'))         ? $_POST['perm']                 : 'r');
 
-       if($ptype === 'profile-check') {
+       if ($ptype === 'profile-check') {
 
-               if((strlen($challenge)) && (strlen($sec))) {
+               if ((strlen($challenge)) && (strlen($sec))) {
 
                        logger('dfrn_poll: POST: profile-check');
 
@@ -220,18 +223,18 @@ function dfrn_poll_post(&$a) {
                        $r = q("SELECT * FROM `profile_check` WHERE `sec` = '%s' ORDER BY `expire` DESC LIMIT 1",
                                dbesc($sec)
                        );
-                       if(! count($r)) {
+                       if (! dbm::is_result($r)) {
                                xml_status(3, 'No ticket');
                                // NOTREACHED
                        }
                        $orig_id = $r[0]['dfrn_id'];
-                       if(strpos($orig_id, ':'))
+                       if (strpos($orig_id, ':'))
                                $orig_id = substr($orig_id,2);
 
                        $c = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
                                intval($r[0]['cid'])
                        );
-                       if(! count($c)) {
+                       if (! dbm::is_result($c)) {
                                xml_status(3, 'No profile');
                        }
                        $contact = $c[0];
@@ -241,7 +244,7 @@ function dfrn_poll_post(&$a) {
 
                        $final_dfrn_id = '';
 
-                       if(($contact['duplex']) && strlen($contact['prvkey'])) {
+                       if (($contact['duplex']) && strlen($contact['prvkey'])) {
                                openssl_private_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['prvkey']);
                                openssl_private_decrypt($challenge,$decoded_challenge,$contact['prvkey']);
                        }
@@ -252,12 +255,12 @@ function dfrn_poll_post(&$a) {
 
                        $final_dfrn_id = substr($final_dfrn_id, 0, strpos($final_dfrn_id, '.'));
 
-                       if(strpos($final_dfrn_id,':') == 1)
+                       if (strpos($final_dfrn_id,':') == 1)
                                $final_dfrn_id = substr($final_dfrn_id,2);
 
-                       if($final_dfrn_id != $orig_id) {
+                       if ($final_dfrn_id != $orig_id) {
                                logger('profile_check: ' . $final_dfrn_id . ' != ' . $orig_id, LOGGER_DEBUG);
-                               // did not decode properly - cannot trust this site 
+                               // did not decode properly - cannot trust this site
                                xml_status(3, 'Bad decryption');
                        }
 
@@ -270,7 +273,7 @@ function dfrn_poll_post(&$a) {
        }
 
        $direction    = (-1);
-       if(strpos($dfrn_id,':') == 1) {
+       if (strpos($dfrn_id,':') == 1) {
                $direction = intval(substr($dfrn_id,0,1));
                $dfrn_id   = substr($dfrn_id,2);
        }
@@ -281,8 +284,9 @@ function dfrn_poll_post(&$a) {
                dbesc($challenge)
        );
 
-       if(! count($r))
+       if (! dbm::is_result($r)) {
                killme();
+       }
 
        $type = $r[0]['type'];
        $last_update = $r[0]['last_update'];
@@ -316,15 +320,16 @@ function dfrn_poll_post(&$a) {
        $r = q("SELECT * FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 $sql_extra LIMIT 1");
 
 
-       if(! count($r))
+       if (! dbm::is_result($r)) {
                killme();
+       }
 
        $contact = $r[0];
        $owner_uid = $r[0]['uid'];
        $contact_id = $r[0]['id'];
 
 
-       if($type === 'reputation' && strlen($url)) {
+       if ($type === 'reputation' && strlen($url)) {
                $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `uid` = %d LIMIT 1",
                        dbesc($url),
                        intval($owner_uid)
@@ -332,11 +337,11 @@ function dfrn_poll_post(&$a) {
                $reputation = 0;
                $text = '';
 
-               if(count($r)) {
+               if (dbm::is_result($r)) {
                        $reputation = $r[0]['rating'];
                        $text = $r[0]['reason'];
 
-                       if($r[0]['id'] == $contact_id) {        // inquiring about own reputation not allowed
+                       if ($r[0]['id'] == $contact_id) {       // inquiring about own reputation not allowed
                                $reputation = 0;
                                $text = '';
                        }
@@ -356,13 +361,13 @@ function dfrn_poll_post(&$a) {
 
                // Update the writable flag if it changed
                logger('dfrn_poll: post request feed: ' . print_r($_POST,true),LOGGER_DATA);
-               if($dfrn_version >= 2.21) {
-                       if($perm === 'rw')
+               if ($dfrn_version >= 2.21) {
+                       if ($perm === 'rw')
                                $writable = 1;
                        else
                                $writable = 0;
 
-                       if($writable !=  $contact['writable']) {
+                       if ($writable !=  $contact['writable']) {
                                q("UPDATE `contact` SET `writable` = %d WHERE `id` = %d",
                                        intval($writable),
                                        intval($contact_id)
@@ -378,7 +383,7 @@ function dfrn_poll_post(&$a) {
        }
 }
 
-function dfrn_poll_content(&$a) {
+function dfrn_poll_content(App $a) {
 
        $dfrn_id         = ((x($_GET,'dfrn_id'))         ? $_GET['dfrn_id']              : '');
        $type            = ((x($_GET,'type'))            ? $_GET['type']                 : 'data');
@@ -390,13 +395,13 @@ function dfrn_poll_content(&$a) {
        $quiet           = ((x($_GET,'quiet'))           ? true                          : false);
 
        $direction = (-1);
-       if(strpos($dfrn_id,':') == 1) {
+       if (strpos($dfrn_id,':') == 1) {
                $direction = intval(substr($dfrn_id,0,1));
                $dfrn_id = substr($dfrn_id,2);
        }
 
 
-       if($dfrn_id != '') {
+       if ($dfrn_id != '') {
                // initial communication from external contact
                $hash = random_string();
 
@@ -404,7 +409,7 @@ function dfrn_poll_content(&$a) {
 
                $r = q("DELETE FROM `challenge` WHERE `expire` < " . intval(time()));
 
-               if($type !== 'profile') {
+               if ($type !== 'profile') {
                        $r = q("INSERT INTO `challenge` ( `challenge`, `dfrn-id`, `expire` , `type`, `last_update` )
                                VALUES( '%s', '%s', '%s', '%s', '%s' ) ",
                                dbesc($hash),
@@ -417,7 +422,7 @@ function dfrn_poll_content(&$a) {
                $sql_extra = '';
                switch($direction) {
                        case (-1):
-                               if($type === 'profile')
+                               if ($type === 'profile')
                                        $sql_extra = sprintf(" AND ( `dfrn-id` = '%s' OR `issued-id` = '%s' ) ", dbesc($dfrn_id),dbesc($dfrn_id));
                                else
                                        $sql_extra = sprintf(" AND `issued-id` = '%s' ", dbesc($dfrn_id));
@@ -445,13 +450,13 @@ function dfrn_poll_content(&$a) {
                        dbesc($nickname)
                );
 
-               if(count($r)) {
+               if (dbm::is_result($r)) {
 
                        $challenge = '';
                        $encrypted_id = '';
                        $id_str = $my_id . '.' . mt_rand(1000,9999);
 
-                       if(($r[0]['duplex'] && strlen($r[0]['pubkey'])) || (! strlen($r[0]['prvkey']))) {
+                       if (($r[0]['duplex'] && strlen($r[0]['pubkey'])) || (! strlen($r[0]['prvkey']))) {
                                openssl_public_encrypt($hash,$challenge,$r[0]['pubkey']);
                                openssl_public_encrypt($id_str,$encrypted_id,$r[0]['pubkey']);
                        }
@@ -469,11 +474,11 @@ function dfrn_poll_content(&$a) {
                        $encrypted_id = '';
                }
 
-               if(($type === 'profile') && (strlen($sec))) {
+               if (($type === 'profile') && (strlen($sec))) {
 
                        // URL reply
 
-                       if($dfrn_version < 2.2) {
+                       if ($dfrn_version < 2.2) {
                                $s = fetch_url($r[0]['poll']
                                        . '?dfrn_id=' . $encrypted_id
                                        . '&type=profile-check'
@@ -492,18 +497,18 @@ function dfrn_poll_content(&$a) {
                                ));
                        }
 
-                       $profile = ((count($r) && $r[0]['nickname']) ? $r[0]['nickname'] : $nickname);
+                       $profile = ((dbm::is_result($r) && $r[0]['nickname']) ? $r[0]['nickname'] : $nickname);
 
                        switch($destination_url) {
                                case 'profile':
-                                       $dest = $a->get_baseurl() . '/profile/' . $profile . '?f=&tab=profile';
+                                       $dest = App::get_baseurl() . '/profile/' . $profile . '?f=&tab=profile';
                                        break;
                                case 'photos':
-                                       $dest = $a->get_baseurl() . '/photos/' . $profile;
+                                       $dest = App::get_baseurl() . '/photos/' . $profile;
                                        break;
                                case 'status':
                                case '':
-                                       $dest = $a->get_baseurl() . '/profile/' . $profile;
+                                       $dest = App::get_baseurl() . '/profile/' . $profile;
                                        break;
                                default:
                                        $dest = $destination_url . '?f=&redir=1';
@@ -512,7 +517,7 @@ function dfrn_poll_content(&$a) {
 
                        logger("dfrn_poll: sec profile: " . $s, LOGGER_DATA);
 
-                       if(strlen($s) && strstr($s,'<?xml')) {
+                       if (strlen($s) && strstr($s,'<?xml')) {
 
                                $xml = parse_xml_string($s);
 
@@ -522,15 +527,15 @@ function dfrn_poll_content(&$a) {
                                logger('dfrn_poll: secure profile: sec: ' . $xml->sec . ' expecting ' . $sec);
 
 
-                               if(((int) $xml->status == 0) && ($xml->challenge == $hash)  && ($xml->sec == $sec)) {
+                               if (((int) $xml->status == 0) && ($xml->challenge == $hash)  && ($xml->sec == $sec)) {
                                        $_SESSION['authenticated'] = 1;
-                                       if(! x($_SESSION,'remote'))
+                                       if (! x($_SESSION,'remote'))
                                                $_SESSION['remote'] = array();
                                        $_SESSION['remote'][] = array('cid' => $r[0]['id'],'uid' => $r[0]['uid'],'url' => $r[0]['url']);
                                        $_SESSION['visitor_id'] = $r[0]['id'];
                                        $_SESSION['visitor_home'] = $r[0]['url'];
                                        $_SESSION['visitor_visiting'] = $r[0]['uid'];
-                                       if(!$quiet)
+                                       if (!$quiet)
                                                info( sprintf(t('%1$s welcomes %2$s'), $r[0]['username'] , $r[0]['name']) . EOL);
                                        // Visitors get 1 day session.
                                        $session_id = session_id();