Merge pull request #10109 from annando/post-type

[friendica.git] / mod / dfrn_poll.php

diff --git a/mod/dfrn_poll.php b/mod/dfrn_poll.php
index 7f7fbe498f8ff39e6ad9ae04055f133c660aa65e..54a996f651221be56a66335ffa6b6f7ac435a213 100644 (file)
--- a/mod/dfrn_poll.php
+++ b/mod/dfrn_poll.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -114,7 +114,7 @@ function dfrn_poll_init(App $a)
                );
 
                if (DBA::isResult($r)) {
-                       $s = DI::httpRequest()->fetchUrl($r[0]['poll'] . '?dfrn_id=' . $my_id . '&type=profile-check');
+                       $s = DI::httpRequest()->fetch($r[0]['poll'] . '?dfrn_id=' . $my_id . '&type=profile-check');
 
                        Logger::log("dfrn_poll: old profile returns " . $s, Logger::DATA);
 
@@ -132,7 +132,7 @@ function dfrn_poll_init(App $a)
                                        Session::setVisitorsContacts();
 
                                        if (!$quiet) {
-                                               info(DI::l10n()->t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']) . EOL);
+                                               info(DI::l10n()->t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']));
                                        }
 
                                        // Visitors get 1 day session.
@@ -239,7 +239,6 @@ function dfrn_poll_post(App $a)
 {
        $dfrn_id      =  $_POST['dfrn_id']   ?? '';
        $challenge    =  $_POST['challenge'] ?? '';
-       $url          =  $_POST['url']       ?? '';
        $sec          =  $_POST['sec']       ?? '';
        $ptype        =  $_POST['type']      ?? '';
        $perm         = ($_POST['perm']      ?? '') ?: 'r';
@@ -319,7 +318,6 @@ function dfrn_poll_post(App $a)
                exit();
        }
 
-       $type = $r[0]['type'];
        $last_update = $r[0]['last_update'];
 
        DBA::delete('challenge', ['dfrn-id' => $dfrn_id, 'challenge' => $challenge]);
@@ -346,59 +344,29 @@ function dfrn_poll_post(App $a)
        }
 
        $contact = $r[0];
-       $owner_uid = $r[0]['uid'];
        $contact_id = $r[0]['id'];
 
-       if ($type === 'reputation' && strlen($url)) {
-               $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `uid` = %d LIMIT 1",
-                       DBA::escape($url),
-                       intval($owner_uid)
-               );
-               $reputation = 0;
-               $text = '';
-
-               if (DBA::isResult($r)) {
-                       $reputation = $r[0]['rating'];
-                       $text = $r[0]['reason'];
-
-                       if ($r[0]['id'] == $contact_id) { // inquiring about own reputation not allowed
-                               $reputation = 0;
-                               $text = '';
-                       }
+       // Update the writable flag if it changed
+       Logger::debug('post request feed', ['post' => $_POST]);
+       if ($dfrn_version >= 2.21) {
+               if ($perm === 'rw') {
+                       $writable = 1;
+               } else {
+                       $writable = 0;
                }
 
-               echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?>
-               <reputation>
-                       <url>$url</url>
-                       <rating>$reputation</rating>
-                       <description>$text</description>
-               </reputation>
-               ";
-               exit();
-               // NOTREACHED
-       } else {
-               // Update the writable flag if it changed
-               Logger::debug('post request feed', ['post' => $_POST]);
-               if ($dfrn_version >= 2.21) {
-                       if ($perm === 'rw') {
-                               $writable = 1;
-                       } else {
-                               $writable = 0;
-                       }
-
-                       if ($writable != $contact['writable']) {
-                               q("UPDATE `contact` SET `writable` = %d WHERE `id` = %d",
-                                       intval($writable),
-                                       intval($contact_id)
-                               );
-                       }
+               if ($writable != $contact['writable']) {
+                       q("UPDATE `contact` SET `writable` = %d WHERE `id` = %d",
+                               intval($writable),
+                               intval($contact_id)
+                       );
                }
-
-               header("Content-type: application/atom+xml");
-               $o = DFRN::feed($dfrn_id, $a->argv[1], $last_update, $direction);
-               echo $o;
-               exit();
        }
+
+       header("Content-type: application/atom+xml");
+       $o = DFRN::feed($dfrn_id, $a->argv[1], $last_update, $direction);
+       echo $o;
+       exit();
 }
 
 function dfrn_poll_content(App $a)
@@ -498,12 +466,12 @@ function dfrn_poll_content(App $a)
 
                        // URL reply
                        if ($dfrn_version < 2.2) {
-                               $s = DI::httpRequest()->fetchUrl($r[0]['poll']
-                                                          . '?dfrn_id=' . $encrypted_id
-                                                          . '&type=profile-check'
-                                                          . '&dfrn_version=' . DFRN_PROTOCOL_VERSION
-                                                          . '&challenge=' . $challenge
-                                                          . '&sec=' . $sec
+                               $s = DI::httpRequest()->fetch($r[0]['poll']
+                                                             . '?dfrn_id=' . $encrypted_id
+                                                             . '&type=profile-check'
+                                                             . '&dfrn_version=' . DFRN_PROTOCOL_VERSION
+                                                             . '&challenge=' . $challenge
+                                                             . '&sec=' . $sec
                                );
                        } else {
                                $s = DI::httpRequest()->post($r[0]['poll'], [
@@ -535,7 +503,7 @@ function dfrn_poll_content(App $a)
                                        Session::setVisitorsContacts();
 
                                        if (!$quiet) {
-                                               info(DI::l10n()->t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']) . EOL);
+                                               info(DI::l10n()->t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']));
                                        }
 
                                        // Visitors get 1 day session.