]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_poll.php
Fixes:
[friendica.git] / mod / dfrn_poll.php
index 91fa49618a7713bdd443be67b5a0591fe1043b3f..fa9ad13f5679d1b0b4978d3232818c5409853fe1 100644 (file)
@@ -1,44 +1,67 @@
 <?php
 
-use Friendica\App;
-
-require_once('include/items.php');
-require_once('include/auth.php');
-require_once('include/dfrn.php');
-
-function dfrn_poll_init(App $a) {
-       $dfrn_id         = ((x($_GET,'dfrn_id'))         ? $_GET['dfrn_id']              : '');
-       $type            = ((x($_GET,'type'))            ? $_GET['type']                 : 'data');
-       $last_update     = ((x($_GET,'last_update'))     ? $_GET['last_update']          : '');
-       $destination_url = ((x($_GET,'destination_url')) ? $_GET['destination_url']      : '');
-       $challenge       = ((x($_GET,'challenge'))       ? $_GET['challenge']            : '');
-       $sec             = ((x($_GET,'sec'))             ? $_GET['sec']                  : '');
-       $dfrn_version    = ((x($_GET,'dfrn_version'))    ? (float) $_GET['dfrn_version'] : 2.0);
-       $perm            = ((x($_GET,'perm'))            ? $_GET['perm']                 : 'r');
-       $quiet                   = ((x($_GET,'quiet'))                   ? true                                                  : false);
+/**
+ * @file mod/dfrn_poll.php
+ */
 
-       $direction = (-1);
+use Friendica\App;
+use Friendica\Core\Config;
+use Friendica\Core\L10n;
+use Friendica\Core\System;
+use Friendica\Database\DBA;
+use Friendica\Database\DBM;
+use Friendica\Module\Login;
+use Friendica\Protocol\DFRN;
+use Friendica\Protocol\OStatus;
+use Friendica\Util\Network;
+use Friendica\Util\XML;
+
+require_once 'include/items.php';
+
+function dfrn_poll_init(App $a)
+{
+       Login::sessionAuth();
+
+       $dfrn_id         = defaults($_GET, 'dfrn_id'        , '');
+       $type            = defaults($_GET, 'type'           , 'data');
+       $last_update     = defaults($_GET, 'last_update'    , '');
+       $destination_url = defaults($_GET, 'destination_url', '');
+       $challenge       = defaults($_GET, 'challenge'      , '');
+       $sec             = defaults($_GET, 'sec'            , '');
+       $dfrn_version    = (float) defaults($_GET, 'dfrn_version'   , 2.0);
+       $perm            = defaults($_GET, 'perm'           , 'r');
+       $quiet                   = x($_GET, 'quiet');
+
+       // Possibly it is an OStatus compatible server that requests a user feed
+       if (($a->argc > 1) && ($dfrn_id == '') && !strstr($_SERVER["HTTP_USER_AGENT"], 'Friendica')) {
+               $nickname = $a->argv[1];
+               header("Content-type: application/atom+xml");
+               echo OStatus::feed($nickname, $last_update, 10);
+               killme();
+       }
 
+       $direction = -1;
 
-       if(strpos($dfrn_id,':') == 1) {
-               $direction = intval(substr($dfrn_id,0,1));
-               $dfrn_id   = substr($dfrn_id,2);
+       if (strpos($dfrn_id, ':') == 1) {
+               $direction = intval(substr($dfrn_id, 0, 1));
+               $dfrn_id = substr($dfrn_id, 2);
        }
 
        $hidewall = false;
 
-       if(($dfrn_id === '') && (! x($_POST,'dfrn_id'))) {
-               if((get_config('system','block_public')) && (! local_user()) && (! remote_user())) {
-                       http_status_exit(403);
+       if (($dfrn_id === '') && (!x($_POST, 'dfrn_id'))) {
+               if (Config::get('system', 'block_public') && !local_user() && !remote_user()) {
+                       System::httpExit(403);
                }
 
                $user = '';
-               if($a->argc > 1) {
+               if ($a->argc > 1) {
                        $r = q("SELECT `hidewall`,`nickname` FROM `user` WHERE `user`.`nickname` = '%s' LIMIT 1",
                                dbesc($a->argv[1])
                        );
-                       if (!$r)
-                               http_status_exit(404);
+                       if (!$r) {
+                               System::httpExit(404);
+                       }
 
                        $hidewall = ($r[0]['hidewall'] && !local_user());
 
@@ -47,16 +70,15 @@ function dfrn_poll_init(App $a) {
 
                logger('dfrn_poll: public feed request from ' . $_SERVER['REMOTE_ADDR'] . ' for ' . $user);
                header("Content-type: application/atom+xml");
-               echo dfrn::feed('', $user,$last_update, 0, $hidewall);
+               echo DFRN::feed('', $user, $last_update, 0, $hidewall);
                killme();
        }
 
-       if(($type === 'profile') && (! strlen($sec))) {
-
+       if (($type === 'profile') && (!strlen($sec))) {
                $sql_extra = '';
-               switch($direction) {
-                       case (-1):
-                               $sql_extra = sprintf(" AND ( `dfrn-id` = '%s' OR `issued-id` = '%s' ) ", dbesc($dfrn_id),dbesc($dfrn_id));
+               switch ($direction) {
+                       case -1:
+                               $sql_extra = sprintf(" AND ( `dfrn-id` = '%s' OR `issued-id` = '%s' ) ", dbesc($dfrn_id), dbesc($dfrn_id));
                                $my_id = $dfrn_id;
                                break;
                        case 0:
@@ -68,7 +90,7 @@ function dfrn_poll_init(App $a) {
                                $my_id = '0:' . $dfrn_id;
                                break;
                        default:
-                               goaway(z_root());
+                               goaway(System::baseUrl());
                                break; // NOTREACHED
                }
 
@@ -79,29 +101,31 @@ function dfrn_poll_init(App $a) {
                        dbesc($a->argv[1])
                );
 
-               if (dbm::is_result($r)) {
-
-                       $s = fetch_url($r[0]['poll'] . '?dfrn_id=' . $my_id . '&type=profile-check');
+               if (DBM::is_result($r)) {
+                       $s = Network::fetchUrl($r[0]['poll'] . '?dfrn_id=' . $my_id . '&type=profile-check');
 
                        logger("dfrn_poll: old profile returns " . $s, LOGGER_DATA);
 
-                       if(strlen($s)) {
+                       if (strlen($s)) {
+                               $xml = XML::parseString($s);
 
-                               $xml = parse_xml_string($s);
-
-                               if((int) $xml->status == 1) {
+                               if ((int) $xml->status === 1) {
                                        $_SESSION['authenticated'] = 1;
-                                       if(! x($_SESSION,'remote'))
-                                               $_SESSION['remote'] = array();
+                                       if (!x($_SESSION, 'remote')) {
+                                               $_SESSION['remote'] = [];
+                                       }
 
-                                       $_SESSION['remote'][] = array('cid' => $r[0]['id'],'uid' => $r[0]['uid'],'url' => $r[0]['url']);
+                                       $_SESSION['remote'][] = ['cid' => $r[0]['id'], 'uid' => $r[0]['uid'], 'url' => $r[0]['url']];
 
                                        $_SESSION['visitor_id'] = $r[0]['id'];
                                        $_SESSION['visitor_home'] = $r[0]['url'];
                                        $_SESSION['visitor_handle'] = $r[0]['addr'];
                                        $_SESSION['visitor_visiting'] = $r[0]['uid'];
-                                       if(!$quiet)
-                                               info( sprintf(t('%1$s welcomes %2$s'), $r[0]['username'] , $r[0]['name']) . EOL);
+                                       $_SESSION['my_url'] = $r[0]['url'];
+                                       if (!$quiet) {
+                                               info(L10n::t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']) . EOL);
+                                       }
+
                                        // Visitors get 1 day session.
                                        $session_id = session_id();
                                        $expire = time() + 86400;
@@ -112,70 +136,68 @@ function dfrn_poll_init(App $a) {
                                }
                        }
                        $profile = $r[0]['nickname'];
-                       goaway((strlen($destination_url)) ? $destination_url : App::get_baseurl() . '/profile/' . $profile);
+                       goaway((strlen($destination_url)) ? $destination_url : System::baseUrl() . '/profile/' . $profile);
                }
-               goaway(z_root());
-
+               goaway(System::baseUrl());
        }
 
-       if($type === 'profile-check' && $dfrn_version < 2.2 ) {
-
-               if((strlen($challenge)) && (strlen($sec))) {
-
-                       q("DELETE FROM `profile_check` WHERE `expire` < " . intval(time()));
+       if ($type === 'profile-check' && $dfrn_version < 2.2) {
+               if ((strlen($challenge)) && (strlen($sec))) {
+                       DBA::delete('profile_check', ["`expire` < ?", time()]);
                        $r = q("SELECT * FROM `profile_check` WHERE `sec` = '%s' ORDER BY `expire` DESC LIMIT 1",
                                dbesc($sec)
                        );
-                       if (! dbm::is_result($r)) {
-                               xml_status(3, 'No ticket');
+                       if (!DBM::is_result($r)) {
+                               System::xmlExit(3, 'No ticket');
                                // NOTREACHED
                        }
+
                        $orig_id = $r[0]['dfrn_id'];
-                       if(strpos($orig_id, ':'))
-                               $orig_id = substr($orig_id,2);
+                       if (strpos($orig_id, ':')) {
+                               $orig_id = substr($orig_id, 2);
+                       }
 
                        $c = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
                                intval($r[0]['cid'])
                        );
-                       if (! dbm::is_result($c)) {
-                               xml_status(3, 'No profile');
+                       if (!DBM::is_result($c)) {
+                               System::xmlExit(3, 'No profile');
                        }
+
                        $contact = $c[0];
 
                        $sent_dfrn_id = hex2bin($dfrn_id);
-                       $challenge    = hex2bin($challenge);
+                       $challenge = hex2bin($challenge);
 
                        $final_dfrn_id = '';
 
-                       if(($contact['duplex']) && strlen($contact['prvkey'])) {
-                               openssl_private_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['prvkey']);
-                               openssl_private_decrypt($challenge,$decoded_challenge,$contact['prvkey']);
-                       }
-                       else {
-                               openssl_public_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['pubkey']);
-                               openssl_public_decrypt($challenge,$decoded_challenge,$contact['pubkey']);
+                       if (($contact['duplex']) && strlen($contact['prvkey'])) {
+                               openssl_private_decrypt($sent_dfrn_id, $final_dfrn_id, $contact['prvkey']);
+                               openssl_private_decrypt($challenge, $decoded_challenge, $contact['prvkey']);
+                       } else {
+                               openssl_public_decrypt($sent_dfrn_id, $final_dfrn_id, $contact['pubkey']);
+                               openssl_public_decrypt($challenge, $decoded_challenge, $contact['pubkey']);
                        }
 
                        $final_dfrn_id = substr($final_dfrn_id, 0, strpos($final_dfrn_id, '.'));
 
-                       if(strpos($final_dfrn_id,':') == 1)
-                               $final_dfrn_id = substr($final_dfrn_id,2);
+                       if (strpos($final_dfrn_id, ':') == 1) {
+                               $final_dfrn_id = substr($final_dfrn_id, 2);
+                       }
 
-                       if($final_dfrn_id != $orig_id) {
+                       if ($final_dfrn_id != $orig_id) {
                                logger('profile_check: ' . $final_dfrn_id . ' != ' . $orig_id, LOGGER_DEBUG);
                                // did not decode properly - cannot trust this site
-                               xml_status(3, 'Bad decryption');
+                               System::xmlExit(3, 'Bad decryption');
                        }
 
                        header("Content-type: text/xml");
                        echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?><dfrn_poll><status>0</status><challenge>$decoded_challenge</challenge><sec>$sec</sec></dfrn_poll>";
                        killme();
                        // NOTREACHED
-               }
-               else {
-                               // old protocol
-
-                       switch($direction) {
+               } else {
+                       // old protocol
+                       switch ($direction) {
                                case 1:
                                        $dfrn_id = '0:' . $dfrn_id;
                                        break;
@@ -186,82 +208,79 @@ function dfrn_poll_init(App $a) {
                                        break;
                        }
 
-
-                       q("DELETE FROM `profile_check` WHERE `expire` < " . intval(time()));
+                       DBA::delete('profile_check', ["`expire` < ?", time()]);
                        $r = q("SELECT * FROM `profile_check` WHERE `dfrn_id` = '%s' ORDER BY `expire` DESC",
                                dbesc($dfrn_id));
-                       if (dbm::is_result($r)) {
-                               xml_status(1);
+                       if (DBM::is_result($r)) {
+                               System::xmlExit(1);
                                return; // NOTREACHED
                        }
-                       xml_status(0);
+                       System::xmlExit(0);
                        return; // NOTREACHED
                }
        }
-
 }
 
-
-
-function dfrn_poll_post(App $a) {
-
-       $dfrn_id      = ((x($_POST,'dfrn_id'))      ? $_POST['dfrn_id']              : '');
-       $challenge    = ((x($_POST,'challenge'))    ? $_POST['challenge']            : '');
-       $url          = ((x($_POST,'url'))          ? $_POST['url']                  : '');
-       $sec          = ((x($_POST,'sec'))          ? $_POST['sec']                  : '');
-       $ptype        = ((x($_POST,'type'))         ? $_POST['type']                 : '');
-       $dfrn_version = ((x($_POST,'dfrn_version')) ? (float) $_POST['dfrn_version'] : 2.0);
-       $perm         = ((x($_POST,'perm'))         ? $_POST['perm']                 : 'r');
-
-       if($ptype === 'profile-check') {
-
-               if((strlen($challenge)) && (strlen($sec))) {
-
+function dfrn_poll_post(App $a)
+{
+       $dfrn_id      = x($_POST,'dfrn_id')      ? $_POST['dfrn_id']              : '';
+       $challenge    = x($_POST,'challenge')    ? $_POST['challenge']            : '';
+       $url          = x($_POST,'url')          ? $_POST['url']                  : '';
+       $sec          = x($_POST,'sec')          ? $_POST['sec']                  : '';
+       $ptype        = x($_POST,'type')         ? $_POST['type']                 : '';
+       $dfrn_version = x($_POST,'dfrn_version') ? (float) $_POST['dfrn_version'] : 2.0;
+       $perm         = x($_POST,'perm')         ? $_POST['perm']                 : 'r';
+
+       if ($ptype === 'profile-check') {
+               if (strlen($challenge) && strlen($sec)) {
                        logger('dfrn_poll: POST: profile-check');
 
-                       q("DELETE FROM `profile_check` WHERE `expire` < " . intval(time()));
+                       DBA::delete('profile_check', ["`expire` < ?", time()]);
                        $r = q("SELECT * FROM `profile_check` WHERE `sec` = '%s' ORDER BY `expire` DESC LIMIT 1",
                                dbesc($sec)
                        );
-                       if (! dbm::is_result($r)) {
-                               xml_status(3, 'No ticket');
+                       if (!DBM::is_result($r)) {
+                               System::xmlExit(3, 'No ticket');
                                // NOTREACHED
                        }
+
                        $orig_id = $r[0]['dfrn_id'];
-                       if(strpos($orig_id, ':'))
-                               $orig_id = substr($orig_id,2);
+                       if (strpos($orig_id, ':')) {
+                               $orig_id = substr($orig_id, 2);
+                       }
 
                        $c = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
                                intval($r[0]['cid'])
                        );
-                       if (! dbm::is_result($c)) {
-                               xml_status(3, 'No profile');
+                       if (!DBM::is_result($c)) {
+                               System::xmlExit(3, 'No profile');
                        }
+
                        $contact = $c[0];
 
                        $sent_dfrn_id = hex2bin($dfrn_id);
-                       $challenge    = hex2bin($challenge);
+                       $challenge = hex2bin($challenge);
 
                        $final_dfrn_id = '';
 
-                       if(($contact['duplex']) && strlen($contact['prvkey'])) {
-                               openssl_private_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['prvkey']);
-                               openssl_private_decrypt($challenge,$decoded_challenge,$contact['prvkey']);
-                       }
-                       else {
-                               openssl_public_decrypt($sent_dfrn_id,$final_dfrn_id,$contact['pubkey']);
-                               openssl_public_decrypt($challenge,$decoded_challenge,$contact['pubkey']);
+                       if ($contact['duplex'] && strlen($contact['prvkey'])) {
+                               openssl_private_decrypt($sent_dfrn_id, $final_dfrn_id, $contact['prvkey']);
+                               openssl_private_decrypt($challenge, $decoded_challenge, $contact['prvkey']);
+                       } else {
+                               openssl_public_decrypt($sent_dfrn_id, $final_dfrn_id, $contact['pubkey']);
+                               openssl_public_decrypt($challenge, $decoded_challenge, $contact['pubkey']);
                        }
 
                        $final_dfrn_id = substr($final_dfrn_id, 0, strpos($final_dfrn_id, '.'));
 
-                       if(strpos($final_dfrn_id,':') == 1)
-                               $final_dfrn_id = substr($final_dfrn_id,2);
+                       if (strpos($final_dfrn_id, ':') == 1) {
+                               $final_dfrn_id = substr($final_dfrn_id, 2);
+                       }
 
-                       if($final_dfrn_id != $orig_id) {
+                       if ($final_dfrn_id != $orig_id) {
                                logger('profile_check: ' . $final_dfrn_id . ' != ' . $orig_id, LOGGER_DEBUG);
                                // did not decode properly - cannot trust this site
-                               xml_status(3, 'Bad decryption');
+                               System::xmlExit(3, 'Bad decryption');
                        }
 
                        header("Content-type: text/xml");
@@ -269,37 +288,31 @@ function dfrn_poll_post(App $a) {
                        killme();
                        // NOTREACHED
                }
-
        }
 
-       $direction    = (-1);
-       if(strpos($dfrn_id,':') == 1) {
-               $direction = intval(substr($dfrn_id,0,1));
-               $dfrn_id   = substr($dfrn_id,2);
+       $direction = -1;
+       if (strpos($dfrn_id, ':') == 1) {
+               $direction = intval(substr($dfrn_id, 0, 1));
+               $dfrn_id = substr($dfrn_id, 2);
        }
 
-
        $r = q("SELECT * FROM `challenge` WHERE `dfrn-id` = '%s' AND `challenge` = '%s' LIMIT 1",
                dbesc($dfrn_id),
                dbesc($challenge)
        );
 
-       if (! dbm::is_result($r)) {
+       if (!DBM::is_result($r)) {
                killme();
        }
 
        $type = $r[0]['type'];
        $last_update = $r[0]['last_update'];
 
-       $r = q("DELETE FROM `challenge` WHERE `dfrn-id` = '%s' AND `challenge` = '%s'",
-               dbesc($dfrn_id),
-               dbesc($challenge)
-       );
-
+       DBA::delete('challenge', ['dfrn-id' => $dfrn_id, 'challenge' => $challenge]);
 
        $sql_extra = '';
-       switch($direction) {
-               case (-1):
+       switch ($direction) {
+               case -1:
                        $sql_extra = sprintf(" AND `issued-id` = '%s' ", dbesc($dfrn_id));
                        $my_id = $dfrn_id;
                        break;
@@ -312,15 +325,12 @@ function dfrn_poll_post(App $a) {
                        $my_id = '0:' . $dfrn_id;
                        break;
                default:
-                       goaway(z_root());
+                       goaway(System::baseUrl());
                        break; // NOTREACHED
        }
 
-
        $r = q("SELECT * FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 $sql_extra LIMIT 1");
-
-
-       if (! dbm::is_result($r)) {
+       if (!DBM::is_result($r)) {
                killme();
        }
 
@@ -328,8 +338,7 @@ function dfrn_poll_post(App $a) {
        $owner_uid = $r[0]['uid'];
        $contact_id = $r[0]['id'];
 
-
-       if($type === 'reputation' && strlen($url)) {
+       if ($type === 'reputation' && strlen($url)) {
                $r = q("SELECT * FROM `contact` WHERE `url` = '%s' AND `uid` = %d LIMIT 1",
                        dbesc($url),
                        intval($owner_uid)
@@ -337,11 +346,11 @@ function dfrn_poll_post(App $a) {
                $reputation = 0;
                $text = '';
 
-               if (dbm::is_result($r)) {
+               if (DBM::is_result($r)) {
                        $reputation = $r[0]['rating'];
                        $text = $r[0]['reason'];
 
-                       if($r[0]['id'] == $contact_id) {        // inquiring about own reputation not allowed
+                       if ($r[0]['id'] == $contact_id) { // inquiring about own reputation not allowed
                                $reputation = 0;
                                $text = '';
                        }
@@ -356,18 +365,17 @@ function dfrn_poll_post(App $a) {
                ";
                killme();
                // NOTREACHED
-       }
-       else {
-
+       } else {
                // Update the writable flag if it changed
-               logger('dfrn_poll: post request feed: ' . print_r($_POST,true),LOGGER_DATA);
-               if($dfrn_version >= 2.21) {
-                       if($perm === 'rw')
+               logger('dfrn_poll: post request feed: ' . print_r($_POST, true), LOGGER_DATA);
+               if ($dfrn_version >= 2.21) {
+                       if ($perm === 'rw') {
                                $writable = 1;
-                       else
+                       } else {
                                $writable = 0;
+                       }
 
-                       if($writable !=  $contact['writable']) {
+                       if ($writable != $contact['writable']) {
                                q("UPDATE `contact` SET `writable` = %d WHERE `id` = %d",
                                        intval($writable),
                                        intval($contact_id)
@@ -376,40 +384,38 @@ function dfrn_poll_post(App $a) {
                }
 
                header("Content-type: application/atom+xml");
-               $o = dfrn::feed($dfrn_id, $a->argv[1], $last_update, $direction);
+               $o = DFRN::feed($dfrn_id, $a->argv[1], $last_update, $direction);
                echo $o;
                killme();
-
        }
 }
 
-function dfrn_poll_content(App $a) {
-
-       $dfrn_id         = ((x($_GET,'dfrn_id'))         ? $_GET['dfrn_id']              : '');
-       $type            = ((x($_GET,'type'))            ? $_GET['type']                 : 'data');
-       $last_update     = ((x($_GET,'last_update'))     ? $_GET['last_update']          : '');
-       $destination_url = ((x($_GET,'destination_url')) ? $_GET['destination_url']      : '');
-       $sec             = ((x($_GET,'sec'))             ? $_GET['sec']                  : '');
-       $dfrn_version    = ((x($_GET,'dfrn_version'))    ? (float) $_GET['dfrn_version'] : 2.0);
-       $perm            = ((x($_GET,'perm'))            ? $_GET['perm']                 : 'r');
-       $quiet           = ((x($_GET,'quiet'))           ? true                          : false);
-
-       $direction = (-1);
-       if(strpos($dfrn_id,':') == 1) {
-               $direction = intval(substr($dfrn_id,0,1));
-               $dfrn_id = substr($dfrn_id,2);
+function dfrn_poll_content(App $a)
+{
+       $dfrn_id         = x($_GET,'dfrn_id')         ? $_GET['dfrn_id']              : '';
+       $type            = x($_GET,'type')            ? $_GET['type']                 : 'data';
+       $last_update     = x($_GET,'last_update')     ? $_GET['last_update']          : '';
+       $destination_url = x($_GET,'destination_url') ? $_GET['destination_url']      : '';
+       $sec             = x($_GET,'sec')             ? $_GET['sec']                  : '';
+       $dfrn_version    = x($_GET,'dfrn_version')    ? (float) $_GET['dfrn_version'] : 2.0;
+       $perm            = x($_GET,'perm')            ? $_GET['perm']                 : 'r';
+       $quiet           = x($_GET,'quiet')           ? true                          : false;
+
+       $direction = -1;
+       if (strpos($dfrn_id, ':') == 1) {
+               $direction = intval(substr($dfrn_id, 0, 1));
+               $dfrn_id = substr($dfrn_id, 2);
        }
 
-
-       if($dfrn_id != '') {
+       if ($dfrn_id != '') {
                // initial communication from external contact
                $hash = random_string();
 
                $status = 0;
 
-               $r = q("DELETE FROM `challenge` WHERE `expire` < " . intval(time()));
+               DBA::delete('challenge', ["`expire` < ?", time()]);
 
-               if($type !== 'profile') {
+               if ($type !== 'profile') {
                        $r = q("INSERT INTO `challenge` ( `challenge`, `dfrn-id`, `expire` , `type`, `last_update` )
                                VALUES( '%s', '%s', '%s', '%s', '%s' ) ",
                                dbesc($hash),
@@ -419,13 +425,16 @@ function dfrn_poll_content(App $a) {
                                dbesc($last_update)
                        );
                }
+
                $sql_extra = '';
-               switch($direction) {
-                       case (-1):
-                               if($type === 'profile')
-                                       $sql_extra = sprintf(" AND ( `dfrn-id` = '%s' OR `issued-id` = '%s' ) ", dbesc($dfrn_id),dbesc($dfrn_id));
-                               else
+               switch ($direction) {
+                       case -1:
+                               if ($type === 'profile') {
+                                       $sql_extra = sprintf(" AND ( `dfrn-id` = '%s' OR `issued-id` = '%s' ) ", dbesc($dfrn_id), dbesc($dfrn_id));
+                               } else {
                                        $sql_extra = sprintf(" AND `issued-id` = '%s' ", dbesc($dfrn_id));
+                               }
+
                                $my_id = $dfrn_id;
                                break;
                        case 0:
@@ -437,7 +446,7 @@ function dfrn_poll_content(App $a) {
                                $my_id = '0:' . $dfrn_id;
                                break;
                        default:
-                               goaway(z_root());
+                               goaway(System::baseUrl());
                                break; // NOTREACHED
                }
 
@@ -449,94 +458,91 @@ function dfrn_poll_content(App $a) {
                        AND `user`.`nickname` = '%s' $sql_extra LIMIT 1",
                        dbesc($nickname)
                );
-
-               if (dbm::is_result($r)) {
-
+               if (DBM::is_result($r)) {
                        $challenge = '';
                        $encrypted_id = '';
-                       $id_str = $my_id . '.' . mt_rand(1000,9999);
-
-                       if(($r[0]['duplex'] && strlen($r[0]['pubkey'])) || (! strlen($r[0]['prvkey']))) {
-                               openssl_public_encrypt($hash,$challenge,$r[0]['pubkey']);
-                               openssl_public_encrypt($id_str,$encrypted_id,$r[0]['pubkey']);
-                       }
-                       else {
-                               openssl_private_encrypt($hash,$challenge,$r[0]['prvkey']);
-                               openssl_private_encrypt($id_str,$encrypted_id,$r[0]['prvkey']);
+                       $id_str = $my_id . '.' . mt_rand(1000, 9999);
+
+                       if (($r[0]['duplex'] && strlen($r[0]['pubkey'])) || !strlen($r[0]['prvkey'])) {
+                               openssl_public_encrypt($hash, $challenge, $r[0]['pubkey']);
+                               openssl_public_encrypt($id_str, $encrypted_id, $r[0]['pubkey']);
+                       } else {
+                               openssl_private_encrypt($hash, $challenge, $r[0]['prvkey']);
+                               openssl_private_encrypt($id_str, $encrypted_id, $r[0]['prvkey']);
                        }
 
                        $challenge = bin2hex($challenge);
                        $encrypted_id = bin2hex($encrypted_id);
-               }
-               else {
+               } else {
                        $status = 1;
                        $challenge = '';
                        $encrypted_id = '';
                }
 
-               if(($type === 'profile') && (strlen($sec))) {
-
+               if (($type === 'profile') && (strlen($sec))) {
                        // URL reply
-
-                       if($dfrn_version < 2.2) {
-                               $s = fetch_url($r[0]['poll']
+                       if ($dfrn_version < 2.2) {
+                               $s = Network::fetchUrl($r[0]['poll']
                                        . '?dfrn_id=' . $encrypted_id
                                        . '&type=profile-check'
                                        . '&dfrn_version=' . DFRN_PROTOCOL_VERSION
                                        . '&challenge=' . $challenge
                                        . '&sec=' . $sec
                                );
-                       }
-                       else {
-                               $s = post_url($r[0]['poll'], array(
+                       } else {
+                               $s = Network::post($r[0]['poll'], [
                                        'dfrn_id' => $encrypted_id,
                                        'type' => 'profile-check',
                                        'dfrn_version' => DFRN_PROTOCOL_VERSION,
                                        'challenge' => $challenge,
                                        'sec' => $sec
-                               ));
+                               ]);
                        }
 
-                       $profile = ((dbm::is_result($r) && $r[0]['nickname']) ? $r[0]['nickname'] : $nickname);
+                       $profile = ((DBM::is_result($r) && $r[0]['nickname']) ? $r[0]['nickname'] : $nickname);
 
-                       switch($destination_url) {
+                       switch ($destination_url) {
                                case 'profile':
-                                       $dest = App::get_baseurl() . '/profile/' . $profile . '?f=&tab=profile';
+                                       $dest = System::baseUrl() . '/profile/' . $profile . '?f=&tab=profile';
                                        break;
                                case 'photos':
-                                       $dest = App::get_baseurl() . '/photos/' . $profile;
+                                       $dest = System::baseUrl() . '/photos/' . $profile;
                                        break;
                                case 'status':
                                case '':
-                                       $dest = App::get_baseurl() . '/profile/' . $profile;
+                                       $dest = System::baseUrl() . '/profile/' . $profile;
                                        break;
                                default:
-                                       $dest = $destination_url . '?f=&redir=1';
+                                       $appendix = (strstr($destination_url, '?') ? '&f=&redir=1' : '?f=&redir=1');
+                                       $dest = $destination_url . $appendix;
                                        break;
                        }
 
                        logger("dfrn_poll: sec profile: " . $s, LOGGER_DATA);
 
-                       if(strlen($s) && strstr($s,'<?xml')) {
+                       if (strlen($s) && strstr($s, '<?xml')) {
+                               $xml = XML::parseString($s);
 
-                               $xml = parse_xml_string($s);
-
-                               logger('dfrn_poll: profile: parsed xml: ' . print_r($xml,true), LOGGER_DATA);
+                               logger('dfrn_poll: profile: parsed xml: ' . print_r($xml, true), LOGGER_DATA);
 
                                logger('dfrn_poll: secure profile: challenge: ' . $xml->challenge . ' expecting ' . $hash);
                                logger('dfrn_poll: secure profile: sec: ' . $xml->sec . ' expecting ' . $sec);
 
-
-                               if(((int) $xml->status == 0) && ($xml->challenge == $hash)  && ($xml->sec == $sec)) {
+                               if (((int) $xml->status == 0) && ($xml->challenge == $hash) && ($xml->sec == $sec)) {
                                        $_SESSION['authenticated'] = 1;
-                                       if(! x($_SESSION,'remote'))
-                                               $_SESSION['remote'] = array();
-                                       $_SESSION['remote'][] = array('cid' => $r[0]['id'],'uid' => $r[0]['uid'],'url' => $r[0]['url']);
+                                       if (!x($_SESSION, 'remote')) {
+                                               $_SESSION['remote'] = [];
+                                       }
+
+                                       $_SESSION['remote'][] = ['cid' => $r[0]['id'], 'uid' => $r[0]['uid'], 'url' => $r[0]['url']];
                                        $_SESSION['visitor_id'] = $r[0]['id'];
                                        $_SESSION['visitor_home'] = $r[0]['url'];
                                        $_SESSION['visitor_visiting'] = $r[0]['uid'];
-                                       if(!$quiet)
-                                               info( sprintf(t('%1$s welcomes %2$s'), $r[0]['username'] , $r[0]['name']) . EOL);
+                                       $_SESSION['my_url'] = $r[0]['url'];
+                                       if (!$quiet) {
+                                               info(L10n::t('%1$s welcomes %2$s', $r[0]['username'], $r[0]['name']) . EOL);
+                                       }
+
                                        // Visitors get 1 day session.
                                        $session_id = session_id();
                                        $expire = time() + 86400;
@@ -550,9 +556,7 @@ function dfrn_poll_content(App $a) {
                        }
                        goaway($dest);
                        // NOTREACHED
-
-               }
-               else {
+               } else {
                        // XML reply
                        header("Content-type: text/xml");
                        echo '<?xml version="1.0" encoding="UTF-8"?>' . "\r\n"
@@ -561,7 +565,7 @@ function dfrn_poll_content(App $a) {
                                . "\t" . '<dfrn_version>' . DFRN_PROTOCOL_VERSION . '</dfrn_version>' . "\r\n"
                                . "\t" . '<dfrn_id>' . $encrypted_id . '</dfrn_id>' . "\r\n"
                                . "\t" . '<challenge>' . $challenge . '</challenge>' . "\r\n"
-                               . '</dfrn_poll>' . "\r\n" ;
+                               . '</dfrn_poll>' . "\r\n";
                        killme();
                        // NOTREACHED
                }