]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_request.php
Rename removeTags to escapeTags
[friendica.git] / mod / dfrn_request.php
index 21c5d2c0fc118927c2b96840b4da07e2e72bec1f..26d7efda5250c027b80a1fa469b6c2feade3d7f2 100644 (file)
@@ -15,6 +15,9 @@
 use Friendica\App;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
+use Friendica\Core\Logger;
+use Friendica\Core\Protocol;
+use Friendica\Core\Renderer;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Model\Contact;
@@ -25,6 +28,7 @@ use Friendica\Module\Login;
 use Friendica\Network\Probe;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Strings;
 
 require_once 'include/enotify.php';
 
@@ -56,12 +60,12 @@ function dfrn_request_init(App $a)
 function dfrn_request_post(App $a)
 {
        if (($a->argc != 2) || (!count($a->profile))) {
-               logger('Wrong count of argc or profiles: argc=' . $a->argc . ',profile()=' . count($a->profile));
+               Logger::log('Wrong count of argc or profiles: argc=' . $a->argc . ',profile()=' . count($a->profile));
                return;
        }
 
        if (x($_POST, 'cancel')) {
-               goaway(System::baseUrl());
+               $a->internalRedirect();
        }
 
        /*
@@ -72,7 +76,7 @@ function dfrn_request_post(App $a)
        if ((x($_POST, 'localconfirm')) && ($_POST['localconfirm'] == 1)) {
                // Ensure this is a valid request
                if (local_user() && ($a->user['nickname'] == $a->argv[1]) && (x($_POST, 'dfrn_url'))) {
-                       $dfrn_url = notags(trim($_POST['dfrn_url']));
+                       $dfrn_url = Strings::escapeTags(trim($_POST['dfrn_url']));
                        $aes_allow = (((x($_POST, 'aes_allow')) && ($_POST['aes_allow'] == 1)) ? 1 : 0);
                        $confirm_key = ((x($_POST, 'confirm_key')) ? $_POST['confirm_key'] : "");
                        $hidden = ((x($_POST, 'hidden-contact')) ? intval($_POST['hidden-contact']) : 0);
@@ -84,7 +88,7 @@ function dfrn_request_post(App $a)
                                // Lookup the contact based on their URL (which is the only unique thing we have at the moment)
                                $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND NOT `self` LIMIT 1",
                                        intval(local_user()),
-                                       DBA::escape(normalise_link($dfrn_url))
+                                       DBA::escape(Strings::normaliseLink($dfrn_url))
                                );
 
                                if (DBA::isResult($r)) {
@@ -133,12 +137,12 @@ function dfrn_request_post(App $a)
 
                                        // Create a contact record on our site for the other person
                                        $r = q("INSERT INTO `contact` ( `uid`, `created`,`url`, `nurl`, `addr`, `name`, `nick`, `photo`, `site-pubkey`,
-                                               `request`, `confirm`, `notify`, `poll`, `poco`, `network`, `aes_allow`, `hidden`, `blocked`, `pending`)
-                                               VALUES ( %d, '%s', '%s', '%s', '%s', '%s' , '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d)",
+                                               `request`, `confirm`, `notify`, `poll`, `network`, `aes_allow`, `hidden`, `blocked`, `pending`)
+                                               VALUES ( %d, '%s', '%s', '%s', '%s', '%s' , '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d)",
                                                intval(local_user()),
                                                DateTimeFormat::utcNow(),
                                                DBA::escape($dfrn_url),
-                                               DBA::escape(normalise_link($dfrn_url)),
+                                               DBA::escape(Strings::normaliseLink($dfrn_url)),
                                                $parms['addr'],
                                                $parms['fn'],
                                                $parms['nick'],
@@ -148,8 +152,7 @@ function dfrn_request_post(App $a)
                                                $parms['dfrn-confirm'],
                                                $parms['dfrn-notify'],
                                                $parms['dfrn-poll'],
-                                               $parms['dfrn-poco'],
-                                               DBA::escape(NETWORK_DFRN),
+                                               DBA::escape(Protocol::DFRN),
                                                intval($aes_allow),
                                                intval($hidden),
                                                intval($blocked),
@@ -173,9 +176,9 @@ function dfrn_request_post(App $a)
                                                Contact::updateAvatar($photo, local_user(), $r[0]["id"], true);
                                        }
 
-                                       $forwardurl = System::baseUrl() . "/contacts/" . $r[0]['id'];
+                                       $forward_path = "contact/" . $r[0]['id'];
                                } else {
-                                       $forwardurl = System::baseUrl() . "/contacts";
+                                       $forward_path = "contact";
                                }
 
                                // Allow the blocked remote notification to complete
@@ -188,14 +191,14 @@ function dfrn_request_post(App $a)
                                }
 
                                // (ignore reply, nothing we can do it failed)
-                               goaway($forwardurl);
+                               $a->internalRedirect($forward_path);
                                return; // NOTREACHED
                        }
                }
 
                // invalid/bogus request
                notice(L10n::t('Unrecoverable protocol error.') . EOL);
-               goaway(System::baseUrl());
+               $a->internalRedirect();
                return; // NOTREACHED
        }
 
@@ -267,7 +270,7 @@ function dfrn_request_post(App $a)
                        }
                }
 
-               $real_name = x($_POST, 'realname') ? notags(trim($_POST['realname'])) : '';
+               $real_name = x($_POST, 'realname') ? Strings::escapeTags(trim($_POST['realname'])) : '';
 
                $url = trim($_POST['dfrn_url']);
                if (!strlen($url)) {
@@ -288,18 +291,18 @@ function dfrn_request_post(App $a)
                        // Every time we detect the remote subscription we define this as OStatus.
                        // We do this even if it is not OStatus.
                        // we only need to pass this through another section of the code.
-                       if ($network != NETWORK_DIASPORA) {
-                               $network = NETWORK_OSTATUS;
+                       if ($network != Protocol::DIASPORA) {
+                               $network = Protocol::OSTATUS;
                        }
 
                        $url = substr($url, 5);
                } else {
-                       $network = NETWORK_DFRN;
+                       $network = Protocol::DFRN;
                }
 
-               logger('dfrn_request: url: ' . $url . ',network=' . $network, LOGGER_DEBUG);
+               Logger::log('dfrn_request: url: ' . $url . ',network=' . $network, Logger::DEBUG);
 
-               if ($network === NETWORK_DFRN) {
+               if ($network === Protocol::DFRN) {
                        $ret = q("SELECT * FROM `contact` WHERE `uid` = %d AND `url` = '%s' AND `self` = 0 LIMIT 1",
                                intval($uid),
                                DBA::escape($url)
@@ -318,7 +321,7 @@ function dfrn_request_post(App $a)
                                }
                        }
 
-                       $issued_id = random_string();
+                       $issued_id = Strings::getRandomHex();
 
                        if (is_array($contact_record)) {
                                // There is a contact record but no issued-id, so this
@@ -331,19 +334,19 @@ function dfrn_request_post(App $a)
                                $url = Network::isUrlValid($url);
                                if (!$url) {
                                        notice(L10n::t('Invalid profile URL.') . EOL);
-                                       goaway(System::baseUrl() . '/' . $a->cmd);
+                                       $a->internalRedirect($a->cmd);
                                        return; // NOTREACHED
                                }
 
                                if (!Network::isUrlAllowed($url)) {
                                        notice(L10n::t('Disallowed profile URL.') . EOL);
-                                       goaway(System::baseUrl() . '/' . $a->cmd);
+                                       $a->internalRedirect($a->cmd);
                                        return; // NOTREACHED
                                }
 
                                if (Network::isUrlBlocked($url)) {
                                        notice(L10n::t('Blocked domain') . EOL);
-                                       goaway(System::baseUrl() . '/' . $a->cmd);
+                                       $a->internalRedirect($a->cmd);
                                        return; // NOTREACHED
                                }
 
@@ -351,7 +354,7 @@ function dfrn_request_post(App $a)
 
                                if (!count($parms)) {
                                        notice(L10n::t('Profile location is not valid or does not contain profile information.') . EOL);
-                                       goaway(System::baseUrl() . '/' . $a->cmd);
+                                       $a->internalRedirect($a->cmd);
                                } else {
                                        if (!x($parms, 'fn')) {
                                                notice(L10n::t('Warning: profile location has no identifiable owner name.') . EOL);
@@ -373,12 +376,12 @@ function dfrn_request_post(App $a)
 
                                DBA::escapeArray($parms);
                                $r = q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `name`, `nick`, `issued-id`, `photo`, `site-pubkey`,
-                                       `request`, `confirm`, `notify`, `poll`, `poco`, `network`, `blocked`, `pending` )
-                                       VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d )",
+                                       `request`, `confirm`, `notify`, `poll`, `network`, `blocked`, `pending` )
+                                       VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d )",
                                        intval($uid),
                                        DBA::escape(DateTimeFormat::utcNow()),
                                        $parms['url'],
-                                       DBA::escape(normalise_link($url)),
+                                       DBA::escape(Strings::normaliseLink($url)),
                                        $parms['addr'],
                                        $parms['fn'],
                                        $parms['nick'],
@@ -389,8 +392,7 @@ function dfrn_request_post(App $a)
                                        $parms['dfrn-confirm'],
                                        $parms['dfrn-notify'],
                                        $parms['dfrn-poll'],
-                                       $parms['dfrn-poco'],
-                                       DBA::escape(NETWORK_DFRN),
+                                       DBA::escape(Protocol::DFRN),
                                        intval($blocked),
                                        intval($pending)
                                );
@@ -414,7 +416,7 @@ function dfrn_request_post(App $a)
                                return;
                        }
 
-                       $hash = random_string() . (string) time();   // Generate a confirm_key
+                       $hash = Strings::getRandomHex() . (string) time();   // Generate a confirm_key
 
                        if (is_array($contact_record)) {
                                $ret = q("INSERT INTO `intro` ( `uid`, `contact-id`, `blocked`, `knowyou`, `note`, `hash`, `datetime`)
@@ -422,7 +424,7 @@ function dfrn_request_post(App $a)
                                        intval($uid),
                                        intval($contact_record['id']),
                                        ((x($_POST,'knowyou') && ($_POST['knowyou'] == 1)) ? 1 : 0),
-                                       DBA::escape(notags(trim(defaults($_POST, 'dfrn-request-message', '')))),
+                                       DBA::escape(Strings::escapeTags(trim(defaults($_POST, 'dfrn-request-message', '')))),
                                        DBA::escape($hash),
                                        DBA::escape(DateTimeFormat::utcNow())
                                );
@@ -434,39 +436,39 @@ function dfrn_request_post(App $a)
                        }
 
                        // "Homecoming" - send the requestor back to their site to record the introduction.
-                       $dfrn_url = bin2hex(System::baseUrl() . '/profile/' . $nickname);
+                       $dfrn_url = bin2hex($a->getBaseURL() . '/profile/' . $nickname);
                        $aes_allow = ((function_exists('openssl_encrypt')) ? 1 : 0);
 
-                       goaway($parms['dfrn-request'] . "?dfrn_url=$dfrn_url"
+                       System::externalRedirect($parms['dfrn-request'] . "?dfrn_url=$dfrn_url"
                                . '&dfrn_version=' . DFRN_PROTOCOL_VERSION
                                . '&confirm_key=' . $hash
                                . (($aes_allow) ? "&aes_allow=1" : "")
                        );
                        // NOTREACHED
-                       // END $network === NETWORK_DFRN
-               } elseif (($network != NETWORK_PHANTOM) && ($url != "")) {
+                       // END $network === Protocol::DFRN
+               } elseif (($network != Protocol::PHANTOM) && ($url != "")) {
 
                        /* Substitute our user's feed URL into $url template
                         * Send the subscriber home to subscribe
                         */
                        // Diaspora needs the uri in the format user@domain.tld
                        // Diaspora will support the remote subscription in a future version
-                       if ($network == NETWORK_DIASPORA) {
-                               $uri = $nickname . '@' . $a->get_hostname();
+                       if ($network == Protocol::DIASPORA) {
+                               $uri = $nickname . '@' . $a->getHostName();
 
-                               if ($a->get_path()) {
-                                       $uri .= '/' . $a->get_path();
+                               if ($a->getURLPath()) {
+                                       $uri .= '/' . $a->getURLPath();
                                }
 
                                $uri = urlencode($uri);
                        } else {
-                               $uri = System::baseUrl() . '/profile/' . $nickname;
+                               $uri = 'profile/' . $nickname;
                        }
 
                        $url = str_replace('{uri}', $uri, $url);
-                       goaway($url);
+                       System::externalRedirect($url);
                        // NOTREACHED
-                       // END $network != NETWORK_PHANTOM
+                       // END $network != Protocol::PHANTOM
                } else {
                        notice(L10n::t("Remote subscription can't be done for your network. Please subscribe directly on your system.") . EOL);
                        return;
@@ -496,12 +498,12 @@ function dfrn_request_content(App $a)
                        return Login::form();
                }
 
-               $dfrn_url = notags(trim(hex2bin($_GET['dfrn_url'])));
+               $dfrn_url = Strings::escapeTags(trim(hex2bin($_GET['dfrn_url'])));
                $aes_allow = x($_GET, 'aes_allow') && $_GET['aes_allow'] == 1 ? 1 : 0;
                $confirm_key = x($_GET, 'confirm_key') ? $_GET['confirm_key'] : "";
 
                // Checking fastlane for validity
-               if (x($_SESSION, "fastlane") && (normalise_link($_SESSION["fastlane"]) == normalise_link($dfrn_url))) {
+               if (x($_SESSION, "fastlane") && (Strings::normaliseLink($_SESSION["fastlane"]) == Strings::normaliseLink($dfrn_url))) {
                        $_POST["dfrn_url"] = $dfrn_url;
                        $_POST["confirm_key"] = $confirm_key;
                        $_POST["localconfirm"] = 1;
@@ -514,8 +516,8 @@ function dfrn_request_content(App $a)
                        return; // NOTREACHED
                }
 
-               $tpl = get_markup_template("dfrn_req_confirm.tpl");
-               $o = replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate("dfrn_req_confirm.tpl");
+               $o = Renderer::replaceMacros($tpl, [
                        '$dfrn_url' => $dfrn_url,
                        '$aes_allow' => (($aes_allow) ? '<input type="hidden" name="aes_allow" value="1" />' : "" ),
                        '$hidethem' => L10n::t('Hide this contact'),
@@ -610,7 +612,7 @@ function dfrn_request_content(App $a)
                } elseif (x($_GET, 'address') && ($_GET['address'] != "")) {
                        $myaddr = $_GET['address'];
                } elseif (local_user()) {
-                       if (strlen($a->urlpath)) {
+                       if (strlen($a->getURLPath())) {
                                $myaddr = System::baseUrl() . '/profile/' . $a->user['nickname'];
                        } else {
                                $myaddr = $a->user['nickname'] . '@' . substr(System::baseUrl(), strpos(System::baseUrl(), '://') + 3);
@@ -627,9 +629,9 @@ function dfrn_request_content(App $a)
                 * it doesn't matter if they know you or not.
                 */
                if ($a->profile['page-flags'] == Contact::PAGE_NORMAL) {
-                       $tpl = get_markup_template('dfrn_request.tpl');
+                       $tpl = Renderer::getMarkupTemplate('dfrn_request.tpl');
                } else {
-                       $tpl = get_markup_template('auto_request.tpl');
+                       $tpl = Renderer::getMarkupTemplate('auto_request.tpl');
                }
 
                $page_desc = L10n::t("Please enter your 'Identity Address' from one of the following supported communications networks:");
@@ -639,7 +641,7 @@ function dfrn_request_content(App $a)
                        get_server() . '/servers'
                );
 
-               $o = replace_macros($tpl, [
+               $o = Renderer::replaceMacros($tpl, [
                        '$header' => L10n::t('Friend/Connection Request'),
                        '$desc' => L10n::t('Examples: jojo@demo.friendica.com, http://demo.friendica.com/profile/jojo, testuser@gnusocial.de'),
                        '$pls_answer' => L10n::t('Please answer the following:'),