]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_request.php
Remove unused upubkey and uprvkey from queries
[friendica.git] / mod / dfrn_request.php
index c8742394b5fdd3ce8497da011ac623f2f8d13c45..39b212fbddc37a4847d51e09739dfc4ae9292739 100644 (file)
@@ -8,14 +8,21 @@
  * friend requests.
  *
  * @see PDF with dfrn specs: https://github.com/friendica/friendica/blob/master/spec/dfrn2.pdf
+ *    You also find a graphic which describes the confirmation process at
+ *    https://github.com/friendica/friendica/blob/master/spec/dfrn2_contact_request.png
  */
 
-require_once('include/enotify.php');
-require_once('include/Scrape.php');
-require_once('include/Probe.php');
-require_once('include/group.php');
+use Friendica\App;
+use Friendica\Core\Config;
+use Friendica\Core\PConfig;
+use Friendica\Core\System;
+use Friendica\Database\DBM;
+use Friendica\Network\Probe;
 
-function dfrn_request_init(&$a) {
+require_once 'include/enotify.php';
+require_once 'include/group.php';
+
+function dfrn_request_init(App $a) {
 
        if($a->argc > 1)
                $which = $a->argv[1];
@@ -40,7 +47,7 @@ function dfrn_request_init(&$a) {
  * After logging in, we click 'submit' to approve the linkage.
  *
  */
-function dfrn_request_post(&$a) {
+function dfrn_request_post(App $a) {
 
        if(($a->argc != 2) || (! count($a->profile))) {
                logger('Wrong count of argc or profiles: argc=' . $a->argc . ',profile()=' . count($a->profile));
@@ -49,7 +56,7 @@ function dfrn_request_post(&$a) {
 
 
        if(x($_POST, 'cancel')) {
-               goaway(z_root());
+               goaway(System::baseUrl());
        }
 
 
@@ -75,6 +82,8 @@ function dfrn_request_post(&$a) {
                        $confirm_key = ((x($_POST,'confirm_key')) ? $_POST['confirm_key'] : "");
                        $hidden = ((x($_POST,'hidden-contact')) ? intval($_POST['hidden-contact']) : 0);
                        $contact_record = null;
+                       $blocked = 1;
+                       $pending = 1;
 
                        if(x($dfrn_url)) {
 
@@ -83,11 +92,11 @@ function dfrn_request_post(&$a) {
                                 */
 
                                $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND NOT `self` LIMIT 1",
-                                       dbesc($dfrn_url),
+                                       intval(local_user()),
                                        dbesc(normalise_link($dfrn_url))
                                );
 
-                               if(count($r)) {
+                               if (DBM::is_result($r)) {
                                        if(strlen($r[0]['dfrn-id'])) {
 
                                                /*
@@ -116,17 +125,19 @@ function dfrn_request_post(&$a) {
 
                                        $parms = Probe::profile($dfrn_url);
 
-                                       if(! count($parms)) {
+                                       if (! count($parms)) {
                                                notice( t('Profile location is not valid or does not contain profile information.') . EOL );
                                                return;
                                        }
                                        else {
-                                               if(! x($parms,'fn'))
+                                               if (! x($parms,'fn')) {
                                                        notice( t('Warning: profile location has no identifiable owner name.') . EOL );
-                                               if(! x($parms,'photo'))
+                                               }
+                                               if (! x($parms,'photo')) {
                                                        notice( t('Warning: profile location has no profile photo.') . EOL );
-                                               $invalid = Probe::valid_dfrn($parms);
-                                               if($invalid) {
+                                               }
+                                               $invalid = Probe::validDfrn($parms);
+                                               if ($invalid) {
                                                        notice( sprintf( tt("%d required parameter was not found at the given location",
                                                                                                "%d required parameters were not found at the given location",
                                                                                                $invalid), $invalid) . EOL );
@@ -139,17 +150,15 @@ function dfrn_request_post(&$a) {
                                        $photo = $parms["photo"];
 
                                        // Escape the entire array
-
-                                       dbesc_array($parms);
-
+                                       DBM::esc_array($parms);
 
                                        /*
                                         * Create a contact record on our site for the other person
                                         */
 
                                        $r = q("INSERT INTO `contact` ( `uid`, `created`,`url`, `nurl`, `addr`, `name`, `nick`, `photo`, `site-pubkey`,
-                                               `request`, `confirm`, `notify`, `poll`, `poco`, `network`, `aes_allow`, `hidden`)
-                                               VALUES ( %d, '%s', '%s', '%s', '%s', '%s' , '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d)",
+                                               `request`, `confirm`, `notify`, `poll`, `poco`, `network`, `aes_allow`, `hidden`, `blocked`, `pending`)
+                                               VALUES ( %d, '%s', '%s', '%s', '%s', '%s' , '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d, %d, %d)",
                                                intval(local_user()),
                                                datetime_convert(),
                                                dbesc($dfrn_url),
@@ -166,11 +175,13 @@ function dfrn_request_post(&$a) {
                                                $parms['dfrn-poco'],
                                                dbesc(NETWORK_DFRN),
                                                intval($aes_allow),
-                                               intval($hidden)
+                                               intval($hidden),
+                                               intval($blocked),
+                                               intval($pending)
                                        );
                                }
 
-                               if($r) {
+                               if ($r) {
                                        info( t("Introduction complete.") . EOL);
                                }
 
@@ -179,7 +190,7 @@ function dfrn_request_post(&$a) {
                                        dbesc($dfrn_url),
                                        $parms['key'] // this was already escaped
                                );
-                               if(count($r)) {
+                               if (DBM::is_result($r)) {
                                        $def_gid = get_default_group(local_user(), $r[0]["network"]);
                                        if(intval($def_gid))
                                                group_add_member(local_user(), '', $r[0]['id'], $def_gid);
@@ -187,19 +198,22 @@ function dfrn_request_post(&$a) {
                                        if (isset($photo))
                                                update_contact_avatar($photo, local_user(), $r[0]["id"], true);
 
-                                       $forwardurl = $a->get_baseurl()."/contacts/".$r[0]['id'];
-                               } else
-                                       $forwardurl = $a->get_baseurl()."/contacts";
+                                       $forwardurl = System::baseUrl()."/contacts/".$r[0]['id'];
+                               } else {
+                                       $forwardurl = System::baseUrl()."/contacts";
+                               }
 
                                /*
                                 * Allow the blocked remote notification to complete
                                 */
 
-                               if(is_array($contact_record))
+                               if (is_array($contact_record)) {
                                        $dfrn_request = $contact_record['request'];
+                               }
 
-                               if(strlen($dfrn_request) && strlen($confirm_key))
+                               if (strlen($dfrn_request) && strlen($confirm_key)) {
                                        $s = fetch_url($dfrn_request . '?confirm_key=' . $confirm_key);
+                               }
 
                                // (ignore reply, nothing we can do it failed)
 
@@ -214,7 +228,7 @@ function dfrn_request_post(&$a) {
                // invalid/bogus request
 
                notice( t('Unrecoverable protocol error.') . EOL );
-               goaway(z_root());
+               goaway(System::baseUrl());
                return; // NOTREACHED
        }
 
@@ -252,6 +266,8 @@ function dfrn_request_post(&$a) {
        $contact_record = null;
        $failed         = false;
        $parms          = null;
+       $blocked = 1;
+       $pending = 1;
 
 
        if( x($_POST,'dfrn_url')) {
@@ -265,7 +281,7 @@ function dfrn_request_post(&$a) {
                                dbesc(datetime_convert('UTC','UTC','now - 24 hours')),
                                intval($uid)
                        );
-                       if(count($r) > $maxreq) {
+                       if (DBM::is_result($r) && count($r) > $maxreq) {
                                notice( sprintf( t('%s has received too many connection requests today.'),  $a->profile['name']) . EOL);
                                notice( t('Spam protection measures have been invoked.') . EOL);
                                notice( t('Friends are advised to please try again in 24 hours.') . EOL);
@@ -287,10 +303,10 @@ function dfrn_request_post(&$a) {
                        AND `intro`.`datetime` < UTC_TIMESTAMP() - INTERVAL 30 MINUTE ",
                        dbesc(NETWORK_MAIL2)
                );
-               if(count($r)) {
-                       foreach($r as $rr) {
+               if (DBM::is_result($r)) {
+                       foreach ($r as $rr) {
                                if(! $rr['rel']) {
-                                       q("DELETE FROM `contact` WHERE `id` = %d",
+                                       q("DELETE FROM `contact` WHERE `id` = %d AND NOT `self`",
                                                intval($rr['cid'])
                                        );
                                }
@@ -312,10 +328,10 @@ function dfrn_request_post(&$a) {
                        AND `intro`.`datetime` < UTC_TIMESTAMP() - INTERVAL 3 DAY ",
                        dbesc(NETWORK_MAIL2)
                );
-               if(count($r)) {
-                       foreach($r as $rr) {
+               if (DBM::is_result($r)) {
+                       foreach ($r as $rr) {
                                if(! $rr['rel']) {
-                                       q("DELETE FROM `contact` WHERE `id` = %d",
+                                       q("DELETE FROM `contact` WHERE `id` = %d AND NOT `self`",
                                                intval($rr['cid'])
                                        );
                                }
@@ -350,13 +366,11 @@ function dfrn_request_post(&$a) {
                        $nurl    = normalise_url($host);
                        $poll    = 'email ' . random_string();
                        $notify  = 'smtp ' . random_string();
-                       $blocked = 1;
-                       $pending = 1;
                        $network = NETWORK_MAIL2;
                        $rel     = CONTACT_IS_FOLLOWER;
 
-                       $mail_disabled = ((function_exists('imap_open') && (! get_config('system','imap_disabled'))) ? 0 : 1);
-                       if(get_config('system','dfrn_only'))
+                       $mail_disabled = ((function_exists('imap_open') && (! Config::get('system','imap_disabled'))) ? 0 : 1);
+                       if(Config::get('system','dfrn_only'))
                                $mail_disabled = 1;
 
                        if(! $mail_disabled) {
@@ -364,8 +378,8 @@ function dfrn_request_post(&$a) {
                                $r = q("SELECT * FROM `mailacct` WHERE `uid` = %d LIMIT 1",
                                        intval($uid)
                                );
-                               if(! count($r)) {
 
+                               if (! DBM::is_result($r)) {
                                        notice( t('This account has not been configured for email. Request failed.') . EOL);
                                        return;
                                }
@@ -392,7 +406,7 @@ function dfrn_request_post(&$a) {
                                dbesc($poll),
                                intval($uid)
                        );
-                       if(count($r)) {
+                       if (DBM::is_result($r)) {
                                $contact_id = $r[0]['id'];
 
                                $def_gid = get_default_group($uid, $r[0]["network"]);
@@ -425,8 +439,8 @@ function dfrn_request_post(&$a) {
 
                        $hash = random_string();
 
-                       $r = q("insert into intro ( uid, `contact-id`, knowyou, note, hash, datetime, blocked )
-                               values( %d , %d, %d, '%s', '%s', '%s', %d ) ",
+                       $r = q("INSERT INTO `intro` ( `uid`, `contact-id`, knowyou, note, hash, datetime, blocked )
+                               VALUES( %d , %d, %d, '%s', '%s', '%s', %d ) ",
                                intval($uid),
                                intval($contact_id),
                                ((x($_POST,'knowyou') && ($_POST['knowyou'] == 1)) ? 1 : 0),
@@ -440,11 +454,11 @@ function dfrn_request_post(&$a) {
 
                } else {
                        // Detect the network
-                       $data = probe_url($url);
+                       $data = Probe::uri($url);
                        $network = $data["network"];
 
                        // Canonicalise email-style profile locator
-                       $url = Probe::webfinger_dfrn($url,$hcard);
+                       $url = Probe::webfingerDfrn($url,$hcard);
 
                        if (substr($url,0,5) === 'stat:') {
 
@@ -467,7 +481,7 @@ function dfrn_request_post(&$a) {
                                dbesc($url)
                        );
 
-                       if(count($ret)) {
+                       if (DBM::is_result($ret)) {
                                if(strlen($ret[0]['issued-id'])) {
                                        notice( t('You have already introduced yourself here.') . EOL );
                                        return;
@@ -493,34 +507,39 @@ function dfrn_request_post(&$a) {
                                );
                        }
                        else {
-                               if(! validate_url($url)) {
+                               if (! validate_url($url)) {
                                        notice( t('Invalid profile URL.') . EOL);
-                                       goaway($a->get_baseurl() . '/' . $a->cmd);
+                                       goaway(System::baseUrl() . '/' . $a->cmd);
                                        return; // NOTREACHED
                                }
 
-                               if(! allowed_url($url)) {
+                               if (! allowed_url($url)) {
                                        notice( t('Disallowed profile URL.') . EOL);
-                                       goaway($a->get_baseurl() . '/' . $a->cmd);
+                                       goaway(System::baseUrl() . '/' . $a->cmd);
                                        return; // NOTREACHED
                                }
 
-
-                               require_once('include/Scrape.php');
+                               if (blocked_url($url)) {
+                                       notice( t('Blocked domain') . EOL);
+                                       goaway(System::baseUrl() . '/' . $a->cmd);
+                                       return; // NOTREACHED
+                               }
 
                                $parms = Probe::profile(($hcard) ? $hcard : $url);
 
-                               if(! count($parms)) {
+                               if (! count($parms)) {
                                        notice( t('Profile location is not valid or does not contain profile information.') . EOL );
-                                       goaway($a->get_baseurl() . '/' . $a->cmd);
+                                       goaway(System::baseUrl() . '/' . $a->cmd);
                                }
                                else {
-                                       if(! x($parms,'fn'))
+                                       if (! x($parms,'fn')) {
                                                notice( t('Warning: profile location has no identifiable owner name.') . EOL );
-                                       if(! x($parms,'photo'))
+                                       }
+                                       if (! x($parms,'photo')) {
                                                notice( t('Warning: profile location has no profile photo.') . EOL );
-                                       $invalid = Probe::valid_dfrn($parms);
-                                       if($invalid) {
+                                       }
+                                       $invalid = Probe::validDfrn($parms);
+                                       if ($invalid) {
                                                notice( sprintf( tt("%d required parameter was not found at the given location",
                                                                                        "%d required parameters were not found at the given location",
                                                                                        $invalid), $invalid) . EOL );
@@ -534,10 +553,10 @@ function dfrn_request_post(&$a) {
                                $parms['issued-id'] = $issued_id;
                                $photo = $parms["photo"];
 
-                               dbesc_array($parms);
+                               DBM::esc_array($parms);
                                $r = q("INSERT INTO `contact` ( `uid`, `created`, `url`, `nurl`, `addr`, `name`, `nick`, `issued-id`, `photo`, `site-pubkey`,
-                                       `request`, `confirm`, `notify`, `poll`, `poco`, `network` )
-                                       VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s' )",
+                                       `request`, `confirm`, `notify`, `poll`, `poco`, `network`, `blocked`, `pending` )
+                                       VALUES ( %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, %d )",
                                        intval($uid),
                                        dbesc(datetime_convert()),
                                        $parms['url'],
@@ -553,32 +572,34 @@ function dfrn_request_post(&$a) {
                                        $parms['dfrn-notify'],
                                        $parms['dfrn-poll'],
                                        $parms['dfrn-poco'],
-                                       dbesc(NETWORK_DFRN)
+                                       dbesc(NETWORK_DFRN),
+                                       intval($blocked),
+                                       intval($pending)
                                );
 
                                // find the contact record we just created
-                               if($r) {
+                               if ($r) {
                                        $r = q("SELECT `id` FROM `contact`
                                                WHERE `uid` = %d AND `url` = '%s' AND `issued-id` = '%s' LIMIT 1",
                                                intval($uid),
                                                $parms['url'],
                                                $parms['issued-id']
                                        );
-                                       if(count($r)) {
+                                       if (DBM::is_result($r)) {
                                                $contact_record = $r[0];
                                                update_contact_avatar($photo, $uid, $contact_record["id"], true);
                                        }
                                }
 
                        }
-                       if($r === false) {
+                       if ($r === false) {
                                notice( t('Failed to update contact record.') . EOL );
                                return;
                        }
 
                        $hash = random_string() . (string) time();   // Generate a confirm_key
 
-                       if(is_array($contact_record)) {
+                       if (is_array($contact_record)) {
                                $ret = q("INSERT INTO `intro` ( `uid`, `contact-id`, `blocked`, `knowyou`, `note`, `hash`, `datetime`)
                                        VALUES ( %d, %d, 1, %d, '%s', '%s', '%s' )",
                                        intval($uid),
@@ -592,12 +613,13 @@ function dfrn_request_post(&$a) {
 
                        // This notice will only be seen by the requestor if the requestor and requestee are on the same server.
 
-                       if(! $failed)
+                       if (! $failed) {
                                info( t('Your introduction has been sent.') . EOL );
+                       }
 
                        // "Homecoming" - send the requestor back to their site to record the introduction.
 
-                       $dfrn_url = bin2hex($a->get_baseurl() . '/profile/' . $nickname);
+                       $dfrn_url = bin2hex(System::baseUrl() . '/profile/' . $nickname);
                        $aes_allow = ((function_exists('openssl_encrypt')) ? 1 : 0);
 
                        goaway($parms['dfrn-request'] . "?dfrn_url=$dfrn_url"
@@ -607,7 +629,7 @@ function dfrn_request_post(&$a) {
                        );
                        // NOTREACHED
                        // END $network === NETWORK_DFRN
-               } elseif (($network != NETWORK_PHANTOM) AND ($url != "")) {
+               } elseif (($network != NETWORK_PHANTOM) && ($url != "")) {
 
                        /*
                         *
@@ -625,8 +647,9 @@ function dfrn_request_post(&$a) {
                                        $uri .= '/'.$a->get_path();
 
                                $uri = urlencode($uri);
-                       } else
-                               $uri = $a->get_baseurl().'/profile/'.$nickname;
+                       } else {
+                               $uri = System::baseUrl().'/profile/'.$nickname;
+                       }
 
                        $url = str_replace('{uri}', $uri, $url);
                        goaway($url);
@@ -641,18 +664,19 @@ function dfrn_request_post(&$a) {
 }
 
 
-function dfrn_request_content(&$a) {
+function dfrn_request_content(App $a) {
 
-       if(($a->argc != 2) || (! count($a->profile)))
+       if (($a->argc != 2) || (! count($a->profile))) {
                return "";
+       }
 
 
        // "Homecoming". Make sure we're logged in to this site as the correct user. Then offer a confirm button
        // to send us to the post section to record the introduction.
 
-       if(x($_GET,'dfrn_url')) {
+       if (x($_GET,'dfrn_url')) {
 
-               if(! local_user()) {
+               if (! local_user()) {
                        info( t("Please login to confirm introduction.") . EOL );
                        /* setup the return URL to come back to this page if they use openid */
                        $_SESSION['return_url'] = $a->query_string;
@@ -672,7 +696,7 @@ function dfrn_request_content(&$a) {
                $confirm_key = (x($_GET,'confirm_key') ? $_GET['confirm_key'] : "");
 
                // Checking fastlane for validity
-               if (x($_SESSION, "fastlane") AND (normalise_link($_SESSION["fastlane"]) == normalise_link($dfrn_url))) {
+               if (x($_SESSION, "fastlane") && (normalise_link($_SESSION["fastlane"]) == normalise_link($dfrn_url))) {
                        $_POST["dfrn_url"] = $dfrn_url;
                        $_POST["confirm_key"] = $confirm_key;
                        $_POST["localconfirm"] = 1;
@@ -712,7 +736,7 @@ function dfrn_request_content(&$a) {
                        dbesc($_GET['confirm_key'])
                );
 
-               if(count($intro)) {
+               if (DBM::is_result($intro)) {
 
                        $r = q("SELECT `contact`.*, `user`.* FROM `contact` LEFT JOIN `user` ON `contact`.`uid` = `user`.`uid`
                                WHERE `contact`.`id` = %d LIMIT 1",
@@ -721,7 +745,7 @@ function dfrn_request_content(&$a) {
 
                        $auto_confirm = false;
 
-                       if(count($r)) {
+                       if (DBM::is_result($r)) {
                                if(($r[0]['page-flags'] != PAGE_NORMAL) && ($r[0]['page-flags'] != PAGE_PRVGROUP))
                                        $auto_confirm = true;
 
@@ -734,7 +758,7 @@ function dfrn_request_content(&$a) {
                                                'to_name'      => $r[0]['username'],
                                                'to_email'     => $r[0]['email'],
                                                'uid'          => $r[0]['uid'],
-                                               'link'             => $a->get_baseurl() . '/notifications/intros',
+                                               'link'         => System::baseUrl() . '/notifications/intros',
                                                'source_name'  => ((strlen(stripslashes($r[0]['name']))) ? stripslashes($r[0]['name']) : t('[Name Withheld]')),
                                                'source_link'  => $r[0]['url'],
                                                'source_photo' => $r[0]['photo'],
@@ -744,14 +768,14 @@ function dfrn_request_content(&$a) {
                                }
 
                                if($auto_confirm) {
-                                       require_once('mod/dfrn_confirm.php');
+                                       require_once 'mod/dfrn_confirm.php';
                                        $handsfree = array(
-                                               'uid' => $r[0]['uid'],
-                                               'node' => $r[0]['nickname'],
-                                               'dfrn_id' => $r[0]['issued-id'],
+                                               'uid'      => $r[0]['uid'],
+                                               'node'     => $r[0]['nickname'],
+                                               'dfrn_id'  => $r[0]['issued-id'],
                                                'intro_id' => $intro[0]['id'],
-                                               'duplex' => (($r[0]['page-flags'] == PAGE_FREELOVE) ? 1 : 0),
-                                               'activity' => intval(get_pconfig($r[0]['uid'],'system','post_newfriend'))
+                                               'duplex'   => (($r[0]['page-flags'] == PAGE_FREELOVE) ? 1 : 0),
+                                               'activity' => intval(PConfig::get($r[0]['uid'],'system','post_newfriend'))
                                        );
                                        dfrn_confirm_post($a,$handsfree);
                                }
@@ -778,8 +802,8 @@ function dfrn_request_content(&$a) {
                 * Normal web request. Display our user's introduction form.
                 */
 
-               if((get_config('system','block_public')) && (! local_user()) && (! remote_user())) {
-                       if(! get_config('system','local_block')) {
+               if((Config::get('system','block_public')) && (! local_user()) && (! remote_user())) {
+                       if(! Config::get('system','local_block')) {
                                notice( t('Public access denied.') . EOL);
                                return;
                        }
@@ -792,21 +816,22 @@ function dfrn_request_content(&$a) {
 
                // At first look if an address was provided
                // Otherwise take the local address
-               if (x($_GET,'addr') AND ($_GET['addr'] != ""))
+               if (x($_GET,'addr') && ($_GET['addr'] != "")) {
                        $myaddr = hex2bin($_GET['addr']);
-               elseif (x($_GET,'address') AND ($_GET['address'] != ""))
+               } elseif (x($_GET,'address') && ($_GET['address'] != "")) {
                        $myaddr = $_GET['address'];
-               elseif(local_user()) {
-                       if(strlen($a->path)) {
-                               $myaddr = $a->get_baseurl() . '/profile/' . $a->user['nickname'];
+               } elseif (local_user()) {
+                       if (strlen($a->path)) {
+                               $myaddr = System::baseUrl() . '/profile/' . $a->user['nickname'];
+                       } else {
+                               $myaddr = $a->user['nickname'] . '@' . substr(System::baseUrl(), strpos(System::baseUrl(),'://') + 3 );
                        }
-                       else {
-                               $myaddr = $a->user['nickname'] . '@' . substr(z_root(), strpos(z_root(),'://') + 3 );
-                       }
-               } else  // last, try a zrl
+               } else {
+                       // last, try a zrl
                        $myaddr = get_my_url();
+               }
 
-               $target_addr = $a->profile['nickname'] . '@' . substr(z_root(), strpos(z_root(),'://') + 3 );
+               $target_addr = $a->profile['nickname'] . '@' . substr(System::baseUrl(), strpos(System::baseUrl(),'://') + 3 );
 
 
                /*
@@ -817,25 +842,29 @@ function dfrn_request_content(&$a) {
                 *
                 */
 
-               if($a->profile['page-flags'] == PAGE_NORMAL)
+               if ($a->profile['page-flags'] == PAGE_NORMAL) {
                        $tpl = get_markup_template('dfrn_request.tpl');
-               else
+               } else {
                        $tpl = get_markup_template('auto_request.tpl');
+               }
 
                $page_desc = t("Please enter your 'Identity Address' from one of the following supported communications networks:");
 
                // see if we are allowed to have NETWORK_MAIL2 contacts
 
-               $mail_disabled = ((function_exists('imap_open') && (! get_config('system','imap_disabled'))) ? 0 : 1);
-               if(get_config('system','dfrn_only'))
+               $mail_disabled = ((function_exists('imap_open') && (! Config::get('system','imap_disabled'))) ? 0 : 1);
+
+               if (Config::get('system','dfrn_only')) {
                        $mail_disabled = 1;
+               }
 
-               if(! $mail_disabled) {
+               if (! $mail_disabled) {
                        $r = q("SELECT * FROM `mailacct` WHERE `uid` = %d LIMIT 1",
                                intval($a->profile['uid'])
                        );
-                       if(! count($r))
+                       if (! DBM::is_result($r)) {
                                $mail_disabled = 1;
+                       }
                }
 
                // "coming soon" is disabled for now
@@ -851,7 +880,7 @@ function dfrn_request_content(&$a) {
                        '$header' => t('Friend/Connection Request'),
                        '$desc' => t('Examples: jojo@demo.friendica.com, http://demo.friendica.com/profile/jojo, testuser@identi.ca'),
                        '$pls_answer' => t('Please answer the following:'),
-                       '$does_know_you' => array('knowyou', sprintf(t('Does %s know you?'),$a->profile['name']), false, '', array(t('No'),t('Yes'))),
+                       '$does_know_you' => array('knowyou', sprintf(t('Does %s know you?'),$a->profile['name']), false, '', array(t('No'), t('Yes'))),
                        /*'$does_know' => sprintf( t('Does %s know you?'),$a->profile['name']),
                        '$yes' => t('Yes'),
                        '$no' => t('No'), */