Merge pull request #4243 from MrPetovan/task/switch-to-array-new-style

[friendica.git] / mod / display.php

diff --git a/mod/display.php b/mod/display.php
index 67e6f435ec380393d5bd5f2b57901cad51447574..5ae8b6f4518f8d27a58539ba217908b987ac1f68 100644 (file)
--- a/mod/display.php
+++ b/mod/display.php
@@ -1,20 +1,24 @@
 <?php
-
+/**
+ * @file mod/display.php
+ */
 use Friendica\App;
 use Friendica\Core\Config;
 use Friendica\Core\System;
 use Friendica\Database\DBM;
 use Friendica\Model\Contact;
 use Friendica\Model\Group;
+use Friendica\Model\Profile;
 use Friendica\Protocol\DFRN;
 
-function display_init(App $a) {
-       if (Config::get('system','block_public') && !local_user() && !remote_user()) {
+function display_init(App $a)
+{
+       if (Config::get('system', 'block_public') && !local_user() && !remote_user()) {
                return;
        }
 
        $nick = (($a->argc > 1) ? $a->argv[1] : '');
-       $profiledata = array();
+       $profiledata = [];
 
        if ($a->argc == 3) {
                if (substr($a->argv[2], -5) == '.atom') {
@@ -98,16 +102,16 @@ function display_init(App $a) {
                                }
                                $profiledata["network"] = NETWORK_DFRN;
                        } else {
-                               $profiledata = array();
+                               $profiledata = [];
                        }
                }
        }
 
-       profile_load($a, $nick, 0, $profiledata);
+       Profile::load($a, $nick, 0, $profiledata);
 }
 
 function display_fetchauthor($a, $item) {
-       $profiledata = array();
+       $profiledata = [];
        $profiledata["uid"] = -1;
        $profiledata["nickname"] = $item["author-name"];
        $profiledata["name"] = $item["author-name"];
@@ -177,7 +181,7 @@ function display_fetchauthor($a, $item) {
        $profiledata["photo"] = System::removedBaseUrl($profiledata["photo"]);
 
        if (local_user()) {
-               if (in_array($profiledata["network"], array(NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS))) {
+               if (in_array($profiledata["network"], [NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS])) {
                        $profiledata["remoteconnect"] = System::baseUrl()."/follow?url=".urlencode($profiledata["url"]);
                }
        } elseif ($profiledata["network"] == NETWORK_DFRN) {
@@ -202,8 +206,9 @@ function display_content(App $a, $update = false, $update_uid = 0) {
 
        if ($update) {
                $item_id = $_REQUEST['item_id'];
-               $item = dba::select('item', ['uid'], ['id' => $item_id], ['limit' => 1]);
-               $a->profile = array('uid' => intval($item['uid']), 'profile_uid' => intval($item['uid']));
+               $item = dba::selectFirst('item', ['uid', 'parent'], ['id' => $item_id]);
+               $a->profile = ['uid' => intval($item['uid']), 'profile_uid' => intval($item['uid'])];
+               $item_parent = $item['parent'];
        } else {
                $item_id = (($a->argc > 2) ? $a->argv[2] : 0);
 
@@ -240,7 +245,7 @@ function display_content(App $a, $update = false, $update_uid = 0) {
        }
 
        // We are displaying an "alternate" link if that post was public. See issue 2864
-       $is_public = dba::exists('item', array('id' => $item_id, 'private' => false));
+       $is_public = dba::exists('item', ['id' => $item_id, 'private' => false]);
        if ($is_public) {
                // For the atom feed the nickname doesn't matter at all, we only need the item id.
                $alternate = System::baseUrl().'/display/feed-item/'.$item_id.'.atom';
@@ -251,17 +256,17 @@ function display_content(App $a, $update = false, $update_uid = 0) {
        }
 
        $a->page['htmlhead'] .= replace_macros(get_markup_template('display-head.tpl'),
-                               array('$alternate' => $alternate,
-                                       '$conversation' => $conversation));
+                               ['$alternate' => $alternate,
+                                       '$conversation' => $conversation]);
 
-       $groups = array();
+       $groups = [];
 
        $contact = null;
        $remote_contact = false;
 
        $contact_id = 0;
 
-       if (is_array($_SESSION['remote'])) {
+       if (x($_SESSION, 'remote') && is_array($_SESSION['remote'])) {
                foreach ($_SESSION['remote'] as $v) {
                        if ($v['uid'] == $a->profile['uid']) {
                                $contact_id = $v['cid'];
@@ -295,14 +300,14 @@ function display_content(App $a, $update = false, $update_uid = 0) {
        }
        $is_owner = (local_user() && (in_array($a->profile['profile_uid'], [local_user(), 0])) ? true : false);
 
-       if ($a->profile['hidewall'] && !$is_owner && !$remote_contact) {
+       if (x($a->profile, 'hidewall') && !$is_owner && !$remote_contact) {
                notice(t('Access to this profile has been restricted.') . EOL);
                return;
        }
 
        // We need the editor here to be able to reshare an item.
        if ($is_owner) {
-               $x = array(
+               $x = [
                        'is_owner' => true,
                        'allow_location' => $a->user['allow_location'],
                        'default_location' => $a->user['default-location'],
@@ -312,9 +317,8 @@ function display_content(App $a, $update = false, $update_uid = 0) {
                        'bang' => '',
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
-                       'acl_data' => construct_acl_data($a, $a->user), // For non-Javascript ACL selector
-               );
-               $o .= status_editor($a,$x,0,true);
+               ];
+               $o .= status_editor($a, $x, 0, true);
        }
 
        $sql_extra = item_permissions_sql($a->profile['uid'], $remote_contact, $groups);
@@ -345,9 +349,9 @@ function display_content(App $a, $update = false, $update_uid = 0) {
        $s = dba::inArray($r);
 
        if (local_user() && (local_user() == $a->profile['uid'])) {
-               $unseen = dba::select('item', array('id'), array('parent' => $s[0]['parent'], 'unseen' => true), array('limit' => 1));
+               $unseen = dba::selectFirst('item', ['id'], ['parent' => $s[0]['parent'], 'unseen' => true]);
                if (DBM::is_result($unseen)) {
-                       dba::update('item', array('unseen' => false), array('parent' => $s[0]['parent'], 'unseen' => true));
+                       dba::update('item', ['unseen' => false], ['parent' => $s[0]['parent'], 'unseen' => true]);
                }
        }