Check for parent existence in mod/display

[friendica.git] / mod / display.php

diff --git a/mod/display.php b/mod/display.php
index 175616f98d9c4ef77a292773d67b95dbc0d25c80..b388b915e17a9b79c359ee6a957fe605c9769baf 100644 (file)
--- a/mod/display.php
+++ b/mod/display.php
@@ -93,7 +93,8 @@ function display_init(App $a)
        }
 
        if ($item["id"] != $item["parent"]) {
-               $item = Item::selectFirstForUser($item_user, $fields, ['id' => $item["parent"]]);
+               $parent = Item::selectFirstForUser($item_user, $fields, ['id' => $item["parent"]]);
+               $item = $parent ?: $item;
        }
 
        $profiledata = display_fetchauthor($a, $item);
@@ -133,51 +134,20 @@ function display_fetchauthor($a, $item)
        $profiledata['network'] = $author['network'];
 
        // Check for a repeated message
-       $skip = false;
-       $body = trim($item["body"]);
-
-       // Skip if it isn't a pure repeated messages
-       // Does it start with a share?
-       if (!$skip && strpos($body, "[share") > 0) {
-               $skip = true;
-       }
-       // Does it end with a share?
-       if (!$skip && (strlen($body) > (strrpos($body, "[/share]") + 8))) {
-               $skip = true;
-       }
-       if (!$skip) {
-               $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism","$1",$body);
-               // Skip if there is no shared message in there
-               if ($body == $attributes) {
-                       $skip = true;
+       $shared = Item::getShareArray($item);
+       if (!empty($shared) && empty($shared['comment'])) {
+               if (!empty($shared['author'])) {
+                       $profiledata['name'] = $shared['author'];
                }
-       }
 
-       if (!$skip) {
-               preg_match("/author='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["name"] = html_entity_decode($matches[1],ENT_QUOTES,'UTF-8');
-               }
-               preg_match('/author="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["name"] = html_entity_decode($matches[1],ENT_QUOTES,'UTF-8');
-               }
-               preg_match("/profile='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["url"] = $matches[1];
-               }
-               preg_match('/profile="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["url"] = $matches[1];
+               if (!empty($shared['profile'])) {
+                       $profiledata['url'] = $shared['profile'];
                }
-               preg_match("/avatar='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["photo"] = $matches[1];
-               }
-               preg_match('/avatar="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["photo"] = $matches[1];
+
+               if (!empty($shared['avatar'])) {
+                       $profiledata['photo'] = $shared['avatar'];
                }
+
                $profiledata["nickname"] = $profiledata["name"];
                $profiledata["network"] = Protocol::matchByProfileUrl($profiledata["url"]);
 
@@ -273,16 +243,20 @@ function display_content(App $a, $update = false, $update_uid = 0)
        $is_remote_contact = false;
        $item_uid = local_user();
 
-       if (isset($item_parent_uri)) {
+       $parent = null;
+       if (!empty($item_parent_uri)) {
                $parent = Item::selectFirst(['uid'], ['uri' => $item_parent_uri, 'wall' => true]);
-               if (DBA::isResult($parent)) {
-                       $a->profile['uid'] = ($a->profile['uid'] ?? 0) ?: $parent['uid'];
-                       $a->profile['profile_uid'] = ($a->profile['profile_uid'] ?? 0) ?: $parent['uid'];
-                       $is_remote_contact = Session::getRemoteContactID($a->profile['profile_uid']);
-                       if ($is_remote_contact) {
-                               $item_uid = $parent['uid'];
-                       }
+       }
+
+       if (DBA::isResult($parent)) {
+               $a->profile['uid'] = ($a->profile['uid'] ?? 0) ?: $parent['uid'];
+               $a->profile['profile_uid'] = ($a->profile['profile_uid'] ?? 0) ?: $parent['uid'];
+               $is_remote_contact = Session::getRemoteContactID($a->profile['profile_uid']);
+               if ($is_remote_contact) {
+                       $item_uid = $parent['uid'];
                }
+       } else {
+               $a->profile = ['uid' => intval($item['uid']), 'profile_uid' => intval($item['uid'])];
        }
 
        $page_contact = DBA::selectFirst('contact', [], ['self' => true, 'uid' => $a->profile['uid']]);