]> git.mxchange.org Git - friendica.git/blobdiff - mod/display.php
Check for parent existence in mod/display
[friendica.git] / mod / display.php
index 874e2e8bf36dfb43bda90f1e6caa8906d79f5920..b388b915e17a9b79c359ee6a957fe605c9769baf 100644 (file)
@@ -32,7 +32,7 @@ function display_init(App $a)
                Objects::rawContent();
        }
 
-       if (Config::get('system', 'block_public') && !local_user() && !remote_user()) {
+       if (Config::get('system', 'block_public') && !Session::isAuthenticated()) {
                return;
        }
 
@@ -53,11 +53,17 @@ function display_init(App $a)
                        if (DBA::isResult($item)) {
                                $nick = $a->user["nickname"];
                        }
+               }
+
                // Is this item private but could be visible to the remove visitor?
-               } elseif (Session::getRemoteContactID($item['uid'])) {
-                       $item = Item::selectFirst($fields, ['guid' => $a->argv[1], 'private' => 1]);
+               if (!DBA::isResult($item) && remote_user()) {
+                       $item = Item::selectFirst($fields, ['guid' => $a->argv[1], 'private' => 1, 'origin' => true]);
                        if (DBA::isResult($item)) {
-                               $item_user = $item['uid'];
+                               if (!Contact::isFollower(remote_user(), $item['uid'])) {
+                                       $item = null;
+                               } else {
+                                       $item_user = $item['uid'];
+                               }
                        }
                }
 
@@ -81,17 +87,14 @@ function display_init(App $a)
                displayShowFeed($item['id'], $a->argc > 3 && $a->argv[3] == 'conversation.atom');
        }
 
-       if ($a->argc >= 3 && $nick == 'feed-item') {
-               displayShowFeed($item['id'], $a->argc > 3 && $a->argv[3] == 'conversation.atom');
-       }
-
        if (!empty($_SERVER['HTTP_ACCEPT']) && strstr($_SERVER['HTTP_ACCEPT'], 'application/atom+xml')) {
                Logger::log('Directly serving XML for id '.$item["id"], Logger::DEBUG);
                displayShowFeed($item["id"], false);
        }
 
        if ($item["id"] != $item["parent"]) {
-               $item = Item::selectFirstForUser($item_user, $fields, ['id' => $item["parent"]]);
+               $parent = Item::selectFirstForUser($item_user, $fields, ['id' => $item["parent"]]);
+               $item = $parent ?: $item;
        }
 
        $profiledata = display_fetchauthor($a, $item);
@@ -99,7 +102,7 @@ function display_init(App $a)
        if (strstr(Strings::normaliseLink($profiledata["url"]), Strings::normaliseLink(System::baseUrl()))) {
                $nickname = str_replace(Strings::normaliseLink(System::baseUrl())."/profile/", "", Strings::normaliseLink($profiledata["url"]));
 
-               if (($nickname != $a->user["nickname"])) {
+               if ($nickname != $a->user["nickname"]) {
                        $profile = DBA::fetchFirst("SELECT `profile`.`uid` AS `profile_uid`, `profile`.* , `contact`.`avatar-date` AS picdate, `user`.* FROM `profile`
                                INNER JOIN `contact` on `contact`.`uid` = `profile`.`uid` INNER JOIN `user` ON `profile`.`uid` = `user`.`uid`
                                WHERE `user`.`nickname` = ? AND `profile`.`is-default` AND `contact`.`self` LIMIT 1",
@@ -131,51 +134,20 @@ function display_fetchauthor($a, $item)
        $profiledata['network'] = $author['network'];
 
        // Check for a repeated message
-       $skip = false;
-       $body = trim($item["body"]);
-
-       // Skip if it isn't a pure repeated messages
-       // Does it start with a share?
-       if (!$skip && strpos($body, "[share") > 0) {
-               $skip = true;
-       }
-       // Does it end with a share?
-       if (!$skip && (strlen($body) > (strrpos($body, "[/share]") + 8))) {
-               $skip = true;
-       }
-       if (!$skip) {
-               $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism","$1",$body);
-               // Skip if there is no shared message in there
-               if ($body == $attributes) {
-                       $skip = true;
+       $shared = Item::getShareArray($item);
+       if (!empty($shared) && empty($shared['comment'])) {
+               if (!empty($shared['author'])) {
+                       $profiledata['name'] = $shared['author'];
                }
-       }
 
-       if (!$skip) {
-               preg_match("/author='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["name"] = html_entity_decode($matches[1],ENT_QUOTES,'UTF-8');
-               }
-               preg_match('/author="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["name"] = html_entity_decode($matches[1],ENT_QUOTES,'UTF-8');
-               }
-               preg_match("/profile='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["url"] = $matches[1];
+               if (!empty($shared['profile'])) {
+                       $profiledata['url'] = $shared['profile'];
                }
-               preg_match('/profile="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["url"] = $matches[1];
-               }
-               preg_match("/avatar='(.*?)'/ism", $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["photo"] = $matches[1];
-               }
-               preg_match('/avatar="(.*?)"/ism', $attributes, $matches);
-               if (!empty($matches[1])) {
-                       $profiledata["photo"] = $matches[1];
+
+               if (!empty($shared['avatar'])) {
+                       $profiledata['photo'] = $shared['avatar'];
                }
+
                $profiledata["nickname"] = $profiledata["name"];
                $profiledata["network"] = Protocol::matchByProfileUrl($profiledata["url"]);
 
@@ -194,7 +166,7 @@ function display_fetchauthor($a, $item)
 
 function display_content(App $a, $update = false, $update_uid = 0)
 {
-       if (Config::get('system','block_public') && !local_user() && !remote_user()) {
+       if (Config::get('system','block_public') && !Session::isAuthenticated()) {
                throw new HTTPException\ForbiddenException(L10n::t('Public access denied.'));
        }
 
@@ -226,9 +198,11 @@ function display_content(App $a, $update = false, $update_uid = 0)
                                        $item_parent = $item["parent"];
                                        $item_parent_uri = $item['parent-uri'];
                                }
-                       } elseif (Session::getRemoteContactID($item['uid'])) {
-                               $item = Item::selectFirst($fields, ['guid' => $a->argv[1], 'private' => 1]);
-                               if (DBA::isResult($item)) {
+                       }
+
+                       if (($item_parent == 0) && remote_user()) {
+                               $item = Item::selectFirst($fields, ['guid' => $a->argv[1], 'private' => 1, 'origin' => true]);
+                               if (DBA::isResult($item) && Contact::isFollower(remote_user(), $item['uid'])) {
                                        $item_id = $item["id"];
                                        $item_parent = $item["parent"];
                                        $item_parent_uri = $item['parent-uri'];
@@ -269,18 +243,21 @@ function display_content(App $a, $update = false, $update_uid = 0)
        $is_remote_contact = false;
        $item_uid = local_user();
 
-       if (isset($item_parent_uri)) {
+       $parent = null;
+       if (!empty($item_parent_uri)) {
                $parent = Item::selectFirst(['uid'], ['uri' => $item_parent_uri, 'wall' => true]);
-               if (DBA::isResult($parent)) {
-                       $a->profile['uid'] = defaults($a->profile, 'uid', $parent['uid']);
-                       $a->profile['profile_uid'] = defaults($a->profile, 'profile_uid', $parent['uid']);
-                       $is_remote_contact = Session::getRemoteContactID($a->profile['profile_uid']);
-                       if ($is_remote_contact) {
-                               $item_uid = $parent['uid'];
-                       }
-               }
        }
 
+       if (DBA::isResult($parent)) {
+               $a->profile['uid'] = ($a->profile['uid'] ?? 0) ?: $parent['uid'];
+               $a->profile['profile_uid'] = ($a->profile['profile_uid'] ?? 0) ?: $parent['uid'];
+               $is_remote_contact = Session::getRemoteContactID($a->profile['profile_uid']);
+               if ($is_remote_contact) {
+                       $item_uid = $parent['uid'];
+               }
+       } else {
+               $a->profile = ['uid' => intval($item['uid']), 'profile_uid' => intval($item['uid'])];
+       }
 
        $page_contact = DBA::selectFirst('contact', [], ['self' => true, 'uid' => $a->profile['uid']]);
        if (DBA::isResult($page_contact)) {
@@ -301,7 +278,7 @@ function display_content(App $a, $update = false, $update_uid = 0)
                        'default_location' => $a->user['default-location'],
                        'nickname' => $a->user['nickname'],
                        'lockstate' => (is_array($a->user) && (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) || strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'),
-                       'acl' => ACL::getFullSelectorHTML($a->user, true),
+                       'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true),
                        'bang' => '',
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
@@ -323,7 +300,7 @@ function display_content(App $a, $update = false, $update_uid = 0)
 
        $condition = ["`id` = ? AND `item`.`uid` IN (0, ?) " . $sql_extra, $item_id, $item_uid];
        $fields = ['parent-uri', 'body', 'title', 'author-name', 'author-avatar', 'plink', 'author-id', 'owner-id', 'contact-id'];
-       $item = Item::selectFirstForUser(local_user(), $fields, $condition);
+       $item = Item::selectFirstForUser($a->profile['profile_uid'], $fields, $condition);
 
        if (!DBA::isResult($item)) {
                throw new HTTPException\NotFoundException(L10n::t('The requested item doesn\'t exist or has been deleted.'));