Catch HTTPExceptions in App::runFrontend()

[friendica.git] / mod / fetch.php

diff --git a/mod/fetch.php b/mod/fetch.php
index 6892990c247ef54c7f8004f38e4375e1a724f6ab..5dcedb1aafdca58b6b8d0a01b58ed8611fe88155 100644 (file)
--- a/mod/fetch.php
+++ b/mod/fetch.php
@@ -5,42 +5,37 @@ This file is part of the Diaspora protocol. It is used for fetching single publi
 
 use Friendica\App;
 use Friendica\Core\L10n;
+use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Protocol\Diaspora;
+use Friendica\Model\Item;
+use Friendica\Model\User;
+use Friendica\Util\Strings;
 use Friendica\Util\XML;
+use Friendica\Database\DBA;
 
 function fetch_init(App $a)
 {
 
        if (($a->argc != 3) || (!in_array($a->argv[1], ["post", "status_message", "reshare"]))) {
-               header($_SERVER["SERVER_PROTOCOL"].' 404 '.L10n::t('Not Found'));
-               killme();
+               System::httpExit(404);
        }
 
        $guid = $a->argv[2];
 
        // Fetch the item
-       $item = q(
-               "SELECT `uid`, `title`, `body`, `guid`, `contact-id`, `private`, `created`, `app`, `location`, `coord`
-                       FROM `item` WHERE `wall` AND NOT `private` AND `guid` = '%s' AND `network` IN ('%s', '%s') AND `id` = `parent` LIMIT 1",
-               dbesc($guid),
-               NETWORK_DFRN,
-               NETWORK_DIASPORA
-       );
-       if (!$item) {
-               $r = q(
-                       "SELECT `author-link`
-                       FROM `item` WHERE `uid` = 0 AND `guid` = '%s' AND `network` IN ('%s', '%s') AND `id` = `parent` LIMIT 1",
-                       dbesc($guid),
-                       NETWORK_DFRN,
-                       NETWORK_DIASPORA
-               );
-
-               if ($r) {
-                       $parts = parse_url($r[0]["author-link"]);
+       $fields = ['uid', 'title', 'body', 'guid', 'contact-id', 'private', 'created', 'app', 'location', 'coord', 'network',
+               'event-id', 'resource-id', 'author-link', 'author-avatar', 'author-name', 'plink', 'owner-link', 'attach'];
+       $condition = ['wall' => true, 'private' => false, 'guid' => $guid, 'network' => [Protocol::DFRN, Protocol::DIASPORA]];
+       $item = Item::selectFirst($fields, $condition);
+       if (!DBA::isResult($item)) {
+               $condition = ['guid' => $guid, 'network' => [Protocol::DFRN, Protocol::DIASPORA]];
+               $item = Item::selectFirst(['author-link'], $condition);
+               if (DBA::isResult($item)) {
+                       $parts = parse_url($item["author-link"]);
                        $host = $parts["scheme"]."://".$parts["host"];
 
-                       if (normalise_link($host) != normalise_link(System::baseUrl())) {
+                       if (Strings::normaliseLink($host) != Strings::normaliseLink(System::baseUrl())) {
                                $location = $host."/fetch/".$a->argv[1]."/".urlencode($guid);
 
                                header("HTTP/1.1 301 Moved Permanently");
@@ -49,25 +44,16 @@ function fetch_init(App $a)
                        }
                }
 
-               header($_SERVER["SERVER_PROTOCOL"].' 404 '.L10n::t('Not Found'));
-               killme();
+               System::httpExit(404);
        }
 
        // Fetch some data from the author (We could combine both queries - but I think this is more readable)
-       $r = q(
-               "SELECT `user`.`prvkey`, `contact`.`addr`, `user`.`nickname`, `contact`.`nick` FROM `user`
-               INNER JOIN `contact` ON `contact`.`uid` = `user`.`uid` AND `contact`.`self`
-               WHERE `user`.`uid` = %d",
-               intval($item[0]["uid"])
-       );
-
-       if (!$r) {
-               header($_SERVER["SERVER_PROTOCOL"].' 404 '.L10n::t('Not Found'));
-               killme();
+       $user = User::getOwnerDataById($item["uid"]);
+       if (!$user) {
+               System::httpExit(404);
        }
-       $user = $r[0];
 
-       $status = Diaspora::buildStatus($item[0], $user);
+       $status = Diaspora::buildStatus($item, $user);
        $xml = Diaspora::buildPostXml($status["type"], $status["message"]);
 
        // Send the envelope