create third privacy state - public post but not searchable or publicly visible

[friendica.git] / mod / item.php

diff --git a/mod/item.php b/mod/item.php
index 54f9fc06aaf5d5a87aa862fd7794e629960d953f..554e97fe46a0d595b2df122a3c32b5c3f4830865 100644 (file)
--- a/mod/item.php
+++ b/mod/item.php
@@ -228,7 +228,7 @@ function item_post(&$a) {
                                || strlen($parent_item['allow_gid']) 
                                || strlen($parent_item['deny_cid']) 
                                || strlen($parent_item['deny_gid'])) {
-                               $private = 1;
+                               $private = (($parent_item['private']) ? $parent_item['private'] : 1);
                        }
 
                        $str_contact_allow = $parent_item['allow_cid'];
@@ -728,26 +728,10 @@ function item_post(&$a) {
                        
                        }
 
-                       // We won't be able to sign Diaspora comments for authenticated visitors - we don't have their private key
 
-                       if($self) {
-                               require_once('include/bb2diaspora.php');
-                               $signed_body = html_entity_decode(bb2diaspora($datarray['body']));
-                               $myaddr = $a->user['nickname'] . '@' . substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
-                               if($datarray['verb'] === ACTIVITY_LIKE) 
-                                       $signed_text = $datarray['guid'] . ';' . 'Post' . ';' . $parent_item['guid'] . ';' . 'true' . ';' . $myaddr;
-                               else
-                                       $signed_text = $datarray['guid'] . ';' . $parent_item['guid'] . ';' . $signed_body . ';' . $myaddr;
-
-                               $authorsig = base64_encode(rsa_sign($signed_text,$a->user['prvkey'],'sha256'));
+                       // Store the comment signature information in case we need to relay to Diaspora
+                       store_diaspora_comment_sig($datarray, $author, ($self ? $a->user['prvkey'] : false), $parent_item, $post_id);
 
-                               q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
-                                       intval($post_id),
-                                       dbesc($signed_text),
-                                       dbesc(base64_encode($authorsig)),
-                                       dbesc($myaddr)
-                               );
-                       }
                }
                else {
                        $parent = $post_id;
@@ -1038,3 +1022,47 @@ function handle_tag($a, &$body, &$inform, &$str_tags, $profile_uid, $tag) {
 
        return array('replaced' => $replaced, 'contact' => $r[0]);      
 }
+
+
+function store_diaspora_comment_sig($datarray, $author, $uprvkey, $parent_item, $post_id) {
+       // We won't be able to sign Diaspora comments for authenticated visitors - we don't have their private key
+
+       $enabled = intval(get_config('system','diaspora_enabled'));
+       if(! $enabled) {
+               logger('mod_item: diaspora support disabled, not storing comment signature', LOGGER_DEBUG);
+               return;
+       }
+
+
+       logger('mod_item: storing diaspora comment signature');
+
+       require_once('include/bb2diaspora.php');
+       $signed_body = html_entity_decode(bb2diaspora($datarray['body']));
+
+//     $myaddr = $user['nickname'] . '@' . substr($baseurl, strpos($baseurl,'://') + 3);
+//     if( $author['network'] === NETWORK_DIASPORA)
+//             $diaspora_handle = $author['addr'];
+//     else {
+       // Only works for NETWORK_DFRN
+       $contact_baseurl_start = strpos($author['url'],'://') + 3;
+       $contact_baseurl_length = strpos($author['url'],'/profile') - $contact_baseurl_start;
+       $contact_baseurl = substr($author['url'], $contact_baseurl_start, $contact_baseurl_length);
+       $diaspora_handle = $author['nick'] . '@' . $contact_baseurl;
+//     }
+
+       $signed_text = $datarray['guid'] . ';' . $parent_item['guid'] . ';' . $signed_body . ';' . $diaspora_handle;
+
+       if( $uprvkey !== false )
+               $authorsig = base64_encode(rsa_sign($signed_text,$uprvkey,'sha256'));
+       else
+               $authorsig = '';
+
+       q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
+               intval($post_id),
+               dbesc($signed_text),
+               dbesc(base64_encode($authorsig)),
+               dbesc($diaspora_handle)
+       );
+
+       return;
+}