a l10n call too much

[friendica.git] / mod / item.php

diff --git a/mod/item.php b/mod/item.php
index 4e14a047f5577f45e6ac2b04a518d04c0c8dd460..99251a4a47dfaf11b7bfa38be49b78b434c0bbf9 100644 (file)
--- a/mod/item.php
+++ b/mod/item.php
@@ -40,7 +40,6 @@ use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Attach;
-use Friendica\Model\Config\PConfig;
 use Friendica\Model\Contact;
 use Friendica\Model\Conversation;
 use Friendica\Model\FileTag;
@@ -129,7 +128,7 @@ function item_post(App $a) {
                        $thread_parent_contact = Contact::getDetailsByURL($toplevel_item["author-link"]);
 
                        if ($toplevel_item['id'] != $toplevel_item['parent']) {
-                               $toplevel_item = Item::selectFirst(Item::ITEM_FIELDLIST, ['id' => $toplevel_item['parent']]);
+                               $toplevel_item = Item::selectFirst([], ['id' => $toplevel_item['parent']]);
                        }
                }
 
@@ -262,33 +261,13 @@ function item_post(App $a) {
                $network           = $orig_post['network'];
                $guid              = $orig_post['guid'];
                $extid             = $orig_post['extid'];
-
        } else {
+               $aclFormatter = DI::aclFormatter();
 
-               /*
-                * if coming from the API and no privacy settings are set,
-                * use the user default permissions - as they won't have
-                * been supplied via a form.
-                */
-               if ($api_source
-                       && !array_key_exists('contact_allow', $_REQUEST)
-                       && !array_key_exists('group_allow', $_REQUEST)
-                       && !array_key_exists('contact_deny', $_REQUEST)
-                       && !array_key_exists('group_deny', $_REQUEST)) {
-                       $str_group_allow   = $user['allow_gid'];
-                       $str_contact_allow = $user['allow_cid'];
-                       $str_group_deny    = $user['deny_gid'];
-                       $str_contact_deny  = $user['deny_cid'];
-               } else {
-                       // use the posted permissions
-
-                       $aclFormatter = DI::aclFormatter();
-
-                       $str_group_allow   = $aclFormatter->toString($_REQUEST['group_allow'] ?? '');
-                       $str_contact_allow = $aclFormatter->toString($_REQUEST['contact_allow'] ?? '');
-                       $str_group_deny    = $aclFormatter->toString($_REQUEST['group_deny'] ?? '');
-                       $str_contact_deny  = $aclFormatter->toString($_REQUEST['contact_deny'] ?? '');
-               }
+               $str_group_allow   = isset($_REQUEST['group_allow'])   ? $aclFormatter->toString($_REQUEST['group_allow'])    : $user['allow_gid'] ?? '';
+               $str_contact_allow = isset($_REQUEST['contact_allow']) ? $aclFormatter->toString($_REQUEST['contact__allow']) : $user['allow_cid'] ?? '';
+               $str_group_deny    = isset($_REQUEST['group_deny'])    ? $aclFormatter->toString($_REQUEST['group_deny'])     : $user['deny_gid']  ?? '';
+               $str_contact_deny  = isset($_REQUEST['contact_deny'])  ? $aclFormatter->toString($_REQUEST['contact_deny'])   : $user['deny_cid']  ?? '';
 
                $title             = Strings::escapeTags(trim($_REQUEST['title']    ?? ''));
                $location          = Strings::escapeTags(trim($_REQUEST['location'] ?? ''));
@@ -303,10 +282,10 @@ function item_post(App $a) {
 
                if (strlen($str_group_allow) || strlen($str_contact_allow) || strlen($str_group_deny) || strlen($str_contact_deny)) {
                        $private = Item::PRIVATE;
-               } elseif (PConfig::get($profile_uid, 'system', 'unlisted')) {
-                       $private == Item::UNLISTED;
+               } elseif (DI::pConfig()->get($profile_uid, 'system', 'unlisted')) {
+                       $private = Item::UNLISTED;
                } else {
-                       $private == Item::PUBLIC;
+                       $private = Item::PUBLIC;
                }
 
                // If this is a comment, set the permissions from the parent.
@@ -319,10 +298,10 @@ function item_post(App $a) {
                                $network = $toplevel_item['network'];
                        }
 
-                       $str_contact_allow = $toplevel_item['allow_cid'];
-                       $str_group_allow   = $toplevel_item['allow_gid'];
-                       $str_contact_deny  = $toplevel_item['deny_cid'];
-                       $str_group_deny    = $toplevel_item['deny_gid'];
+                       $str_contact_allow = $toplevel_item['allow_cid'] ?? '';
+                       $str_group_allow   = $toplevel_item['allow_gid'] ?? '';
+                       $str_contact_deny  = $toplevel_item['deny_cid'] ?? '';
+                       $str_group_deny    = $toplevel_item['deny_gid'] ?? '';
                        $private           = $toplevel_item['private'];
 
                        $wall              = $toplevel_item['wall'];