]> git.mxchange.org Git - friendica.git/blobdiff - mod/message.php
Merge pull request #1 from friendica/develop
[friendica.git] / mod / message.php
index f9c5c29ec773a934f3795453c8c6a15b257848f3..393d5d276bdee950a8ca48049e4b1ede011d5121 100644 (file)
@@ -5,20 +5,21 @@
 
 use Friendica\App;
 use Friendica\Content\Nav;
+use Friendica\Content\Pager;
 use Friendica\Content\Smilies;
 use Friendica\Content\Text\BBCode;
 use Friendica\Core\ACL;
 use Friendica\Core\L10n;
+use Friendica\Core\Renderer;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Model\Contact;
 use Friendica\Model\Mail;
+use Friendica\Module\Login;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Proxy as ProxyUtils;
+use Friendica\Util\Strings;
 use Friendica\Util\Temporal;
-use Friendica\Module\Login;
-
-require_once 'include/conversation.php';
 
 function message_init(App $a)
 {
@@ -35,15 +36,15 @@ function message_init(App $a)
                'accesskey' => 'm',
        ];
 
-       $tpl = get_markup_template('message_side.tpl');
-       $a->page['aside'] = replace_macros($tpl, [
+       $tpl = Renderer::getMarkupTemplate('message_side.tpl');
+       $a->page['aside'] = Renderer::replaceMacros($tpl, [
                '$tabs' => $tabs,
                '$new' => $new,
        ]);
        $base = System::baseUrl();
 
-       $head_tpl = get_markup_template('message-head.tpl');
-       $a->page['htmlhead'] .= replace_macros($head_tpl, [
+       $head_tpl = Renderer::getMarkupTemplate('message-head.tpl');
+       $a->page['htmlhead'] .= Renderer::replaceMacros($head_tpl, [
                '$baseurl' => System::baseUrl(true),
                '$base' => $base
        ]);
@@ -56,10 +57,10 @@ function message_post(App $a)
                return;
        }
 
-       $replyto   = x($_REQUEST, 'replyto')   ? notags(trim($_REQUEST['replyto']))   : '';
-       $subject   = x($_REQUEST, 'subject')   ? notags(trim($_REQUEST['subject']))   : '';
-       $body      = x($_REQUEST, 'body')      ? escape_tags(trim($_REQUEST['body'])) : '';
-       $recipient = x($_REQUEST, 'messageto') ? intval($_REQUEST['messageto'])       : 0;
+       $replyto   = !empty($_REQUEST['replyto'])   ? Strings::escapeTags(trim($_REQUEST['replyto'])) : '';
+       $subject   = !empty($_REQUEST['subject'])   ? Strings::escapeTags(trim($_REQUEST['subject'])) : '';
+       $body      = !empty($_REQUEST['body'])      ? Strings::escapeHtml(trim($_REQUEST['body']))    : '';
+       $recipient = !empty($_REQUEST['messageto']) ? intval($_REQUEST['messageto'])                  : 0;
 
        $ret = Mail::send($recipient, $body, $subject, $replyto);
        $norecip = false;
@@ -87,7 +88,7 @@ function message_post(App $a)
                $a->argc = 2;
                $a->argv[1] = 'new';
        } else {
-               goaway($a->cmd . '/' . $ret);
+               $a->internalRedirect($a->cmd . '/' . $ret);
        }
 }
 
@@ -103,7 +104,7 @@ function message_content(App $a)
 
        $myprofile = System::baseUrl() . '/profile/' . $a->user['nickname'];
 
-       $tpl = get_markup_template('mail_head.tpl');
+       $tpl = Renderer::getMarkupTemplate('mail_head.tpl');
        if ($a->argc > 1 && $a->argv[1] == 'new') {
                $button = [
                        'label' => L10n::t('Discard'),
@@ -118,7 +119,7 @@ function message_content(App $a)
                        'accesskey' => 'm',
                ];
        }
-       $header = replace_macros($tpl, [
+       $header = Renderer::replaceMacros($tpl, [
                '$messages' => L10n::t('Messages'),
                '$button' => $button,
        ]);
@@ -142,7 +143,7 @@ function message_content(App $a)
                        }
 
                        //$a->page['aside'] = '';
-                       return replace_macros(get_markup_template('confirm.tpl'), [
+                       return Renderer::replaceMacros(Renderer::getMarkupTemplate('confirm.tpl'), [
                                '$method' => 'get',
                                '$message' => L10n::t('Do you really want to delete this message?'),
                                '$extra_inputs' => $inputs,
@@ -155,7 +156,7 @@ function message_content(App $a)
 
                // Now check how the user responded to the confirmation query
                if (!empty($_REQUEST['canceled'])) {
-                       goaway('/message');
+                       $a->internalRedirect('message');
                }
 
                $cmd = $a->argv[1];
@@ -163,7 +164,7 @@ function message_content(App $a)
                        $message = DBA::selectFirst('mail', ['convid'], ['id' => $a->argv[2], 'uid' => local_user()]);
                        if(!DBA::isResult($message)){
                                info(L10n::t('Conversation not found.') . EOL);
-                               goaway('/message');
+                               $a->internalRedirect('message');
                        }
 
                        if (DBA::delete('mail', ['id' => $a->argv[2], 'uid' => local_user()])) {
@@ -173,10 +174,10 @@ function message_content(App $a)
                        $conversation = DBA::selectFirst('mail', ['id'], ['convid' => $message['convid'], 'uid' => local_user()]);
                        if(!DBA::isResult($conversation)){
                                info(L10n::t('Conversation removed.') . EOL);
-                               goaway('/message');
+                               $a->internalRedirect('message');
                        }
 
-                       goaway('/message/' . $conversation['id'] );
+                       $a->internalRedirect('message/' . $conversation['id'] );
                } else {
                        $r = q("SELECT `parent-uri`,`convid` FROM `mail` WHERE `id` = %d AND `uid` = %d LIMIT 1",
                                intval($a->argv[2]),
@@ -184,21 +185,20 @@ function message_content(App $a)
                        );
                        if (DBA::isResult($r)) {
                                $parent = $r[0]['parent-uri'];
-                               $convid = $r[0]['convid'];
 
                                if (DBA::delete('mail', ['parent-uri' => $parent, 'uid' => local_user()])) {
                                        info(L10n::t('Conversation removed.') . EOL);
                                }
                        }
-                       goaway('/message' );
+                       $a->internalRedirect('message');
                }
        }
 
        if (($a->argc > 1) && ($a->argv[1] === 'new')) {
                $o .= $header;
 
-               $tpl = get_markup_template('msg-header.tpl');
-               $a->page['htmlhead'] .= replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('msg-header.tpl');
+               $a->page['htmlhead'] .= Renderer::replaceMacros($tpl, [
                        '$baseurl' => System::baseUrl(true),
                        '$nickname' => $a->user['nickname'],
                        '$linkurl' => L10n::t('Please enter a link URL:')
@@ -216,7 +216,7 @@ function message_content(App $a)
                        if (!DBA::isResult($r)) {
                                $r = q("SELECT `name`, `url`, `id` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1",
                                        intval(local_user()),
-                                       DBA::escape(normalise_link(base64_decode($a->argv[2])))
+                                       DBA::escape(Strings::normaliseLink(base64_decode($a->argv[2])))
                                );
                        }
 
@@ -229,7 +229,6 @@ function message_content(App $a)
 
                        if (DBA::isResult($r)) {
                                $prename = $r[0]['name'];
-                               $preurl = $r[0]['url'];
                                $preid = $r[0]['id'];
                                $preselect = [$preid];
                        } else {
@@ -242,30 +241,30 @@ function message_content(App $a)
                // the ugly select box
                $select = ACL::getMessageContactSelectHTML('messageto', 'message-to-select', $preselect, 4, 10);
 
-               $tpl = get_markup_template('prv_message.tpl');
-               $o .= replace_macros($tpl, [
-                       '$header' => L10n::t('Send Private Message'),
-                       '$to' => L10n::t('To:'),
+               $tpl = Renderer::getMarkupTemplate('prv_message.tpl');
+               $o .= Renderer::replaceMacros($tpl, [
+                       '$header'     => L10n::t('Send Private Message'),
+                       '$to'         => L10n::t('To:'),
                        '$showinputs' => 'true',
-                       '$prefill' => $prefill,
-                       '$preid' => $preid,
-                       '$subject' => L10n::t('Subject:'),
-                       '$subjtxt' => x($_REQUEST, 'subject') ? strip_tags($_REQUEST['subject']) : '',
-                       '$text' => x($_REQUEST, 'body') ? escape_tags(htmlspecialchars($_REQUEST['body'])) : '',
-                       '$readonly' => '',
-                       '$yourmessage' => L10n::t('Your message:'),
-                       '$select' => $select,
-                       '$parent' => '',
-                       '$upload' => L10n::t('Upload photo'),
-                       '$insert' => L10n::t('Insert web link'),
-                       '$wait' => L10n::t('Please wait'),
-                       '$submit' => L10n::t('Submit')
+                       '$prefill'    => $prefill,
+                       '$preid'      => $preid,
+                       '$subject'    => L10n::t('Subject:'),
+                       '$subjtxt'    => $_REQUEST['subject'] ?? '',
+                       '$text'       => $_REQUEST['body'] ?? '',
+                       '$readonly'   => '',
+                       '$yourmessage'=> L10n::t('Your message:'),
+                       '$select'     => $select,
+                       '$parent'     => '',
+                       '$upload'     => L10n::t('Upload photo'),
+                       '$insert'     => L10n::t('Insert web link'),
+                       '$wait'       => L10n::t('Please wait'),
+                       '$submit'     => L10n::t('Submit')
                ]);
                return $o;
        }
 
 
-       $_SESSION['return_url'] = $a->query_string;
+       $_SESSION['return_path'] = $a->query_string;
 
        if ($a->argc == 1) {
 
@@ -273,16 +272,18 @@ function message_content(App $a)
 
                $o .= $header;
 
+               $total = 0;
                $r = q("SELECT count(*) AS `total`, ANY_VALUE(`created`) AS `created` FROM `mail`
                        WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `created` DESC",
                        intval(local_user())
                );
-
                if (DBA::isResult($r)) {
-                       $a->setPagerTotal($r[0]['total']);
+                       $total = $r[0]['total'];
                }
 
-               $r = get_messages(local_user(), $a->pager['start'], $a->pager['itemspage']);
+               $pager = new Pager($a->query_string);
+
+               $r = get_messages(local_user(), $pager->getStart(), $pager->getItemsPerPage());
 
                if (!DBA::isResult($r)) {
                        info(L10n::t('No messages.') . EOL);
@@ -291,7 +292,7 @@ function message_content(App $a)
 
                $o .= render_messages($r, 'mail_list.tpl');
 
-               $o .= paginate($a);
+               $o .= $pager->renderFull($total);
 
                return $o;
        }
@@ -300,43 +301,60 @@ function message_content(App $a)
 
                $o .= $header;
 
-               $r = q("SELECT `mail`.*, `contact`.`name`, `contact`.`url`, `contact`.`thumb`
-                       FROM `mail` LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id`
-                       WHERE `mail`.`uid` = %d AND `mail`.`id` = %d LIMIT 1",
-                       intval(local_user()),
-                       intval($a->argv[1])
+               $message = DBA::fetchFirst("
+                       SELECT `mail`.*, `contact`.`name`, `contact`.`url`, `contact`.`thumb`
+                       FROM `mail`
+                       LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id`
+                       WHERE `mail`.`uid` = ? AND `mail`.`id` = ?
+                       LIMIT 1",
+                       local_user(),
+                       $a->argv[1]
                );
-               if (DBA::isResult($r)) {
-                       $contact_id = $r[0]['contact-id'];
-                       $convid = $r[0]['convid'];
-
-                       $sql_extra = sprintf(" and `mail`.`parent-uri` = '%s' ", DBA::escape($r[0]['parent-uri']));
-                       if ($convid)
-                               $sql_extra = sprintf(" and ( `mail`.`parent-uri` = '%s' OR `mail`.`convid` = '%d' ) ",
-                                       DBA::escape($r[0]['parent-uri']),
-                                       intval($convid)
-                               );
+               if (DBA::isResult($message)) {
+                       $contact_id = $message['contact-id'];
 
-                       $messages = q("SELECT `mail`.*, `contact`.`name`, `contact`.`url`, `contact`.`thumb`
-                               FROM `mail` LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id`
-                               WHERE `mail`.`uid` = %d $sql_extra ORDER BY `mail`.`created` ASC",
-                               intval(local_user())
+                       $params = [
+                               local_user(),
+                               $message['parent-uri']
+                       ];
+
+                       if ($message['convid']) {
+                               $sql_extra = "AND (`mail`.`parent-uri` = ? OR `mail`.`convid` = ?)";
+                               $params[] = $message['convid'];
+                       } else {
+                               $sql_extra = "AND `mail`.`parent-uri` = ?";
+                       }
+                       $messages_stmt = DBA::p("
+                               SELECT `mail`.*, `contact`.`name`, `contact`.`url`, `contact`.`thumb`
+                               FROM `mail`
+                               LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id`
+                               WHERE `mail`.`uid` = ?
+                               $sql_extra
+                               ORDER BY `mail`.`created` ASC",
+                               ...$params
                        );
+
+                       $messages = DBA::toArray($messages_stmt);
+
+                       DBA::update('mail', ['seen' => 1], ['parent-uri' => $message['parent-uri'], 'uid' => local_user()]);
+
+                       if ($message['convid']) {
+                               // Clear Diaspora private message notifications
+                               DBA::update('notify', ['seen' => 1], ['type' => NOTIFY_MAIL, 'parent' => $message['convid'], 'uid' => local_user()]);
+                       }
+                       // Clear DFRN private message notifications
+                       DBA::update('notify', ['seen' => 1], ['type' => NOTIFY_MAIL, 'parent' => $message['parent-uri'], 'uid' => local_user()]);
                } else {
                        $messages = false;
                }
+
                if (!DBA::isResult($messages)) {
                        notice(L10n::t('Message not available.') . EOL);
                        return $o;
                }
 
-               $r = q("UPDATE `mail` SET `seen` = 1 WHERE `parent-uri` = '%s' AND `uid` = %d",
-                       DBA::escape($r[0]['parent-uri']),
-                       intval(local_user())
-               );
-
-               $tpl = get_markup_template('msg-header.tpl');
-               $a->page['htmlhead'] .= replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('msg-header.tpl');
+               $a->page['htmlhead'] .= Renderer::replaceMacros($tpl, [
                        '$baseurl' => System::baseUrl(true),
                        '$nickname' => $a->user['nickname'],
                        '$linkurl' => L10n::t('Please enter a link URL:')
@@ -347,8 +365,10 @@ function message_content(App $a)
                $unknown = false;
 
                foreach ($messages as $message) {
-                       if ($message['unknown'])
+                       if ($message['unknown']) {
                                $unknown = true;
+                       }
+
                        if ($message['from-url'] == $myprofile) {
                                $from_url = $myprofile;
                                $sparkle = '';
@@ -364,7 +384,7 @@ function message_content(App $a)
 
                        $from_name_e = $message['from-name'];
                        $subject_e = $message['title'];
-                       $body_e = Smilies::replace(BBCode::convert($message['body']));
+                       $body_e = BBCode::convert($message['body']);
                        $to_name_e = $message['name'];
 
                        $contact = Contact::getDetailsByURL($message['from-url']);
@@ -395,8 +415,8 @@ function message_content(App $a)
                $select = $message['name'] . '<input type="hidden" name="messageto" value="' . $contact_id . '" />';
                $parent = '<input type="hidden" name="replyto" value="' . $message['parent-uri'] . '" />';
 
-               $tpl = get_markup_template('mail_display.tpl');
-               $o = replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('mail_display.tpl');
+               $o = Renderer::replaceMacros($tpl, [
                        '$thread_id' => $a->argv[1],
                        '$thread_subject' => $message['title'],
                        '$thread_seen' => $seen,
@@ -426,31 +446,63 @@ function message_content(App $a)
        }
 }
 
-function get_messages($user, $lstart, $lend)
+/**
+ * @param int $uid
+ * @param int $start
+ * @param int $limit
+ * @return array
+ */
+function get_messages($uid, $start, $limit)
 {
-       //TODO: rewritte with a sub-query to get the first message of each private thread with certainty
-       return q("SELECT max(`mail`.`created`) AS `mailcreated`, min(`mail`.`seen`) AS `mailseen`,
-               ANY_VALUE(`mail`.`id`) AS `id`, ANY_VALUE(`mail`.`uid`) AS `uid`, ANY_VALUE(`mail`.`guid`) AS `guid`,
-               ANY_VALUE(`mail`.`from-name`) AS `from-name`, ANY_VALUE(`mail`.`from-photo`) AS `from-photo`,
-               ANY_VALUE(`mail`.`from-url`) AS `from-url`, ANY_VALUE(`mail`.`contact-id`) AS `contact-id`,
-               ANY_VALUE(`mail`.`convid`) AS `convid`, ANY_VALUE(`mail`.`title`) AS `title`, ANY_VALUE(`mail`.`body`) AS `body`,
-               ANY_VALUE(`mail`.`seen`) AS `seen`, ANY_VALUE(`mail`.`reply`) AS `reply`, ANY_VALUE(`mail`.`replied`) AS `replied`,
-               ANY_VALUE(`mail`.`unknown`) AS `unknown`, ANY_VALUE(`mail`.`uri`) AS `uri`,
-               `mail`.`parent-uri`,
-               ANY_VALUE(`mail`.`created`) AS `created`, ANY_VALUE(`contact`.`name`) AS `name`, ANY_VALUE(`contact`.`url`) AS `url`,
-               ANY_VALUE(`contact`.`thumb`) AS `thumb`, ANY_VALUE(`contact`.`network`) AS `network`,
-               count( * ) as `count`
-               FROM `mail` LEFT JOIN `contact` ON `mail`.`contact-id` = `contact`.`id`
-               WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `mailcreated` DESC LIMIT %d , %d ",
-               intval($user), intval($lstart), intval($lend)
-       );
+       return DBA::toArray(DBA::p('SELECT
+                       m.`id`,
+                       m.`uid`,
+                       m.`guid`,
+                       m.`from-name`,
+                       m.`from-photo`,
+                       m.`from-url`,
+                       m.`contact-id`,
+                       m.`convid`,
+                       m.`title`,
+                       m.`body`,
+                       m.`seen`,
+                       m.`reply`,
+                       m.`replied`,
+                       m.`unknown`,
+                       m.`uri`,
+                       m.`parent-uri`,
+                       m.`created`,
+                       c.`name`,
+                       c.`url`,
+                       c.`thumb`,
+                       c.`network`,
+                       m2.`count`,
+                       m2.`mailcreated`,
+                       m2.`mailseen`
+               FROM `mail` m
+               JOIN (
+                       SELECT
+                               `parent-uri`,
+                           MIN(`id`)      AS `id`,
+                           COUNT(*)       AS `count`,
+                           MAX(`created`) AS `mailcreated`,
+                           MIN(`seen`)    AS `mailseen`
+                       FROM `mail`
+                       WHERE `uid` = ?
+                       GROUP BY `parent-uri`
+               ) m2 ON m.`parent-uri` = m2.`parent-uri` AND m.`id` = m2.`id`
+               LEFT JOIN `contact` c ON m.`contact-id` = c.`id`
+               WHERE m.`uid` = ?
+               ORDER BY m2.`mailcreated` DESC
+               LIMIT ?, ?'
+               , $uid, $uid, $start, $limit));
 }
 
 function render_messages(array $msg, $t)
 {
-       $a = get_app();
+       $a = \get_app();
 
-       $tpl = get_markup_template($t);
+       $tpl = Renderer::getMarkupTemplate($t);
        $rslt = '';
 
        $myprofile = System::baseUrl() . '/profile/' . $a->user['nickname'];
@@ -458,13 +510,12 @@ function render_messages(array $msg, $t)
        foreach ($msg as $rr) {
                if ($rr['unknown']) {
                        $participants = L10n::t("Unknown sender - %s", $rr['from-name']);
-               } elseif (link_compare($rr['from-url'], $myprofile)) {
+               } elseif (Strings::compareLink($rr['from-url'], $myprofile)) {
                        $participants = L10n::t("You and %s", $rr['name']);
                } else {
                        $participants = L10n::t("%s and You", $rr['from-name']);
                }
 
-               $subject_e = (($rr['mailseen']) ? $rr['title'] : '<strong>' . $rr['title'] . '</strong>');
                $body_e = $rr['body'];
                $to_name_e = $rr['name'];
 
@@ -475,14 +526,14 @@ function render_messages(array $msg, $t)
                        $from_photo = (($rr['thumb']) ? $rr['thumb'] : $rr['from-photo']);
                }
 
-               $rslt .= replace_macros($tpl, [
+               $rslt .= Renderer::replaceMacros($tpl, [
                        '$id' => $rr['id'],
                        '$from_name' => $participants,
                        '$from_url' => Contact::magicLink($rr['url']),
-                       '$from_addr' => defaults($contact, 'addr', ''),
+                       '$from_addr' => $contact['addr'] ?? '',
                        '$sparkle' => ' sparkle',
                        '$from_photo' => ProxyUtils::proxifyUrl($from_photo, false, ProxyUtils::SIZE_THUMB),
-                       '$subject' => $subject_e,
+                       '$subject' => $rr['title'],
                        '$delete' => L10n::t('Delete conversation'),
                        '$body' => $body_e,
                        '$to_name' => $to_name_e,