]> git.mxchange.org Git - friendica.git/blobdiff - mod/message.php
Remove unused/empty template variables in register
[friendica.git] / mod / message.php
index 6a48eb658e523317e7e7f681fb9f27e6a1b5cfd1..e0d9f4404ff1e238ed8d2389ce1e1bcdd90a22e9 100644 (file)
@@ -5,15 +5,20 @@
 
 use Friendica\App;
 use Friendica\Content\Nav;
+use Friendica\Content\Pager;
 use Friendica\Content\Smilies;
 use Friendica\Content\Text\BBCode;
 use Friendica\Core\ACL;
 use Friendica\Core\L10n;
+use Friendica\Core\Renderer;
 use Friendica\Core\System;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
 use Friendica\Model\Contact;
 use Friendica\Model\Mail;
+use Friendica\Module\Login;
 use Friendica\Util\DateTimeFormat;
+use Friendica\Util\Proxy as ProxyUtils;
+use Friendica\Util\Strings;
 use Friendica\Util\Temporal;
 
 require_once 'include/conversation.php';
@@ -33,21 +38,15 @@ function message_init(App $a)
                'accesskey' => 'm',
        ];
 
-       $tpl = get_markup_template('message_side.tpl');
-       $a->page['aside'] = replace_macros($tpl, [
+       $tpl = Renderer::getMarkupTemplate('message_side.tpl');
+       $a->page['aside'] = Renderer::replaceMacros($tpl, [
                '$tabs' => $tabs,
                '$new' => $new,
        ]);
        $base = System::baseUrl();
 
-       $head_tpl = get_markup_template('message-head.tpl');
-       $a->page['htmlhead'] .= replace_macros($head_tpl, [
-               '$baseurl' => System::baseUrl(true),
-               '$base' => $base
-       ]);
-
-       $end_tpl = get_markup_template('message-end.tpl');
-       $a->page['end'] .= replace_macros($end_tpl, [
+       $head_tpl = Renderer::getMarkupTemplate('message-head.tpl');
+       $a->page['htmlhead'] .= Renderer::replaceMacros($head_tpl, [
                '$baseurl' => System::baseUrl(true),
                '$base' => $base
        ]);
@@ -60,10 +59,10 @@ function message_post(App $a)
                return;
        }
 
-       $replyto   = x($_REQUEST, 'replyto')   ? notags(trim($_REQUEST['replyto']))   : '';
-       $subject   = x($_REQUEST, 'subject')   ? notags(trim($_REQUEST['subject']))   : '';
-       $body      = x($_REQUEST, 'body')      ? escape_tags(trim($_REQUEST['body'])) : '';
-       $recipient = x($_REQUEST, 'messageto') ? intval($_REQUEST['messageto'])       : 0;
+       $replyto   = !empty($_REQUEST['replyto'])   ? Strings::escapeTags(trim($_REQUEST['replyto'])) : '';
+       $subject   = !empty($_REQUEST['subject'])   ? Strings::escapeTags(trim($_REQUEST['subject'])) : '';
+       $body      = !empty($_REQUEST['body'])      ? Strings::escapeHtml(trim($_REQUEST['body']))    : '';
+       $recipient = !empty($_REQUEST['messageto']) ? intval($_REQUEST['messageto'])                  : 0;
 
        $ret = Mail::send($recipient, $body, $subject, $replyto);
        $norecip = false;
@@ -91,7 +90,7 @@ function message_post(App $a)
                $a->argc = 2;
                $a->argv[1] = 'new';
        } else {
-               goaway($_SESSION['return_url']);
+               $a->internalRedirect($a->cmd . '/' . $ret);
        }
 }
 
@@ -102,14 +101,29 @@ function message_content(App $a)
 
        if (!local_user()) {
                notice(L10n::t('Permission denied.') . EOL);
-               return;
+               return Login::form();
        }
 
        $myprofile = System::baseUrl() . '/profile/' . $a->user['nickname'];
 
-       $tpl = get_markup_template('mail_head.tpl');
-       $header = replace_macros($tpl, [
+       $tpl = Renderer::getMarkupTemplate('mail_head.tpl');
+       if ($a->argc > 1 && $a->argv[1] == 'new') {
+               $button = [
+                       'label' => L10n::t('Discard'),
+                       'url' => '/message',
+                       'sel' => 'close',
+               ];
+       } else {
+               $button = [
+                       'label' => L10n::t('New Message'),
+                       'url' => '/message/new',
+                       'sel' => 'new',
+                       'accesskey' => 'm',
+               ];
+       }
+       $header = Renderer::replaceMacros($tpl, [
                '$messages' => L10n::t('Messages'),
+               '$button' => $button,
        ]);
 
        if (($a->argc == 3) && ($a->argv[1] === 'drop' || $a->argv[1] === 'dropconv')) {
@@ -118,7 +132,7 @@ function message_content(App $a)
                }
 
                // Check if we should do HTML-based delete confirmation
-               if ($_REQUEST['confirm']) {
+               if (!empty($_REQUEST['confirm'])) {
                        // <form> can't take arguments in its "action" parameter
                        // so add any arguments as hidden inputs
                        $query = explode_querystring($a->query_string);
@@ -131,7 +145,7 @@ function message_content(App $a)
                        }
 
                        //$a->page['aside'] = '';
-                       return replace_macros(get_markup_template('confirm.tpl'), [
+                       return Renderer::replaceMacros(Renderer::getMarkupTemplate('confirm.tpl'), [
                                '$method' => 'get',
                                '$message' => L10n::t('Do you really want to delete this message?'),
                                '$extra_inputs' => $inputs,
@@ -141,48 +155,53 @@ function message_content(App $a)
                                '$cancel' => L10n::t('Cancel'),
                        ]);
                }
+
                // Now check how the user responded to the confirmation query
-               if ($_REQUEST['canceled']) {
-                       goaway($_SESSION['return_url']);
+               if (!empty($_REQUEST['canceled'])) {
+                       $a->internalRedirect('message');
                }
 
                $cmd = $a->argv[1];
                if ($cmd === 'drop') {
-                       if (dba::delete('mail', ['id' => $a->argv[2], 'uid' => local_user()])) {
+                       $message = DBA::selectFirst('mail', ['convid'], ['id' => $a->argv[2], 'uid' => local_user()]);
+                       if(!DBA::isResult($message)){
+                               info(L10n::t('Conversation not found.') . EOL);
+                               $a->internalRedirect('message');
+                       }
+
+                       if (DBA::delete('mail', ['id' => $a->argv[2], 'uid' => local_user()])) {
                                info(L10n::t('Message deleted.') . EOL);
                        }
-                       //goaway(System::baseUrl(true) . '/message' );
-                       goaway($_SESSION['return_url']);
+
+                       $conversation = DBA::selectFirst('mail', ['id'], ['convid' => $message['convid'], 'uid' => local_user()]);
+                       if(!DBA::isResult($conversation)){
+                               info(L10n::t('Conversation removed.') . EOL);
+                               $a->internalRedirect('message');
+                       }
+
+                       $a->internalRedirect('message/' . $conversation['id'] );
                } else {
                        $r = q("SELECT `parent-uri`,`convid` FROM `mail` WHERE `id` = %d AND `uid` = %d LIMIT 1",
                                intval($a->argv[2]),
                                intval(local_user())
                        );
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $parent = $r[0]['parent-uri'];
                                $convid = $r[0]['convid'];
 
-                               if (dba::delete('mail', ['parent-uri' => $parent, 'uid' => local_user()])) {
+                               if (DBA::delete('mail', ['parent-uri' => $parent, 'uid' => local_user()])) {
                                        info(L10n::t('Conversation removed.') . EOL);
                                }
                        }
-                       //goaway(System::baseUrl(true) . '/message' );
-                       goaway($_SESSION['return_url']);
+                       $a->internalRedirect('message');
                }
        }
 
        if (($a->argc > 1) && ($a->argv[1] === 'new')) {
                $o .= $header;
 
-               $tpl = get_markup_template('msg-header.tpl');
-               $a->page['htmlhead'] .= replace_macros($tpl, [
-                       '$baseurl' => System::baseUrl(true),
-                       '$nickname' => $a->user['nickname'],
-                       '$linkurl' => L10n::t('Please enter a link URL:')
-               ]);
-
-               $tpl = get_markup_template('msg-end.tpl');
-               $a->page['end'] .= replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('msg-header.tpl');
+               $a->page['htmlhead'] .= Renderer::replaceMacros($tpl, [
                        '$baseurl' => System::baseUrl(true),
                        '$nickname' => $a->user['nickname'],
                        '$linkurl' => L10n::t('Please enter a link URL:')
@@ -197,21 +216,21 @@ function message_content(App $a)
                                intval(local_user()),
                                intval($a->argv[2])
                        );
-                       if (!DBM::is_result($r)) {
+                       if (!DBA::isResult($r)) {
                                $r = q("SELECT `name`, `url`, `id` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1",
                                        intval(local_user()),
-                                       dbesc(normalise_link(base64_decode($a->argv[2])))
+                                       DBA::escape(Strings::normaliseLink(base64_decode($a->argv[2])))
                                );
                        }
 
-                       if (!DBM::is_result($r)) {
+                       if (!DBA::isResult($r)) {
                                $r = q("SELECT `name`, `url`, `id` FROM `contact` WHERE `uid` = %d AND `addr` = '%s' LIMIT 1",
                                        intval(local_user()),
-                                       dbesc(base64_decode($a->argv[2]))
+                                       DBA::escape(base64_decode($a->argv[2]))
                                );
                        }
 
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $prename = $r[0]['name'];
                                $preurl = $r[0]['url'];
                                $preid = $r[0]['id'];
@@ -226,16 +245,16 @@ function message_content(App $a)
                // the ugly select box
                $select = ACL::getMessageContactSelectHTML('messageto', 'message-to-select', $preselect, 4, 10);
 
-               $tpl = get_markup_template('prv_message.tpl');
-               $o .= replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('prv_message.tpl');
+               $o .= Renderer::replaceMacros($tpl, [
                        '$header' => L10n::t('Send Private Message'),
                        '$to' => L10n::t('To:'),
                        '$showinputs' => 'true',
                        '$prefill' => $prefill,
                        '$preid' => $preid,
                        '$subject' => L10n::t('Subject:'),
-                       '$subjtxt' => x($_REQUEST, 'subject') ? strip_tags($_REQUEST['subject']) : '',
-                       '$text' => x($_REQUEST, 'body') ? escape_tags(htmlspecialchars($_REQUEST['body'])) : '',
+                       '$subjtxt' => !empty($_REQUEST['subject']) ? strip_tags($_REQUEST['subject']) : '',
+                       '$text' => !empty($_REQUEST['body']) ? Strings::escapeHtml(htmlspecialchars($_REQUEST['body'])) : '',
                        '$readonly' => '',
                        '$yourmessage' => L10n::t('Your message:'),
                        '$select' => $select,
@@ -249,7 +268,7 @@ function message_content(App $a)
        }
 
 
-       $_SESSION['return_url'] = $a->query_string;
+       $_SESSION['return_path'] = $a->query_string;
 
        if ($a->argc == 1) {
 
@@ -257,25 +276,27 @@ function message_content(App $a)
 
                $o .= $header;
 
+               $total = 0;
                $r = q("SELECT count(*) AS `total`, ANY_VALUE(`created`) AS `created` FROM `mail`
                        WHERE `mail`.`uid` = %d GROUP BY `parent-uri` ORDER BY `created` DESC",
                        intval(local_user())
                );
-
-               if (DBM::is_result($r)) {
-                       $a->set_pager_total($r[0]['total']);
+               if (DBA::isResult($r)) {
+                       $total = $r[0]['total'];
                }
 
-               $r = get_messages(local_user(), $a->pager['start'], $a->pager['itemspage']);
+               $pager = new Pager($a->query_string);
+
+               $r = get_messages(local_user(), $pager->getStart(), $pager->getItemsPerPage());
 
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        info(L10n::t('No messages.') . EOL);
                        return $o;
                }
 
                $o .= render_messages($r, 'mail_list.tpl');
 
-               $o .= paginate($a);
+               $o .= $pager->renderFull($total);
 
                return $o;
        }
@@ -290,14 +311,14 @@ function message_content(App $a)
                        intval(local_user()),
                        intval($a->argv[1])
                );
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $contact_id = $r[0]['contact-id'];
                        $convid = $r[0]['convid'];
 
-                       $sql_extra = sprintf(" and `mail`.`parent-uri` = '%s' ", dbesc($r[0]['parent-uri']));
+                       $sql_extra = sprintf(" and `mail`.`parent-uri` = '%s' ", DBA::escape($r[0]['parent-uri']));
                        if ($convid)
                                $sql_extra = sprintf(" and ( `mail`.`parent-uri` = '%s' OR `mail`.`convid` = '%d' ) ",
-                                       dbesc($r[0]['parent-uri']),
+                                       DBA::escape($r[0]['parent-uri']),
                                        intval($convid)
                                );
 
@@ -306,26 +327,21 @@ function message_content(App $a)
                                WHERE `mail`.`uid` = %d $sql_extra ORDER BY `mail`.`created` ASC",
                                intval(local_user())
                        );
+               } else {
+                       $messages = false;
                }
-               if (!count($messages)) {
+               if (!DBA::isResult($messages)) {
                        notice(L10n::t('Message not available.') . EOL);
                        return $o;
                }
 
                $r = q("UPDATE `mail` SET `seen` = 1 WHERE `parent-uri` = '%s' AND `uid` = %d",
-                       dbesc($r[0]['parent-uri']),
+                       DBA::escape($r[0]['parent-uri']),
                        intval(local_user())
                );
 
-               $tpl = get_markup_template('msg-header.tpl');
-               $a->page['htmlhead'] .= replace_macros($tpl, [
-                       '$baseurl' => System::baseUrl(true),
-                       '$nickname' => $a->user['nickname'],
-                       '$linkurl' => L10n::t('Please enter a link URL:')
-               ]);
-
-               $tpl = get_markup_template('msg-end.tpl');
-               $a->page['end'] .= replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('msg-header.tpl');
+               $a->page['htmlhead'] .= Renderer::replaceMacros($tpl, [
                        '$baseurl' => System::baseUrl(true),
                        '$nickname' => $a->user['nickname'],
                        '$linkurl' => L10n::t('Please enter a link URL:')
@@ -341,11 +357,8 @@ function message_content(App $a)
                        if ($message['from-url'] == $myprofile) {
                                $from_url = $myprofile;
                                $sparkle = '';
-                       } elseif ($message['contact-id'] != 0) {
-                               $from_url = 'redir/' . $message['contact-id'];
-                               $sparkle = ' sparkle';
                        } else {
-                               $from_url = $message['from-url'] . "?zrl=" . urlencode($myprofile);
+                               $from_url = Contact::magicLink($message['from-url']);
                                $sparkle = ' sparkle';
                        }
 
@@ -372,7 +385,7 @@ function message_content(App $a)
                                'from_url' => $from_url,
                                'from_addr' => $contact['addr'],
                                'sparkle' => $sparkle,
-                               'from_photo' => proxy_url($from_photo, false, PROXY_SIZE_THUMB),
+                               'from_photo' => ProxyUtils::proxifyUrl($from_photo, false, ProxyUtils::SIZE_THUMB),
                                'subject' => $subject_e,
                                'body' => $body_e,
                                'delete' => L10n::t('Delete message'),
@@ -387,8 +400,8 @@ function message_content(App $a)
                $select = $message['name'] . '<input type="hidden" name="messageto" value="' . $contact_id . '" />';
                $parent = '<input type="hidden" name="replyto" value="' . $message['parent-uri'] . '" />';
 
-               $tpl = get_markup_template('mail_display.tpl');
-               $o = replace_macros($tpl, [
+               $tpl = Renderer::getMarkupTemplate('mail_display.tpl');
+               $o = Renderer::replaceMacros($tpl, [
                        '$thread_id' => $a->argv[1],
                        '$thread_subject' => $message['title'],
                        '$thread_seen' => $seen,
@@ -442,7 +455,7 @@ function render_messages(array $msg, $t)
 {
        $a = get_app();
 
-       $tpl = get_markup_template($t);
+       $tpl = Renderer::getMarkupTemplate($t);
        $rslt = '';
 
        $myprofile = System::baseUrl() . '/profile/' . $a->user['nickname'];
@@ -450,7 +463,7 @@ function render_messages(array $msg, $t)
        foreach ($msg as $rr) {
                if ($rr['unknown']) {
                        $participants = L10n::t("Unknown sender - %s", $rr['from-name']);
-               } elseif (link_compare($rr['from-url'], $myprofile)) {
+               } elseif (Strings::compareLink($rr['from-url'], $myprofile)) {
                        $participants = L10n::t("You and %s", $rr['name']);
                } else {
                        $participants = L10n::t("%s and You", $rr['from-name']);
@@ -467,13 +480,13 @@ function render_messages(array $msg, $t)
                        $from_photo = (($rr['thumb']) ? $rr['thumb'] : $rr['from-photo']);
                }
 
-               $rslt .= replace_macros($tpl, [
+               $rslt .= Renderer::replaceMacros($tpl, [
                        '$id' => $rr['id'],
                        '$from_name' => $participants,
-                       '$from_url' => (($rr['network'] === NETWORK_DFRN) ? 'redir/' . $rr['contact-id'] : $rr['url']),
-                       '$from_addr' => $contact['addr'],
+                       '$from_url' => Contact::magicLink($rr['url']),
+                       '$from_addr' => defaults($contact, 'addr', ''),
                        '$sparkle' => ' sparkle',
-                       '$from_photo' => proxy_url($from_photo, false, PROXY_SIZE_THUMB),
+                       '$from_photo' => ProxyUtils::proxifyUrl($from_photo, false, ProxyUtils::SIZE_THUMB),
                        '$subject' => $subject_e,
                        '$delete' => L10n::t('Delete conversation'),
                        '$body' => $body_e,