]> git.mxchange.org Git - friendica.git/blobdiff - mod/network.php
Merge pull request #7988 from friendica/MrPetovan-notice
[friendica.git] / mod / network.php
index fddec60c8dc86457e1273d551adb2d766e63babb..44c7c8b44f9aa4859baf0d606cbee35e7ac1465c 100644 (file)
@@ -5,6 +5,7 @@
  */
 
 use Friendica\App;
+use Friendica\BaseObject;
 use Friendica\Content\Feature;
 use Friendica\Content\ForumManager;
 use Friendica\Content\Nav;
@@ -40,22 +41,6 @@ function network_init(App $a)
 
        Hook::add('head', __FILE__, 'network_infinite_scroll_head');
 
-       $search = (!empty($_GET['search']) ? Strings::escapeHtml($_GET['search']) : '');
-
-       if (($search != '') && !empty($_GET['submit'])) {
-               $a->internalRedirect('search?search=' . urlencode($search));
-       }
-
-       if (!empty($_GET['save'])) {
-               $exists = DBA::exists('search', ['uid' => local_user(), 'term' => $search]);
-               if (!$exists) {
-                       DBA::insert('search', ['uid' => local_user(), 'term' => $search]);
-               }
-       }
-       if (!empty($_GET['remove'])) {
-               DBA::delete('search', ['uid' => local_user(), 'term' => $search]);
-       }
-
        $is_a_date_query = false;
 
        $group_id = (($a->argc > 1 && is_numeric($a->argv[1])) ? intval($a->argv[1]) : 0);
@@ -67,9 +52,12 @@ function network_init(App $a)
                $group_id = 0;
        }
 
+       /** @var DateTimeFormat $dtFormat */
+       $dtFormat = BaseObject::getClass(DateTimeFormat::class);
+
        if ($a->argc > 1) {
                for ($x = 1; $x < $a->argc; $x ++) {
-                       if (is_a_date_arg($a->argv[$x])) {
+                       if ($dtFormat->isYearMonth($a->argv[$x])) {
                                $is_a_date_query = true;
                                break;
                        }
@@ -82,7 +70,7 @@ function network_init(App $a)
 
        // fetch last used network view and redirect if needed
        if (!$is_a_date_query) {
-               $sel_nets = defaults($_GET, 'nets', '');
+               $sel_nets = $_GET['nets'] ?? '';
                $sel_tabs = network_query_get_sel_tab($a);
                $sel_groups = network_query_get_sel_group($a);
                $last_sel_tabs = PConfig::get(local_user(), 'network.view', 'tab.selected');
@@ -98,7 +86,7 @@ function network_init(App $a)
 
                if ($remember_tab) {
                        // redirect if current selected tab is '/network' and
-                       // last selected tab is _not_ '/network?order=comment'.
+                       // last selected tab is _not_ '/network?order=activity'.
                        // and this isn't a date query
 
                        $tab_baseurls = [
@@ -110,12 +98,12 @@ function network_init(App $a)
                                '',     //bookmarked
                        ];
                        $tab_args = [
-                               'order=comment', //all
-                               'order=post',    //postord
-                               'conv=1',        //conv
-                               '',                 //new
-                               'star=1',        //starred
-                               'bmark=1',       //bookmarked
+                               'order=activity', //all
+                               'order=post',     //postord
+                               'conv=1',         //conv
+                               '',               //new
+                               'star=1',         //starred
+                               'bmark=1',        //bookmarked
                        ];
 
                        $k = array_search('active', $last_sel_tabs);
@@ -154,62 +142,25 @@ function network_init(App $a)
        $a->page['aside'] .= Group::sidebarWidget('network/0', 'network', 'standard', $group_id);
        $a->page['aside'] .= ForumManager::widget(local_user(), $cid);
        $a->page['aside'] .= Widget::postedByYear('network', local_user(), false);
-       $a->page['aside'] .= Widget::networks('network', defaults($_GET, 'nets', '') );
-       $a->page['aside'] .= saved_searches($search);
-       $a->page['aside'] .= Widget::fileAs('network', defaults($_GET, 'file', '') );
-}
-
-function saved_searches($search)
-{
-       $srchurl = '/network?f='
-               . (!empty($_GET['cid'])   ? '&cid='   . rawurlencode($_GET['cid'])   : '')
-               . (!empty($_GET['star'])  ? '&star='  . rawurlencode($_GET['star'])  : '')
-               . (!empty($_GET['bmark']) ? '&bmark=' . rawurlencode($_GET['bmark']) : '')
-               . (!empty($_GET['conv'])  ? '&conv='  . rawurlencode($_GET['conv'])  : '')
-               . (!empty($_GET['nets'])  ? '&nets='  . rawurlencode($_GET['nets'])  : '')
-               . (!empty($_GET['cmin'])  ? '&cmin='  . rawurlencode($_GET['cmin'])  : '')
-               . (!empty($_GET['cmax'])  ? '&cmax='  . rawurlencode($_GET['cmax'])  : '')
-               . (!empty($_GET['file'])  ? '&file='  . rawurlencode($_GET['file'])  : '');
-       ;
-
-       $terms = DBA::select('search', ['id', 'term'], ['uid' => local_user()]);
-       $saved = [];
-
-       while ($rr = DBA::fetch($terms)) {
-               $saved[] = [
-                       'id'          => $rr['id'],
-                       'term'        => $rr['term'],
-                       'encodedterm' => urlencode($rr['term']),
-                       'delete'      => L10n::t('Remove term'),
-                       'selected'    => ($search == $rr['term']),
-               ];
-       }
-
-       $tpl = Renderer::getMarkupTemplate('saved_searches_aside.tpl');
-       $o = Renderer::replaceMacros($tpl, [
-               '$title'     => L10n::t('Saved Searches'),
-               '$add'       => L10n::t('add'),
-               '$searchbox' => HTML::search($search, 'netsearch-box', $srchurl),
-               '$saved'     => $saved,
-       ]);
-
-       return $o;
+       $a->page['aside'] .= Widget::networks('network', $_GET['nets'] ?? '');
+       $a->page['aside'] .= Widget\SavedSearches::getHTML($a->query_string);
+       $a->page['aside'] .= Widget::fileAs('network', $_GET['file'] ?? '');
 }
 
 /**
  * Return selected tab from query
  *
  * urls -> returns
- *        '/network'                    => $no_active = 'active'
- *        '/network?order=comment'    => $comment_active = 'active'
- *        '/network?order=post'    => $postord_active = 'active'
+ *        '/network'                => $no_active = 'active'
+ *        '/network?order=activity' => $activity_active = 'active'
+ *        '/network?order=post'     => $postord_active = 'active'
  *        '/network?conv=1',        => $conv_active = 'active'
- *        '/network/new',                => $new_active = 'active'
+ *        '/network/new',           => $new_active = 'active'
  *        '/network?star=1',        => $starred_active = 'active'
- *        '/network?bmark=1',        => $bookmarked_active = 'active'
+ *        '/network?bmark=1',       => $bookmarked_active = 'active'
  *
  * @param App $a
- * @return array ($no_active, $comment_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active);
+ * @return array ($no_active, $activity_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active);
  */
 function network_query_get_sel_tab(App $a)
 {
@@ -243,8 +194,8 @@ function network_query_get_sel_tab(App $a)
 
        if ($no_active == 'active' && !empty($_GET['order'])) {
                switch($_GET['order']) {
-                       case 'post'    : $postord_active = 'active'; $no_active=''; break;
-                       case 'comment' : $all_active     = 'active'; $no_active=''; break;
+                       case 'post' :     $postord_active = 'active'; $no_active=''; break;
+                       case 'activity' : $all_active     = 'active'; $no_active=''; break;
                }
        }
 
@@ -409,7 +360,7 @@ function networkFlatView(App $a, $update = 0)
 
        $o = '';
 
-       $file = defaults($_GET, 'file', '');
+       $file = $_GET['file'] ?? '';
 
        if (!$update && !$rawmode) {
                $tabs = network_tabs($a);
@@ -426,7 +377,7 @@ function networkFlatView(App $a, $update = 0)
                        (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) ||
                        strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'),
                        'default_perms' => ACL::getDefaultUserPermissions($a->user),
-                       'acl' => ACL::getFullSelectorHTML($a->user, true),
+                       'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true),
                        'bang' => '',
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
@@ -514,9 +465,12 @@ function networkThreadedView(App $a, $update, $parent)
 
        $default_permissions = [];
 
+       /** @var DateTimeFormat $dtFormat */
+       $dtFormat = BaseObject::getClass(DateTimeFormat::class);
+
        if ($a->argc > 1) {
                for ($x = 1; $x < $a->argc; $x ++) {
-                       if (is_a_date_arg($a->argv[$x])) {
+                       if ($dtFormat->isYearMonth($a->argv[$x])) {
                                if ($datequery) {
                                        $datequery2 = Strings::escapeHtml($a->argv[$x]);
                                } else {
@@ -532,12 +486,12 @@ function networkThreadedView(App $a, $update, $parent)
 
        $o = '';
 
-       $cid   = intval(defaults($_GET, 'cid'  , 0));
-       $star  = intval(defaults($_GET, 'star' , 0));
-       $bmark = intval(defaults($_GET, 'bmark', 0));
-       $conv  = intval(defaults($_GET, 'conv' , 0));
-       $order = Strings::escapeTags(defaults($_GET, 'order', 'comment'));
-       $nets  =        defaults($_GET, 'nets' , '');
+       $cid   = intval($_GET['cid']   ?? 0);
+       $star  = intval($_GET['star']  ?? 0);
+       $bmark = intval($_GET['bmark'] ?? 0);
+       $conv  = intval($_GET['conv']  ?? 0);
+       $order = Strings::escapeTags(($_GET['order'] ?? '') ?: 'activity');
+       $nets  =        $_GET['nets']  ?? '';
 
        $allowedCids = [];
        if ($cid) {
@@ -600,7 +554,7 @@ function networkThreadedView(App $a, $update, $parent)
                        (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) ||
                        strlen($a->user['deny_cid']) || strlen($a->user['deny_gid']))) ? 'lock' : 'unlock'),
                        'default_perms' => ACL::getDefaultUserPermissions($a->user),
-                       'acl' => ACL::getFullSelectorHTML($a->user, true, $default_permissions),
+                       'acl' => ACL::getFullSelectorHTML($a->page, $a->user, true, $default_permissions),
                        'bang' => (($gid || $cid || $nets) ? '!' : ''),
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
@@ -676,7 +630,7 @@ function networkThreadedView(App $a, $update, $parent)
                        $entries[0] = [
                                'id' => 'network',
                                'name' => $contact['name'],
-                               'itemurl' => defaults($contact, 'addr', $contact['nurl']),
+                               'itemurl' => ($contact['addr'] ?? '') ?: $contact['nurl'],
                                'thumb' => ProxyUtils::proxifyUrl($contact['thumb'], false, ProxyUtils::SIZE_THUMB),
                                'details' => $contact['location'],
                        ];
@@ -959,9 +913,9 @@ function network_tabs(App $a)
        // item filter tabs
        /// @TODO fix this logic, reduce duplication
        /// $a->page['content'] .= '<div class="tabs-wrapper">';
-       list($no_active, $all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active) = network_query_get_sel_tab($a);
+       list($no_active, $all_active, $post_active, $conv_active, $new_active, $starred_active, $bookmarked_active) = network_query_get_sel_tab($a);
 
-       // if no tabs are selected, defaults to comments
+       // if no tabs are selected, defaults to activitys
        if ($no_active == 'active') {
                $all_active = 'active';
        }
@@ -971,19 +925,19 @@ function network_tabs(App $a)
        // tabs
        $tabs = [
                [
-                       'label' => L10n::t('Commented Order'),
-                       'url'   => str_replace('/new', '', $cmd) . '?order=comment' . (!empty($_GET['cid']) ? '&cid=' . $_GET['cid'] : ''),
+                       'label' => L10n::t('Latest Activity'),
+                       'url'   => str_replace('/new', '', $cmd) . '?order=activity' . (!empty($_GET['cid']) ? '&cid=' . $_GET['cid'] : ''),
                        'sel'   => $all_active,
-                       'title' => L10n::t('Sort by Comment Date'),
-                       'id'    => 'commented-order-tab',
+                       'title' => L10n::t('Sort by latest activity'),
+                       'id'    => 'activity-order-tab',
                        'accesskey' => 'e',
                ],
                [
-                       'label' => L10n::t('Posted Order'),
+                       'label' => L10n::t('Latest Posts'),
                        'url'   => str_replace('/new', '', $cmd) . '?order=post' . (!empty($_GET['cid']) ? '&cid=' . $_GET['cid'] : ''),
-                       'sel'   => $postord_active,
-                       'title' => L10n::t('Sort by Post Date'),
-                       'id'    => 'posted-order-tab',
+                       'sel'   => $post_active,
+                       'title' => L10n::t('Sort by post received date'),
+                       'id'    => 'post-order-tab',
                        'accesskey' => 't',
                ],
        ];
@@ -1031,7 +985,7 @@ function network_tabs(App $a)
        // save selected tab, but only if not in file mode
        if (empty($_GET['file'])) {
                PConfig::set(local_user(), 'network.view', 'tab.selected', [
-                       $all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active
+                       $all_active, $post_active, $conv_active, $new_active, $starred_active, $bookmarked_active
                ]);
        }
 
@@ -1066,7 +1020,7 @@ function network_infinite_scroll_head(App $a, &$htmlhead)
        global $pager;
 
        if (PConfig::get(local_user(), 'system', 'infinite_scroll')
-               && defaults($_GET, 'mode', '') != 'minimal'
+               && ($_GET['mode'] ?? '') != 'minimal'
        ) {
                $tpl = Renderer::getMarkupTemplate('infinite_scroll_head.tpl');
                $htmlhead .= Renderer::replaceMacros($tpl, [