]> git.mxchange.org Git - friendica.git/blobdiff - mod/network.php
Avoid a notice
[friendica.git] / mod / network.php
index 95f240953a760130f02563e88b499bd7d5cba473..58e147d1f70d4d97431c9161b562f5ef3d21b86c 100644 (file)
@@ -14,6 +14,7 @@ use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
 use Friendica\Core\PConfig;
+use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Model\Contact;
@@ -22,6 +23,7 @@ use Friendica\Model\Item;
 use Friendica\Model\Profile;
 use Friendica\Module\Login;
 use Friendica\Util\DateTimeFormat;
+use Friendica\Util\Proxy as ProxyUtils;
 
 require_once 'include/conversation.php';
 require_once 'include/items.php';
@@ -316,7 +318,7 @@ function networkSetSeen($condition)
                return;
        }
 
-       $unseen = DBA::exists('item', $condition);
+       $unseen = Item::exists($condition);
 
        if ($unseen) {
                $r = Item::update(['unseen' => false], $condition);
@@ -416,9 +418,9 @@ function networkFlatView(App $a, $update = 0)
                        'allow_location' => $a->user['allow_location'],
                        'default_location' => $a->user['default-location'],
                        'nickname' => $a->user['nickname'],
-                       'lockstate' => (((is_array($a->user) &&
-                       ((strlen($a->user['allow_cid'])) || (strlen($a->user['allow_gid'])) ||
-                       (strlen($a->user['deny_cid'])) || (strlen($a->user['deny_gid']))))) ? 'lock' : 'unlock'),
+                       'lockstate' => (is_array($a->user) &&
+                       (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) ||
+                       strlen($a->user['deny_cid']) || strlen($a->user['deny_gid'])) ? 'lock' : 'unlock'),
                        'default_perms' => ACL::getDefaultUserPermissions($a->user),
                        'acl' => ACL::getFullSelectorHTML($a->user, true),
                        'bang' => '',
@@ -447,7 +449,7 @@ function networkFlatView(App $a, $update = 0)
                while ($term = DBA::fetch($result)) {
                        $posts[] = $term['oid'];
                }
-               DBA::close($terms);
+               DBA::close($result);
 
                $condition = ['uid' => local_user(), 'id' => $posts];
        } else {
@@ -494,6 +496,8 @@ function networkThreadedView(App $a, $update, $parent)
 
        $gid = 0;
 
+       $default_permissions = [];
+
        if ($a->argc > 1) {
                for ($x = 1; $x < $a->argc; $x ++) {
                        if (is_a_date_arg($a->argv[$x])) {
@@ -505,7 +509,7 @@ function networkThreadedView(App $a, $update, $parent)
                                }
                        } elseif (intval($a->argv[$x])) {
                                $gid = intval($a->argv[$x]);
-                               $def_acl = ['allow_gid' => '<' . $gid . '>'];
+                               $default_permissions = ['allow_gid' => '<' . $gid . '>'];
                        }
                }
        }
@@ -520,7 +524,7 @@ function networkThreadedView(App $a, $update, $parent)
        $nets  =        defaults($_GET, 'nets' , '');
 
        if ($cid) {
-               $def_acl = ['allow_cid' => '<' . intval($cid) . '>'];
+               $default_permissions = ['allow_cid' => '<' . intval($cid) . '>'];
        }
 
        if ($nets) {
@@ -531,7 +535,7 @@ function networkThreadedView(App $a, $update, $parent)
                        $str .= '<' . $rr['id'] . '>';
                }
                if (strlen($str)) {
-                       $def_acl = ['allow_cid' => $str];
+                       $default_permissions = ['allow_cid' => $str];
                }
        }
 
@@ -570,11 +574,11 @@ function networkThreadedView(App $a, $update, $parent)
                        'allow_location' => $a->user['allow_location'],
                        'default_location' => $a->user['default-location'],
                        'nickname' => $a->user['nickname'],
-                       'lockstate' => ((($gid) || ($cid) || ($nets) || (is_array($a->user) &&
-                       ((strlen($a->user['allow_cid'])) || (strlen($a->user['allow_gid'])) ||
-                       (strlen($a->user['deny_cid'])) || (strlen($a->user['deny_gid']))))) ? 'lock' : 'unlock'),
+                       'lockstate' => ($gid || $cid || $nets || (is_array($a->user) &&
+                       (strlen($a->user['allow_cid']) || strlen($a->user['allow_gid']) ||
+                       strlen($a->user['deny_cid']) || strlen($a->user['deny_gid']))) ? 'lock' : 'unlock'),
                        'default_perms' => ACL::getDefaultUserPermissions($a->user),
-                       'acl' => ACL::getFullSelectorHTML((($gid || $cid || $nets) ? $def_acl : $a->user), true),
+                       'acl' => ACL::getFullSelectorHTML($a->user, true, $default_permissions),
                        'bang' => (($gid || $cid || $nets) ? '!' : ''),
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
@@ -604,8 +608,8 @@ function networkThreadedView(App $a, $update, $parent)
                $sql_post_table = " INNER JOIN `thread` ON `thread`.`iid` = `item`.`parent`";
        }
 
-       $sql_nets = (($nets) ? sprintf(" AND $sql_table.`network` = '%s' ", dbesc($nets)) : '');
-       $sql_tag_nets = (($nets) ? sprintf(" AND `item`.`network` = '%s' ", dbesc($nets)) : '');
+       $sql_nets = (($nets) ? sprintf(" AND $sql_table.`network` = '%s' ", DBA::escape($nets)) : '');
+       $sql_tag_nets = (($nets) ? sprintf(" AND `item`.`network` = '%s' ", DBA::escape($nets)) : '');
 
        if ($gid) {
                $group = DBA::selectFirst('group', ['name'], ['id' => $gid, 'uid' => local_user()]);
@@ -652,7 +656,7 @@ function networkThreadedView(App $a, $update, $parent)
                                'id' => 'network',
                                'name' => htmlentities($contact['name']),
                                'itemurl' => defaults($contact, 'addr', $contact['nurl']),
-                               'thumb' => proxy_url($contact['thumb'], false, PROXY_SIZE_THUMB),
+                               'thumb' => ProxyUtils::proxifyUrl($contact['thumb'], false, ProxyUtils::SIZE_THUMB),
                                'details' => $contact['location'],
                        ];
 
@@ -663,7 +667,7 @@ function networkThreadedView(App $a, $update, $parent)
                                'id' => 'network',
                        ]) . $o;
 
-                       if ($contact['network'] === NETWORK_OSTATUS && $contact['writable'] && !PConfig::get(local_user(),'system','nowarn_insecure')) {
+                       if ($contact['network'] === Protocol::OSTATUS && $contact['writable'] && !PConfig::get(local_user(),'system','nowarn_insecure')) {
                                notice(L10n::t('Private messages to this person are at risk of public disclosure.') . EOL);
                        }
                } else {
@@ -680,11 +684,11 @@ function networkThreadedView(App $a, $update, $parent)
 
        if ($datequery) {
                $sql_extra3 .= protect_sprintf(sprintf(" AND $sql_table.created <= '%s' ",
-                               dbesc(DateTimeFormat::convert($datequery, 'UTC', date_default_timezone_get()))));
+                               DBA::escape(DateTimeFormat::convert($datequery, 'UTC', date_default_timezone_get()))));
        }
        if ($datequery2) {
                $sql_extra3 .= protect_sprintf(sprintf(" AND $sql_table.created >= '%s' ",
-                               dbesc(DateTimeFormat::convert($datequery2, 'UTC', date_default_timezone_get()))));
+                               DBA::escape(DateTimeFormat::convert($datequery2, 'UTC', date_default_timezone_get()))));
        }
 
        if ($conv) {
@@ -703,7 +707,7 @@ function networkThreadedView(App $a, $update, $parent)
        $sql_order = "$sql_table.$ordering";
 
        if (x($_GET, 'offset')) {
-               $sql_range = sprintf(" AND $sql_order <= '%s'", dbesc($_GET['offset']));
+               $sql_range = sprintf(" AND $sql_order <= '%s'", DBA::escape($_GET['offset']));
        } else {
                $sql_range = '';
        }
@@ -716,7 +720,7 @@ function networkThreadedView(App $a, $update, $parent)
                case 'received':
                        if ($last_received != '') {
                                $last_date = $last_received;
-                               $sql_range .= sprintf(" AND $sql_table.`received` < '%s'", dbesc($last_received));
+                               $sql_range .= sprintf(" AND $sql_table.`received` < '%s'", DBA::escape($last_received));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -724,7 +728,7 @@ function networkThreadedView(App $a, $update, $parent)
                case 'commented':
                        if ($last_commented != '') {
                                $last_date = $last_commented;
-                               $sql_range .= sprintf(" AND $sql_table.`commented` < '%s'", dbesc($last_commented));
+                               $sql_range .= sprintf(" AND $sql_table.`commented` < '%s'", DBA::escape($last_commented));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -732,14 +736,14 @@ function networkThreadedView(App $a, $update, $parent)
                case 'created':
                        if ($last_created != '') {
                                $last_date = $last_created;
-                               $sql_range .= sprintf(" AND $sql_table.`created` < '%s'", dbesc($last_created));
+                               $sql_range .= sprintf(" AND $sql_table.`created` < '%s'", DBA::escape($last_created));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
                        break;
                case 'id':
                        if (($last_id > 0) && ($sql_table == '`thread`')) {
-                               $sql_range .= sprintf(" AND $sql_table.`iid` < '%s'", dbesc($last_id));
+                               $sql_range .= sprintf(" AND $sql_table.`iid` < '%s'", DBA::escape($last_id));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -767,7 +771,7 @@ function networkThreadedView(App $a, $update, $parent)
                        FROM `item` $sql_post_table
                        STRAIGHT_JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
                                AND (NOT `contact`.`blocked` OR `contact`.`pending`)
-                               AND (`item`.`parent-uri` != `item`.`uri`
+                               AND (`item`.`gravity` != %d
                                        OR `contact`.`uid` = `item`.`uid` AND `contact`.`self`
                                        OR `contact`.`rel` IN (%d, %d) AND NOT `contact`.`readonly`)
                        LEFT JOIN `user-item` ON `user-item`.`iid` = `item`.`id` AND `user-item`.`uid` = %d
@@ -776,8 +780,9 @@ function networkThreadedView(App $a, $update, $parent)
                        AND NOT `item`.`moderated` AND $sql_extra4
                        $sql_extra3 $sql_extra $sql_range $sql_nets
                        ORDER BY `order_date` DESC LIMIT 100",
-                       intval(CONTACT_IS_SHARING),
-                       intval(CONTACT_IS_FRIEND),
+                       intval(GRAVITY_PARENT),
+                       intval(Contact::SHARING),
+                       intval(Contact::FRIEND),
                        intval(local_user()),
                        intval(local_user())
                );
@@ -787,7 +792,7 @@ function networkThreadedView(App $a, $update, $parent)
                        STRAIGHT_JOIN `contact` ON `contact`.`id` = `thread`.`contact-id`
                                AND (NOT `contact`.`blocked` OR `contact`.`pending`)
                        STRAIGHT_JOIN `item` ON `item`.`id` = `thread`.`iid`
-                               AND (`item`.`parent-uri` != `item`.`uri`
+                               AND (`item`.`gravity` != %d
                                        OR `contact`.`uid` = `item`.`uid` AND `contact`.`self`
                                        OR `contact`.`rel` IN (%d, %d) AND NOT `contact`.`readonly`)
                        LEFT JOIN `user-item` ON `user-item`.`iid` = `item`.`id` AND `user-item`.`uid` = %d
@@ -796,15 +801,16 @@ function networkThreadedView(App $a, $update, $parent)
                        AND (`user-item`.`hidden` IS NULL OR NOT `user-item`.`hidden`)
                        $sql_extra2 $sql_extra3 $sql_range $sql_extra $sql_nets
                        ORDER BY `order_date` DESC $pager_sql",
-                       intval(CONTACT_IS_SHARING),
-                       intval(CONTACT_IS_FRIEND),
+                       intval(GRAVITY_PARENT),
+                       intval(Contact::SHARING),
+                       intval(Contact::FRIEND),
                        intval(local_user()),
                        intval(local_user())
                );
        }
 
        // Only show it when unfiltered (no groups, no networks, ...)
-       if (in_array($nets, ['', NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS]) && (strlen($sql_extra . $sql_extra2 . $sql_extra3) == 0)) {
+       if (in_array($nets, ['', Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS]) && (strlen($sql_extra . $sql_extra2 . $sql_extra3) == 0)) {
                if (DBA::isResult($r)) {
                        $top_limit = current($r)['order_date'];
                        $bottom_limit = end($r)['order_date'];
@@ -902,7 +908,7 @@ function networkThreadedView(App $a, $update, $parent)
                $condition = ['unseen' => true, 'uid' => local_user()];
                networkSetSeen($condition);
        } elseif ($parents_str) {
-               $condition = ["`uid` = ? AND `unseen` AND `parent` IN (" . dbesc($parents_str) . ")", local_user()];
+               $condition = ["`uid` = ? AND `unseen` AND `parent` IN (" . DBA::escape($parents_str) . ")", local_user()];
                networkSetSeen($condition);
        }