]> git.mxchange.org Git - friendica.git/blobdiff - mod/network.php
Merge branch 'rewrites/is_filled_array_introduced' of git://github.com/Quix0r/friendi...
[friendica.git] / mod / network.php
index 0f9b0d2339ad41977f03e864c517b7b12bda4d00..1123c34371b67644c6596d337ec7182a4489c428 100644 (file)
@@ -6,6 +6,8 @@ function network_init(&$a) {
        }
 
        $is_a_date_query = false;
+       if(x($_GET['cid']) && intval($_GET['cid']) != 0)
+               $cid = $_GET['cid'];
 
        if($a->argc > 1) {
                for($x = 1; $x < $a->argc; $x ++) {
@@ -45,7 +47,7 @@ function network_init(&$a) {
                else if($sel_groups !== false) {
                        $net_baseurl .= '/' . $sel_groups;
                }
-               
+
                if($remember_tab) {
                        // redirect if current selected tab is '/network' and
                        // last selected tab is _not_ '/network?f=&order=comment'.
@@ -55,19 +57,19 @@ function network_init(&$a) {
                                '',             //all
                                '',             //postord
                                '',             //conv
-                               '/new', //new
+                               '/new',         //new
                                '',             //starred
                                '',             //bookmarked
                                '',             //spam
                        );
                        $tab_args = array(
                                'f=&order=comment',     //all
-                               'f=&order=post',                //postord
-                               'f=&conv=1',                    //conv
-                               '',                                     //new
-                               'f=&star=1',                    //starred
-                               'f=&bmark=1',                   //bookmarked
-                               'f=&spam=1',                    //spam
+                               'f=&order=post',        //postord
+                               'f=&conv=1',            //conv
+                               '',                     //new
+                               'f=&star=1',            //starred
+                               'f=&bmark=1',           //bookmarked
+                               'f=&spam=1',            //spam
                        );
 
                        $k = array_search('active', $last_sel_tabs);
@@ -91,17 +93,17 @@ function network_init(&$a) {
                else if($sel_nets!==false) {
                        $net_args['nets'] = $sel_nets;
                }
-               
+
                if($remember_tab || $remember_net || $remember_group) {
                        $net_args = array_merge($query_array, $net_args);
                        $net_queries = build_querystring($net_args);
-                       
+
                        $redir_url = ($net_queries ? $net_baseurl."?".$net_queries : $net_baseurl);
-                       
+
                        goaway($a->get_baseurl() . $redir_url);
                }
        }
-       
+
        if(x($_GET['nets']) && $_GET['nets'] === 'all')
                unset($_GET['nets']);
 
@@ -112,6 +114,7 @@ function network_init(&$a) {
        require_once('include/group.php');
        require_once('include/contact_widgets.php');
        require_once('include/items.php');
+       require_once('include/ForumManager.php');
 
        if(! x($a->page,'aside'))
                $a->page['aside'] = '';
@@ -119,19 +122,19 @@ function network_init(&$a) {
        $search = ((x($_GET,'search')) ? escape_tags($_GET['search']) : '');
 
        if(x($_GET,'save')) {
-               $r = q("select * from `search` where `uid` = %d and `term` = '%s' limit 1",
+               $r = q("SELECT * FROM `search` WHERE `uid` = %d AND `term` = '%s' LIMIT 1",
                        intval(local_user()),
                        dbesc($search)
                );
                if(! count($r)) {
-                       q("insert into `search` ( `uid`,`term` ) values ( %d, '%s') ",
+                       q("INSERT INTO `search` ( `uid`,`term` ) VALUES ( %d, '%s') ",
                                intval(local_user()),
                                dbesc($search)
                        );
                }
        }
        if(x($_GET,'remove')) {
-               q("delete from `search` where `uid` = %d and `term` = '%s'",
+               q("DELETE FROM `search` WHERE `uid` = %d AND `term` = '%s'",
                        intval(local_user()),
                        dbesc($search)
                );
@@ -139,14 +142,17 @@ function network_init(&$a) {
 
        // search terms header
        if(x($_GET,'search')) {
-               $a->page['content'] .= '<h2>' . t('Search Results For:') . ' '  . $search . '</h2>';
+               $a->page['content'] .= replace_macros(get_markup_template("section_title.tpl"),array(
+                       '$title' => sprintf( t('Results for: %s'), $search)
+               ));
        }
 
-       $a->page['aside'] .= (feature_enabled(local_user(),'groups') ? group_side('network/0','network',true,$group_id) : '');
-       $a->page['aside'] .= posted_date_widget($a->get_baseurl() . '/network',local_user(),false);
-       $a->page['aside'] .= networks_widget($a->get_baseurl(true) . '/network',(x($_GET, 'nets') ? $_GET['nets'] : ''));
+       $a->page['aside'] .= (feature_enabled(local_user(),'groups') ? group_side('network/0','network','standard',$group_id) : '');
+       $a->page['aside'] .= (feature_enabled(local_user(),'forumlist_widget') ? ForumManager::widget(local_user(),$cid) : '');
+       $a->page['aside'] .= posted_date_widget('network',local_user(),false);
+       $a->page['aside'] .= networks_widget('network',(x($_GET, 'nets') ? $_GET['nets'] : ''));
        $a->page['aside'] .= saved_searches($search);
-       $a->page['aside'] .= fileas_widget($a->get_baseurl(true) . '/network',(x($_GET, 'file') ? $_GET['file'] : ''));
+       $a->page['aside'] .= fileas_widget('network',(x($_GET, 'file') ? $_GET['file'] : ''));
 
 }
 
@@ -170,7 +176,7 @@ function saved_searches($search) {
 
        $o = '';
 
-       $r = q("select `id`,`term` from `search` WHERE `uid` = %d",
+       $r = q("SELECT `id`,`term` FROM `search` WHERE `uid` = %d",
                intval(local_user())
        );
 
@@ -179,11 +185,11 @@ function saved_searches($search) {
        if(count($r)) {
                foreach($r as $rr) {
                        $saved[] = array(
-                               'id'            => $rr['id'],
-                               'term'                  => $rr['term'],
+                               'id'            => $rr['id'],
+                               'term'          => $rr['term'],
                                'encodedterm'   => urlencode($rr['term']),
-                               'delete'                => t('Remove term'),
-                               'selected'              => ($search==$rr['term']),
+                               'delete'        => t('Remove term'),
+                               'selected'      => ($search==$rr['term']),
                        );
                }
        }
@@ -191,10 +197,10 @@ function saved_searches($search) {
 
        $tpl = get_markup_template("saved_searches_aside.tpl");
        $o = replace_macros($tpl, array(
-               '$title'         => t('Saved Searches'),
-               '$add'           => t('add'),
-               '$searchbox' => search($search,'netsearch-box',$srchurl,true),
-               '$saved'         => $saved,
+               '$title'        => t('Saved Searches'),
+               '$add'          => t('add'),
+               '$searchbox'    => search($search,'netsearch-box',$srchurl,true),
+               '$saved'        => $saved,
        ));
 
        return $o;
@@ -274,7 +280,8 @@ function network_query_get_sel_tab($a) {
 }
 
 /**
- * Return selected network from query
+ * @brief Return selected network from query
+ * @return string Name of the selected network
  */
 function network_query_get_sel_net() {
        $network = false;
@@ -306,7 +313,10 @@ function network_content(&$a, $update = 0) {
                return login(false);
        }
 
-       // TODO:is this really necessary? $a is already available to hooks
+       // Rawmode is used for fetching new content at the end of the page
+       $rawmode = (isset($_GET["mode"]) AND ($_GET["mode"] == "raw"));
+
+       /// @TODO Is this really necessary? $a is already available to hooks
        $arr = array('query' => $a->query_string);
        call_hooks('network_content_init', $arr);
 
@@ -339,80 +349,7 @@ function network_content(&$a, $update = 0) {
 
        $o = '';
 
-       // item filter tabs
-       // TODO: fix this logic, reduce duplication
-       //$a->page['content'] .= '<div class="tabs-wrapper">';
-
-       list($no_active, $all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active, $spam_active) = network_query_get_sel_tab($a);
-       // if no tabs are selected, defaults to comments
-       if ($no_active=='active') $all_active='active';
-
-       $cmd = (($datequery) ? '' : $a->cmd);
-       $len_naked_cmd = strlen(str_replace('/new','',$cmd));
-
-       // tabs
-       $tabs = array(
-               array(
-                       'label' => t('Commented Order'),
-                       'url'=>$a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . '?f=&order=comment' . ((x($_GET,'cid')) ? '&cid=' . $_GET['cid'] : ''),
-                       'sel'=>$all_active,
-                       'title'=> t('Sort by Comment Date'),
-               ),
-               array(
-                       'label' => t('Posted Order'),
-                       'url'=>$a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . '?f=&order=post' . ((x($_GET,'cid')) ? '&cid=' . $_GET['cid'] : ''),
-                       'sel'=>$postord_active,
-                       'title' => t('Sort by Post Date'),
-               ),
-       );
-
-       if(feature_enabled(local_user(),'personal_tab')) {
-               $tabs[] = array(
-                       'label' => t('Personal'),
-                       'url' => $a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&conv=1',
-                       'sel' => $conv_active,
-                       'title' => t('Posts that mention or involve you'),
-               );
-       }
 
-       if(feature_enabled(local_user(),'new_tab')) {
-               $tabs[] = array(
-                       'label' => t('New'),
-                       'url' => $a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . ($len_naked_cmd ? '/' : '') . 'new' . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : ''),
-                       'sel' => $new_active,
-                       'title' => t('Activity Stream - by date'),
-               );
-       }
-
-       if(feature_enabled(local_user(),'link_tab')) {
-               $tabs[] = array(
-                       'label' => t('Shared Links'),
-                       'url'=>$a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&bmark=1',
-                       'sel'=>$bookmarked_active,
-                       'title'=> t('Interesting Links'),
-               );
-       }
-
-       if(feature_enabled(local_user(),'star_posts')) {
-               $tabs[] = array(
-                       'label' => t('Starred'),
-                       'url'=>$a->get_baseurl(true) . '/' . str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&star=1',
-                       'sel'=>$starred_active,
-                       'title' => t('Favourite Posts'),
-               );
-       }
-
-       // save selected tab, but only if not in search or file mode
-       if(!x($_GET,'search') && !x($_GET,'file')) {
-               set_pconfig( local_user(), 'network.view','tab.selected',array($all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active, $spam_active) );
-       }
-
-       $arr = array('tabs' => $tabs);
-       call_hooks('network_tabs', $arr);
-
-       $o .= replace_macros(get_markup_template('common_tabs.tpl'), array('$tabs'=> $arr['tabs']));
-
-       // --- end item filter tabs
 
        $contact_id = $a->cid;
 
@@ -438,7 +375,7 @@ function network_content(&$a, $update = 0) {
                $def_acl = array('allow_cid' => '<' . intval($cid) . '>');
 
        if($nets) {
-               $r = q("select id from contact where uid = %d and network = '%s' and self = 0",
+               $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND network = '%s' AND `self` = 0",
                        intval(local_user()),
                        dbesc($nets)
                );
@@ -452,12 +389,10 @@ function network_content(&$a, $update = 0) {
        }
        set_pconfig(local_user(), 'network.view', 'net.selected', ($nets ? $nets : 'all'));
 
-/*if ($update) {
-print_r($_GET);
-die("ss");
-}*/
+       if(!$update AND !$rawmode) {
+               $tabs = network_tabs($a);
+               $o .= $tabs;
 
-       if(! $update) {
                if($group) {
                        if(($t = group_public_members($group)) && (! get_pconfig(local_user(),'system','nowarn_insecure'))) {
                                notice( sprintf( tt('Warning: This group contains %s member from an insecure network.',
@@ -469,20 +404,33 @@ die("ss");
 
                nav_set_selected('network');
 
-               $celeb = ((($a->user['page-flags'] == PAGE_SOAPBOX) || ($a->user['page-flags'] == PAGE_COMMUNITY)) ? true : false);
+               $content = "";
+
+               if ($cid) {
+                       // If $cid belongs to a communitity forum or a privat goup,.add a mention to the status editor
+                       $contact = q("SELECT `nick` FROM `contact` WHERE `id` = %d AND `uid` = %d AND (`forum` OR `prv`) ",
+                               intval($cid),
+                               intval(local_user())
+                       );
+                       if ($contact)
+                               $content = "@".$contact[0]["nick"]."+".$cid;
+               }
 
                $x = array(
                        'is_owner' => true,
                        'allow_location' => $a->user['allow_location'],
                        'default_location' => $a->user['default-location'],
                        'nickname' => $a->user['nickname'],
-                       'lockstate' => ((($group) || ($cid) || ($nets) || (is_array($a->user) && ((strlen($a->user['allow_cid'])) || (strlen($a->user['allow_gid'])) || (strlen($a->user['deny_cid'])) || (strlen($a->user['deny_gid']))))) ? 'lock' : 'unlock'),
-                       'default_perms' => get_acl_permissions($a->user),
-                       'acl' => populate_acl((($group || $cid || $nets) ? $def_acl : $a->user), $celeb),
-                       'bang' => (($group || $cid || $nets) ? '!' : ''),
+                       'lockstate'=> ((($group) || ($cid) || ($nets) || (is_array($a->user) &&
+                                       ((strlen($a->user['allow_cid'])) || (strlen($a->user['allow_gid'])) ||
+                                       (strlen($a->user['deny_cid'])) || (strlen($a->user['deny_gid']))))) ? 'lock' : 'unlock'),
+                       'default_perms' => get_acl_permissions($a->user),
+                       'acl'   => populate_acl((($group || $cid || $nets) ? $def_acl : $a->user), true),
+                       'bang'  => (($group || $cid || $nets) ? '!' : ''),
                        'visitor' => 'block',
                        'profile_uid' => local_user(),
                        'acl_data' => construct_acl_data($a, $a->user), // For non-Javascript ACL selector
+                       'content' => $content,
                );
 
                $o .= status_editor($a,$x);
@@ -518,40 +466,63 @@ die("ss");
                        if($update)
                                killme();
                        notice( t('No such group') . EOL );
-                       goaway($a->get_baseurl(true) . '/network/0');
+                       goaway('network/0');
                        // NOTREACHED
                }
 
                $contacts = expand_groups(array($group));
-
-               $contact_str_self = "";
+               $gcontacts = expand_groups(array($group), false, true);
 
                if((is_array($contacts)) && count($contacts)) {
+                       $contact_str_self = "";
+                       $gcontact_str_self = "";
+
                        $contact_str = implode(',',$contacts);
-                       $self = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", intval($_SESSION['uid']));
-                       if (count($self))
-                               $contact_str_self = ",".$self[0]["id"];
-               }
-               else {
-                               $contact_str = ' 0 ';
-                               info( t('Group is empty'));
+                       $gcontact_str = implode(',',$gcontacts);
+                       $self = q("SELECT `contact`.`id`, `gcontact`.`id` AS `gid` FROM `contact`
+                                       INNER JOIN `gcontact` ON `gcontact`.`nurl` = `contact`.`nurl`
+                                       WHERE `uid` = %d AND `self`", intval($_SESSION['uid']));
+                       if (count($self)) {
+                               $contact_str_self = $self[0]["id"];
+                               $gcontact_str_self = $self[0]["gid"];
+                       }
+
+                       $sql_post_table = " INNER JOIN `item` AS `temp1` ON `temp1`.`id` = ".$sql_table.".".$sql_parent;
+                       $sql_extra3 .= " AND ($sql_table.`contact-id` IN ($contact_str) ";
+                       $sql_extra3 .= " OR ($sql_table.`contact-id` = '$contact_str_self' AND `temp1`.`allow_gid` LIKE '".protect_sprintf('%<'.intval($group).'>%')."' AND `temp1`.`private`))";
+               } else {
+                       $sql_extra3 .= " AND false ";
+                       info( t('Group is empty'));
                }
 
-               //$sql_post_table = " INNER JOIN (SELECT DISTINCT(`parent`) FROM `item` WHERE (`contact-id` IN ($contact_str) OR `allow_gid` like '".protect_sprintf('%<'.intval($group).'>%')."') and deleted = 0 ORDER BY `created` DESC) AS `temp1` ON $sql_table.$sql_parent = `temp1`.`parent` ";
+               $o = replace_macros(get_markup_template("section_title.tpl"),array(
+                       '$title' => sprintf( t('Group: %s'), $r[0]['name'])
+               )) . $o;
 
-               $sql_extra3 .= " AND `contact-id` IN ($contact_str$contact_str_self) ";
-               $sql_extra3 .= " AND EXISTS (SELECT id FROM `item` WHERE (`contact-id` IN ($contact_str)  OR `allow_gid` like '".protect_sprintf('%<'.intval($group).'>%')."') and deleted = 0 AND parent = $sql_table.$sql_parent) ";
-               $o = '<h2>' . t('Group: ') . $r[0]['name'] . '</h2>' . $o;
-       } elseif($cid) {
+       }
+       elseif($cid) {
 
-               $r = q("SELECT `id`,`name`,`network`,`writable`,`nurl` FROM `contact` WHERE `id` = %d
+               $r = q("SELECT `id`,`name`,`network`,`writable`,`nurl`, `forum`, `prv`, `addr`, `thumb`, `location` FROM `contact` WHERE `id` = %d
                                AND `blocked` = 0 AND `pending` = 0 LIMIT 1",
                        intval($cid)
                );
                if(count($r)) {
-                       $sql_post_table = " INNER JOIN (SELECT DISTINCT(`parent`) FROM `item` WHERE 1 $sql_options AND `contact-id` = ".intval($cid)." and deleted = 0 ORDER BY `item`.`received` DESC) AS `temp1` ON $sql_table.$sql_parent = `temp1`.`parent` ";
-                       $sql_extra = "";
-                       $o = '<h2>' . t('Contact: ') . $r[0]['name'] . '</h2>' . $o;
+                       $sql_extra = " AND ".$sql_table.".`contact-id` = ".intval($cid);
+
+                       $entries[0] = array(
+                               'id' => 'network',
+                               'name' => htmlentities($r[0]['name']),
+                               'itemurl' => (($r[0]['addr']) ? ($r[0]['addr']) : ($r[0]['nurl'])),
+                               'thumb' => proxy_url($r[0]['thumb'], false, PROXY_SIZE_THUMB),
+                               'account_type' => (($r[0]['forum']) || ($r[0]['prv']) ? t('Forum') : ''),
+                               'details' => $r[0]['location'],
+                       );
+
+                       $o = replace_macros(get_markup_template("viewcontact_template.tpl"),array(
+                               'contacts' => $entries,
+                               'id' => 'network',
+                       )) . $o;
+
                        if($r[0]['network'] === NETWORK_OSTATUS && $r[0]['writable'] && (! get_pconfig(local_user(),'system','nowarn_insecure'))) {
                                notice( t('Private messages to this person are at risk of public disclosure.') . EOL);
                        }
@@ -559,7 +530,7 @@ die("ss");
                }
                else {
                        notice( t('Invalid contact.') . EOL);
-                       goaway($a->get_baseurl(true) . '/network');
+                       goaway('network');
                        // NOTREACHED
                }
        }
@@ -587,7 +558,7 @@ die("ss");
                $search = escape_tags($_GET['search']);
 
                if(strpos($search,'#') === 0) {
-                       $tag = true;
+                       $tag = true;
                        $search = substr($search,1);
                }
 
@@ -618,7 +589,7 @@ die("ss");
        }
 
        if($conv)
-               $sql_extra3 .= " AND `mention`";
+               $sql_extra3 .= " AND $sql_table.`mention`";
 
        if($update) {
 
@@ -628,29 +599,30 @@ die("ss");
        }
        else {
                if(get_config('system', 'old_pager')) {
-                       $r = q("SELECT COUNT(*) AS `total`
-                               FROM $sql_table $sql_post_table INNER JOIN `contact` ON `contact`.`id` = $sql_table.`contact-id`
-                               AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-                               WHERE $sql_table.`uid` = %d AND $sql_table.`visible` = 1 AND $sql_table.`deleted` = 0
-                               $sql_extra2 $sql_extra3
-                               $sql_extra $sql_nets ",
-                               intval($_SESSION['uid'])
-                       );
-
-                       if(count($r)) {
-                               $a->set_pager_total($r[0]['total']);
-                       }
+                       $r = q("SELECT COUNT(*) AS `total`
+                               FROM $sql_table $sql_post_table INNER JOIN `contact` ON `contact`.`id` = $sql_table.`contact-id`
+                               AND NOT `contact`.`blocked` AND NOT `contact`.`pending`
+                               WHERE $sql_table.`uid` = %d AND $sql_table.`visible` AND NOT $sql_table.`deleted`
+                               $sql_extra2 $sql_extra3
+                               $sql_extra $sql_nets ",
+                               intval($_SESSION['uid'])
+                       );
+
+                       if(count($r)) {
+                               $a->set_pager_total($r[0]['total']);
+                       }
                }
 
                //  check if we serve a mobile device and get the user settings
                //  accordingly
                if ($a->is_mobile) {
-                   $itemspage_network = get_pconfig(local_user(),'system','itemspage_mobile_network');
-                   $itemspage_network = ((intval($itemspage_network)) ? $itemspage_network : 20);
+                       $itemspage_network = get_pconfig(local_user(),'system','itemspage_mobile_network');
+                       $itemspage_network = ((intval($itemspage_network)) ? $itemspage_network : 20);
                } else {
-                   $itemspage_network = get_pconfig(local_user(),'system','itemspage_network');
-                   $itemspage_network = ((intval($itemspage_network)) ? $itemspage_network : 40);
+                       $itemspage_network = get_pconfig(local_user(),'system','itemspage_network');
+                       $itemspage_network = ((intval($itemspage_network)) ? $itemspage_network : 40);
                }
+
                //  now that we have the user settings, see if the theme forces
                //  a maximum item number which is lower then the user choice
                if(($a->force_max_items > 0) && ($a->force_max_items < $itemspage_network))
@@ -661,23 +633,18 @@ die("ss");
        }
 
        if($nouveau) {
-               $simple_update = (($update) ? " and `item`.`unseen` = 1 " : '');
+               $simple_update = (($update) ? " AND `item`.`unseen` " : '');
 
                if ($sql_order == "")
                        $sql_order = "`item`.`received`";
 
                // "New Item View" - show all items unthreaded in reverse created date order
-               $items = q("SELECT `item`.*, `item`.`id` AS `item_id`, `item`.`network` AS `item_network`,
-                       `contact`.`name`, `contact`.`photo`, `contact`.`url`, `contact`.`rel`, `contact`.`writable`,
-                       `contact`.`network`, `contact`.`thumb`, `contact`.`dfrn-id`, `contact`.`self`,
-                       `contact`.`id` AS `cid`, `contact`.`uid` AS `contact-uid`
-                       FROM $sql_table $sql_post_table INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
-                       AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-                       WHERE `item`.`uid` = %d AND `item`.`visible` = 1
-                       AND `item`.`deleted` = 0 and `item`.`moderated` = 0
+               $items = q("SELECT %s FROM $sql_table $sql_post_table %s
+                       WHERE %s AND `item`.`uid` = %d
                        $simple_update
                        $sql_extra $sql_nets
                        ORDER BY $sql_order DESC $pager_sql ",
+                       item_fieldlists(), item_joins(), item_condition(),
                        intval($_SESSION['uid'])
                );
 
@@ -705,25 +672,26 @@ die("ss");
 
                // Fetch a page full of parent items for this page
                if($update) {
-                       if (!get_config("system", "like_no_comment"))
-                               $sql_extra4 = "(`item`.`deleted` = 0 OR `item`.`verb` = '".ACTIVITY_LIKE."' OR `item`.`verb` = '".ACTIVITY_DISLIKE."')";
+                       if (get_config("system", "like_no_comment"))
+                               $sql_extra4 = " AND `item`.`verb` = '".ACTIVITY_POST."'";
                        else
-                               $sql_extra4 = "`item`.`deleted` = 0 AND `item`.`verb` = '".ACTIVITY_POST."'";
+                               $sql_extra4 = "";
 
                        $r = q("SELECT `item`.`parent` AS `item_id`, `item`.`network` AS `item_network`, `contact`.`uid` AS `contact_uid`
                                FROM $sql_table $sql_post_table INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
-                               AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-                               WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND $sql_extra4
-                               AND `item`.`moderated` = 0 AND `item`.`unseen` = 1
-                               $sql_extra3 $sql_extra $sql_nets ORDER BY `item_id` DESC LIMIT 100",
+                               AND NOT `contact`.`blocked` AND NOT `contact`.`pending`
+                               WHERE `item`.`uid` = %d AND `item`.`visible` AND NOT `item`.`deleted` $sql_extra4
+                               AND NOT `item`.`moderated` AND `item`.`unseen`
+                               $sql_extra3 $sql_extra $sql_nets
+                               ORDER BY `item_id` DESC LIMIT 100",
                                intval(local_user())
                        );
                } else {
                        $r = q("SELECT `thread`.`iid` AS `item_id`, `thread`.`network` AS `item_network`, `contact`.`uid` AS `contact_uid`
                                FROM $sql_table $sql_post_table STRAIGHT_JOIN `contact` ON `contact`.`id` = `thread`.`contact-id`
-                               AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-                               WHERE `thread`.`uid` = %d AND `thread`.`visible` = 1 AND `thread`.`deleted` = 0
-                               AND `thread`.`moderated` = 0
+                               AND NOT `contact`.`blocked` AND NOT `contact`.`pending`
+                               WHERE `thread`.`uid` = %d AND `thread`.`visible` AND NOT `thread`.`deleted`
+                               AND NOT `thread`.`moderated`
                                $sql_extra2 $sql_extra3 $sql_extra $sql_nets
                                ORDER BY $sql_order DESC $pager_sql ",
                                intval(local_user())
@@ -736,7 +704,7 @@ die("ss");
                $parents_str = '';
                $date_offset = "";
 
-               if(count($r)) {
+               if(dba::is_result($r)) {
                        foreach($r as $rr)
                                if(! in_array($rr['item_id'],$parents_arr))
                                        $parents_arr[] = $rr['item_id'];
@@ -753,15 +721,7 @@ die("ss");
                        $items = array();
 
                        foreach ($parents_arr AS $parents) {
-//                                     $sql_extra ORDER BY `item`.`commented` DESC LIMIT %d",
-                               $thread_items = q("SELECT `item`.*, `item`.`id` AS `item_id`, `item`.`network` AS `item_network`,
-                                       `contact`.`name`, `contact`.`photo`, `contact`.`url`, `contact`.`alias`, `contact`.`rel`, `contact`.`writable`,
-                                       `contact`.`network`, `contact`.`thumb`, `contact`.`dfrn-id`, `contact`.`self`,
-                                       `contact`.`id` AS `cid`, `contact`.`uid` AS `contact-uid`
-                                       FROM `item` INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id`
-                                       AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0
-                                       WHERE `item`.`uid` = %d AND `item`.`visible` = 1 AND `item`.`deleted` = 0
-                                       AND `item`.`moderated` = 0
+                               $thread_items = q(item_query()." AND `item`.`uid` = %d
                                        AND `item`.`parent` = %d
                                        ORDER BY `item`.`commented` DESC LIMIT %d",
                                        intval(local_user()),
@@ -801,14 +761,24 @@ die("ss");
 
 
        if((! $group) && (! $cid) && (! $star)) {
-               $r = q("UPDATE `item` SET `unseen` = 0
-                       WHERE `unseen` = 1 AND `uid` = %d",
-                       intval(local_user())
-               );
+
+               $unseen = q("SELECT `id` FROM `item` WHERE `unseen` AND `uid` = %d",
+                               intval(local_user()));
+
+               if ($unseen)
+                       $r = q("UPDATE `item` SET `unseen` = 0
+                               WHERE `unseen` = 1 AND `uid` = %d",
+                               intval(local_user())
+                       );
        }
        else {
-               if($update_unseen)
-                       $r = q("UPDATE `item` SET `unseen` = 0 $update_unseen");
+               if($update_unseen) {
+
+                       $unseen = q("SELECT `id` FROM `item` ".$update_unseen);
+
+                       if ($unseen)
+                               $r = q("UPDATE `item` SET `unseen` = 0 $update_unseen");
+               }
        }
 
        // Set this so that the conversation function can find out contact info for our wall-wall items
@@ -820,14 +790,110 @@ die("ss");
 
        if(!$update) {
                if(get_pconfig(local_user(),'system','infinite_scroll')) {
-                               $o .= scroll_loader();
+                       $o .= scroll_loader();
                } elseif(!get_config('system', 'old_pager')) {
-                       $o .= alt_pager($a,count($items));
+                       $o .= alt_pager($a,count($items));
                } else {
-                       $o .= paginate($a);
+                       $o .= paginate($a);
                }
        }
 
        return $o;
 }
 
+/**
+ * @brief Get the network tabs menu
+ * 
+ * @param app $a The global App
+ * @return string Html of the networktab
+ */
+function network_tabs($a) {
+       // item filter tabs
+       /// @TODO fix this logic, reduce duplication
+       /// $a->page['content'] .= '<div class="tabs-wrapper">';
+
+       list($no_active, $all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active, $spam_active) = network_query_get_sel_tab($a);
+       // if no tabs are selected, defaults to comments
+       if ($no_active=='active') $all_active='active';
+
+       $cmd = (($datequery) ? '' : $a->cmd);
+       $len_naked_cmd = strlen(str_replace('/new','',$cmd));
+
+       // tabs
+       $tabs = array(
+               array(
+                       'label' => t('Commented Order'),
+                       'url'   => str_replace('/new', '', $cmd) . '?f=&order=comment' . ((x($_GET,'cid')) ? '&cid=' . $_GET['cid'] : ''),
+                       'sel'   => $all_active,
+                       'title' => t('Sort by Comment Date'),
+                       'id'    => 'commented-order-tab',
+                       'accesskey' => "e",
+               ),
+               array(
+                       'label' => t('Posted Order'),
+                       'url'   => str_replace('/new', '', $cmd) . '?f=&order=post' . ((x($_GET,'cid')) ? '&cid=' . $_GET['cid'] : ''),
+                       'sel'   => $postord_active,
+                       'title' => t('Sort by Post Date'),
+                       'id'    => 'posted-order-tab',
+                       'accesskey' => "t",
+               ),
+       );
+
+       if(feature_enabled(local_user(),'personal_tab')) {
+               $tabs[] = array(
+                       'label' => t('Personal'),
+                       'url'   => str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&conv=1',
+                       'sel'   => $conv_active,
+                       'title' => t('Posts that mention or involve you'),
+                       'id'    => 'personal-tab',
+                       'accesskey' => "r",
+               );
+       }
+
+       if(feature_enabled(local_user(),'new_tab')) {
+               $tabs[] = array(
+                       'label' => t('New'),
+                       'url'   => str_replace('/new', '', $cmd) . ($len_naked_cmd ? '/' : '') . 'new' . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : ''),
+                       'sel'   => $new_active,
+                       'title' => t('Activity Stream - by date'),
+                       'id'    => 'activitiy-by-date-tab',
+                       'accesskey' => "w",
+               );
+       }
+
+       if(feature_enabled(local_user(),'link_tab')) {
+               $tabs[] = array(
+                       'label' => t('Shared Links'),
+                       'url'   => str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&bmark=1',
+                       'sel'   => $bookmarked_active,
+                       'title' => t('Interesting Links'),
+                       'id'    => 'shared-links-tab',
+                       'accesskey' => "b",
+               );
+       }
+
+       if(feature_enabled(local_user(),'star_posts')) {
+               $tabs[] = array(
+                       'label' => t('Starred'),
+                       'url'   => str_replace('/new', '', $cmd) . ((x($_GET,'cid')) ? '/?f=&cid=' . $_GET['cid'] : '/?f=') . '&star=1',
+                       'sel'   => $starred_active,
+                       'title' => t('Favourite Posts'),
+                       'id'    => 'starred-posts-tab',
+                       'accesskey' => "m",
+               );
+       }
+
+       // save selected tab, but only if not in search or file mode
+       if(!x($_GET,'search') && !x($_GET,'file')) {
+               set_pconfig( local_user(), 'network.view','tab.selected',array($all_active, $postord_active, $conv_active, $new_active, $starred_active, $bookmarked_active, $spam_active) );
+       }
+
+       $arr = array('tabs' => $tabs);
+       call_hooks('network_tabs', $arr);
+       
+       $tpl = get_markup_template('common_tabs.tpl');
+
+       return replace_macros($tpl, array('$tabs' => $arr['tabs']));
+
+       // --- end item filter tabs
+}