]> git.mxchange.org Git - friendica.git/blobdiff - mod/network.php
Use the Item class instead of DBA calls when possible
[friendica.git] / mod / network.php
index 995b1da55bb78d369d2d359e15516d0c9d1628a1..6cee4d2b806f296a7870c06ef69b52b0709ba8e2 100644 (file)
@@ -14,14 +14,16 @@ use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
 use Friendica\Core\PConfig;
+use Friendica\Core\Protocol;
 use Friendica\Core\System;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
 use Friendica\Model\Contact;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
 use Friendica\Model\Profile;
 use Friendica\Module\Login;
 use Friendica\Util\DateTimeFormat;
+use Friendica\Util\Proxy as ProxyUtils;
 
 require_once 'include/conversation.php';
 require_once 'include/items.php';
@@ -40,13 +42,13 @@ function network_init(App $a)
        }
 
        if (x($_GET, 'save')) {
-               $exists = dba::exists('search', ['uid' => local_user(), 'term' => $search]);
+               $exists = DBA::exists('search', ['uid' => local_user(), 'term' => $search]);
                if (!$exists) {
-                       dba::insert('search', ['uid' => local_user(), 'term' => $search]);
+                       DBA::insert('search', ['uid' => local_user(), 'term' => $search]);
                }
        }
        if (x($_GET, 'remove')) {
-               dba::delete('search', ['uid' => local_user(), 'term' => $search]);
+               DBA::delete('search', ['uid' => local_user(), 'term' => $search]);
        }
 
        $is_a_date_query = false;
@@ -181,10 +183,10 @@ function saved_searches($search)
 
        $o = '';
 
-       $terms = dba::select('search', ['id', 'term'], ['uid' => local_user()]);
+       $terms = DBA::select('search', ['id', 'term'], ['uid' => local_user()]);
        $saved = [];
 
-       while ($rr = dba::fetch($terms)) {
+       while ($rr = DBA::fetch($terms)) {
                $saved[] = [
                        'id'          => $rr['id'],
                        'term'        => $rr['term'],
@@ -316,7 +318,7 @@ function networkSetSeen($condition)
                return;
        }
 
-       $unseen = dba::exists('item', $condition);
+       $unseen = Item::exists($condition);
 
        if ($unseen) {
                $r = Item::update(['unseen' => false], $condition);
@@ -360,21 +362,21 @@ function network_content(App $a, $update = 0, $parent = 0)
        $arr = ['query' => $a->query_string];
        Addon::callHooks('network_content_init', $arr);
 
-       $nouveau = false;
+       $flat_mode = false;
 
        if ($a->argc > 1) {
                for ($x = 1; $x < $a->argc; $x ++) {
                        if ($a->argv[$x] === 'new') {
-                               $nouveau = true;
+                               $flat_mode = true;
                        }
                }
        }
 
        if (x($_GET, 'file')) {
-               $nouveau = true;
+               $flat_mode = true;
        }
 
-       if ($nouveau) {
+       if ($flat_mode) {
                $o = networkFlatView($a, $update);
        } else {
                $o = networkThreadedView($a, $update, $parent);
@@ -393,7 +395,7 @@ function network_content(App $a, $update = 0, $parent = 0)
 function networkFlatView(App $a, $update = 0)
 {
        // Rawmode is used for fetching new content at the end of the page
-       $rawmode = (isset($_GET['mode']) AND ( $_GET['mode'] == 'raw'));
+       $rawmode = (isset($_GET['mode']) && ($_GET['mode'] == 'raw'));
 
        if (isset($_GET['last_id'])) {
                $last_id = intval($_GET['last_id']);
@@ -441,13 +443,13 @@ function networkFlatView(App $a, $update = 0)
                $condition = ["`term` = ? AND `otype` = ? AND `type` = ? AND `uid` = ?",
                        $file, TERM_OBJ_POST, TERM_FILE, local_user()];
                $params = ['order' => ['tid' => true], 'limit' => [$a->pager['start'], $a->pager['itemspage']]];
-               $result = dba::select('term', ['oid'], $condition);
+               $result = DBA::select('term', ['oid'], $condition);
 
                $posts = [];
-               while ($term = dba::fetch($result)) {
+               while ($term = DBA::fetch($result)) {
                        $posts[] = $term['oid'];
                }
-               dba::close($terms);
+               DBA::close($terms);
 
                $condition = ['uid' => local_user(), 'id' => $posts];
        } else {
@@ -455,8 +457,8 @@ function networkFlatView(App $a, $update = 0)
        }
 
        $params = ['order' => ['id' => true], 'limit' => [$a->pager['start'], $a->pager['itemspage']]];
-       $result = Item::select(local_user(), [], $condition, $params);
-       $items = dba::inArray($result);
+       $result = Item::selectForUser(local_user(), [], $condition, $params);
+       $items = Item::inArray($result);
 
        $condition = ['unseen' => true, 'uid' => local_user()];
        networkSetSeen($condition);
@@ -479,9 +481,9 @@ function networkThreadedView(App $a, $update, $parent)
        $rawmode = (isset($_GET['mode']) AND ( $_GET['mode'] == 'raw'));
 
        if (isset($_GET['last_received']) && isset($_GET['last_commented']) && isset($_GET['last_created']) && isset($_GET['last_id'])) {
-               $last_received = DBM::date($_GET['last_received']);
-               $last_commented = DBM::date($_GET['last_commented']);
-               $last_created = DBM::date($_GET['last_created']);
+               $last_received = DateTimeFormat::utc($_GET['last_received']);
+               $last_commented = DateTimeFormat::utc($_GET['last_commented']);
+               $last_created = DateTimeFormat::utc($_GET['last_created']);
                $last_id = intval($_GET['last_id']);
        } else {
                $last_received = '';
@@ -524,10 +526,10 @@ function networkThreadedView(App $a, $update, $parent)
        }
 
        if ($nets) {
-               $r = dba::select('contact', ['id'], ['uid' => local_user(), 'network' => $nets], ['self' => false]);
+               $r = DBA::select('contact', ['id'], ['uid' => local_user(), 'network' => $nets], ['self' => false]);
 
                $str = '';
-               while ($rr = dba::fetch($r)) {
+               while ($rr = DBA::fetch($r)) {
                        $str .= '<' . $rr['id'] . '>';
                }
                if (strlen($str)) {
@@ -555,8 +557,8 @@ function networkThreadedView(App $a, $update, $parent)
                if ($cid) {
                        // If $cid belongs to a communitity forum or a privat goup,.add a mention to the status editor
                        $condition = ["`id` = ? AND (`forum` OR `prv`)", $cid];
-                       $contact = dba::selectFirst('contact', ['addr', 'nick'], $condition);
-                       if (DBM::is_result($contact)) {
+                       $contact = DBA::selectFirst('contact', ['addr', 'nick'], $condition);
+                       if (DBA::isResult($contact)) {
                                if ($contact['addr'] != '') {
                                        $content = '!' . $contact['addr'];
                                } else {
@@ -589,13 +591,14 @@ function networkThreadedView(App $a, $update, $parent)
        // desired.
 
        $sql_post_table = '';
-       $sql_options = (($star) ? " AND `thread`.`starred` " : '');
-       $sql_options .= (($bmark) ? " AND `thread`.`bookmark` " : '');
+       $sql_options = ($star ? " AND `thread`.`starred` " : '');
+       $sql_options .= ($bmark ? sprintf(" AND `thread`.`post-type` = %d ", Item::PT_PAGE) : '');
        $sql_extra = $sql_options;
        $sql_extra2 = '';
        $sql_extra3 = '';
        $sql_table = '`thread`';
        $sql_parent = '`iid`';
+       $sql_order = '';
 
        if ($update) {
                $sql_table = '`item`';
@@ -603,12 +606,12 @@ function networkThreadedView(App $a, $update, $parent)
                $sql_post_table = " INNER JOIN `thread` ON `thread`.`iid` = `item`.`parent`";
        }
 
-       $sql_nets = (($nets) ? sprintf(" AND $sql_table.`network` = '%s' ", dbesc($nets)) : '');
-       $sql_tag_nets = (($nets) ? sprintf(" AND `item`.`network` = '%s' ", dbesc($nets)) : '');
+       $sql_nets = (($nets) ? sprintf(" AND $sql_table.`network` = '%s' ", DBA::escape($nets)) : '');
+       $sql_tag_nets = (($nets) ? sprintf(" AND `item`.`network` = '%s' ", DBA::escape($nets)) : '');
 
        if ($gid) {
-               $group = dba::selectFirst('group', ['name'], ['id' => $gid, 'uid' => local_user()]);
-               if (!DBM::is_result($group)) {
+               $group = DBA::selectFirst('group', ['name'], ['id' => $gid, 'uid' => local_user()]);
+               if (!DBA::isResult($group)) {
                        if ($update) {
                                killme();
                        }
@@ -623,8 +626,8 @@ function networkThreadedView(App $a, $update, $parent)
                        $contact_str_self = '';
 
                        $contact_str = implode(',', $contacts);
-                       $self = dba::selectFirst('contact', ['id'], ['uid' => local_user(), 'self' => true]);
-                       if (DBM::is_result($self)) {
+                       $self = DBA::selectFirst('contact', ['id'], ['uid' => local_user(), 'self' => true]);
+                       if (DBA::isResult($self)) {
                                $contact_str_self = $self['id'];
                        }
 
@@ -643,15 +646,15 @@ function networkThreadedView(App $a, $update, $parent)
                $fields = ['id', 'name', 'network', 'writable', 'nurl',
                        'forum', 'prv', 'contact-type', 'addr', 'thumb', 'location'];
                $condition = ["`id` = ? AND (NOT `blocked` OR `pending`)", $cid];
-               $contact = dba::selectFirst('contact', $fields, $condition);
-               if (DBM::is_result($contact)) {
+               $contact = DBA::selectFirst('contact', $fields, $condition);
+               if (DBA::isResult($contact)) {
                        $sql_extra = " AND " . $sql_table . ".`contact-id` = " . intval($cid);
 
                        $entries[0] = [
                                'id' => 'network',
                                'name' => htmlentities($contact['name']),
                                'itemurl' => defaults($contact, 'addr', $contact['nurl']),
-                               'thumb' => proxy_url($contact['thumb'], false, PROXY_SIZE_THUMB),
+                               'thumb' => ProxyUtils::proxifyUrl($contact['thumb'], false, ProxyUtils::SIZE_THUMB),
                                'details' => $contact['location'],
                        ];
 
@@ -662,7 +665,7 @@ function networkThreadedView(App $a, $update, $parent)
                                'id' => 'network',
                        ]) . $o;
 
-                       if ($contact['network'] === NETWORK_OSTATUS && $contact['writable'] && !PConfig::get(local_user(),'system','nowarn_insecure')) {
+                       if ($contact['network'] === Protocol::OSTATUS && $contact['writable'] && !PConfig::get(local_user(),'system','nowarn_insecure')) {
                                notice(L10n::t('Private messages to this person are at risk of public disclosure.') . EOL);
                        }
                } else {
@@ -679,11 +682,11 @@ function networkThreadedView(App $a, $update, $parent)
 
        if ($datequery) {
                $sql_extra3 .= protect_sprintf(sprintf(" AND $sql_table.created <= '%s' ",
-                               dbesc(DateTimeFormat::convert($datequery, 'UTC', date_default_timezone_get()))));
+                               DBA::escape(DateTimeFormat::convert($datequery, 'UTC', date_default_timezone_get()))));
        }
        if ($datequery2) {
                $sql_extra3 .= protect_sprintf(sprintf(" AND $sql_table.created >= '%s' ",
-                               dbesc(DateTimeFormat::convert($datequery2, 'UTC', date_default_timezone_get()))));
+                               DBA::escape(DateTimeFormat::convert($datequery2, 'UTC', date_default_timezone_get()))));
        }
 
        if ($conv) {
@@ -699,12 +702,10 @@ function networkThreadedView(App $a, $update, $parent)
                $order_mode = 'commented';
        }
 
-       if ($sql_order == '') {
-               $sql_order = "$sql_table.$ordering";
-       }
+       $sql_order = "$sql_table.$ordering";
 
        if (x($_GET, 'offset')) {
-               $sql_range = sprintf(" AND $sql_order <= '%s'", dbesc($_GET['offset']));
+               $sql_range = sprintf(" AND $sql_order <= '%s'", DBA::escape($_GET['offset']));
        } else {
                $sql_range = '';
        }
@@ -717,7 +718,7 @@ function networkThreadedView(App $a, $update, $parent)
                case 'received':
                        if ($last_received != '') {
                                $last_date = $last_received;
-                               $sql_range .= sprintf(" AND $sql_table.`received` < '%s'", dbesc($last_received));
+                               $sql_range .= sprintf(" AND $sql_table.`received` < '%s'", DBA::escape($last_received));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -725,7 +726,7 @@ function networkThreadedView(App $a, $update, $parent)
                case 'commented':
                        if ($last_commented != '') {
                                $last_date = $last_commented;
-                               $sql_range .= sprintf(" AND $sql_table.`commented` < '%s'", dbesc($last_commented));
+                               $sql_range .= sprintf(" AND $sql_table.`commented` < '%s'", DBA::escape($last_commented));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -733,14 +734,14 @@ function networkThreadedView(App $a, $update, $parent)
                case 'created':
                        if ($last_created != '') {
                                $last_date = $last_created;
-                               $sql_range .= sprintf(" AND $sql_table.`created` < '%s'", dbesc($last_created));
+                               $sql_range .= sprintf(" AND $sql_table.`created` < '%s'", DBA::escape($last_created));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
                        break;
                case 'id':
                        if (($last_id > 0) && ($sql_table == '`thread`')) {
-                               $sql_range .= sprintf(" AND $sql_table.`iid` < '%s'", dbesc($last_id));
+                               $sql_range .= sprintf(" AND $sql_table.`iid` < '%s'", DBA::escape($last_id));
                                $a->set_pager_page(1);
                                $pager_sql = sprintf(" LIMIT %d, %d ", intval($a->pager['start']), intval($a->pager['itemspage']));
                        }
@@ -756,7 +757,7 @@ function networkThreadedView(App $a, $update, $parent)
                        // Load all unseen items
                        $sql_extra4 = "`item`.`unseen`";
                        if (Config::get("system", "like_no_comment")) {
-                               $sql_extra4 .= " AND `item`.`verb` = '".ACTIVITY_POST."'";
+                               $sql_extra4 .= " AND `item`.`gravity` IN (" . GRAVITY_PARENT . "," . GRAVITY_COMMENT . ")";
                        }
                        if ($order === 'post') {
                                // Only show toplevel posts when updating posts in this order mode
@@ -777,8 +778,8 @@ function networkThreadedView(App $a, $update, $parent)
                        AND NOT `item`.`moderated` AND $sql_extra4
                        $sql_extra3 $sql_extra $sql_range $sql_nets
                        ORDER BY `order_date` DESC LIMIT 100",
-                       intval(CONTACT_IS_SHARING),
-                       intval(CONTACT_IS_FRIEND),
+                       intval(Contact::SHARING),
+                       intval(Contact::FRIEND),
                        intval(local_user()),
                        intval(local_user())
                );
@@ -797,16 +798,16 @@ function networkThreadedView(App $a, $update, $parent)
                        AND (`user-item`.`hidden` IS NULL OR NOT `user-item`.`hidden`)
                        $sql_extra2 $sql_extra3 $sql_range $sql_extra $sql_nets
                        ORDER BY `order_date` DESC $pager_sql",
-                       intval(CONTACT_IS_SHARING),
-                       intval(CONTACT_IS_FRIEND),
+                       intval(Contact::SHARING),
+                       intval(Contact::FRIEND),
                        intval(local_user()),
                        intval(local_user())
                );
        }
 
        // Only show it when unfiltered (no groups, no networks, ...)
-       if (in_array($nets, ['', NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS]) && (strlen($sql_extra . $sql_extra2 . $sql_extra3) == 0)) {
-               if (DBM::is_result($r)) {
+       if (in_array($nets, ['', Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS]) && (strlen($sql_extra . $sql_extra2 . $sql_extra3) == 0)) {
+               if (DBA::isResult($r)) {
                        $top_limit = current($r)['order_date'];
                        $bottom_limit = end($r)['order_date'];
                        if (empty($_SESSION['network_last_top_limit']) || ($_SESSION['network_last_top_limit'] < $top_limit)) {
@@ -835,7 +836,7 @@ function networkThreadedView(App $a, $update, $parent)
                        $top_limit = DateTimeFormat::utcNow();
                }
 
-               $items = dba::p("SELECT `item`.`parent-uri` AS `uri`, 0 AS `item_id`, `item`.$ordering AS `order_date` FROM `item`
+               $items = DBA::p("SELECT `item`.`parent-uri` AS `uri`, 0 AS `item_id`, `item`.$ordering AS `order_date`, `author`.`url` AS `author-link` FROM `item`
                        STRAIGHT_JOIN (SELECT `oid` FROM `term` WHERE `term` IN
                                (SELECT SUBSTR(`term`, 2) FROM `search` WHERE `uid` = ? AND `term` LIKE '#%') AND `otype` = ? AND `type` = ? AND `uid` = 0) AS `term`
                        ON `item`.`id` = `term`.`oid`
@@ -845,7 +846,7 @@ function networkThreadedView(App $a, $update, $parent)
                        local_user(), TERM_OBJ_POST, TERM_HASHTAG,
                        $top_limit, $bottom_limit);
 
-               $data = dba::inArray($items);
+               $data = DBA::toArray($items);
 
                if (count($data) > 0) {
                        $tag_top_limit = current($data)['order_date'];
@@ -862,7 +863,7 @@ function networkThreadedView(App $a, $update, $parent)
                                // Don't show hash tag posts from blocked or ignored contacts
                                $condition = ["`nurl` = ? AND `uid` = ? AND (`blocked` OR `readonly`)",
                                        normalise_link($item['author-link']), local_user()];
-                               if (!dba::exists('contact', $condition)) {
+                               if (!DBA::exists('contact', $condition)) {
                                        $s[$item['uri']] = $item;
                                }
                        }
@@ -875,7 +876,7 @@ function networkThreadedView(App $a, $update, $parent)
 
        $items = $r;
 
-       if (DBM::is_result($items)) {
+       if (DBA::isResult($items)) {
                $parents_arr = [];
 
                foreach ($items as $item) {
@@ -903,7 +904,7 @@ function networkThreadedView(App $a, $update, $parent)
                $condition = ['unseen' => true, 'uid' => local_user()];
                networkSetSeen($condition);
        } elseif ($parents_str) {
-               $condition = ["`uid` = ? AND `unseen` AND `parent` IN (" . dbesc($parents_str) . ")", local_user()];
+               $condition = ["`uid` = ? AND `unseen` AND `parent` IN (" . DBA::escape($parents_str) . ")", local_user()];
                networkSetSeen($condition);
        }