Remove unreliable ANY_VALUE from message list query

[friendica.git] / mod / notifications.php

diff --git a/mod/notifications.php b/mod/notifications.php
index d5cfbf276da2a02245ce24077b1cf03cf1e3521a..54c54fa222b00009b4390bb5d23710ed6d5391f5 100644 (file)
--- a/mod/notifications.php
+++ b/mod/notifications.php
@@ -7,9 +7,11 @@
 use Friendica\App;
 use Friendica\Content\ContactSelector;
 use Friendica\Content\Nav;
+use Friendica\Content\Pager;
 use Friendica\Core\L10n;
 use Friendica\Core\NotificationsManager;
 use Friendica\Core\Protocol;
+use Friendica\Core\Renderer;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
 use Friendica\Module\Login;
@@ -120,18 +122,18 @@ function notifications_content(App $a)
        }
 
        // Set the pager
-       $a->setPagerItemsPage($perpage);
+       $pager = new Pager($a->query_string, $perpage);
 
        // Add additional informations (needed for json output)
-       $notifs['items_page'] = $a->pager['itemspage'];
-       $notifs['page'] = $a->pager['page'];
+       $notifs['items_page'] = $pager->getItemsPerPage();
+       $notifs['page'] = $pager->getPage();
 
        // Json output
        if (intval($json) === 1) {
                System::jsonExit($notifs);
        }
 
-       $notif_tpl = get_markup_template('notifications.tpl');
+       $notif_tpl = Renderer::getMarkupTemplate('notifications.tpl');
 
        $notif_show_lnk = [
                'href' => ($show ? 'notifications/' . $notifs['ident'] : 'notifications/' . $notifs['ident'] . '?show=all' ),
@@ -140,8 +142,8 @@ function notifications_content(App $a)
 
        // Process the data for template creation
        if (defaults($notifs, 'ident', '') === 'introductions') {
-               $sugg = get_markup_template('suggestions.tpl');
-               $tpl = get_markup_template('intros.tpl');
+               $sugg = Renderer::getMarkupTemplate('suggestions.tpl');
+               $tpl = Renderer::getMarkupTemplate('intros.tpl');
 
                // The link to switch between ignored and normal connection requests
                $notif_show_lnk = [
@@ -157,7 +159,7 @@ function notifications_content(App $a)
                        // We have to distinguish between these two because they use different data.
                        switch ($notif['label']) {
                                case 'friend_suggestion':
-                                       $notif_content[] = replace_macros($sugg, [
+                                       $notif_content[] = Renderer::replaceMacros($sugg, [
                                                '$type'       => $notif['label'],
                                                '$str_notifytype' => L10n::t('Notification type:'),
                                                '$notify_type'=> $notif['notify_type'],
@@ -207,8 +209,8 @@ function notifications_content(App $a)
                                                $helptext3 = L10n::t('Accepting %s as a sharer allows them to subscribe to your posts, but you will not receive updates from them in your news feed.', $notif['name']);
                                        }
 
-                                       $dfrn_tpl = get_markup_template('netfriend.tpl');
-                                       $dfrn_text = replace_macros($dfrn_tpl, [
+                                       $dfrn_tpl = Renderer::getMarkupTemplate('netfriend.tpl');
+                                       $dfrn_text = Renderer::replaceMacros($dfrn_tpl, [
                                                '$intro_id'    => $notif['intro_id'],
                                                '$friend_selected' => $friend_selected,
                                                '$fan_selected'=> $fan_selected,
@@ -233,7 +235,7 @@ function notifications_content(App $a)
                                                $discard = '';
                                        }
 
-                                       $notif_content[] = replace_macros($tpl, [
+                                       $notif_content[] = Renderer::replaceMacros($tpl, [
                                                '$type'        => $notif['label'],
                                                '$header'      => htmlentities($header),
                                                '$str_notifytype' => L10n::t('Notification type:'),
@@ -292,9 +294,9 @@ function notifications_content(App $a)
                                'notify'      => 'notify.tpl',
                        ];
 
-                       $tpl_notif = get_markup_template($notification_templates[$notif['label']]);
+                       $tpl_notif = Renderer::getMarkupTemplate($notification_templates[$notif['label']]);
 
-                       $notif_content[] = replace_macros($tpl_notif, [
+                       $notif_content[] = Renderer::replaceMacros($tpl_notif, [
                                '$item_label' => $notif['label'],
                                '$item_link'  => $notif['link'],
                                '$item_image' => $notif['image'],
@@ -309,13 +311,13 @@ function notifications_content(App $a)
                $notif_nocontent = L10n::t('No more %s notifications.', $notifs['ident']);
        }
 
-       $o .= replace_macros($notif_tpl, [
+       $o .= Renderer::replaceMacros($notif_tpl, [
                '$notif_header'    => $notif_header,
                '$tabs'            => $tabs,
                '$notif_content'   => $notif_content,
                '$notif_nocontent' => $notif_nocontent,
                '$notif_show_lnk'  => $notif_show_lnk,
-               '$notif_paginate'  => alt_pager($a, count($notif_content))
+               '$notif_paginate'  => $pager->renderMinimal(count($notif_content))
        ]);
 
        return $o;