]> git.mxchange.org Git - friendica.git/blobdiff - mod/photos.php
Merge pull request #13541 from MrPetovan/bug/13534-image-blurred
[friendica.git] / mod / photos.php
index d44afa588cd779cf3f0147fafd38d44dc8dcacd4..53388512fa9768c96ea594d259780c9a0f7e12b6 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2022, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -20,7 +20,6 @@
  */
 
 use Friendica\App;
-use Friendica\Content\Feature;
 use Friendica\Content\Nav;
 use Friendica\Content\Pager;
 use Friendica\Content\Text\BBCode;
@@ -32,6 +31,7 @@ use Friendica\Core\Logger;
 use Friendica\Core\Renderer;
 use Friendica\Core\System;
 use Friendica\Database\DBA;
+use Friendica\Database\DBStructure;
 use Friendica\DI;
 use Friendica\Model\Contact;
 use Friendica\Model\Item;
@@ -41,18 +41,17 @@ use Friendica\Model\Profile;
 use Friendica\Model\Tag;
 use Friendica\Model\User;
 use Friendica\Module\BaseProfile;
+use Friendica\Network\HTTPException;
 use Friendica\Network\Probe;
-use Friendica\Object\Image;
 use Friendica\Protocol\Activity;
+use Friendica\Security\Security;
 use Friendica\Util\Crypto;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Images;
 use Friendica\Util\Map;
-use Friendica\Security\Security;
 use Friendica\Util\Strings;
 use Friendica\Util\Temporal;
 use Friendica\Util\XML;
-use Friendica\Network\HTTPException;
 
 function photos_init(App $a)
 {
@@ -63,7 +62,7 @@ function photos_init(App $a)
        Nav::setSelected('home');
 
        if (DI::args()->getArgc() > 1) {
-               $owner = User::getOwnerDataByNick(DI::args()->getArgv()[1]);
+               $owner = Profile::load(DI::app(), DI::args()->getArgv()[1], false);
                if (!isset($owner['account_removed']) || $owner['account_removed']) {
                        throw new HTTPException\NotFoundException(DI::l10n()->t('User not found.'));
                }
@@ -112,19 +111,13 @@ function photos_init(App $a)
                        ]);
                }
 
-               if (empty(DI::page()['aside'])) {
-                       DI::page()['aside'] = '';
-               }
-
-               DI::page()['aside'] .= Widget\VCard::getHTML($owner);
-
                if (!empty($photo_albums_widget)) {
                        DI::page()['aside'] .= $photo_albums_widget;
                }
 
                $tpl = Renderer::getMarkupTemplate("photos_head.tpl");
 
-               DI::page()['htmlhead'] .= Renderer::replaceMacros($tpl,[
+               DI::page()['htmlhead'] .= Renderer::replaceMacros($tpl, [
                        '$ispublic' => DI::l10n()->t('everybody')
                ]);
        }
@@ -170,14 +163,14 @@ function photos_post(App $a)
 
        $aclFormatter = DI::aclFormatter();
        $str_contact_allow = isset($_REQUEST['contact_allow']) ? $aclFormatter->toString($_REQUEST['contact_allow']) : $owner_record['allow_cid'] ?? '';
-       $str_group_allow   = isset($_REQUEST['group_allow'])   ? $aclFormatter->toString($_REQUEST['group_allow'])   : $owner_record['allow_gid'] ?? '';
+       $str_circle_allow  = isset($_REQUEST['circle_allow'])  ? $aclFormatter->toString($_REQUEST['circle_allow'])  : $owner_record['allow_gid'] ?? '';
        $str_contact_deny  = isset($_REQUEST['contact_deny'])  ? $aclFormatter->toString($_REQUEST['contact_deny'])  : $owner_record['deny_cid']  ?? '';
-       $str_group_deny    = isset($_REQUEST['group_deny'])    ? $aclFormatter->toString($_REQUEST['group_deny'])    : $owner_record['deny_gid']  ?? '';
+       $str_circle_deny   = isset($_REQUEST['circle_deny'])   ? $aclFormatter->toString($_REQUEST['circle_deny'])   : $owner_record['deny_gid']  ?? '';
 
        $visibility = $_REQUEST['visibility'] ?? '';
        if ($visibility === 'public') {
                // The ACL selector introduced in version 2019.12 sends ACL input data even when the Public visibility is selected
-               $str_contact_allow = $str_group_allow = $str_contact_deny = $str_group_deny = '';
+               $str_contact_allow = $str_circle_allow = $str_contact_deny = $str_circle_deny = '';
        } else if ($visibility === 'custom') {
                // Since we know from the visibility parameter the item should be private, we have to prevent the empty ACL
                // case that would make it public. So we always append the author's contact id to the allowed contacts.
@@ -221,13 +214,15 @@ function photos_post(App $a)
 
                        // get the list of photos we are about to delete
                        if ($visitor) {
-                               $r = DBA::toArray(DBA::p("SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `contact-id` = ? AND `uid` = ? AND `album` = ?",
+                               $r = DBA::toArray(DBA::p(
+                                       "SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `contact-id` = ? AND `uid` = ? AND `album` = ?",
                                        $visitor,
                                        $page_owner_uid,
                                        $album
                                ));
                        } else {
-                               $r = DBA::toArray(DBA::p("SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `uid` = ? AND `album` = ?",
+                               $r = DBA::toArray(DBA::p(
+                                       "SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `uid` = ? AND `album` = ?",
                                        DI::userSession()->getLocalUserId(),
                                        $album
                                ));
@@ -265,7 +260,6 @@ function photos_post(App $a)
                        // same as above but remove single photo
                        if ($visitor) {
                                $condition = ['contact-id' => $visitor, 'uid' => $page_owner_uid, 'resource-id' => DI::args()->getArgv()[3]];
-
                        } else {
                                $condition = ['uid' => DI::userSession()->getLocalUserId(), 'resource-id' => DI::args()->getArgv()[3]];
                        }
@@ -318,16 +312,16 @@ function photos_post(App $a)
 
                                        Photo::update(['height' => $height, 'width' => $width], ['resource-id' => $resource_id, 'uid' => $page_owner_uid, 'scale' => 0], $image);
 
-                                       if ($width > 640 || $height > 640) {
-                                               $image->scaleDown(640);
+                                       if ($width > \Friendica\Util\Proxy::PIXEL_MEDIUM || $height > \Friendica\Util\Proxy::PIXEL_MEDIUM) {
+                                               $image->scaleDown(\Friendica\Util\Proxy::PIXEL_MEDIUM);
                                                $width  = $image->getWidth();
                                                $height = $image->getHeight();
 
                                                Photo::update(['height' => $height, 'width' => $width], ['resource-id' => $resource_id, 'uid' => $page_owner_uid, 'scale' => 1], $image);
                                        }
 
-                                       if ($width > 320 || $height > 320) {
-                                               $image->scaleDown(320);
+                                       if ($width > \Friendica\Util\Proxy::PIXEL_SMALL || $height > \Friendica\Util\Proxy::PIXEL_SMALL) {
+                                               $image->scaleDown(\Friendica\Util\Proxy::PIXEL_SMALL);
                                                $width  = $image->getWidth();
                                                $height = $image->getHeight();
 
@@ -345,7 +339,7 @@ function photos_post(App $a)
                        $photo = $photos[0];
                        $ext = $phototypes[$photo['type']];
                        Photo::update(
-                               ['desc' => $desc, 'album' => $albname, 'allow_cid' => $str_contact_allow, 'allow_gid' => $str_group_allow, 'deny_cid' => $str_contact_deny, 'deny_gid' => $str_group_deny],
+                               ['desc' => $desc, 'album' => $albname, 'allow_cid' => $str_contact_allow, 'allow_gid' => $str_circle_allow, 'deny_cid' => $str_contact_deny, 'deny_gid' => $str_circle_deny],
                                ['resource-id' => $resource_id, 'uid' => $page_owner_uid]
                        );
 
@@ -382,9 +376,7 @@ function photos_post(App $a)
                        $arr['visible']       = 0;
                        $arr['origin']        = 1;
 
-                       $arr['body']          = '[url=' . DI::baseUrl() . '/photos/' . $user['nickname'] . '/image/' . $photo['resource-id'] . ']'
-                                               . '[img]' . DI::baseUrl() . '/photo/' . $photo['resource-id'] . '-' . $photo['scale'] . '.'. $ext . '[/img]'
-                                               . '[/url]';
+                       $arr['body']          = Images::getBBCodeByResource($photo['resource-id'], $user['nickname'], $photo['scale'], $ext);
 
                        $item_id = Item::insert($arr);
                }
@@ -414,7 +406,7 @@ function photos_post(App $a)
                                        if (strpos($tag, '@') === 0) {
                                                $profile = '';
                                                $contact = null;
-                                               $name = substr($tag,1);
+                                               $name = substr($tag, 1);
 
                                                if ((strpos($name, '@')) || (strpos($name, 'http://'))) {
                                                        $newname = $name;
@@ -450,13 +442,15 @@ function photos_post(App $a)
                                                        if ($tagcid) {
                                                                $contact = DBA::selectFirst('contact', [], ['id' => $tagcid, 'uid' => $page_owner_uid]);
                                                        } else {
-                                                               $newname = str_replace('_',' ',$name);
+                                                               $newname = str_replace('_', ' ', $name);
 
                                                                //select someone from this user's contacts by name
                                                                $contact = DBA::selectFirst('contact', [], ['name' => $newname, 'uid' => $page_owner_uid]);
                                                                if (!DBA::isResult($contact)) {
                                                                        //select someone by attag or nick and the name passed in
-                                                                       $contact = DBA::selectFirst('contact', [],
+                                                                       $contact = DBA::selectFirst(
+                                                                               'contact',
+                                                                               [],
                                                                                ['(`attag` = ? OR `nick` = ?) AND `uid` = ?', $name, $name, $page_owner_uid],
                                                                                ['order' => ['attag' => true]]
                                                                        );
@@ -565,213 +559,6 @@ function photos_post(App $a)
                DI::baseUrl()->redirect($_SESSION['photo_return']);
                return; // NOTREACHED
        }
-
-
-       // default post action - upload a photo
-       Hook::callAll('photo_post_init', $_POST);
-
-       // Determine the album to use
-       $album    = trim($_REQUEST['album'] ?? '');
-       $newalbum = trim($_REQUEST['newalbum'] ?? '');
-
-       Logger::debug('album= ' . $album . ' newalbum= ' . $newalbum);
-
-       if (!strlen($album)) {
-               if (strlen($newalbum)) {
-                       $album = $newalbum;
-               } else {
-                       $album = DateTimeFormat::localNow('Y');
-               }
-       }
-
-       /*
-        * We create a wall item for every photo, but we don't want to
-        * overwhelm the data stream with a hundred newly uploaded photos.
-        * So we will make the first photo uploaded to this album in the last several hours
-        * visible by default, the rest will become visible over time when and if
-        * they acquire comments, likes, dislikes, and/or tags
-        */
-
-       $r = Photo::selectToArray([], ['`album` = ? AND `uid` = ? AND `created` > ?', $album, $page_owner_uid, DateTimeFormat::utc('now - 3 hours')]);
-
-       if (!DBA::isResult($r) || ($album == DI::l10n()->t(Photo::PROFILE_PHOTOS))) {
-               $visible = 1;
-       } else {
-               $visible = 0;
-       }
-
-       if (!empty($_REQUEST['not_visible']) && $_REQUEST['not_visible'] !== 'false') {
-               $visible = 0;
-       }
-
-       $ret = ['src' => '', 'filename' => '', 'filesize' => 0, 'type' => ''];
-
-       Hook::callAll('photo_post_file', $ret);
-
-       if (!empty($ret['src']) && !empty($ret['filesize'])) {
-               $src      = $ret['src'];
-               $filename = $ret['filename'];
-               $filesize = $ret['filesize'];
-               $type     = $ret['type'];
-               $error    = UPLOAD_ERR_OK;
-       } elseif (!empty($_FILES['userfile'])) {
-               $src      = $_FILES['userfile']['tmp_name'];
-               $filename = basename($_FILES['userfile']['name']);
-               $filesize = intval($_FILES['userfile']['size']);
-               $type     = $_FILES['userfile']['type'];
-               $error    = $_FILES['userfile']['error'];
-       } else {
-               $error    = UPLOAD_ERR_NO_FILE;
-       }
-
-       if ($error !== UPLOAD_ERR_OK) {
-               switch ($error) {
-                       case UPLOAD_ERR_INI_SIZE:
-                               DI::sysmsg()->addNotice(DI::l10n()->t('Image exceeds size limit of %s', ini_get('upload_max_filesize')));
-                               break;
-                       case UPLOAD_ERR_FORM_SIZE:
-                               DI::sysmsg()->addNotice(DI::l10n()->t('Image exceeds size limit of %s', Strings::formatBytes($_REQUEST['MAX_FILE_SIZE'] ?? 0)));
-                               break;
-                       case UPLOAD_ERR_PARTIAL:
-                               DI::sysmsg()->addNotice(DI::l10n()->t('Image upload didn\'t complete, please try again'));
-                               break;
-                       case UPLOAD_ERR_NO_FILE:
-                               DI::sysmsg()->addNotice(DI::l10n()->t('Image file is missing'));
-                               break;
-                       case UPLOAD_ERR_NO_TMP_DIR:
-                       case UPLOAD_ERR_CANT_WRITE:
-                       case UPLOAD_ERR_EXTENSION:
-                               DI::sysmsg()->addNotice(DI::l10n()->t('Server can\'t accept new file upload at this time, please contact your administrator'));
-                               break;
-               }
-               @unlink($src);
-               $foo = 0;
-               Hook::callAll('photo_post_end', $foo);
-               return;
-       }
-
-       $type = Images::getMimeTypeBySource($src, $filename, $type);
-
-       Logger::info('photos: upload: received file: ' . $filename . ' as ' . $src . ' ('. $type . ') ' . $filesize . ' bytes');
-
-       $maximagesize = DI::config()->get('system', 'maximagesize');
-
-       if ($maximagesize && ($filesize > $maximagesize)) {
-               DI::sysmsg()->addNotice(DI::l10n()->t('Image exceeds size limit of %s', Strings::formatBytes($maximagesize)));
-               @unlink($src);
-               $foo = 0;
-               Hook::callAll('photo_post_end', $foo);
-               return;
-       }
-
-       if (!$filesize) {
-               DI::sysmsg()->addNotice(DI::l10n()->t('Image file is empty.'));
-               @unlink($src);
-               $foo = 0;
-               Hook::callAll('photo_post_end', $foo);
-               return;
-       }
-
-       Logger::debug('loading contents', ['src' => $src]);
-
-       $imagedata = @file_get_contents($src);
-
-       $image = new Image($imagedata, $type);
-
-       if (!$image->isValid()) {
-               Logger::notice('unable to process image');
-               DI::sysmsg()->addNotice(DI::l10n()->t('Unable to process image.'));
-               @unlink($src);
-               $foo = 0;
-               Hook::callAll('photo_post_end',$foo);
-               return;
-       }
-
-       $exif = $image->orient($src);
-       @unlink($src);
-
-       $max_length = DI::config()->get('system', 'max_image_length');
-       if ($max_length > 0) {
-               $image->scaleDown($max_length);
-       }
-
-       $width  = $image->getWidth();
-       $height = $image->getHeight();
-
-       $smallest = 0;
-
-       $resource_id = Photo::newResource();
-
-       $r = Photo::store($image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 0 , Photo::DEFAULT, $str_contact_allow, $str_group_allow, $str_contact_deny, $str_group_deny);
-
-       if (!$r) {
-               Logger::warning('image store failed');
-               DI::sysmsg()->addNotice(DI::l10n()->t('Image upload failed.'));
-               return;
-       }
-
-       if ($width > 640 || $height > 640) {
-               $image->scaleDown(640);
-               Photo::store($image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 1, Photo::DEFAULT, $str_contact_allow, $str_group_allow, $str_contact_deny, $str_group_deny);
-               $smallest = 1;
-       }
-
-       if ($width > 320 || $height > 320) {
-               $image->scaleDown(320);
-               Photo::store($image, $page_owner_uid, $visitor, $resource_id, $filename, $album, 2, Photo::DEFAULT, $str_contact_allow, $str_group_allow, $str_contact_deny, $str_group_deny);
-               $smallest = 2;
-       }
-
-       $uri = Item::newURI();
-
-       // Create item container
-       $lat = $lon = null;
-       if (!empty($exif['GPS']) && Feature::isEnabled($page_owner_uid, 'photo_location')) {
-               $lat = Photo::getGps($exif['GPS']['GPSLatitude'], $exif['GPS']['GPSLatitudeRef']);
-               $lon = Photo::getGps($exif['GPS']['GPSLongitude'], $exif['GPS']['GPSLongitudeRef']);
-       }
-
-       $arr = [];
-       if ($lat && $lon) {
-               $arr['coord'] = $lat . ' ' . $lon;
-       }
-
-       $arr['guid']          = System::createUUID();
-       $arr['uid']           = $page_owner_uid;
-       $arr['uri']           = $uri;
-       $arr['post-type']     = Item::PT_IMAGE;
-       $arr['wall']          = 1;
-       $arr['resource-id']   = $resource_id;
-       $arr['contact-id']    = $owner_record['id'];
-       $arr['owner-name']    = $owner_record['name'];
-       $arr['owner-link']    = $owner_record['url'];
-       $arr['owner-avatar']  = $owner_record['thumb'];
-       $arr['author-name']   = $owner_record['name'];
-       $arr['author-link']   = $owner_record['url'];
-       $arr['author-avatar'] = $owner_record['thumb'];
-       $arr['title']         = '';
-       $arr['allow_cid']     = $str_contact_allow;
-       $arr['allow_gid']     = $str_group_allow;
-       $arr['deny_cid']      = $str_contact_deny;
-       $arr['deny_gid']      = $str_group_deny;
-       $arr['visible']       = $visible;
-       $arr['origin']        = 1;
-
-       $arr['body']          = '[url=' . DI::baseUrl() . '/photos/' . $owner_record['nickname'] . '/image/' . $resource_id . ']'
-                               . '[img]' . DI::baseUrl() . "/photo/{$resource_id}-{$smallest}.".$image->getExt() . '[/img]'
-                               . '[/url]';
-
-       $item_id = Item::insert($arr);
-       // Update the photo albums cache
-       Photo::clearAlbumCache($page_owner_uid);
-
-       Hook::callAll('photo_post_end', $item_id);
-
-       // addon uploaders should call "exit()" within the photo_post_end hook
-       // if they do not wish to be redirected
-
-       DI::baseUrl()->redirect($_SESSION['photo_return']);
-       // NOTREACHED
 }
 
 function photos_content(App $a)
@@ -865,9 +652,8 @@ function photos_content(App $a)
                $contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => $owner_uid, 'blocked' => false, 'pending' => false]);
        }
 
-       if ($user['hidewall'] && (DI::userSession()->getLocalUserId() != $owner_uid) && !$remote_contact) {
-               DI::sysmsg()->addNotice(DI::l10n()->t('Access to this item is restricted.'));
-               return;
+       if ($user['hidewall'] && !DI::userSession()->isAuthenticated()) {
+               DI::baseUrl()->redirect('profile/' . $user['nickname'] . '/restricted');
        }
 
        $sql_extra = Security::getPermissionsSQLByUserId($owner_uid);
@@ -876,7 +662,7 @@ function photos_content(App $a)
 
        // tabs
        $is_owner = (DI::userSession()->getLocalUserId() && (DI::userSession()->getLocalUserId() == $owner_uid));
-       $o .= BaseProfile::getTabsHTML($a, 'photos', $is_owner, $user['nickname'], $profile['hide-friends']);
+       $o .= BaseProfile::getTabsHTML('photos', $is_owner, $user['nickname'], $profile['hide-friends']);
 
        // Display upload form
        if ($datatype === 'upload') {
@@ -885,6 +671,9 @@ function photos_content(App $a)
                        return;
                }
 
+               // This prevents the photo upload form to return to itself without a hint the picture has been correctly uploaded.
+               DI::session()->remove('photo_return');
+
                $selname = (!is_null($datum) && Strings::isHex($datum)) ? hex2bin($datum) : '';
 
                $albumselect = '';
@@ -903,33 +692,39 @@ function photos_content(App $a)
 
                $uploader = '';
 
-               $ret = ['post_url' => 'profile/' . $user['nickname'] . '/photos',
-                               'addon_text' => $uploader,
-                               'default_upload' => true];
+               $ret = [
+                       'post_url' => 'profile/' . $user['nickname'] . '/photos',
+                       'addon_text' => $uploader,
+                       'default_upload' => true
+               ];
 
-               Hook::callAll('photo_upload_form',$ret);
+               Hook::callAll('photo_upload_form', $ret);
 
                $default_upload_box = Renderer::replaceMacros(Renderer::getMarkupTemplate('photos_default_uploader_box.tpl'), []);
                $default_upload_submit = Renderer::replaceMacros(Renderer::getMarkupTemplate('photos_default_uploader_submit.tpl'), [
                        '$submit' => DI::l10n()->t('Submit'),
                ]);
 
-               $maximagesize_Mbytes = 0;
                // Get the relevant size limits for uploads. Abbreviated var names: MaxImageSize -> mis; upload_max_filesize -> umf
                $mis_bytes = Strings::getBytesFromShorthand(DI::config()->get('system', 'maximagesize'));
                $umf_bytes = Strings::getBytesFromShorthand(ini_get('upload_max_filesize'));
 
+               // Per Friendica definition a value of '0' means unlimited:
+               if ($mis_bytes == 0) {
+                       $mis_bytes = INF;
+               }
+
                // When PHP is configured with upload_max_filesize less than maximagesize provide this lower limit.
-               $maximagesize_Mbytes = (is_numeric($mis_bytes) && ($mis_bytes < $umf_bytes) ? $mis_bytes : $umf_bytes) / (1048576);
+               $maximagesize_bytes = (is_numeric($mis_bytes) && ($mis_bytes < $umf_bytes) ? $mis_bytes : $umf_bytes);
 
-               // @todo We may be want to use appropriate binary prefixed dynamicly
-               $usage_message = DI::l10n()->t('The maximum accepted image size is %.6g MB', $maximagesize_Mbytes);
+               // @todo We may be want to use appropriate binary prefixed dynamically
+               $usage_message = DI::l10n()->t('The maximum accepted image size is %s', Strings::formatBytes($maximagesize_bytes));
 
                $tpl = Renderer::getMarkupTemplate('photos_upload.tpl');
 
                $aclselect_e = ($visitor ? '' : ACL::getFullSelectorHTML(DI::page(), $a->getLoggedInUserId()));
 
-               $o .= Renderer::replaceMacros($tpl,[
+               $o .= Renderer::replaceMacros($tpl, [
                        '$pagename' => DI::l10n()->t('Upload Photos'),
                        '$sessid' => session_id(),
                        '$usage' => $usage_message,
@@ -957,7 +752,7 @@ function photos_content(App $a)
        if ($datatype === 'album') {
                // if $datum is not a valid hex, redirect to the default page
                if (is_null($datum) || !Strings::isHex($datum)) {
-                       DI::baseUrl()->redirect('photos/' . $user['nickname']. '/album');
+                       DI::baseUrl()->redirect('photos/' . $user['nickname'] . '/album');
                }
                $album = hex2bin($datum);
 
@@ -966,7 +761,8 @@ function photos_content(App $a)
                }
 
                $total = 0;
-               $r = DBA::toArray(DBA::p("SELECT `resource-id`, max(`scale`) AS `scale` FROM `photo` WHERE `uid` = ? AND `album` = ?
+               $r = DBA::toArray(DBA::p(
+                       "SELECT `resource-id`, max(`scale`) AS `scale` FROM `photo` WHERE `uid` = ? AND `album` = ?
                        AND `scale` <= 4 $sql_extra GROUP BY `resource-id`",
                        $owner_uid,
                        $album
@@ -985,7 +781,8 @@ function photos_content(App $a)
                        $order = 'DESC';
                }
 
-               $r = DBA::toArray(DBA::p("SELECT `resource-id`, ANY_VALUE(`id`) AS `id`, ANY_VALUE(`filename`) AS `filename`,
+               $r = DBA::toArray(DBA::p(
+                       "SELECT `resource-id`, ANY_VALUE(`id`) AS `id`, ANY_VALUE(`filename`) AS `filename`,
                        ANY_VALUE(`type`) AS `type`, max(`scale`) AS `scale`, ANY_VALUE(`desc`) as `desc`,
                        ANY_VALUE(`created`) as `created`
                        FROM `photo` WHERE `uid` = ? AND `album` = ?
@@ -1019,7 +816,7 @@ function photos_content(App $a)
 
                                $album_e = $album;
 
-                               $o .= Renderer::replaceMacros($edit_tpl,[
+                               $o .= Renderer::replaceMacros($edit_tpl, [
                                        '$nametext' => DI::l10n()->t('New album name: '),
                                        '$nickname' => $user['nickname'],
                                        '$album' => $album_e,
@@ -1053,16 +850,16 @@ function photos_content(App $a)
                                $desc_e = $rr['desc'];
 
                                $photos[] = [
-                                       'id' => $rr['id'],
-                                       'twist' => ' ' . ($twist ? 'rotleft' : 'rotright') . rand(2,4),
-                                       'link' => 'photos/' . $user['nickname'] . '/image/' . $rr['resource-id']
+                                       'id'    => $rr['id'],
+                                       'twist' => ' ' . ($twist ? 'rotleft' : 'rotright') . rand(2, 4),
+                                       'link'  => 'photos/' . $user['nickname'] . '/image/' . $rr['resource-id']
                                                . ($order_field === 'created' ? '?order=created' : ''),
                                        'title' => DI::l10n()->t('View Photo'),
-                                       'src' => 'photo/' . $rr['resource-id'] . '-' . $rr['scale'] . '.' .$ext,
-                                       'alt' => $imgalt_e,
-                                       'desc'=> $desc_e,
-                                       'ext' => $ext,
-                                       'hash'=> $rr['resource-id'],
+                                       'src'   => 'photo/' . $rr['resource-id'] . '-' . $rr['scale'] . '.' . $ext,
+                                       'alt'   => $imgalt_e,
+                                       'desc'  => $desc_e,
+                                       'ext'   => $ext,
+                                       'hash'  => $rr['resource-id'],
                                ];
                        }
                }
@@ -1080,7 +877,6 @@ function photos_content(App $a)
                ]);
 
                return $o;
-
        }
 
        // Display one photo
@@ -1126,7 +922,7 @@ function photos_content(App $a)
 
                        if ($order_field === 'created') {
                                $params = ['order' => [$order_field]];
-                       } elseif (!empty($order_field)) {
+                       } elseif (!empty($order_field) && DBStructure::existsColumn('photo', [$order_field])) {
                                $params = ['order' => [$order_field => true]];
                        } else {
                                $params = [];
@@ -1139,11 +935,17 @@ function photos_content(App $a)
                                $nxt = null;
                                foreach ($prvnxt as $z => $entry) {
                                        if ($entry['resource-id'] == $ph[0]['resource-id']) {
-                                               $prv = $z - 1;
-                                               $nxt = $z + 1;
+                                               $prv = $order_field === 'created' ? $z - 1 : $z + 1;
+                                               $nxt = $order_field === 'created' ? $z + 1 : $z - 1;
                                                if ($prv < 0) {
                                                        $prv = count($prvnxt) - 1;
                                                }
+                                               if ($nxt < 0) {
+                                                       $nxt = count($prvnxt) - 1;
+                                               }
+                                               if ($prv >= count($prvnxt)) {
+                                                       $prv = 0;
+                                               }
                                                if ($nxt >= count($prvnxt)) {
                                                        $nxt = 0;
                                                }
@@ -1159,7 +961,7 @@ function photos_content(App $a)
                                }
 
                                $tpl = Renderer::getMarkupTemplate('photo_edit_head.tpl');
-                               DI::page()['htmlhead'] .= Renderer::replaceMacros($tpl,[
+                               DI::page()['htmlhead'] .= Renderer::replaceMacros($tpl, [
                                        '$prevlink' => $prevlink,
                                        '$nextlink' => $nextlink
                                ]);
@@ -1171,7 +973,7 @@ function photos_content(App $a)
                                if ($nextlink) {
                                        $nextlink = [$nextlink, '<div class="icon next"></div>'];
                                }
-                       }
+                       }
                }
 
                if (count($ph) == 1) {
@@ -1211,12 +1013,12 @@ function photos_content(App $a)
                }
 
                $photo = [
-                       'href' => 'photo/' . $hires['resource-id'] . '-' . $hires['scale'] . '.' . $phototypes[$hires['type']],
-                       'title'=> DI::l10n()->t('View Full Size'),
-                       'src'  => 'photo/' . $lores['resource-id'] . '-' . $lores['scale'] . '.' . $phototypes[$lores['type']] . '?_u=' . DateTimeFormat::utcNow('ymdhis'),
-                       'height' => $hires['height'],
-                       'width' => $hires['width'],
-                       'album' => $hires['album'],
+                       'href'     => 'photo/' . $hires['resource-id'] . '-' . $hires['scale'] . '.' . $phototypes[$hires['type']],
+                       'title'    => DI::l10n()->t('View Full Size'),
+                       'src'      => 'photo/' . $lores['resource-id'] . '-' . $lores['scale'] . '.' . $phototypes[$lores['type']] . '?_u=' . DateTimeFormat::utcNow('ymdhis'),
+                       'height'   => $hires['height'],
+                       'width'    => $hires['width'],
+                       'album'    => $hires['album'],
                        'filename' => $hires['filename'],
                ];
 
@@ -1283,12 +1085,12 @@ function photos_content(App $a)
 
                        $edit = Renderer::replaceMacros($edit_tpl, [
                                '$id' => $ph[0]['id'],
-                               '$album' => ['albname', DI::l10n()->t('New album name'), $album_e,''],
+                               '$album' => ['albname', DI::l10n()->t('New album name'), $album_e, ''],
                                '$caption' => ['desc', DI::l10n()->t('Caption'), $caption_e, ''],
                                '$tags' => ['newtag', DI::l10n()->t('Add a Tag'), "", DI::l10n()->t('Example: @bob, @Barbara_Jensen, @jim@example.com, #California, #camping')],
-                               '$rotate_none' => ['rotate', DI::l10n()->t('Do not rotate'),0,'', true],
-                               '$rotate_cw' => ['rotate', DI::l10n()->t("Rotate CW \x28right\x29"),1,''],
-                               '$rotate_ccw' => ['rotate', DI::l10n()->t("Rotate CCW \x28left\x29"),2,''],
+                               '$rotate_none' => ['rotate', DI::l10n()->t('Do not rotate'), 0, '', true],
+                               '$rotate_cw' => ['rotate', DI::l10n()->t("Rotate CW \x28right\x29"), 1, ''],
+                               '$rotate_ccw' => ['rotate', DI::l10n()->t("Rotate CCW \x28left\x29"), 2, ''],
 
                                '$nickname' => $user['nickname'],
                                '$resource_id' => $ph[0]['resource-id'],
@@ -1341,7 +1143,7 @@ function photos_content(App $a)
                                                '$preview' => DI::l10n()->t('Preview'),
                                                '$loading' => DI::l10n()->t('Loading...'),
                                                '$qcomment' => $qcomment,
-                                               '$rand_num' => Crypto::randomDigits(12)
+                                               '$rand_num' => Crypto::randomDigits(12),
                                        ]);
                                }
                        }
@@ -1383,7 +1185,7 @@ function photos_content(App $a)
                                                $qcomment = $words ? explode("\n", $words) : [];
                                        }
 
-                                       $comments .= Renderer::replaceMacros($cmnt_tpl,[
+                                       $comments .= Renderer::replaceMacros($cmnt_tpl, [
                                                '$return_path' => '',
                                                '$jsreload' => $return_path,
                                                '$id' => $link_item['id'],
@@ -1396,7 +1198,7 @@ function photos_content(App $a)
                                                '$submit' => DI::l10n()->t('Submit'),
                                                '$preview' => DI::l10n()->t('Preview'),
                                                '$qcomment' => $qcomment,
-                                               '$rand_num' => Crypto::randomDigits(12)
+                                               '$rand_num' => Crypto::randomDigits(12),
                                        ]);
                                }
 
@@ -1407,13 +1209,19 @@ function photos_content(App $a)
                                        $activity = DI::activity();
 
                                        if (($activity->match($item['verb'], Activity::LIKE) ||
-                                            $activity->match($item['verb'], Activity::DISLIKE)) &&
-                                           ($item['gravity'] != Item::GRAVITY_PARENT)) {
+                                                       $activity->match($item['verb'], Activity::DISLIKE)) &&
+                                               ($item['gravity'] != Item::GRAVITY_PARENT)
+                                       ) {
                                                continue;
                                        }
 
-                                       $author = ['uid' => 0, 'id' => $item['author-id'],
-                                               'network' => $item['author-network'], 'url' => $item['author-link']];
+                                       $author = [
+                                               'uid'     => 0,
+                                               'id'      => $item['author-id'],
+                                               'network' => $item['author-network'],
+                                               'url'     => $item['author-link'],
+                                               'alias'   => $item['author-alias']
+                                       ];
                                        $profile_url = Contact::magicLinkByContact($author);
                                        if (strpos($profile_url, 'contact/redir/') === 0) {
                                                $sparkle = ' sparkle';
@@ -1432,7 +1240,7 @@ function photos_content(App $a)
                                        $title_e = $item['title'];
                                        $body_e = BBCode::convertForUriId($item['uri-id'], $item['body']);
 
-                                       $comments .= Renderer::replaceMacros($template,[
+                                       $comments .= Renderer::replaceMacros($template, [
                                                '$id'          => $item['id'],
                                                '$profile_url' => $profile_url,
                                                '$name'        => $item['author-name'],
@@ -1470,7 +1278,7 @@ function photos_content(App $a)
                                                        '$submit' => DI::l10n()->t('Submit'),
                                                        '$preview' => DI::l10n()->t('Preview'),
                                                        '$qcomment' => $qcomment,
-                                                       '$rand_num' => Crypto::randomDigits(12)
+                                                       '$rand_num' => Crypto::randomDigits(12),
                                                ]);
                                        }
                                }