]> git.mxchange.org Git - friendica.git/blobdiff - mod/photos.php
Merge pull request #5967 from annando/ap-nick
[friendica.git] / mod / photos.php
index 6d611cafa2ffb05ec45105757972cda670b594fe..55c8881e4cecd17d74d278fbc2e75dd8bb4d817d 100644 (file)
@@ -14,7 +14,6 @@ use Friendica\Core\L10n;
 use Friendica\Core\System;
 use Friendica\Core\Worker;
 use Friendica\Database\DBA;
-use Friendica\Database\DBM;
 use Friendica\Model\Contact;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
@@ -27,9 +26,9 @@ use Friendica\Protocol\DFRN;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Map;
 use Friendica\Util\Temporal;
+use Friendica\Util\Security;
 
 require_once 'include/items.php';
-require_once 'include/security.php';
 
 function photos_init(App $a) {
 
@@ -46,10 +45,10 @@ function photos_init(App $a) {
        if ($a->argc > 1) {
                $nick = $a->argv[1];
                $user = q("SELECT * FROM `user` WHERE `nickname` = '%s' AND `blocked` = 0 LIMIT 1",
-                       dbesc($nick)
+                       DBA::escape($nick)
                );
 
-               if (!DBM::is_result($user)) {
+               if (!DBA::isResult($user)) {
                        return;
                }
 
@@ -80,6 +79,7 @@ function photos_init(App $a) {
 
                if ($albums) {
                        $a->data['albums'] = $albums;
+
                        if ($albums_visible) {
                                $ret['success'] = true;
                        }
@@ -118,13 +118,15 @@ function photos_init(App $a) {
                        ]);
                }
 
-
                if (empty($a->page['aside'])) {
                        $a->page['aside'] = '';
                }
 
                $a->page['aside'] .= $vcard_widget;
-               $a->page['aside'] .= $photo_albums_widget;
+
+               if (!empty($photo_albums_widget)) {
+                       $a->page['aside'] .= $photo_albums_widget;
+               }
 
                $tpl = get_markup_template("photos_head.tpl");
 
@@ -148,7 +150,7 @@ function photos_post(App $a)
        $visitor   = 0;
 
        $page_owner_uid = $a->data['user']['uid'];
-       $community_page = $a->data['user']['page-flags'] == PAGE_COMMUNITY;
+       $community_page = $a->data['user']['page-flags'] == Contact::PAGE_COMMUNITY;
 
        if (local_user() && (local_user() == $page_owner_uid)) {
                $can_post = true;
@@ -164,13 +166,13 @@ function photos_post(App $a)
                        }
                }
 
-               if ($contact_id) {
+               if ($contact_id > 0) {
                        $r = q("SELECT `uid` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `id` = %d AND `uid` = %d LIMIT 1",
                                intval($contact_id),
                                intval($page_owner_uid)
                        );
 
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $can_post = true;
                                $visitor = $contact_id;
                        }
@@ -199,17 +201,18 @@ function photos_post(App $a)
                }
 
                $r = q("SELECT `album` FROM `photo` WHERE `album` = '%s' AND `uid` = %d",
-                       dbesc($album),
+                       DBA::escape($album),
                        intval($page_owner_uid)
                );
-               if (!DBM::is_result($r)) {
+
+               if (!DBA::isResult($r)) {
                        notice(L10n::t('Album not found.') . EOL);
                        goaway($_SESSION['photo_return']);
                        return; // NOTREACHED
                }
 
                // Check if the user has responded to a delete confirmation query
-               if ($_REQUEST['canceled']) {
+               if (!empty($_REQUEST['canceled'])) {
                        goaway($_SESSION['photo_return']);
                }
 
@@ -217,8 +220,8 @@ function photos_post(App $a)
                $newalbum = notags(trim($_POST['albumname']));
                if ($newalbum != $album) {
                        q("UPDATE `photo` SET `album` = '%s' WHERE `album` = '%s' AND `uid` = %d",
-                               dbesc($newalbum),
-                               dbesc($album),
+                               DBA::escape($newalbum),
+                               DBA::escape($album),
                                intval($page_owner_uid)
                        );
                        // Update the photo albums cache
@@ -251,6 +254,7 @@ function photos_post(App $a)
                                        '$confirm_name' => 'dropalbum', // Needed so that confirmation will bring us back into this if statement
                                        '$cancel' => L10n::t('Cancel'),
                                ]);
+
                                $a->error = 1; // Set $a->error so the other module functions don't execute
                                return;
                        }
@@ -263,17 +267,18 @@ function photos_post(App $a)
                                $r = q("SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `contact-id` = %d AND `uid` = %d AND `album` = '%s'",
                                        intval($visitor),
                                        intval($page_owner_uid),
-                                       dbesc($album)
+                                       DBA::escape($album)
                                );
                        } else {
                                $r = q("SELECT distinct(`resource-id`) as `rid` FROM `photo` WHERE `uid` = %d AND `album` = '%s'",
                                        intval(local_user()),
-                                       dbesc($album)
+                                       DBA::escape($album)
                                );
                        }
-                       if (DBM::is_result($r)) {
+
+                       if (DBA::isResult($r)) {
                                foreach ($r as $rr) {
-                                       $res[] = "'" . dbesc($rr['rid']) . "'" ;
+                                       $res[] = "'" . DBA::escape($rr['rid']) . "'" ;
                                }
                        } else {
                                goaway($_SESSION['photo_return']);
@@ -311,6 +316,7 @@ function photos_post(App $a)
                // Check if we should do HTML-based delete confirmation
                if (!empty($_REQUEST['confirm'])) {
                        $drop_url = $a->query_string;
+
                        $a->page['content'] = replace_macros(get_markup_template('confirm.tpl'), [
                                '$method' => 'post',
                                '$message' => L10n::t('Do you really want to delete this photo?'),
@@ -320,6 +326,7 @@ function photos_post(App $a)
                                '$confirm_name' => 'delete', // Needed so that confirmation will bring us back into this if statement
                                '$cancel' => L10n::t('Cancel'),
                        ]);
+
                        $a->error = 1; // Set $a->error so the other module functions don't execute
                        return;
                }
@@ -328,19 +335,19 @@ function photos_post(App $a)
                        $r = q("SELECT `id`, `resource-id` FROM `photo` WHERE `contact-id` = %d AND `uid` = %d AND `resource-id` = '%s' LIMIT 1",
                                intval($visitor),
                                intval($page_owner_uid),
-                               dbesc($a->argv[2])
+                               DBA::escape($a->argv[2])
                        );
                } else {
                        $r = q("SELECT `id`, `resource-id` FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' LIMIT 1",
                                intval(local_user()),
-                               dbesc($a->argv[2])
+                               DBA::escape($a->argv[2])
                        );
                }
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        q("DELETE FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s'",
                                intval($page_owner_uid),
-                               dbesc($r[0]['resource-id'])
+                               DBA::escape($r[0]['resource-id'])
                        );
 
                        Item::deleteForUser(['resource-id' => $r[0]['resource-id'], 'uid' => $page_owner_uid], $page_owner_uid);
@@ -375,11 +382,11 @@ function photos_post(App $a)
                        logger('rotate');
 
                        $r = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = 0 LIMIT 1",
-                               dbesc($resource_id),
+                               DBA::escape($resource_id),
                                intval($page_owner_uid)
                        );
 
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $image = new Image($r[0]['data'], $r[0]['type']);
 
                                if ($image->isValid()) {
@@ -390,10 +397,10 @@ function photos_post(App $a)
                                        $height = $image->getHeight();
 
                                        $x = q("UPDATE `photo` SET `data` = '%s', `height` = %d, `width` = %d WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = 0",
-                                               dbesc($image->asString()),
+                                               DBA::escape($image->asString()),
                                                intval($height),
                                                intval($width),
-                                               dbesc($resource_id),
+                                               DBA::escape($resource_id),
                                                intval($page_owner_uid)
                                        );
 
@@ -403,10 +410,10 @@ function photos_post(App $a)
                                                $height = $image->getHeight();
 
                                                $x = q("UPDATE `photo` SET `data` = '%s', `height` = %d, `width` = %d WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = 1",
-                                                       dbesc($image->asString()),
+                                                       DBA::escape($image->asString()),
                                                        intval($height),
                                                        intval($width),
-                                                       dbesc($resource_id),
+                                                       DBA::escape($resource_id),
                                                        intval($page_owner_uid)
                                                );
                                        }
@@ -417,10 +424,10 @@ function photos_post(App $a)
                                                $height = $image->getHeight();
 
                                                $x = q("UPDATE `photo` SET `data` = '%s', `height` = %d, `width` = %d WHERE `resource-id` = '%s' AND `uid` = %d AND `scale` = 2",
-                                                       dbesc($image->asString()),
+                                                       DBA::escape($image->asString()),
                                                        intval($height),
                                                        intval($width),
-                                                       dbesc($resource_id),
+                                                       DBA::escape($resource_id),
                                                        intval($page_owner_uid)
                                                );
                                        }
@@ -429,19 +436,20 @@ function photos_post(App $a)
                }
 
                $p = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `uid` = %d ORDER BY `scale` DESC",
-                       dbesc($resource_id),
+                       DBA::escape($resource_id),
                        intval($page_owner_uid)
                );
-               if (DBM::is_result($p)) {
+
+               if (DBA::isResult($p)) {
                        $ext = $phototypes[$p[0]['type']];
                        $r = q("UPDATE `photo` SET `desc` = '%s', `album` = '%s', `allow_cid` = '%s', `allow_gid` = '%s', `deny_cid` = '%s', `deny_gid` = '%s' WHERE `resource-id` = '%s' AND `uid` = %d",
-                               dbesc($desc),
-                               dbesc($albname),
-                               dbesc($str_contact_allow),
-                               dbesc($str_group_allow),
-                               dbesc($str_contact_deny),
-                               dbesc($str_group_deny),
-                               dbesc($resource_id),
+                               DBA::escape($desc),
+                               DBA::escape($albname),
+                               DBA::escape($str_contact_allow),
+                               DBA::escape($str_group_allow),
+                               DBA::escape($str_contact_deny),
+                               DBA::escape($str_group_deny),
+                               DBA::escape($resource_id),
                                intval($page_owner_uid)
                        );
 
@@ -464,7 +472,7 @@ function photos_post(App $a)
                        $uri = Item::newURI($page_owner_uid);
 
                        $arr = [];
-                       $arr['guid']          = System::createGUID(32);
+                       $arr['guid']          = System::createUUID();
                        $arr['uid']           = $page_owner_uid;
                        $arr['uri']           = $uri;
                        $arr['parent-uri']    = $uri;
@@ -496,7 +504,7 @@ function photos_post(App $a)
                if ($item_id) {
                        $item = Item::selectFirst(['tag', 'inform'], ['id' => $item_id, 'uid' => $page_owner_uid]);
                }
-               if (DBM::is_result($item)) {
+               if (DBA::isResult($item)) {
                        $old_tag    = $item['tag'];
                        $old_inform = $item['inform'];
                }
@@ -519,28 +527,35 @@ function photos_post(App $a)
                                        if (strpos($tag, '@') === 0) {
                                                $profile = '';
                                                $name = substr($tag,1);
+
                                                if ((strpos($name, '@')) || (strpos($name, 'http://'))) {
                                                        $newname = $name;
                                                        $links = @Probe::lrdd($name);
+
                                                        if (count($links)) {
                                                                foreach ($links as $link) {
                                                                        if ($link['@attributes']['rel'] === 'http://webfinger.net/rel/profile-page') {
                                                                                $profile = $link['@attributes']['href'];
                                                                        }
+
                                                                        if ($link['@attributes']['rel'] === 'salmon') {
                                                                                $salmon = '$url:' . str_replace(',', '%sc', $link['@attributes']['href']);
+
                                                                                if (strlen($inform)) {
                                                                                        $inform .= ',';
                                                                                }
+
                                                                                $inform .= $salmon;
                                                                        }
                                                                }
                                                        }
+
                                                        $taginfo[] = [$newname, $profile, $salmon];
                                                } else {
                                                        $newname = $name;
                                                        $alias = '';
                                                        $tagcid = 0;
+
                                                        if (strrpos($newname, '+')) {
                                                                $tagcid = intval(substr($newname, strrpos($newname, '+') + 1));
                                                        }
@@ -555,23 +570,24 @@ function photos_post(App $a)
 
                                                                //select someone from this user's contacts by name
                                                                $r = q("SELECT * FROM `contact` WHERE `name` = '%s' AND `uid` = %d LIMIT 1",
-                                                                               dbesc($newname),
+                                                                               DBA::escape($newname),
                                                                                intval($page_owner_uid)
                                                                );
 
-                                                               if (!DBM::is_result($r)) {
+                                                               if (!DBA::isResult($r)) {
                                                                        //select someone by attag or nick and the name passed in
                                                                        $r = q("SELECT * FROM `contact` WHERE `attag` = '%s' OR `nick` = '%s' AND `uid` = %d ORDER BY `attag` DESC LIMIT 1",
-                                                                                       dbesc($name),
-                                                                                       dbesc($name),
+                                                                                       DBA::escape($name),
+                                                                                       DBA::escape($name),
                                                                                        intval($page_owner_uid)
                                                                        );
                                                                }
                                                        }
 
-                                                       if (DBM::is_result($r)) {
+                                                       if (DBA::isResult($r)) {
                                                                $newname = $r[0]['name'];
                                                                $profile = $r[0]['url'];
+
                                                                $notify = 'cid:' . $r[0]['id'];
                                                                if (strlen($inform)) {
                                                                        $inform .= ',';
@@ -579,15 +595,18 @@ function photos_post(App $a)
                                                                $inform .= $notify;
                                                        }
                                                }
+
                                                if ($profile) {
                                                        if (substr($notify, 0, 4) === 'cid:') {
                                                                $taginfo[] = [$newname, $profile, $notify, $r[0], '@[url=' . str_replace(',','%2c',$profile) . ']' . $newname . '[/url]'];
                                                        } else {
                                                                $taginfo[] = [$newname, $profile, $notify, null, $str_tags .= '@[url=' . $profile . ']' . $newname . '[/url]'];
                                                        }
+
                                                        if (strlen($str_tags)) {
                                                                $str_tags .= ',';
                                                        }
+
                                                        $profile = str_replace(',', '%2c', $profile);
                                                        $str_tags .= '@[url='.$profile.']'.$newname.'[/url]';
                                                }
@@ -620,6 +639,7 @@ function photos_post(App $a)
                                        $best = 2;
                                        break;
                                }
+
                                if (intval($scales['scale']) == 4) {
                                        $best = 4;
                                        break;
@@ -631,7 +651,7 @@ function photos_post(App $a)
                                        $uri = Item::newURI($page_owner_uid);
 
                                        $arr = [];
-                                       $arr['guid']          = System::createGUID(32);
+                                       $arr['guid']          = System::createUUID();
                                        $arr['uid']           = $page_owner_uid;
                                        $arr['uri']           = $uri;
                                        $arr['parent-uri']    = $uri;
@@ -708,11 +728,11 @@ function photos_post(App $a)
         */
 
        $r = q("SELECT * FROM `photo` WHERE `album` = '%s' AND `uid` = %d AND `created` > UTC_TIMESTAMP() - INTERVAL 3 HOUR ",
-               dbesc($album),
+               DBA::escape($album),
                intval($page_owner_uid)
        );
 
-       if (!DBM::is_result($r) || ($album == L10n::t('Profile Photos'))) {
+       if (!DBA::isResult($r) || ($album == L10n::t('Profile Photos'))) {
                $visible = 1;
        } else {
                $visible = 0;
@@ -742,12 +762,14 @@ function photos_post(App $a)
                $filesize = $ret['filesize'];
                $type     = $ret['type'];
                $error    = UPLOAD_ERR_OK;
-       } else {
+       } elseif (!empty($_FILES['userfile'])) {
                $src      = $_FILES['userfile']['tmp_name'];
                $filename = basename($_FILES['userfile']['name']);
                $filesize = intval($_FILES['userfile']['size']);
                $type     = $_FILES['userfile']['type'];
                $error    = $_FILES['userfile']['error'];
+       } else {
+               $error    = UPLOAD_ERR_NO_FILE;
        }
 
        if ($error !== UPLOAD_ERR_OK) {
@@ -867,7 +889,7 @@ function photos_post(App $a)
                $arr['coord'] = $lat . ' ' . $lon;
        }
 
-       $arr['guid']          = System::createGUID(32);
+       $arr['guid']          = System::createUUID();
        $arr['uid']           = $page_owner_uid;
        $arr['uri']           = $uri;
        $arr['parent-uri']    = $uri;
@@ -901,7 +923,7 @@ function photos_post(App $a)
                Worker::add(PRIORITY_HIGH, "Notifier", 'wall-new', $item_id);
        }
 
-       Addon::callHooks('photo_post_end', intval($item_id));
+       Addon::callHooks('photo_post_end', $item_id);
 
        // addon uploaders should call "killme()" [e.g. exit] within the photo_post_end hook
        // if they do not wish to be redirected
@@ -926,7 +948,6 @@ function photos_content(App $a)
                return;
        }
 
-       require_once 'include/security.php';
        require_once 'include/conversation.php';
 
        if (empty($a->data['user'])) {
@@ -965,7 +986,7 @@ function photos_content(App $a)
 
        $owner_uid = $a->data['user']['uid'];
 
-       $community_page = (($a->data['user']['page-flags'] == PAGE_COMMUNITY) ? true : false);
+       $community_page = (($a->data['user']['page-flags'] == Contact::PAGE_COMMUNITY) ? true : false);
 
        if (local_user() && (local_user() == $owner_uid)) {
                $can_post = true;
@@ -985,7 +1006,7 @@ function photos_content(App $a)
                                        intval($contact_id),
                                        intval($owner_uid)
                                );
-                               if (DBM::is_result($r)) {
+                               if (DBA::isResult($r)) {
                                        $can_post = true;
                                        $contact = $r[0];
                                        $remote_contact = true;
@@ -1014,7 +1035,7 @@ function photos_content(App $a)
                                intval($contact_id),
                                intval($owner_uid)
                        );
-                       if (DBM::is_result($r)) {
+                       if (DBA::isResult($r)) {
                                $contact = $r[0];
                                $remote_contact = true;
                        }
@@ -1031,7 +1052,7 @@ function photos_content(App $a)
                return;
        }
 
-       $sql_extra = permissions_sql($owner_uid, $remote_contact, $groups);
+       $sql_extra = Security::getPermissionsSQLByUserId($owner_uid, $remote_contact, $groups);
 
        $o = "";
 
@@ -1051,7 +1072,7 @@ function photos_content(App $a)
                $albumselect = '';
 
                $albumselect .= '<option value="" ' . (!$selname ? ' selected="selected" ' : '') . '>&lt;current year&gt;</option>';
-               if (count($a->data['albums'])) {
+               if (!empty($a->data['albums'])) {
                        foreach ($a->data['albums'] as $album) {
                                if (($album['album'] === '') || ($album['album'] === 'Contact Photos') || ($album['album'] === L10n::t('Contact Photos'))) {
                                        continue;
@@ -1091,6 +1112,12 @@ function photos_content(App $a)
                        '$albumselect' => $albumselect,
                        '$permissions' => L10n::t('Permissions'),
                        '$aclselect' => $aclselect_e,
+                       '$lockstate' => is_array($a->user)
+                                       && (strlen($a->user['allow_cid'])
+                                               || strlen($a->user['allow_gid'])
+                                               || strlen($a->user['deny_cid'])
+                                               || strlen($a->user['deny_gid'])
+                                       ) ? 'lock' : 'unlock',
                        '$alt_uploader' => $ret['addon_text'],
                        '$default_upload_box' => ($ret['default_upload'] ? $default_upload_box : ''),
                        '$default_upload_submit' => ($ret['default_upload'] ? $default_upload_submit : ''),
@@ -1112,11 +1139,11 @@ function photos_content(App $a)
                $r = q("SELECT `resource-id`, max(`scale`) AS `scale` FROM `photo` WHERE `uid` = %d AND `album` = '%s'
                        AND `scale` <= 4 $sql_extra GROUP BY `resource-id`",
                        intval($owner_uid),
-                       dbesc($album)
+                       DBA::escape($album)
                );
-               if (DBM::is_result($r)) {
-                       $a->set_pager_total(count($r));
-                       $a->set_pager_itemspage(20);
+               if (DBA::isResult($r)) {
+                       $a->setPagerTotal(count($r));
+                       $a->setPagerItemsPage(20);
                }
 
                /// @TODO I have seen this many times, maybe generalize it script-wide and encapsulate it?
@@ -1133,7 +1160,7 @@ function photos_content(App $a)
                        FROM `photo` WHERE `uid` = %d AND `album` = '%s'
                        AND `scale` <= 4 $sql_extra GROUP BY `resource-id` ORDER BY `created` $order LIMIT %d , %d",
                        intval($owner_uid),
-                       dbesc($album),
+                       DBA::escape($album),
                        intval($a->pager['start']),
                        intval($a->pager['itemspage'])
                );
@@ -1170,7 +1197,7 @@ function photos_content(App $a)
 
                $photos = [];
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        // "Twist" is only used for the duepunto theme with style "slackr"
                        $twist = false;
                        foreach ($r as $rr) {
@@ -1217,16 +1244,16 @@ function photos_content(App $a)
                $ph = q("SELECT * FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s'
                        $sql_extra ORDER BY `scale` ASC ",
                        intval($owner_uid),
-                       dbesc($datum)
+                       DBA::escape($datum)
                );
 
-               if (!DBM::is_result($ph)) {
+               if (!DBA::isResult($ph)) {
                        $ph = q("SELECT `id` FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s'
                                LIMIT 1",
                                intval($owner_uid),
-                               dbesc($datum)
+                               DBA::escape($datum)
                        );
-                       if (DBM::is_result($ph)) {
+                       if (DBA::isResult($ph)) {
                                notice(L10n::t('Permission denied. Access to this item may be restricted.'));
                        } else {
                                notice(L10n::t('Photo not available') . EOL);
@@ -1253,11 +1280,13 @@ function photos_content(App $a)
 
                        $prvnxt = q("SELECT `resource-id` FROM `photo` WHERE `album` = '%s' AND `uid` = %d AND `scale` = 0
                                $sql_extra ORDER BY `created` $order ",
-                               dbesc($ph[0]['album']),
+                               DBA::escape($ph[0]['album']),
                                intval($owner_uid)
                        );
 
-                       if (DBM::is_result($prvnxt)) {
+                       if (DBA::isResult($prvnxt)) {
+                               $prv = null;
+                               $nxt = null;
                                foreach ($prvnxt as $z => $entry) {
                                        if ($entry['resource-id'] == $ph[0]['resource-id']) {
                                                $prv = $z - 1;
@@ -1272,8 +1301,12 @@ function photos_content(App $a)
                                        }
                                }
                                $edit_suffix = ((($cmd === 'edit') && $can_post) ? '/edit' : '');
-                               $prevlink = 'photos/' . $a->data['user']['nickname'] . '/image/' . $prvnxt[$prv]['resource-id'] . $edit_suffix . ($order_field === 'posted' ? '?f=&order=posted' : '');
-                               $nextlink = 'photos/' . $a->data['user']['nickname'] . '/image/' . $prvnxt[$nxt]['resource-id'] . $edit_suffix . ($order_field === 'posted' ? '?f=&order=posted' : '');
+                               if (!is_null($prv)) {
+                                       $prevlink = 'photos/' . $a->data['user']['nickname'] . '/image/' . $prvnxt[$prv]['resource-id'] . $edit_suffix . ($order_field === 'posted' ? '?f=&order=posted' : '');
+                               }
+                               if (!is_null($nxt)) {
+                                       $nextlink = 'photos/' . $a->data['user']['nickname'] . '/image/' . $prvnxt[$nxt]['resource-id'] . $edit_suffix . ($order_field === 'posted' ? '?f=&order=posted' : '');
+                               }
                        }
                }
 
@@ -1348,21 +1381,21 @@ function photos_content(App $a)
 
                /// @todo Rewrite this query. To do so, $sql_extra must be changed
                $linked_items = q("SELECT `id` FROM `item` WHERE `resource-id` = '%s' $sql_extra LIMIT 1",
-                       dbesc($datum)
+                       DBA::escape($datum)
                );
 
                $map = null;
                $link_item = [];
 
-               if (DBM::is_result($linked_items)) {
+               if (DBA::isResult($linked_items)) {
                        // This is a workaround to not being forced to rewrite the while $sql_extra handling
                        $link_item = Item::selectFirst([], ['id' => $linked_items[0]['id']]);
 
                        $condition = ["`parent` = ? AND `parent` != `id`",  $link_item['parent']];
-                       $a->set_pager_total(DBA::count('item', $condition));
+                       $a->setPagerTotal(DBA::count('item', $condition));
 
                        $params = ['order' => ['id'], 'limit' => [$a->pager['start'], $a->pager['itemspage']]];
-                       $result = Item::selectForUser($link_item['uid'], [], $condition, $params);
+                       $result = Item::selectForUser($link_item['uid'], Item::ITEM_FIELDLIST, $condition, $params);
                        $items = Item::inArray($result);
 
                        if (local_user() && (local_user() == $link_item['uid'])) {
@@ -1400,7 +1433,7 @@ function photos_content(App $a)
 
                        $album_e = $ph[0]['album'];
                        $caption_e = $ph[0]['desc'];
-                       $aclselect_e = ACL::getFullSelectorHTML($ph[0]);
+                       $aclselect_e = ACL::getFullSelectorHTML($a->user, false, $ph[0]);
 
                        $edit = replace_macros($edit_tpl, [
                                '$id' => $ph[0]['id'],
@@ -1439,7 +1472,7 @@ function photos_content(App $a)
                        $tpl = get_markup_template('photo_item.tpl');
                        $return_url = $a->cmd;
 
-                       if ($can_post || can_write_wall($owner_uid)) {
+                       if ($can_post || Security::canWriteToUserWall($owner_uid)) {
                                $like_tpl = get_markup_template('like_noshare.tpl');
                                $likebuttons = replace_macros($like_tpl, [
                                        '$id' => $link_item['id'],
@@ -1450,8 +1483,8 @@ function photos_content(App $a)
                                ]);
                        }
 
-                       if (!DBM::is_result($items)) {
-                               if (($can_post || can_write_wall($owner_uid))) {
+                       if (!DBA::isResult($items)) {
+                               if (($can_post || Security::canWriteToUserWall($owner_uid))) {
                                        $comments .= replace_macros($cmnt_tpl, [
                                                '$return_path' => '',
                                                '$jsreload' => $return_url,
@@ -1477,7 +1510,7 @@ function photos_content(App $a)
                        ];
 
                        // display comments
-                       if (DBM::is_result($items)) {
+                       if (DBA::isResult($items)) {
                                foreach ($items as $item) {
                                        builtin_activity_puller($item, $conv_responses);
                                }
@@ -1490,7 +1523,7 @@ function photos_content(App $a)
                                        $dislike = format_like($conv_responses['dislike'][$link_item['uri']], $conv_responses['dislike'][$link_item['uri'] . '-l'], 'dislike', $link_item['id']);
                                }
 
-                               if (($can_post || can_write_wall($owner_uid))) {
+                               if (($can_post || Security::canWriteToUserWall($owner_uid))) {
                                        $comments .= replace_macros($cmnt_tpl,[
                                                '$return_path' => '',
                                                '$jsreload' => $return_url,
@@ -1537,7 +1570,7 @@ function photos_content(App $a)
                                        $body_e = BBCode::convert($item['body']);
 
                                        $comments .= replace_macros($template,[
-                                               '$id' => $item['item_id'],
+                                               '$id' => $item['id'],
                                                '$profile_url' => $profile_url,
                                                '$name' => $item['author-name'],
                                                '$thumb' => $item['author-avatar'],
@@ -1550,7 +1583,7 @@ function photos_content(App $a)
                                                '$comment' => $comment
                                        ]);
 
-                                       if (($can_post || can_write_wall($owner_uid))) {
+                                       if (($can_post || Security::canWriteToUserWall($owner_uid))) {
                                                $comments .= replace_macros($cmnt_tpl, [
                                                        '$return_path' => '',
                                                        '$jsreload' => $return_url,
@@ -1601,7 +1634,7 @@ function photos_content(App $a)
                        '$paginate' => $paginate,
                ]);
 
-               $a->page['htmlhead'] .= "\n" . '<meta name="twitter:card" content="photo" />' . "\n";
+               $a->page['htmlhead'] .= "\n" . '<meta name="twitter:card" content="summary_large_image" />' . "\n";
                $a->page['htmlhead'] .= '<meta name="twitter:title" content="' . $photo["album"] . '" />' . "\n";
                $a->page['htmlhead'] .= '<meta name="twitter:image" content="' . $photo["href"] . '" />' . "\n";
                $a->page['htmlhead'] .= '<meta name="twitter:image:width" content="' . $photo["width"] . '" />' . "\n";
@@ -1616,13 +1649,13 @@ function photos_content(App $a)
        $r = q("SELECT `resource-id`, max(`scale`) AS `scale` FROM `photo` WHERE `uid` = %d AND `album` != '%s' AND `album` != '%s'
                $sql_extra GROUP BY `resource-id`",
                intval($a->data['user']['uid']),
-               dbesc('Contact Photos'),
-               dbesc(L10n::t('Contact Photos'))
+               DBA::escape('Contact Photos'),
+               DBA::escape(L10n::t('Contact Photos'))
        );
 
-       if (DBM::is_result($r)) {
-               $a->set_pager_total(count($r));
-               $a->set_pager_itemspage(20);
+       if (DBA::isResult($r)) {
+               $a->setPagerTotal(count($r));
+               $a->setPagerItemsPage(20);
        }
 
        $r = q("SELECT `resource-id`, ANY_VALUE(`id`) AS `id`, ANY_VALUE(`filename`) AS `filename`,
@@ -1631,14 +1664,14 @@ function photos_content(App $a)
                WHERE `uid` = %d AND `album` != '%s' AND `album` != '%s'
                $sql_extra GROUP BY `resource-id` ORDER BY `created` DESC LIMIT %d , %d",
                intval($a->data['user']['uid']),
-               dbesc('Contact Photos'),
-               dbesc(L10n::t('Contact Photos')),
+               DBA::escape('Contact Photos'),
+               DBA::escape(L10n::t('Contact Photos')),
                intval($a->pager['start']),
                intval($a->pager['itemspage'])
        );
 
        $photos = [];
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                // "Twist" is only used for the duepunto theme with style "slackr"
                $twist = false;
                foreach ($r as $rr) {