]> git.mxchange.org Git - friendica.git/blobdiff - mod/ping.php
Use short form array syntax everywhere
[friendica.git] / mod / ping.php
index f6d5e8cf0266779375304d8588db8d9f788a1356..9dd6780d01bcd7b0cd375a97cb278785dfcef064 100644 (file)
@@ -1,17 +1,22 @@
 <?php
-
+/**
+ * @file include/ping.php
+ */
 use Friendica\App;
+use Friendica\Content\Feature;
+use Friendica\Content\ForumManager;
+use Friendica\Core\Cache;
 use Friendica\Core\System;
 use Friendica\Core\PConfig;
+use Friendica\Database\DBM;
+use Friendica\Model\Contact;
+use Friendica\Model\Group;
+use Friendica\Util\XML;
 
-require_once('include/datetime.php');
-require_once('include/bbcode.php');
-require_once('include/ForumManager.php');
-require_once('include/group.php');
-require_once('mod/proxy.php');
-require_once('include/xml.php');
-require_once('include/cache.php');
-require_once('include/enotify.php');
+require_once 'include/datetime.php';
+require_once 'include/bbcode.php';
+require_once 'mod/proxy.php';
+require_once 'include/enotify.php';
 
 /**
  * @brief Outputs the counts and the lists of various notifications
@@ -55,15 +60,15 @@ function ping_init(App $a)
                $format = 'json';
        }
 
-       $tags          = array();
-       $comments      = array();
-       $likes         = array();
-       $dislikes      = array();
-       $friends       = array();
-       $posts         = array();
-       $regs          = array();
-       $mails         = array();
-       $notifications = array();
+       $tags          = [];
+       $comments      = [];
+       $likes         = [];
+       $dislikes      = [];
+       $friends       = [];
+       $posts         = [];
+       $regs          = [];
+       $mails         = [];
+       $notifications = [];
 
        $intro_count    = 0;
        $mail_count     = 0;
@@ -71,8 +76,8 @@ function ping_init(App $a)
        $network_count  = 0;
        $register_count = 0;
        $sysnotify_count = 0;
-       $groups_unseen  = array();
-       $forums_unseen  = array();
+       $groups_unseen  = [];
+       $forums_unseen  = [];
 
        $all_events       = 0;
        $all_events_today = 0;
@@ -81,7 +86,7 @@ function ping_init(App $a)
        $birthdays        = 0;
        $birthdays_today  = 0;
 
-       $data = array();
+       $data = [];
        $data['intro']    = $intro_count;
        $data['mail']     = $mail_count;
        $data['net']      = $network_count;
@@ -95,11 +100,10 @@ function ping_init(App $a)
        $data['birthdays']        = $birthdays;
        $data['birthdays-today']  = $birthdays_today;
 
-       if (local_user()){
+       if (local_user()) {
                // Different login session than the page that is calling us.
                if (intval($_GET['uid']) && intval($_GET['uid']) != local_user()) {
-
-                       $data = array('result' => array('invalid' => 1));
+                       $data = ['result' => ['invalid' => 1]];
 
                        if ($format == 'json') {
                                if (isset($_GET['callback'])) {
@@ -112,14 +116,15 @@ function ping_init(App $a)
                                }
                        } else {
                                header("Content-type: text/xml");
-                               echo xml::from_array($data, $xml);
+                               echo XML::fromArray($data, $xml);
                        }
                        killme();
                }
 
                $notifs = ping_get_notifications(local_user());
 
-               $items_unseen = q("SELECT `item`.`id`, `item`.`parent`, `item`.`verb`, `item`.`wall`, `item`.`author-name`,
+               $items_unseen = q(
+                       "SELECT `item`.`id`, `item`.`parent`, `item`.`verb`, `item`.`wall`, `item`.`author-name`,
                                `item`.`contact-id`, `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object`,
                                `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`
                                FROM `item` INNER JOIN `item` AS `pitem` ON  `pitem`.`id` = `item`.`parent`
@@ -127,11 +132,12 @@ function ping_init(App $a)
                                 `item`.`deleted` = 0 AND `item`.`uid` = %d AND `pitem`.`parent` != 0
                                AND `item`.`contact-id` != %d
                                ORDER BY `item`.`created` DESC",
-                       intval(local_user()), intval(local_user())
+                       intval(local_user()),
+                       intval(local_user())
                );
 
-               if (dbm::is_result($items_unseen)) {
-                       $arr = array('items' => $items_unseen);
+               if (DBM::is_result($items_unseen)) {
+                       $arr = ['items' => $items_unseen];
                        call_hooks('network_ping', $arr);
 
                        foreach ($items_unseen as $item) {
@@ -144,10 +150,10 @@ function ping_init(App $a)
                }
 
                if ($network_count) {
-                       if (intval(feature_enabled(local_user(), 'groups'))) {
+                       if (intval(Feature::isEnabled(local_user(), 'groups'))) {
                                // Find out how unseen network posts are spread across groups
-                               $group_counts = groups_count_unseen();
-                               if (dbm::is_result($group_counts)) {
+                               $group_counts = Group::countUnseen();
+                               if (DBM::is_result($group_counts)) {
                                        foreach ($group_counts as $group_count) {
                                                if ($group_count['count'] > 0) {
                                                        $groups_unseen[] = $group_count;
@@ -156,10 +162,10 @@ function ping_init(App $a)
                                }
                        }
 
-                       if (intval(feature_enabled(local_user(), 'forumlist_widget'))) {
-                               $forum_counts = ForumManager::count_unseen_items();
-                               if (dbm::is_result($forums_counts)) {
-                                       foreach ($forums_counts as $forum_count) {
+                       if (intval(Feature::isEnabled(local_user(), 'forumlist_widget'))) {
+                               $forum_counts = ForumManager::countUnseenItems();
+                               if (DBM::is_result($forum_counts)) {
+                                       foreach ($forum_counts as $forum_count) {
                                                if ($forum_count['count'] > 0) {
                                                        $forums_unseen[] = $forum_count;
                                                }
@@ -168,13 +174,15 @@ function ping_init(App $a)
                        }
                }
 
-               $intros1 = q("SELECT  `intro`.`id`, `intro`.`datetime`,
+               $intros1 = q(
+                       "SELECT  `intro`.`id`, `intro`.`datetime`,
                        `fcontact`.`name`, `fcontact`.`url`, `fcontact`.`photo`
                        FROM `intro` LEFT JOIN `fcontact` ON `intro`.`fid` = `fcontact`.`id`
                        WHERE `intro`.`uid` = %d  AND `intro`.`blocked` = 0 AND `intro`.`ignore` = 0 AND `intro`.`fid` != 0",
                        intval(local_user())
                );
-               $intros2 = q("SELECT `intro`.`id`, `intro`.`datetime`,
+               $intros2 = q(
+                       "SELECT `intro`.`id`, `intro`.`datetime`,
                        `contact`.`name`, `contact`.`url`, `contact`.`photo`
                        FROM `intro` LEFT JOIN `contact` ON `intro`.`contact-id` = `contact`.`id`
                        WHERE `intro`.`uid` = %d  AND `intro`.`blocked` = 0 AND `intro`.`ignore` = 0 AND `intro`.`contact-id` != 0",
@@ -185,58 +193,62 @@ function ping_init(App $a)
                $intros = $intros1 + $intros2;
 
                $myurl = System::baseUrl() . '/profile/' . $a->user['nickname'] ;
-               $mails = q("SELECT `id`, `from-name`, `from-url`, `from-photo`, `created` FROM `mail`
+               $mails = q(
+                       "SELECT `id`, `from-name`, `from-url`, `from-photo`, `created` FROM `mail`
                        WHERE `uid` = %d AND `seen` = 0 AND `from-url` != '%s' ",
                        intval(local_user()),
                        dbesc($myurl)
                );
                $mail_count = count($mails);
 
-               if ($a->config['register_policy'] == REGISTER_APPROVE && is_site_admin()){
-                       $regs = q("SELECT `contact`.`name`, `contact`.`url`, `contact`.`micro`, `register`.`created`, COUNT(*) AS `total`
+               if ($a->config['register_policy'] == REGISTER_APPROVE && is_site_admin()) {
+                       $regs = q(
+                               "SELECT `contact`.`name`, `contact`.`url`, `contact`.`micro`, `register`.`created`
                                FROM `contact` RIGHT JOIN `register` ON `register`.`uid` = `contact`.`uid`
-                               WHERE `contact`.`self` = 1");
+                               WHERE `contact`.`self` = 1"
+                       );
 
-                       if (dbm::is_result($regs)) {
-                               $register_count = $regs[0]['total'];
+                       if (DBM::is_result($regs)) {
+                               $register_count = count($regs);
                        }
                }
 
                $cachekey = "ping_init:".local_user();
                $ev = Cache::get($cachekey);
                if (is_null($ev)) {
-                       $ev = q("SELECT type, start, adjust FROM `event`
+                       $ev = q(
+                               "SELECT type, start, adjust FROM `event`
                                WHERE `event`.`uid` = %d AND `start` < '%s' AND `finish` > '%s' and `ignore` = 0
                                ORDER BY `start` ASC ",
                                intval(local_user()),
                                dbesc(datetime_convert('UTC', 'UTC', 'now + 7 days')),
                                dbesc(datetime_convert('UTC', 'UTC', 'now'))
                        );
-                       if (dbm::is_result($ev)) {
+                       if (DBM::is_result($ev)) {
                                Cache::set($cachekey, $ev, CACHE_HOUR);
                        }
                }
 
-               if (dbm::is_result($ev)) {
+               if (DBM::is_result($ev)) {
                        $all_events = count($ev);
 
                        if ($all_events) {
                                $str_now = datetime_convert('UTC', $a->timezone, 'now', 'Y-m-d');
-                               foreach($ev as $x) {
+                               foreach ($ev as $x) {
                                        $bd = false;
                                        if ($x['type'] === 'birthday') {
                                                $birthdays ++;
                                                $bd = true;
-                                       }
-                                       else {
+                                       } else {
                                                $events ++;
                                        }
                                        if (datetime_convert('UTC', ((intval($x['adjust'])) ? $a->timezone : 'UTC'), $x['start'], 'Y-m-d') === $str_now) {
                                                $all_events_today ++;
-                                               if ($bd)
+                                               if ($bd) {
                                                        $birthdays_today ++;
-                                               else
+                                               } else {
                                                        $events_today ++;
+                                               }
                                        }
                                }
                        }
@@ -255,7 +267,7 @@ function ping_init(App $a)
                $data['birthdays']        = $birthdays;
                $data['birthdays-today']  = $birthdays_today;
 
-               if (dbm::is_result($notifs)) {
+               if (DBM::is_result($notifs)) {
                        foreach ($notifs as $notif) {
                                if ($notif['seen'] == 0) {
                                        $sysnotify_count ++;
@@ -264,9 +276,9 @@ function ping_init(App $a)
                }
 
                // merge all notification types in one array
-               if (dbm::is_result($intros)) {
+               if (DBM::is_result($intros)) {
                        foreach ($intros as $intro) {
-                               $notif = array(
+                               $notif = [
                                        'href'    => System::baseUrl() . '/notifications/intros/' . $intro['id'],
                                        'name'    => $intro['name'],
                                        'url'     => $intro['url'],
@@ -274,14 +286,14 @@ function ping_init(App $a)
                                        'date'    => $intro['datetime'],
                                        'seen'    => false,
                                        'message' => t('{0} wants to be your friend'),
-                               );
+                               ];
                                $notifs[] = $notif;
                        }
                }
 
-               if (dbm::is_result($mails)) {
+               if (DBM::is_result($mails)) {
                        foreach ($mails as $mail) {
-                               $notif = array(
+                               $notif = [
                                        'href'    => System::baseUrl() . '/message/' . $mail['id'],
                                        'name'    => $mail['from-name'],
                                        'url'     => $mail['from-url'],
@@ -289,14 +301,14 @@ function ping_init(App $a)
                                        'date'    => $mail['created'],
                                        'seen'    => false,
                                        'message' => t('{0} sent you a message'),
-                               );
+                               ];
                                $notifs[] = $notif;
                        }
                }
 
-               if (dbm::is_result($regs)) {
+               if (DBM::is_result($regs)) {
                        foreach ($regs as $reg) {
-                               $notif = array(
+                               $notif = [
                                        'href'    => System::baseUrl() . '/admin/users/',
                                        'name'    => $reg['name'],
                                        'url'     => $reg['url'],
@@ -304,13 +316,13 @@ function ping_init(App $a)
                                        'date'    => $reg['created'],
                                        'seen'    => false,
                                        'message' => t('{0} requested registration'),
-                               );
+                               ];
                                $notifs[] = $notif;
                        }
                }
 
                // sort notifications by $[]['date']
-               $sort_function = function($a, $b) {
+               $sort_function = function ($a, $b) {
                        $adate = strtotime($a['date']);
                        $bdate = strtotime($b['date']);
 
@@ -330,7 +342,7 @@ function ping_init(App $a)
                };
                usort($notifs, $sort_function);
 
-               if (dbm::is_result($notifs)) {
+               if (DBM::is_result($notifs)) {
                        // Are the nofications called from the regular process or via the friendica app?
                        $regularnotifications = (intval($_GET['uid']) && intval($_GET['_']));
 
@@ -339,7 +351,7 @@ function ping_init(App $a)
                                        $notif['message'] = str_replace("{0}", $notif['name'], $notif['message']);
                                }
 
-                               $contact = get_contact_details_by_url($notif['url']);
+                               $contact = Contact::getDetailsByURL($notif['url']);
                                if (isset($contact['micro'])) {
                                        $notif['photo'] = proxy_url($contact['micro'], false, PROXY_SIZE_MICRO);
                                } else {
@@ -348,7 +360,7 @@ function ping_init(App $a)
 
                                $local_time = datetime_convert('UTC', date_default_timezone_get(), $notif['date']);
 
-                               $notifications[] = array(
+                               $notifications[] = [
                                        'id'        => $notif['id'],
                                        'href'      => $notif['href'],
                                        'name'      => $notif['name'],
@@ -358,13 +370,13 @@ function ping_init(App $a)
                                        'message'   => $notif['message'],
                                        'seen'      => $notif['seen'],
                                        'timestamp' => strtotime($local_time)
-                               );
+                               ];
                        }
                }
        }
 
-       $sysmsgs = array();
-       $sysmsgs_info = array();
+       $sysmsgs = [];
+       $sysmsgs_info = [];
 
        if (x($_SESSION, 'sysmsg')) {
                $sysmsgs = $_SESSION['sysmsg'];
@@ -381,12 +393,12 @@ function ping_init(App $a)
                $data['forums'] = $forums_unseen;
                $data['notify'] = $sysnotify_count + $intro_count + $mail_count + $register_count;
                $data['notifications'] = $notifications;
-               $data['sysmsgs'] = array(
+               $data['sysmsgs'] = [
                        'notice' => $sysmsgs,
                        'info' => $sysmsgs_info
-               );
+               ];
 
-               $json_payload = json_encode(array("result" => $data));
+               $json_payload = json_encode(["result" => $data]);
 
                if (isset($_GET['callback'])) {
                        // JSONP support
@@ -401,7 +413,7 @@ function ping_init(App $a)
                $data = ping_format_xml_data($data, $sysnotify_count, $notifications, $sysmsgs, $sysmsgs_info, $groups_unseen, $forums_unseen);
 
                header("Content-type: text/xml");
-               echo xml::from_array(array("result" => $data), $xml);
+               echo XML::fromArray(["result" => $data], $xml);
        }
 
        killme();
@@ -415,7 +427,7 @@ function ping_init(App $a)
  */
 function ping_get_notifications($uid)
 {
-       $result  = array();
+       $result  = [];
        $offset  = 0;
        $seen    = false;
        $seensql = "NOT";
@@ -425,7 +437,8 @@ function ping_get_notifications($uid)
        $a = get_app();
 
        do {
-               $r = q("SELECT `notify`.*, `item`.`visible`, `item`.`spam`, `item`.`deleted`
+               $r = q(
+                       "SELECT `notify`.*, `item`.`visible`, `item`.`spam`, `item`.`deleted`
                        FROM `notify` LEFT JOIN `item` ON `item`.`id` = `notify`.`iid`
                        WHERE `notify`.`uid` = %d AND `notify`.`msg` != ''
                        AND NOT (`notify`.`type` IN (%d, %d))
@@ -447,7 +460,7 @@ function ping_get_notifications($uid)
                        $offset += 50;
                }
 
-               foreach ($r AS $notification) {
+               foreach ($r as $notification) {
                        if (is_null($notification["visible"])) {
                                $notification["visible"] = true;
                        }
@@ -467,7 +480,8 @@ function ping_get_notifications($uid)
                                $notification["name"] = strip_tags(bbcode($notification["name"]));
                                $notification["message"] = format_notification_message($notification["name"], strip_tags(bbcode($notification["msg"])));
 
-                               q("UPDATE `notify` SET `name_cache` = '%s', `msg_cache` = '%s' WHERE `id` = %d",
+                               q(
+                                       "UPDATE `notify` SET `name_cache` = '%s', `msg_cache` = '%s' WHERE `id` = %d",
                                        dbesc($notification["name"]),
                                        dbesc($notification["message"]),
                                        intval($notification["id"])
@@ -476,8 +490,11 @@ function ping_get_notifications($uid)
 
                        $notification["href"] = System::baseUrl() . "/notify/view/" . $notification["id"];
 
-                       if ($notification["visible"] && !$notification["spam"] &&
-                               !$notification["deleted"] && !is_array($result[$notification["parent"]])) {
+                       if ($notification["visible"]
+                               && !$notification["spam"]
+                               && !$notification["deleted"]
+                               && !(x($result, $notification["parent"]) && is_array($result[$notification["parent"]]))
+                       ) {
                                // Should we condense the notifications or show them all?
                                if (PConfig::get(local_user(), 'system', 'detailed_notif')) {
                                        $result[$notification["id"]] = $notification;
@@ -495,22 +512,22 @@ function ping_get_notifications($uid)
  * @brief Backward-compatible XML formatting for ping.php output
  * @deprecated
  *
- * @param array $data The initial ping data array
- * @param int $sysnotify_count Number of unseen system notifications
- * @param array $notifs Complete list of notification
- * @param array $sysmsgs List of system notice messages
- * @param array $sysmsgs_info List of system info messages
- * @param int $groups_unseen Number of unseen group items
- * @param int $forums_unseen Number of unseen forum items
+ * @param array $data          The initial ping data array
+ * @param int   $sysnotify     Number of unseen system notifications
+ * @param array $notifs        Complete list of notification
+ * @param array $sysmsgs       List of system notice messages
+ * @param array $sysmsgs_info  List of system info messages
+ * @param int   $groups_unseen Number of unseen group items
+ * @param int   $forums_unseen Number of unseen forum items
  * @return array XML-transform ready data array
  */
 function ping_format_xml_data($data, $sysnotify, $notifs, $sysmsgs, $sysmsgs_info, $groups_unseen, $forums_unseen)
 {
-       $notifications = array();
-       foreach($notifs as $key => $notif) {
+       $notifications = [];
+       foreach ($notifs as $key => $notif) {
                $notifications[$key . ':note'] = $notif['message'];
 
-               $notifications[$key . ':@attributes'] = array(
+               $notifications[$key . ':@attributes'] = [
                        'id'        => $notif['id'],
                        'href'      => $notif['href'],
                        'name'      => $notif['name'],
@@ -519,39 +536,39 @@ function ping_format_xml_data($data, $sysnotify, $notifs, $sysmsgs, $sysmsgs_inf
                        'date'      => $notif['date'],
                        'seen'      => $notif['seen'],
                        'timestamp' => $notif['timestamp']
-               );
+               ];
        }
 
-       $sysmsg = array();
-       foreach ($sysmsgs as $key => $m){
+       $sysmsg = [];
+       foreach ($sysmsgs as $key => $m) {
                $sysmsg[$key . ':notice'] = $m;
        }
-       foreach ($sysmsgs_info as $key => $m){
+       foreach ($sysmsgs_info as $key => $m) {
                $sysmsg[$key . ':info'] = $m;
        }
 
        $data['notif'] = $notifications;
-       $data['@attributes'] = array('count' => $sysnotify_count + $data['intro'] + $data['mail'] + $data['register']);
+       $data['@attributes'] = ['count' => $sysnotify_count + $data['intro'] + $data['mail'] + $data['register']];
        $data['sysmsgs'] = $sysmsg;
 
        if ($data['register'] == 0) {
                unset($data['register']);
        }
 
-       $groups = array();
+       $groups = [];
        if (count($groups_unseen)) {
                foreach ($groups_unseen as $key => $item) {
                        $groups[$key . ':group'] = $item['count'];
-                       $groups[$key . ':@attributes'] = array('id' => $item['id']);
+                       $groups[$key . ':@attributes'] = ['id' => $item['id']];
                }
                $data['groups'] = $groups;
        }
 
-       $forums = array();
+       $forums = [];
        if (count($forums_unseen)) {
                foreach ($forums_unseen as $key => $item) {
                        $forums[$count . ':forum'] = $item['count'];
-                       $forums[$count . ':@attributes'] = array('id' => $item['id']);
+                       $forums[$count . ':@attributes'] = ['id' => $item['id']];
                }
                $data['forums'] = $forums;
        }