Unused variables removed

[friendica.git] / mod / poco.php

diff --git a/mod/poco.php b/mod/poco.php
index 802824ee5f0de4ff2e64371b135250d69f2fb152..ef77c9c99257181c03c28af696b7a78ba0627333 100644 (file)
--- a/mod/poco.php
+++ b/mod/poco.php
@@ -43,8 +43,7 @@ function poco_init(App $a) {
                $nickname = Strings::escapeTags(trim($a->argv[1]));
        }
        if (empty($nickname)) {
-               $c = q("SELECT * FROM `pconfig` WHERE `cat` = 'system' AND `k` = 'suggestme' AND `v` = 1");
-               if (!DBA::isResult($c)) {
+               if (!DBA::exists('profile', ['net-publish' => true])) {
                        throw new \Friendica\Network\HTTPException\ForbiddenException();
                }
                $system_mode = true;
@@ -81,16 +80,11 @@ function poco_init(App $a) {
                $cid = intval($a->argv[4]);
        }
 
-       if (! $system_mode && ! $global) {
-               $users = q("SELECT `user`.*,`profile`.`hide-friends` from user left join profile on `user`.`uid` = `profile`.`uid`
-                       where `user`.`nickname` = '%s' limit 1",
-                       DBA::escape($nickname)
-               );
-               if (! DBA::isResult($users) || $users[0]['hidewall'] || $users[0]['hide-friends']) {
+       if (!$system_mode && !$global) {
+               $user = DBA::selectFirst('owner-view', ['uid', 'nickname'], ['nickname' => $nickname, 'hide-friends' => false]);
+               if (!DBA::isResult($user)) {
                        throw new \Friendica\Network\HTTPException\NotFoundException();
                }
-
-               $user = $users[0];
        }
 
        if ($justme) {
@@ -113,8 +107,7 @@ function poco_init(App $a) {
                        DBA::escape(Protocol::OSTATUS)
                );
        } elseif ($system_mode) {
-               $contacts = q("SELECT count(*) AS `total` FROM `contact` WHERE `self` = 1
-                       AND `uid` IN (SELECT `uid` FROM `pconfig` WHERE `cat` = 'system' AND `k` = 'suggestme' AND `v` = 1) ");
+               $totalResults = DBA::count('profile', ['net-publish' => true]);
        } else {
                $contacts = q("SELECT count(*) AS `total` FROM `contact` WHERE `uid` = %d AND `blocked` = 0 AND `pending` = 0 AND `hidden` = 0 AND `archive` = 0
                        AND (`success_update` >= `failure_update` OR `last-item` >= `failure_update`)
@@ -126,9 +119,9 @@ function poco_init(App $a) {
                        DBA::escape(Protocol::STATUSNET)
                );
        }
-       if (DBA::isResult($contacts)) {
+       if (empty($totalResults) && DBA::isResult($contacts)) {
                $totalResults = intval($contacts[0]['total']);
-       } else {
+       } elseif (empty($totalResults)) {
                $totalResults = 0;
        }
        if (!empty($_GET['startIndex'])) {
@@ -151,16 +144,7 @@ function poco_init(App $a) {
                );
        } elseif ($system_mode) {
                Logger::log("Start system mode query", Logger::DEBUG);
-               $contacts = q("SELECT `contact`.*, `profile`.`about` AS `pabout`, `profile`.`locality` AS `plocation`, `profile`.`pub_keywords`,
-                               `profile`.`address` AS `paddress`, `profile`.`region` AS `pregion`,
-                               `profile`.`postal-code` AS `ppostalcode`, `profile`.`country-name` AS `pcountry`, `user`.`account-type`
-                       FROM `contact` INNER JOIN `profile` ON `profile`.`uid` = `contact`.`uid`
-                               INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
-                       WHERE `self` = 1
-                       AND `contact`.`uid` IN (SELECT `uid` FROM `pconfig` WHERE `cat` = 'system' AND `k` = 'suggestme' AND `v` = 1) LIMIT %d, %d",
-                       intval($startIndex),
-                       intval($itemsPerPage)
-               );
+               $contacts = DBA::selectToArray('owner-view', [], ['net-publish' => true], ['limit' => [$startIndex, $itemsPerPage]]);
        } else {
                Logger::log("Start query for user " . $user['nickname'], Logger::DEBUG);
                $contacts = q("SELECT * FROM `contact` WHERE `uid` = %d AND `blocked` = 0 AND `pending` = 0 AND `hidden` = 0 AND `archive` = 0
@@ -237,28 +221,6 @@ function poco_init(App $a) {
                                        }
                                }
 
-                               if (($contact['about'] == "") && isset($contact['pabout'])) {
-                                       $contact['about'] = $contact['pabout'];
-                               }
-                               if ($contact['location'] == "") {
-                                       if (isset($contact['plocation'])) {
-                                               $contact['location'] = $contact['plocation'];
-                                       }
-                                       if (isset($contact['pregion']) && ( $contact['pregion'] != "")) {
-                                               if ($contact['location'] != "") {
-                                                       $contact['location'] .= ", ";
-                                               }
-                                               $contact['location'] .= $contact['pregion'];
-                                       }
-
-                                       if (isset($contact['pcountry']) && ( $contact['pcountry'] != "")) {
-                                               if ($contact['location'] != "") {
-                                                       $contact['location'] .= ", ";
-                                               }
-                                               $contact['location'] .= $contact['pcountry'];
-                                       }
-                               }
-
                                if (($contact['keywords'] == "") && isset($contact['pub_keywords'])) {
                                        $contact['keywords'] = $contact['pub_keywords'];
                                }
@@ -350,21 +312,21 @@ function poco_init(App $a) {
                                        $entry['address'] = [];
 
                                        // Deactivated. It just reveals too much data. (Although its from the default profile)
-                                       //if (isset($rr['paddress']))
-                                       //       $entry['address']['streetAddress'] = $rr['paddress'];
+                                       //if (isset($rr['address']))
+                                       //       $entry['address']['streetAddress'] = $rr['address'];
 
-                                       if (isset($contact['plocation'])) {
-                                               $entry['address']['locality'] = $contact['plocation'];
+                                       if (isset($contact['locality'])) {
+                                               $entry['address']['locality'] = $contact['locality'];
                                        }
-                                       if (isset($contact['pregion'])) {
-                                               $entry['address']['region'] = $contact['pregion'];
+                                       if (isset($contact['region'])) {
+                                               $entry['address']['region'] = $contact['region'];
                                        }
                                        // See above
-                                       //if (isset($rr['ppostalcode']))
-                                       //       $entry['address']['postalCode'] = $rr['ppostalcode'];
+                                       //if (isset($rr['postal-code']))
+                                       //       $entry['address']['postalCode'] = $rr['postal-code'];
 
-                                       if (isset($contact['pcountry'])) {
-                                               $entry['address']['country'] = $contact['pcountry'];
+                                       if (isset($contact['country'])) {
+                                               $entry['address']['country'] = $contact['country'];
                                        }
                                }