Merge pull request #7605 from annando/pending-2

[friendica.git] / mod / profile_photo.php

diff --git a/mod/profile_photo.php b/mod/profile_photo.php
index b802050b631f14cbd454dcf23ba7649728f11c37..97d2da349c88bd72955596f3cf4cabd4fae6b0b7 100644 (file)
--- a/mod/profile_photo.php
+++ b/mod/profile_photo.php
@@ -109,11 +109,11 @@ function profile_photo_post(App $a)
                                // If setting for the default profile, unset the profile photo flag from any other photos I own
 
                                if ($is_default_profile) {
-                                       $r = q("UPDATE `photo` SET `profile` = 0 WHERE `profile` = 1 AND `resource-id` != '%s' AND `uid` = %d",
+                                       q("UPDATE `photo` SET `profile` = 0 WHERE `profile` = 1 AND `resource-id` != '%s' AND `uid` = %d",
                                                DBA::escape($base_image['resource-id']), intval(local_user())
                                        );
                                } else {
-                                       $r = q("update profile set photo = '%s', thumb = '%s' where id = %d and uid = %d",
+                                       q("update profile set photo = '%s', thumb = '%s' where id = %d and uid = %d",
                                                DBA::escape(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-4.' . $Image->getExt()),
                                                DBA::escape(System::baseUrl() . '/photo/' . $base_image['resource-id'] . '-5.' . $Image->getExt()),
                                                intval($_REQUEST['profile']), intval(local_user())
@@ -192,14 +192,7 @@ function profile_photo_content(App $a)
                $resource_id = $a->argv[2];
                //die(":".local_user());
 
-               $r = Photo::select([], ["resource-id" => $resource_id, "uid" => local_user()], ["order" => ["scale"=>false]]);
-
-               /*
-               $r = q("SELECT * FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' ORDER BY `scale` ASC", intval(local_user()),
-                       DBA::escape($resource_id)
-               );
-               */
-
+               $r = Photo::selectToArray([], ["resource-id" => $resource_id, "uid" => local_user()], ["order" => ["scale" => false]]);
                if (!DBA::isResult($r)) {
                        notice(L10n::t('Permission denied.') . EOL);
                        return;
@@ -215,9 +208,9 @@ function profile_photo_content(App $a)
                // set an already uloaded photo as profile photo
                // if photo is in 'Profile Photos', change it in db
                if (($r[0]['album'] == L10n::t('Profile Photos')) && ($havescale)) {
-                       $r = q("UPDATE `photo` SET `profile`=0 WHERE `profile`=1 AND `uid`=%d", intval(local_user()));
+                       q("UPDATE `photo` SET `profile`=0 WHERE `profile`=1 AND `uid`=%d", intval(local_user()));
 
-                       $r = q("UPDATE `photo` SET `profile`=1 WHERE `uid` = %d AND `resource-id` = '%s'", intval(local_user()),
+                       q("UPDATE `photo` SET `profile`=1 WHERE `uid` = %d AND `resource-id` = '%s'", intval(local_user()),
                                DBA::escape($resource_id)
                        );
 
@@ -275,8 +268,6 @@ function profile_photo_content(App $a)
                ]);
                return $o;
        }
-
-       return; // NOTREACHED
 }
 
 function profile_photo_crop_ui_head(App $a, Image $image)