Some standards

[friendica.git] / mod / profperm.php

diff --git a/mod/profperm.php b/mod/profperm.php
index 8d09c429cc3b006976543d7cb17236559815632f..a414d8947bf35369a819b9966239585468889b59 100644 (file)
--- a/mod/profperm.php
+++ b/mod/profperm.php
@@ -1,21 +1,22 @@
 <?php
 
-function profperm_init(&$a) {
+function profperm_init(App $a) {
 
-       if(! local_user())
+       if (! local_user()) {
                return;
+       }
 
        $which = $a->user['nickname'];
-       $profile = $a->argv[1];         
+       $profile = $a->argv[1];
 
        profile_load($a,$which,$profile);
 
 }
 
 
-function profperm_content(&$a) {
+function profperm_content(App $a) {
 
-       if(! local_user()) {
+       if (! local_user()) {
                notice( t('Permission denied') . EOL);
                return;
        }
@@ -36,12 +37,13 @@ function profperm_content(&$a) {
 
 
        if(($a->argc > 2) && intval($a->argv[1]) && intval($a->argv[2])) {
-               $r = q("SELECT `id` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `self` = 0 
-                       AND `network` = 'dfrn' AND `id` = %d AND `uid` = %d LIMIT 1",
+               $r = q("SELECT `id` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `self` = 0
+                       AND `network` = '%s' AND `id` = %d AND `uid` = %d LIMIT 1",
+                       dbesc(NETWORK_DFRN),
                        intval($a->argv[2]),
                        intval(local_user())
                );
-               if(count($r))
+               if (dbm::is_result($r))
                        $change = intval($a->argv[2]);
        }
 
@@ -51,7 +53,7 @@ function profperm_content(&$a) {
                        intval($a->argv[1]),
                        intval(local_user())
                );
-               if(! count($r)) {
+               if (! dbm::is_result($r)) {
                        notice( t('Invalid profile identifier.') . EOL );
                        return;
                }
@@ -63,7 +65,7 @@ function profperm_content(&$a) {
                );
 
                $ingroup = array();
-               if(count($r))
+               if (dbm::is_result($r))
                        foreach($r as $member)
                                $ingroup[] = $member['id'];
 
@@ -71,13 +73,13 @@ function profperm_content(&$a) {
 
                if($change) {
                        if(in_array($change,$ingroup)) {
-                               q("UPDATE `contact` SET `profile-id` = 0 WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                               q("UPDATE `contact` SET `profile-id` = 0 WHERE `id` = %d AND `uid` = %d",
                                        intval($change),
                                        intval(local_user())
                                );
                        }
                        else {
-                               q("UPDATE `contact` SET `profile-id` = %d WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                               q("UPDATE `contact` SET `profile-id` = %d WHERE `id` = %d AND `uid` = %d",
                                        intval($a->argv[1]),
                                        intval($change),
                                        intval(local_user())
@@ -93,7 +95,7 @@ function profperm_content(&$a) {
                        $members = $r;
 
                        $ingroup = array();
-                       if(count($r))
+                       if (dbm::is_result($r))
                                foreach($r as $member)
                                        $ingroup[] = $member['id'];
                }
@@ -107,9 +109,9 @@ function profperm_content(&$a) {
        }
 
        $o .= '<div id="prof-update-wrapper">';
-       if($change) 
+       if($change)
                $o = '';
-       
+
        $o .= '<div id="prof-members-title">';
        $o .= '<h3>' . t('Visible To') . '</h3>';
        $o .= '</div>';
@@ -130,13 +132,14 @@ function profperm_content(&$a) {
        $o .= '<h3>' . t("All Contacts \x28with secure profile access\x29") . '</h3>';
        $o .= '</div>';
        $o .= '<div id="prof-all-contacts">';
-               
-               $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `blocked` = 0 and `pending` = 0 and `self` = 0 
-                       AND `network` = 'dfrn' ORDER BY `name` ASC",
-                       intval(local_user())
+
+               $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `blocked` = 0 and `pending` = 0 and `self` = 0
+                       AND `network` = '%s' ORDER BY `name` ASC",
+                       intval(local_user()),
+                       dbesc(NETWORK_DFRN)
                );
 
-               if(count($r)) {
+               if (dbm::is_result($r)) {
                        $textmode = (($switchtotext && (count($r) > $switchtotext)) ? true : false);
                        foreach($r as $member) {
                                if(! in_array($member['id'],$ingroup)) {