Use short form array syntax everywhere

[friendica.git] / mod / wall_attach.php

diff --git a/mod/wall_attach.php b/mod/wall_attach.php
index 68752a0e1f659082e51ec6df90add56663d5ba1d..472a8073247e9a96d7150d50da9e6150a43367a7 100644 (file)
--- a/mod/wall_attach.php
+++ b/mod/wall_attach.php
@@ -1,9 +1,15 @@
 <?php
+/**
+ * @file mod/wall_attach.php
+ */
+use Friendica\App;
+use Friendica\Core\Config;
+use Friendica\Database\DBM;
+use Friendica\Util\Mimetype;
 
-require_once('include/attach.php');
-require_once('include/datetime.php');
+require_once 'include/datetime.php';
 
-function wall_attach_post(&$a) {
+function wall_attach_post(App $a) {
 
        $r_json = (x($_GET,'response') && $_GET['response']=='json');
 
@@ -12,21 +18,21 @@ function wall_attach_post(&$a) {
                $r = q("SELECT `user`.*, `contact`.`id` FROM `user` LEFT JOIN `contact` on `user`.`uid` = `contact`.`uid`  WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 and `contact`.`self` = 1 LIMIT 1",
                        dbesc($nick)
                );
-               if(! count($r)){
+               if (! DBM::is_result($r)) {
                        if ($r_json) {
-                            echo json_encode(array('error'=>t('Invalid request.')));
-                            killme();
-                        }
+                               echo json_encode(['error'=>t('Invalid request.')]);
+                               killme();
+                       }
                        return;
-        }
+       }
 
        } else {
                if ($r_json) {
-                    echo json_encode(array('error'=>t('Invalid request.')));
-                    killme();
-                }
+                       echo json_encode(['error'=>t('Invalid request.')]);
+                       killme();
+               }
                return;
-    }
+       }
 
        $can_post  = false;
        $visitor   = 0;
@@ -40,41 +46,41 @@ function wall_attach_post(&$a) {
                $can_post = true;
        else {
                if($community_page && remote_user()) {
-                       $cid = 0;
+                       $contact_id = 0;
                        if(is_array($_SESSION['remote'])) {
                                foreach($_SESSION['remote'] as $v) {
                                        if($v['uid'] == $page_owner_uid) {
-                                               $cid = $v['cid'];
+                                               $contact_id = $v['cid'];
                                                break;
                                        }
                                }
                        }
-                       if($cid) {
+                       if($contact_id) {
 
                                $r = q("SELECT `uid` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `id` = %d AND `uid` = %d LIMIT 1",
-                                       intval($cid),
+                                       intval($contact_id),
                                        intval($page_owner_uid)
                                );
-                               if(count($r)) {
+                               if (DBM::is_result($r)) {
                                        $can_post = true;
-                                       $visitor = $cid;
+                                       $visitor = $contact_id;
                                }
                        }
                }
        }
        if(! $can_post) {
                if ($r_json) {
-                    echo json_encode(array('error'=>t('Permission denied.')));
-                    killme();
-                }
+                       echo json_encode(['error'=>t('Permission denied.')]);
+                       killme();
+               }
                notice( t('Permission denied.') . EOL );
                killme();
        }
 
        if(! x($_FILES,'userfile')) {
                if ($r_json) {
-                    echo json_encode(array('error'=>t('Invalid request.')));
-                }
+                       echo json_encode(['error'=>t('Invalid request.')]);
+               }
                killme();
        }
 
@@ -82,7 +88,7 @@ function wall_attach_post(&$a) {
        $filename = basename($_FILES['userfile']['name']);
        $filesize = intval($_FILES['userfile']['size']);
 
-       $maxfilesize = get_config('system','maxfilesize');
+       $maxfilesize = Config::get('system','maxfilesize');
 
        /* Found html code written in text field of form,
         * when trying to upload a file with filesize
@@ -93,7 +99,7 @@ function wall_attach_post(&$a) {
        if($filesize <=0) {
                $msg = t('Sorry, maybe your upload is bigger than the PHP configuration allows') . EOL .(t('Or - did you try to upload an empty file?'));
                if ($r_json) {
-                       echo json_encode(array('error'=>$msg));
+                       echo json_encode(['error'=>$msg]);
                } else {
                        notice( $msg. EOL );
                }
@@ -104,24 +110,7 @@ function wall_attach_post(&$a) {
        if(($maxfilesize) && ($filesize > $maxfilesize)) {
                $msg = sprintf(t('File exceeds size limit of %s'), formatBytes($maxfilesize));
                if ($r_json) {
-                       echo json_encode(array('error'=>$msg));
-               } else {
-                       echo  $msg. EOL ;
-               }
-               @unlink($src);
-               killme();
-       }
-
-       $r = q("select sum(octet_length(data)) as total from attach where uid = %d ",
-               intval($page_owner_uid)
-       );
-
-       $limit = service_class_fetch($page_owner_uid,'attach_upload_limit');
-
-       if(($limit !== false) && (($r[0]['total'] + strlen($imagedata)) > $limit)) {
-               $msg = upgrade_message(true);
-               if ($r_json) {
-                       echo json_encode(array('error'=>$msg));
+                       echo json_encode(['error'=>$msg]);
                } else {
                        echo  $msg. EOL ;
                }
@@ -129,33 +118,23 @@ function wall_attach_post(&$a) {
                killme();
        }
 
-
        $filedata = @file_get_contents($src);
-       $mimetype = z_mime_content_type($filename);
+       $mimetype = Mimetype::getContentType($filename);
        $hash = get_guid(64);
        $created = datetime_convert();
-       $r = q("INSERT INTO `attach` ( `uid`, `hash`, `filename`, `filetype`, `filesize`, `data`, `created`, `edited`, `allow_cid`, `allow_gid`,`deny_cid`, `deny_gid` )
-               VALUES ( %d, '%s', '%s', '%s', %d, '%s', '%s', '%s', '%s', '%s', '%s', '%s' ) ",
-               intval($page_owner_uid),
-               dbesc($hash),
-               dbesc($filename),
-               dbesc($mimetype),
-               intval($filesize),
-               dbesc($filedata),
-               dbesc($created),
-               dbesc($created),
-               dbesc('<' . $page_owner_cid . '>'),
-               dbesc(''),
-               dbesc(''),
-               dbesc('')
-       );
+
+       $fields = ['uid' => $page_owner_uid, 'hash' => $hash, 'filename' => $filename, 'filetype' => $mimetype,
+               'filesize' => $filesize, 'data' => $filedata, 'created' => $created, 'edited' => $created,
+               'allow_cid' => '<' . $page_owner_cid . '>', 'allow_gid' => '','deny_cid' => '', 'deny_gid' => ''];
+
+       $r = dba::insert('attach', $fields);
 
        @unlink($src);
 
        if(! $r) {
                $msg =  t('File upload failed.');
                if ($r_json) {
-                       echo json_encode(array('error'=>$msg));
+                       echo json_encode(['error'=>$msg]);
                } else {
                        echo  $msg. EOL ;
                }
@@ -168,10 +147,10 @@ function wall_attach_post(&$a) {
                dbesc($hash)
        );
 
-       if(! count($r)) {
+       if (! DBM::is_result($r)) {
                $msg = t('File upload failed.');
                if ($r_json) {
-                       echo json_encode(array('error'=>$msg));
+                       echo json_encode(['error'=>$msg]);
                } else {
                        echo  $msg. EOL ;
                }
@@ -179,9 +158,9 @@ function wall_attach_post(&$a) {
        }
 
        if ($r_json) {
-            echo json_encode(array('ok'=>true));
-            killme();
-        }
+               echo json_encode(['ok'=>true]);
+               killme();
+       }
 
        $lf = "\n";