<?php
/*
* StatusNet - the distributed open-source microblogging tool
- * Copyright (C) 2008-2010 StatusNet, Inc.
+ * Copyright (C) 2008-2011 StatusNet, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
define('TWITTER_SERVICE', 1); // Twitter is foreign_service ID 1
-require_once INSTALLDIR . '/plugins/TwitterBridge/twitteroauthclient.php';
-
function add_twitter_user($twitter_id, $screen_name)
{
// Clear out any bad old foreign_users with the new user's legit URL
$fuser = Foreign_user::getForeignUser($twitter_id, TWITTER_SERVICE);
if (!empty($fuser)) {
-
// Delete old record if Twitter user changed screen name
if ($fuser->nickname != $screen_name) {
$screen_name,
$oldname));
}
-
} else {
// Kill any old, invalid records for this screen name
$fuser = Foreign_user::getByNickname($screen_name, TWITTER_SERVICE);
}
function is_twitter_bound($notice, $flink) {
+
+ // Don't send activity activities (at least for now)
+ if ($notice->object_type == ActivityObject::ACTIVITY) {
+ return false;
+ }
+
+ $allowedVerbs = array(ActivityVerb::POST, ActivityVerb::SHARE);
+
+ // Don't send things that aren't posts or repeats (at least for now)
+ if (!in_array($notice->verb, $allowedVerbs)) {
+ return false;
+ }
+
// Check to see if notice should go to Twitter
- if (!empty($flink) && ($flink->noticesync & FOREIGN_NOTICE_SEND)) {
+ if (!empty($flink) && (($flink->noticesync & FOREIGN_NOTICE_SEND) == FOREIGN_NOTICE_SEND)) {
// If it's not a Twitter-style reply, or if the user WANTS to send replies,
// or if it's in reply to a twitter notice
- if (!preg_match('/^@[a-zA-Z0-9_]{1,15}\b/u', $notice->content) ||
- ($flink->noticesync & FOREIGN_NOTICE_SEND_REPLY) ||
- is_twitter_notice($notice->reply_to)) {
+ if ( (($flink->noticesync & FOREIGN_NOTICE_SEND_REPLY) == FOREIGN_NOTICE_SEND_REPLY) ||
+ (is_twitter_notice($notice->reply_to) || is_twitter_notice($notice->repeat_of)) ||
+ (empty($notice->reply_to) && !preg_match('/^@[a-zA-Z0-9_]{1,15}\b/u', $notice->content)) ){
return true;
}
}
function is_twitter_notice($id)
{
- $n2s = Notice_to_status::staticGet('notice_id', $id);
+ $n2s = Notice_to_status::getKV('notice_id', $id);
return (!empty($n2s));
}
+/**
+ * Pull the formatted status ID number from a Twitter status object
+ * returned via JSON from Twitter API.
+ *
+ * Encapsulates checking for the id_str attribute, which is required
+ * to read 64-bit "Snowflake" ID numbers on a 32-bit system -- the
+ * integer id attribute gets corrupted into a double-precision float,
+ * losing a few digits of precision.
+ *
+ * Warning: avoid performing arithmetic or direct comparisons with
+ * this number, as it may get coerced back to a double on 32-bit.
+ *
+ * @param object $status
+ * @param string $field base field name if not 'id'
+ * @return mixed id number as int or string
+ */
+function twitter_id($status, $field='id')
+{
+ $field_str = "{$field}_str";
+ if (isset($status->$field_str)) {
+ // String version of the id -- required on 32-bit systems
+ // since the 64-bit numbers get corrupted as ints.
+ return $status->$field_str;
+ } else {
+ return $status->$field;
+ }
+}
+
+/**
+ * Check if we need to broadcast a notice over the Twitter bridge, and
+ * do so if necessary. Will determine whether to do a straight post or
+ * a repeat/retweet
+ *
+ * This function is meant to be called directly from TwitterQueueHandler.
+ *
+ * @param Notice $notice
+ * @return boolean true if complete or successful, false if we should retry
+ */
function broadcast_twitter($notice)
{
$flink = Foreign_link::getByUserID($notice->profile_id,
// Don't bother with basic auth, since it's no longer allowed
if (!empty($flink) && TwitterOAuthClient::isPackedToken($flink->credentials)) {
- if (!empty($notice->repeat_of) && is_twitter_notice($notice->repeat_of)) {
- $retweet = retweet_notice($flink, Notice::staticGet('id', $notice->repeat_of));
- if (!empty($retweet)) {
- Notice_to_status::saveNew($notice->id, $retweet->id);
+ if (is_twitter_bound($notice, $flink)) {
+ if (!empty($notice->repeat_of) && is_twitter_notice($notice->repeat_of)) {
+ $retweet = retweet_notice($flink, Notice::getKV('id', $notice->repeat_of));
+ if (is_object($retweet)) {
+ Notice_to_status::saveNew($notice->id, twitter_id($retweet));
+ return true;
+ } else {
+ // Our error processing will have decided if we need to requeue
+ // this or can discard safely.
+ return $retweet;
+ }
+ } else {
+ return broadcast_oauth($notice, $flink);
}
- } else if (is_twitter_bound($notice, $flink)) {
- return broadcast_oauth($notice, $flink);
}
}
return true;
}
+/**
+ * Send a retweet to Twitter for a notice that has been previously bridged
+ * in or out.
+ *
+ * Warning: the return value is not guaranteed to be an object; some error
+ * conditions will return a 'true' which should be passed on to a calling
+ * queue handler.
+ *
+ * No local information about the resulting retweet is saved: it's up to
+ * caller to save new mappings etc if appropriate.
+ *
+ * @param Foreign_link $flink
+ * @param Notice $notice
+ * @return mixed object with resulting Twitter status data on success, or true/false/null on error conditions.
+ */
function retweet_notice($flink, $notice)
{
$token = TwitterOAuthClient::unpackToken($flink->credentials);
function twitter_status_id($notice)
{
- $n2s = Notice_to_status::staticGet('notice_id', $notice->id);
+ $n2s = Notice_to_status::getKV('notice_id', $notice->id);
if (empty($n2s)) {
return null;
} else {
$params['long'] = $notice->lon;
}
if (!empty($notice->reply_to) && is_twitter_notice($notice->reply_to)) {
- $reply = Notice::staticGet('id', $notice->reply_to);
+ $reply = Notice::getKV('id', $notice->reply_to);
$params['in_reply_to_status_id'] = twitter_status_id($reply);
}
return $params;
try {
$status = $client->statusesUpdate($statustxt, $params);
if (!empty($status)) {
- Notice_to_status::saveNew($notice->id, $status->id);
+ Notice_to_status::saveNew($notice->id, twitter_id($status));
}
} catch (OAuthClientException $e) {
return process_error($e, $flink, $notice);
}
if (empty($status)) {
-
// This could represent a failure posting,
// or the Twitter API might just be behaving flakey.
$errmsg = sprintf('Twitter bridge - No data returned by Twitter API when ' .
common_log(LOG_WARNING, $logmsg);
+ // http://dev.twitter.com/pages/responses_errors
switch($code) {
+ case 400:
+ // Probably invalid data (bad Unicode chars or coords) that
+ // cannot be resolved by just sending again.
+ //
+ // It could also be rate limiting, but retrying immediately
+ // won't help much with that, so we'll discard for now.
+ // If a facility for retrying things later comes up in future,
+ // we can detect the rate-limiting headers and use that.
+ //
+ // Discard the message permanently.
+ return true;
+ break;
case 401:
// Probably a revoked or otherwise bad access token - nuke!
remove_twitter_link($flink);
// User has exceeder her rate limit -- toss the notice
return true;
break;
+ case 404:
+ // Resource not found. Shouldn't happen much on posting,
+ // but just in case!
+ //
+ // Consider it a matter for tossing the notice.
+ return true;
+ break;
default:
// For every other case, it's probably some flakiness so try
// Twitter still has a 140-char hardcoded max.
if (mb_strlen($statustxt) > 140) {
- $noticeUrl = common_shorten_url($notice->uri);
+ $noticeUrl = common_shorten_url($notice->getUrl());
$urlLen = mb_strlen($noticeUrl);
$statustxt = mb_substr($statustxt, 0, 140 - ($urlLen + 3)) . ' … ' . $noticeUrl;
}
common_switch_locale($user->language);
- $subject = sprintf(_m('Your Twitter bridge has been disabled.'));
+ // TRANS: Mail subject after forwarding notices to Twitter has stopped working.
+ $subject = sprintf(_m('Your Twitter bridge has been disabled'));
$site_name = common_config('site', 'name');
+ // TRANS: Mail body after forwarding notices to Twitter has stopped working.
+ // TRANS: %1$ is the name of the user the mail is sent to, %2$s is a URL to the
+ // TRANS: Twitter settings, %3$s is the StatusNet sitename.
$body = sprintf(_m('Hi, %1$s. We\'re sorry to inform you that your ' .
'link to Twitter has been disabled. We no longer seem to have ' .
'permission to update your Twitter status. Did you maybe revoke ' .
projects / quix0rs-gnu-social.git / blobdiff