]> git.mxchange.org Git - friendica-addons.git/blobdiff - pumpio/pumpio.php
Functions moved to Strings class
[friendica-addons.git] / pumpio / pumpio.php
index 40c653d856caf3450e914a2537c33efed6adf74c..71b5cf159759e9851d4a3e281eeedfbf0fcae09d 100644 (file)
@@ -12,7 +12,9 @@ use Friendica\Content\Text\HTML;
 use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
+use Friendica\Core\Logger;
 use Friendica\Core\PConfig;
+use Friendica\Core\Protocol;
 use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\Model\Contact;
@@ -23,6 +25,8 @@ use Friendica\Model\Queue;
 use Friendica\Model\User;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Strings;
+use Friendica\Util\XML;
 
 require 'addon/pumpio/oauth/http.php';
 require 'addon/pumpio/oauth/oauth_client.php';
@@ -101,7 +105,7 @@ function pumpio_registerclient(App $a, $host)
        $application_name  = Config::get('pumpio', 'application_name');
 
        if ($application_name == "") {
-               $application_name = $a->get_hostname();
+               $application_name = $a->getHostName();
        }
 
        $adminlist = explode(",", str_replace(" ", "", Config::get('config', 'admin_email')));
@@ -110,10 +114,10 @@ function pumpio_registerclient(App $a, $host)
        $params["contacts"] = $adminlist[0];
        $params["application_type"] = "native";
        $params["application_name"] = $application_name;
-       $params["logo_url"] = $a->get_baseurl()."/images/friendica-256.png";
-       $params["redirect_uris"] = $a->get_baseurl()."/pumpio/connect";
+       $params["logo_url"] = $a->getBaseURL()."/images/friendica-256.png";
+       $params["redirect_uris"] = $a->getBaseURL()."/pumpio/connect";
 
-       logger("pumpio_registerclient: ".$url." parameters ".print_r($params, true), LOGGER_DEBUG);
+       Logger::log("pumpio_registerclient: ".$url." parameters ".print_r($params, true), Logger::DEBUG);
 
        $ch = curl_init($url);
        curl_setopt($ch, CURLOPT_HEADER, false);
@@ -127,26 +131,23 @@ function pumpio_registerclient(App $a, $host)
 
        if ($curl_info["http_code"] == "200") {
                $values = json_decode($s);
-               logger("pumpio_registerclient: success ".print_r($values, true), LOGGER_DEBUG);
+               Logger::log("pumpio_registerclient: success ".print_r($values, true), Logger::DEBUG);
                return $values;
        }
-       logger("pumpio_registerclient: failed: ".print_r($curl_info, true), LOGGER_DEBUG);
+       Logger::log("pumpio_registerclient: failed: ".print_r($curl_info, true), Logger::DEBUG);
        return false;
 
 }
 
 function pumpio_connect(App $a)
 {
-       // Start a session.  This is necessary to hold on to  a few keys the callback script will also need
-       session_start();
-
        // Define the needed keys
        $consumer_key = PConfig::get(local_user(), 'pumpio', 'consumer_key');
        $consumer_secret = PConfig::get(local_user(), 'pumpio', 'consumer_secret');
        $hostname = PConfig::get(local_user(), 'pumpio', 'host');
 
        if ((($consumer_key == "") || ($consumer_secret == "")) && ($hostname != "")) {
-               logger("pumpio_connect: register client");
+               Logger::log("pumpio_connect: register client");
                $clientdata = pumpio_registerclient($a, $hostname);
                PConfig::set(local_user(), 'pumpio', 'consumer_key', $clientdata->client_id);
                PConfig::set(local_user(), 'pumpio', 'consumer_secret', $clientdata->client_secret);
@@ -154,18 +155,18 @@ function pumpio_connect(App $a)
                $consumer_key = PConfig::get(local_user(), 'pumpio', 'consumer_key');
                $consumer_secret = PConfig::get(local_user(), 'pumpio', 'consumer_secret');
 
-               logger("pumpio_connect: ckey: ".$consumer_key." csecrect: ".$consumer_secret, LOGGER_DEBUG);
+               Logger::log("pumpio_connect: ckey: ".$consumer_key." csecrect: ".$consumer_secret, Logger::DEBUG);
        }
 
        if (($consumer_key == "") || ($consumer_secret == "")) {
-               logger("pumpio_connect: ".sprintf("Unable to register the client at the pump.io server '%s'.", $hostname));
+               Logger::log("pumpio_connect: ".sprintf("Unable to register the client at the pump.io server '%s'.", $hostname));
 
                $o .= L10n::t("Unable to register the client at the pump.io server '%s'.", $hostname);
                return $o;
        }
 
        // The callback URL is the script that gets called after the user authenticates with pumpio
-       $callback_url = $a->get_baseurl()."/pumpio/connect";
+       $callback_url = $a->getBaseURL()."/pumpio/connect";
 
        // Let's begin.  First we need a Request Token.  The request token is required to send the user
        // to pumpio's login page.
@@ -173,7 +174,7 @@ function pumpio_connect(App $a)
        // Create a new instance of the oauth_client_class library.  For this step, all we need to give the library is our
        // Consumer Key and Consumer Secret
        $client = new oauth_client_class;
-       $client->debug = 1;
+       $client->debug = 0;
        $client->server = '';
        $client->oauth_version = '1.0a';
        $client->request_token_url = 'https://'.$hostname.'/oauth/request_token';
@@ -188,7 +189,7 @@ function pumpio_connect(App $a)
        if (($success = $client->Initialize())) {
                if (($success = $client->Process())) {
                        if (strlen($client->access_token)) {
-                               logger("pumpio_connect: otoken: ".$client->access_token." osecrect: ".$client->access_token_secret, LOGGER_DEBUG);
+                               Logger::log("pumpio_connect: otoken: ".$client->access_token." osecrect: ".$client->access_token_secret, Logger::DEBUG);
                                PConfig::set(local_user(), "pumpio", "oauth_token", $client->access_token);
                                PConfig::set(local_user(), "pumpio", "oauth_token_secret", $client->access_token_secret);
                        }
@@ -200,11 +201,11 @@ function pumpio_connect(App $a)
        }
 
        if ($success) {
-               logger("pumpio_connect: authenticated");
-               $o .= L10n::t("You are now authenticated to pumpio.");
-               $o .= '<br /><a href="'.$a->get_baseurl().'/settings/connectors">'.L10n::t("return to the connector page").'</a>';
+               Logger::log("pumpio_connect: authenticated");
+               $o = L10n::t("You are now authenticated to pumpio.");
+               $o .= '<br /><a href="'.$a->getBaseURL().'/settings/connectors">'.L10n::t("return to the connector page").'</a>';
        } else {
-               logger("pumpio_connect: could not connect");
+               Logger::log("pumpio_connect: could not connect");
                $o = 'Could not connect to pumpio. Refresh the page or try again later.';
        }
 
@@ -235,7 +236,7 @@ function pumpio_settings(App $a, &$s)
 
        /* Add our stylesheet to the page so we can make our settings look nice */
 
-       $a->page['htmlhead'] .= '<link rel="stylesheet"  type="text/css" href="' . $a->get_baseurl() . '/addon/pumpio/pumpio.css' . '" media="all" />' . "\r\n";
+       $a->page['htmlhead'] .= '<link rel="stylesheet"  type="text/css" href="' . $a->getBaseURL() . '/addon/pumpio/pumpio.css' . '" media="all" />' . "\r\n";
 
        /* Get the current state of our config variables */
 
@@ -285,7 +286,7 @@ function pumpio_settings(App $a, &$s)
                $s .= '<div id="pumpio-password-wrapper">';
                if (($oauth_token == "") || ($oauth_token_secret == "")) {
                        $s .= '<div id="pumpio-authenticate-wrapper">';
-                       $s .= '<a href="'.$a->get_baseurl().'/pumpio/connect">'.L10n::t("Authenticate your pump.io connection").'</a>';
+                       $s .= '<a href="'.$a->getBaseURL().'/pumpio/connect">'.L10n::t("Authenticate your pump.io connection").'</a>';
                        $s .= '</div><div class="clear"></div>';
                } else {
                        $s .= '<div id="pumpio-import-wrapper">';
@@ -360,19 +361,17 @@ function pumpio_settings_post(App $a, array &$b)
                        $host = trim($host);
                        $host = str_replace(["https://", "http://"], ["", ""], $host);
 
-                       PConfig::set(local_user(), 'pumpio', 'post'           , intval($_POST['pumpio']));
-                       PConfig::set(local_user(), 'pumpio', 'import'         , $_POST['pumpio_import']);
+                       PConfig::set(local_user(), 'pumpio', 'post'           , defaults($_POST, 'pumpio', false));
+                       PConfig::set(local_user(), 'pumpio', 'import'         , defaults($_POST, 'pumpio_import', false));
                        PConfig::set(local_user(), 'pumpio', 'host'           , $host);
                        PConfig::set(local_user(), 'pumpio', 'user'           , $user);
-                       PConfig::set(local_user(), 'pumpio', 'public'         , $_POST['pumpio_public']);
-                       PConfig::set(local_user(), 'pumpio', 'mirror'         , $_POST['pumpio_mirror']);
-                       PConfig::set(local_user(), 'pumpio', 'post_by_default', intval($_POST['pumpio_bydefault']));
+                       PConfig::set(local_user(), 'pumpio', 'public'         , defaults($_POST, 'pumpio_public', false));
+                       PConfig::set(local_user(), 'pumpio', 'mirror'         , defaults($_POST, 'pumpio_mirror', false));
+                       PConfig::set(local_user(), 'pumpio', 'post_by_default', defaults($_POST, 'pumpio_bydefault', false));
 
-                       if (!$_POST['pumpio_mirror']) {
+                       if (!empty($_POST['pumpio_mirror'])) {
                                PConfig::delete(local_user(), 'pumpio', 'lastdate');
                        }
-
-                       //header("Location: ".$a->get_baseurl()."/pumpio/connect");
                }
        }
 }
@@ -413,15 +412,15 @@ function pumpio_send(App $a, array &$b)
                return;
        }
 
-       logger("pumpio_send: parameter ".print_r($b, true), LOGGER_DATA);
+       Logger::log("pumpio_send: parameter ".print_r($b, true), Logger::DATA);
 
        if ($b['parent'] != $b['id']) {
                // Looking if its a reply to a pumpio post
-               $condition = ['id' => $b['parent'], 'network' => NETWORK_PUMPIO];
+               $condition = ['id' => $b['parent'], 'network' => Protocol::PUMPIO];
                $orig_post = Item::selectFirst([], $condition);
 
                if (!DBA::isResult($orig_post)) {
-                       logger("pumpio_send: no pumpio post ".$b["parent"]);
+                       Logger::log("pumpio_send: no pumpio post ".$b["parent"]);
                        return;
                } else {
                        $iscomment = true;
@@ -431,7 +430,7 @@ function pumpio_send(App $a, array &$b)
 
                $receiver = pumpio_getreceiver($a, $b);
 
-               logger("pumpio_send: receiver ".print_r($receiver, true));
+               Logger::log("pumpio_send: receiver ".print_r($receiver, true));
 
                if (!count($receiver) && ($b['private'] || !strstr($b['postopts'], 'pumpio'))) {
                        return;
@@ -563,13 +562,13 @@ function pumpio_send(App $a, array &$b)
                        }
 
                        $post_id = $user->object->id;
-                       logger('pumpio_send '.$username.': success '.$post_id);
+                       Logger::log('pumpio_send '.$username.': success '.$post_id);
                        if ($post_id && $iscomment) {
-                               logger('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$b['id']);
+                               Logger::log('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$b['id']);
                                Item::update(['extid' => $post_id], ['id' => $b['id']]);
                        }
                } else {
-                       logger('pumpio_send '.$username.': '.$url.' general error: ' . print_r($user, true));
+                       Logger::log('pumpio_send '.$username.': '.$url.' general error: ' . print_r($user, true));
 
                        $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", $b['uid']);
                        if (DBA::isResult($r)) {
@@ -578,7 +577,7 @@ function pumpio_send(App $a, array &$b)
 
                        $s = serialize(['url' => $url, 'item' => $b['id'], 'post' => $params]);
 
-                       Queue::add($a->contact, NETWORK_PUMPIO, $s);
+                       Queue::add($a->contact, Protocol::PUMPIO, $s);
                        notice(L10n::t('Pump.io post failed. Queued for retry.').EOL);
                }
        }
@@ -644,18 +643,18 @@ function pumpio_action(App $a, $uid, $uri, $action, $content = "")
        }
 
        if ($success) {
-               logger('pumpio_action '.$username.' '.$action.': success '.$uri);
+               Logger::log('pumpio_action '.$username.' '.$action.': success '.$uri);
        } else {
-               logger('pumpio_action '.$username.' '.$action.': general error: '.$uri.' '.print_r($user, true));
+               Logger::log('pumpio_action '.$username.' '.$action.': general error: '.$uri.' '.print_r($user, true));
 
-               $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", $b['uid']);
+               $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", $uid);
                if (DBA::isResult($r)) {
                        $a->contact = $r[0]["id"];
                }
 
                $s = serialize(['url' => $url, 'item' => $orig_post["id"], 'post' => $params]);
 
-               Queue::add($a->contact, NETWORK_PUMPIO, $s);
+               Queue::add($a->contact, Protocol::PUMPIO, $s);
                notice(L10n::t('Pump.io like failed. Queued for retry.').EOL);
        }
 }
@@ -675,16 +674,16 @@ function pumpio_sync(App $a)
        if ($last) {
                $next = $last + ($poll_interval * 60);
                if ($next > time()) {
-                       logger('pumpio: poll intervall not reached');
+                       Logger::log('pumpio: poll intervall not reached');
                        return;
                }
        }
-       logger('pumpio: cron_start');
+       Logger::log('pumpio: cron_start');
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'pumpio' AND `k` = 'mirror' AND `v` = '1' ORDER BY RAND() ");
        if (DBA::isResult($r)) {
                foreach ($r as $rr) {
-                       logger('pumpio: mirroring user '.$rr['uid']);
+                       Logger::log('pumpio: mirroring user '.$rr['uid']);
                        pumpio_fetchtimeline($a, $rr['uid']);
                }
        }
@@ -702,12 +701,12 @@ function pumpio_sync(App $a)
                        if ($abandon_days != 0) {
                                $user = q("SELECT `login_date` FROM `user` WHERE uid=%d AND `login_date` >= '%s'", $rr['uid'], $abandon_limit);
                                if (!DBA::isResult($user)) {
-                                       logger('abandoned account: timeline from user '.$rr['uid'].' will not be imported');
+                                       Logger::log('abandoned account: timeline from user '.$rr['uid'].' will not be imported');
                                        continue;
                                }
                        }
 
-                       logger('pumpio: importing timeline from user '.$rr['uid']);
+                       Logger::log('pumpio: importing timeline from user '.$rr['uid']);
                        pumpio_fetchinbox($a, $rr['uid']);
 
                        // check for new contacts once a day
@@ -725,7 +724,7 @@ function pumpio_sync(App $a)
                }
        }
 
-       logger('pumpio: cron_end');
+       Logger::log('pumpio: cron_end');
 
        Config::set('pumpio', 'last_poll', time());
 }
@@ -753,7 +752,7 @@ function pumpio_fetchtimeline(App $a, $uid)
                $application_name  = Config::get('pumpio', 'application_name');
        }
        if ($application_name == "") {
-               $application_name = $a->get_hostname();
+               $application_name = $a->getHostName();
        }
 
        $first_time = ($lastdate == "");
@@ -770,7 +769,7 @@ function pumpio_fetchtimeline(App $a, $uid)
 
        $url = 'https://'.$hostname.'/api/user/'.$username.'/feed/major';
 
-       logger('pumpio: fetching for user '.$uid.' '.$url.' C:'.$client->client_id.' CS:'.$client->client_secret.' T:'.$client->access_token.' TS:'.$client->access_token_secret);
+       Logger::log('pumpio: fetching for user '.$uid.' '.$url.' C:'.$client->client_id.' CS:'.$client->client_secret.' T:'.$client->access_token.' TS:'.$client->access_token_secret);
 
        $useraddr = $username.'@'.$hostname;
 
@@ -778,10 +777,11 @@ function pumpio_fetchtimeline(App $a, $uid)
                $success = $client->CallAPI($url, 'GET', [], ['FailOnAccessError'=>true], $user);
        } else {
                $success = false;
+               $user = [];
        }
 
        if (!$success) {
-               logger('pumpio: error fetching posts for user '.$uid." ".$useraddr." ".print_r($user, true));
+               Logger::log('pumpio: error fetching posts for user '.$uid." ".$useraddr." ".print_r($user, true));
                return;
        }
 
@@ -830,7 +830,7 @@ function pumpio_fetchtimeline(App $a, $uid)
                                $_REQUEST["source"] = "pump.io";
 
                                if (isset($post->object->id)) {
-                                       $_REQUEST['message_id'] = NETWORK_PUMPIO.":".$post->object->id;
+                                       $_REQUEST['message_id'] = Protocol::PUMPIO.":".$post->object->id;
                                }
 
                                if ($post->object->displayName != "") {
@@ -850,12 +850,12 @@ function pumpio_fetchtimeline(App $a, $uid)
                                        }
                                }
 
-                               logger('pumpio: posting for user '.$uid);
+                               Logger::log('pumpio: posting for user '.$uid);
 
                                require_once('mod/item.php');
 
                                item_post($a);
-                               logger('pumpio: posting done - user '.$uid);
+                               Logger::log('pumpio: posting done - user '.$uid);
                        }
                }
        }
@@ -879,11 +879,11 @@ function pumpio_dounlike(App $a, $uid, $self, $post, $own_id)
 
        $contactid = 0;
 
-       if (link_compare($post->actor->url, $own_id)) {
+       if (Strings::compareLink($post->actor->url, $own_id)) {
                $contactid = $self[0]['id'];
        } else {
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                       DBA::escape(normalise_link($post->actor->url)),
+                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                        intval($uid)
                );
 
@@ -899,9 +899,9 @@ function pumpio_dounlike(App $a, $uid, $self, $post, $own_id)
        Item::delete(['verb' => ACTIVITY_LIKE, 'uid' => $uid, 'contact-id' => $contactid, 'thr-parent' => $orig_post['uri']]);
 
        if (DBA::isResult($r)) {
-               logger("pumpio_dounlike: unliked existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+               Logger::log("pumpio_dounlike: unliked existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
        } else {
-               logger("pumpio_dounlike: not found. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+               Logger::log("pumpio_dounlike: not found. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
        }
 }
 
@@ -910,7 +910,7 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        require_once('include/items.php');
 
        if (empty($post->object->id)) {
-               logger('Got empty like: '.print_r($post, true), LOGGER_DEBUG);
+               Logger::log('Got empty like: '.print_r($post, true), Logger::DEBUG);
                return;
        }
 
@@ -931,14 +931,14 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
 
        $contactid = 0;
 
-       if (link_compare($post->actor->url, $own_id)) {
+       if (Strings::compareLink($post->actor->url, $own_id)) {
                $contactid = $self[0]['id'];
                $post->actor->displayName = $self[0]['name'];
                $post->actor->url = $self[0]['url'];
                $post->actor->image->url = $self[0]['photo'];
        } else {
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                       DBA::escape(normalise_link($post->actor->url)),
+                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                        intval($uid)
                );
 
@@ -952,8 +952,8 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        }
 
        $condition = ['verb' => ACTIVITY_LIKE, 'uid' => $uid, 'contact-id' => $contactid, 'thr-parent' => $orig_post['uri']];
-       if (DBA::exists('item', $condition)) {
-               logger("pumpio_dolike: found existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+       if (Item::exists($condition)) {
+               Logger::log("pumpio_dolike: found existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
                return;
        }
 
@@ -963,14 +963,16 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        $likedata['gravity'] = GRAVITY_ACTIVITY;
        $likedata['uid'] = $uid;
        $likedata['wall'] = 0;
-       $likedata['network'] = NETWORK_PUMPIO;
+       $likedata['network'] = Protocol::PUMPIO;
        $likedata['uri'] = Item::newURI($uid);
        $likedata['parent-uri'] = $orig_post["uri"];
        $likedata['contact-id'] = $contactid;
        $likedata['app'] = $post->generator->displayName;
        $likedata['author-name'] = $post->actor->displayName;
        $likedata['author-link'] = $post->actor->url;
-       $likedata['author-avatar'] = $post->actor->image->url;
+       if (!empty($post->actor->image)) {
+               $likedata['author-avatar'] = $post->actor->image->url;
+       }
 
        $author  = '[url=' . $likedata['author-link'] . ']' . $likedata['author-name'] . '[/url]';
        $objauthor =  '[url=' . $orig_post['author-link'] . ']' . $orig_post['author-name'] . '[/url]';
@@ -981,16 +983,16 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        $likedata['body'] = L10n::t('%1$s likes %2$s\'s %3$s', $author, $objauthor, $plink);
 
        $likedata['object'] = '<object><type>' . ACTIVITY_OBJ_NOTE . '</type><local>1</local>' .
-               '<id>' . $orig_post['uri'] . '</id><link>' . xmlify('<link rel="alternate" type="text/html" href="' . xmlify($orig_post['plink']) . '" />') . '</link><title>' . $orig_post['title'] . '</title><content>' . $orig_post['body'] . '</content></object>';
+               '<id>' . $orig_post['uri'] . '</id><link>' . XML::escape('<link rel="alternate" type="text/html" href="' . XML::escape($orig_post['plink']) . '" />') . '</link><title>' . $orig_post['title'] . '</title><content>' . $orig_post['body'] . '</content></object>';
 
        $ret = Item::insert($likedata);
 
-       logger("pumpio_dolike: ".$ret." User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+       Logger::log("pumpio_dolike: ".$ret." User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
 }
 
 function pumpio_get_contact($uid, $contact, $no_insert = false)
 {
-       $gcontact = ["url" => $contact->url, "network" => NETWORK_PUMPIO, "generation" => 2,
+       $gcontact = ["url" => $contact->url, "network" => Protocol::PUMPIO, "generation" => 2,
                "name" => $contact->displayName,  "hide" => true,
                "nick" => $contact->preferredUsername,
                "addr" => str_replace("acct:", "", $contact->id)];
@@ -1015,7 +1017,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
        }
 
        $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1",
-               intval($uid), DBA::escape(normalise_link($contact->url)));
+               intval($uid), DBA::escape(Strings::normaliseLink($contact->url)));
 
        if (!DBA::isResult($r)) {
                // create contact record
@@ -1026,7 +1028,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
                        intval($uid),
                        DBA::escape(DateTimeFormat::utcNow()),
                        DBA::escape($contact->url),
-                       DBA::escape(normalise_link($contact->url)),
+                       DBA::escape(Strings::normaliseLink($contact->url)),
                        DBA::escape(str_replace("acct:", "", $contact->id)),
                        DBA::escape(''),
                        DBA::escape($contact->id), // What is it for?
@@ -1034,7 +1036,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
                        DBA::escape($contact->displayName),
                        DBA::escape($contact->preferredUsername),
                        DBA::escape($contact->image->url),
-                       DBA::escape(NETWORK_PUMPIO),
+                       DBA::escape(Protocol::PUMPIO),
                        intval(Contact::FRIEND),
                        intval(1),
                        DBA::escape($contact->location->displayName),
@@ -1043,7 +1045,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
                );
 
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d LIMIT 1",
-                       DBA::escape(normalise_link($contact->url)),
+                       DBA::escape(Strings::normaliseLink($contact->url)),
                        intval($uid)
                        );
 
@@ -1079,13 +1081,13 @@ function pumpio_dodelete(App $a, $uid, $self, $post, $own_id)
 {
        // Two queries for speed issues
        $condition = ['uri' => $post->object->id, 'uid' => $uid];
-       if (DBA::exists('item', $condition)) {
+       if (Item::exists($condition)) {
                Item::delete($condition);
                return true;
        }
 
        $condition = ['extid' => $post->object->id, 'uid' => $uid];
-       if (DBA::exists('item', $condition)) {
+       if (Item::exists($condition)) {
                Item::delete($condition);
                return true;
        }
@@ -1110,10 +1112,10 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
 
        if ($post->verb != "update") {
                // Two queries for speed issues
-               if (DBA::exists('item', ['uri' => $post->object->id, 'uid' => $uid])) {
+               if (Item::exists(['uri' => $post->object->id, 'uid' => $uid])) {
                        return false;
                }
-               if (DBA::exists('item', ['extid' => $post->object->id, 'uid' => $uid])) {
+               if (Item::exists(['extid' => $post->object->id, 'uid' => $uid])) {
                        return false;
                }
        }
@@ -1141,7 +1143,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
        }
 
        $postarray = [];
-       $postarray['network'] = NETWORK_PUMPIO;
+       $postarray['network'] = Protocol::PUMPIO;
        $postarray['uid'] = $uid;
        $postarray['wall'] = 0;
        $postarray['uri'] = $post->object->id;
@@ -1163,7 +1165,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
        } else {
                $contact_id = pumpio_get_contact($uid, $post->actor, true);
 
-               if (link_compare($post->actor->url, $own_id)) {
+               if (Strings::compareLink($post->actor->url, $own_id)) {
                        $contact_id = $self[0]['id'];
                        $post->actor->displayName = $self[0]['name'];
                        $post->actor->url = $self[0]['url'];
@@ -1171,7 +1173,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                } elseif ($contact_id == 0) {
                        // Take an existing contact, the contact of the note or - as a fallback - the id of the user
                        $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                               DBA::escape(normalise_link($post->actor->url)),
+                               DBA::escape(Strings::normaliseLink($post->actor->url)),
                                intval($uid)
                        );
 
@@ -1179,7 +1181,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                                $contact_id = $r[0]['id'];
                        } else {
                                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                                       DBA::escape(normalise_link($post->actor->url)),
+                                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                                        intval($uid)
                                );
 
@@ -1198,7 +1200,10 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                        $reply->cc = $post->cc;
                }
 
-               $reply->to = $post->to;
+               if (isset($post->to)) {
+                       $reply->to = $post->to;
+               }
+
                $reply->object = new stdClass;
                $reply->object->objectType = $post->object->inReplyTo->objectType;
                $reply->object->content = $post->object->inReplyTo->content;
@@ -1215,6 +1220,11 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                $postarray['parent-uri'] = $post->object->inReplyTo->id;
        }
 
+       // When there is no content there is no need to continue
+       if (empty($post->object->content)) {
+               return false;
+       }
+
        if (!empty($post->object->pump_io->proxyURL)) {
                $postarray['extid'] = $post->object->pump_io->proxyURL;
        }
@@ -1223,12 +1233,15 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
        $postarray['verb'] = ACTIVITY_POST;
        $postarray['owner-name'] = $post->actor->displayName;
        $postarray['owner-link'] = $post->actor->url;
-       $postarray['owner-avatar'] = $post->actor->image->url;
-       $postarray['author-name'] = $post->actor->displayName;
-       $postarray['author-link'] = $post->actor->url;
-       $postarray['author-avatar'] = $post->actor->image->url;
+       $postarray['author-name'] = $postarray['owner-name'];
+       $postarray['author-link'] = $postarray['owner-link'];
+       if (!empty($post->actor->image)) {
+               $postarray['owner-avatar'] = $post->actor->image->url;
+               $postarray['author-avatar'] = $postarray['owner-avatar'];
+       }
        $postarray['plink'] = $post->object->url;
        $postarray['app'] = $post->generator->displayName;
+       $postarray['title'] = '';
        $postarray['body'] = HTML::toBBCode($post->object->content);
        $postarray['object'] = json_encode($post);
 
@@ -1258,10 +1271,15 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                        $share_author = $post->object->author->url;
                }
 
+               if (isset($post->object->created)) {
+                       $created = DateTimeFormat::utc($post->object->created);
+               } else {
+                       $created = '';
+               }
+
                $postarray['body'] = share_header($share_author, $post->object->author->url,
                                                $post->object->author->image->url, "",
-                                               DateTimeFormat::utc($post->object->created),
-                                               $post->links->self->href).
+                                               $created, $post->links->self->href).
                                        $postarray['body']."[/share]";
        }
 
@@ -1304,7 +1322,7 @@ function pumpio_fetchinbox(App $a, $uid)
                        INNER JOIN `item` ON `item`.`id` = `thread`.`iid`
                        WHERE `thread`.`network` = '%s' AND `thread`.`uid` = %d AND `item`.`extid` != ''
                        ORDER BY `thread`.`commented` DESC LIMIT 10",
-                               DBA::escape(NETWORK_PUMPIO),
+                               DBA::escape(Protocol::PUMPIO),
                                intval($uid)
                        );
 
@@ -1381,6 +1399,10 @@ function pumpio_getallusers(App &$a, $uid)
                $success = false;
        }
 
+       if (empty($users)) {
+               return;
+       }
+
        if ($users->totalItems > count($users->items)) {
                $url = 'https://'.$hostname.'/api/user/'.$username.'/following?count='.$users->totalItems;
 
@@ -1401,7 +1423,7 @@ function pumpio_getallusers(App &$a, $uid)
 function pumpio_queue_hook(App $a, array &$b)
 {
        $qi = q("SELECT * FROM `queue` WHERE `network` = '%s'",
-               DBA::escape(NETWORK_PUMPIO)
+               DBA::escape(Protocol::PUMPIO)
        );
 
        if (!DBA::isResult($qi)) {
@@ -1409,11 +1431,11 @@ function pumpio_queue_hook(App $a, array &$b)
        }
 
        foreach ($qi as $x) {
-               if ($x['network'] !== NETWORK_PUMPIO) {
+               if ($x['network'] !== Protocol::PUMPIO) {
                        continue;
                }
 
-               logger('pumpio_queue: run');
+               Logger::log('pumpio_queue: run');
 
                $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` ON `contact`.`uid` = `user`.`uid`
                        WHERE `contact`.`self` = 1 AND `contact`.`id` = %d LIMIT 1",
@@ -1425,7 +1447,7 @@ function pumpio_queue_hook(App $a, array &$b)
 
                $userdata = $r[0];
 
-               //logger('pumpio_queue: fetching userdata '.print_r($userdata, true));
+               //Logger::log('pumpio_queue: fetching userdata '.print_r($userdata, true));
 
                $oauth_token        = PConfig::get($userdata['uid'], "pumpio", "oauth_token");
                $oauth_token_secret = PConfig::get($userdata['uid'], "pumpio", "oauth_token_secret");
@@ -1441,7 +1463,7 @@ function pumpio_queue_hook(App $a, array &$b)
                        $consumer_key && $consumer_secret) {
                        $username = $user.'@'.$host;
 
-                       logger('pumpio_queue: able to post for user '.$username);
+                       Logger::log('pumpio_queue: able to post for user '.$username);
 
                        $z = unserialize($x['content']);
 
@@ -1462,21 +1484,21 @@ function pumpio_queue_hook(App $a, array &$b)
 
                        if ($success) {
                                $post_id = $user->object->id;
-                               logger('pumpio_queue: send '.$username.': success '.$post_id);
+                               Logger::log('pumpio_queue: send '.$username.': success '.$post_id);
                                if ($post_id && $iscomment) {
-                                       logger('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$z['item']);
+                                       Logger::log('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$z['item']);
                                        Item::update(['extid' => $post_id], ['id' => $z['item']]);
                                }
                                Queue::removeItem($x['id']);
                        } else {
-                               logger('pumpio_queue: send '.$username.': '.$z['url'].' general error: ' . print_r($user, true));
+                               Logger::log('pumpio_queue: send '.$username.': '.$z['url'].' general error: ' . print_r($user, true));
                        }
                } else {
-                       logger("pumpio_queue: Error getting tokens for user ".$userdata['uid']);
+                       Logger::log("pumpio_queue: Error getting tokens for user ".$userdata['uid']);
                }
 
                if (!$success) {
-                       logger('pumpio_queue: delayed');
+                       Logger::log('pumpio_queue: delayed');
                        Queue::updateTime($x['id']);
                }
        }
@@ -1508,7 +1530,7 @@ function pumpio_getreceiver(App $a, array $b)
                        $r = q("SELECT `name`, `nick`, `url` FROM `contact` WHERE `id` = %d AND `uid` = %d AND `network` = '%s' AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
                                intval($cid),
                                intval($b["uid"]),
-                               DBA::escape(NETWORK_PUMPIO)
+                               DBA::escape(Protocol::PUMPIO)
                                );
 
                        if (DBA::isResult($r)) {
@@ -1526,7 +1548,7 @@ function pumpio_getreceiver(App $a, array $b)
                                "FROM `group_member`, `contact` WHERE `group_member`.`gid` = %d ".
                                "AND `contact`.`id` = `group_member`.`contact-id` AND `contact`.`network` = '%s'",
                                        intval($gid),
-                                       DBA::escape(NETWORK_PUMPIO)
+                                       DBA::escape(Protocol::PUMPIO)
                                );
 
                        foreach ($r AS $row)
@@ -1551,7 +1573,7 @@ function pumpio_getreceiver(App $a, array $b)
                        $r = q("SELECT `name`, `nick`, `url` FROM `contact` WHERE `id` = %d AND `uid` = %d AND `network` = '%s' AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
                                intval($cid),
                                intval($b["uid"]),
-                               DBA::escape(NETWORK_PUMPIO)
+                               DBA::escape(Protocol::PUMPIO)
                                );
 
                        if (DBA::isResult($r)) {
@@ -1576,7 +1598,7 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
        $hostname = PConfig::get($uid, 'pumpio', 'host');
        $username = PConfig::get($uid, "pumpio", "user");
 
-       logger("pumpio_fetchallcomments: completing comment for user ".$uid." post id ".$id);
+       Logger::log("pumpio_fetchallcomments: completing comment for user ".$uid." post id ".$id);
 
        $own_id = "https://".$hostname."/".$username;
 
@@ -1602,7 +1624,7 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
        $client->access_token = $otoken;
        $client->access_token_secret = $osecret;
 
-       logger("pumpio_fetchallcomments: fetching comment for user ".$uid." url ".$url);
+       Logger::log("pumpio_fetchallcomments: fetching comment for user ".$uid." url ".$url);
 
        if (pumpio_reachable($url)) {
                $success = $client->CallAPI($url, 'GET', [], ['FailOnAccessError'=>true], $item);
@@ -1642,11 +1664,11 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
                }
 
                // Checking if the comment already exists - Two queries for speed issues
-               if (DBA::exists('item', ['uri' => $item->id, 'uid' => $uid])) {
+               if (Item::exists(['uri' => $item->id, 'uid' => $uid])) {
                        continue;
                }
 
-               if (DBA::exists('item', ['extid' => $item->id, 'uid' => $uid])) {
+               if (Item::exists(['extid' => $item->id, 'uid' => $uid])) {
                        continue;
                }
 
@@ -1665,15 +1687,14 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
 
                $post->object = $item;
 
-               logger("pumpio_fetchallcomments: posting comment ".$post->object->id." ".print_r($post, true));
+               Logger::log("pumpio_fetchallcomments: posting comment ".$post->object->id." ".print_r($post, true));
                pumpio_dopost($a, $client, $uid, $self, $post, $own_id, false);
        }
 }
 
 function pumpio_reachable($url)
 {
-       $data = Network::curl($url, false, $redirects, ['timeout'=>10]);
-       return intval($data['return_code']) != 0;
+       return Network::curl($url, false, $redirects, ['timeout'=>10])->isSuccess();
 }
 
 /*