]> git.mxchange.org Git - friendica-addons.git/blobdiff - pumpio/pumpio.php
buffer addon added CA translation THX obiolscat
[friendica-addons.git] / pumpio / pumpio.php
index 6217f4d5315d053e55edcf539afe397bc5be0d49..8731e251390616a023aa38faf45f9044a710962c 100644 (file)
@@ -9,53 +9,54 @@
 use Friendica\App;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
-use Friendica\Core\Addon;
 use Friendica\Core\Config;
+use Friendica\Core\Hook;
 use Friendica\Core\L10n;
+use Friendica\Core\Logger;
 use Friendica\Core\PConfig;
 use Friendica\Core\Protocol;
 use Friendica\Core\Worker;
 use Friendica\Database\DBA;
 use Friendica\Model\Contact;
-use Friendica\Model\GContact;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
-use Friendica\Model\Queue;
 use Friendica\Model\User;
+use Friendica\Util\ConfigFileLoader;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Strings;
+use Friendica\Util\XML;
 
 require 'addon/pumpio/oauth/http.php';
 require 'addon/pumpio/oauth/oauth_client.php';
-require_once 'include/enotify.php';
 require_once "mod/share.php";
 
 define('PUMPIO_DEFAULT_POLL_INTERVAL', 5); // given in minutes
 
 function pumpio_install()
 {
-       Addon::registerHook('load_config',          'addon/pumpio/pumpio.php', 'pumpio_load_config');
-       Addon::registerHook('post_local',           'addon/pumpio/pumpio.php', 'pumpio_post_local');
-       Addon::registerHook('notifier_normal',      'addon/pumpio/pumpio.php', 'pumpio_send');
-       Addon::registerHook('jot_networks',         'addon/pumpio/pumpio.php', 'pumpio_jot_nets');
-       Addon::registerHook('connector_settings',      'addon/pumpio/pumpio.php', 'pumpio_settings');
-       Addon::registerHook('connector_settings_post', 'addon/pumpio/pumpio.php', 'pumpio_settings_post');
-       Addon::registerHook('cron', 'addon/pumpio/pumpio.php', 'pumpio_cron');
-       Addon::registerHook('queue_predeliver', 'addon/pumpio/pumpio.php', 'pumpio_queue_hook');
-       Addon::registerHook('check_item_notification', 'addon/pumpio/pumpio.php', 'pumpio_check_item_notification');
+       Hook::register('load_config',          'addon/pumpio/pumpio.php', 'pumpio_load_config');
+       Hook::register('hook_fork',            'addon/pumpio/pumpio.php', 'hook_fork');
+       Hook::register('post_local',           'addon/pumpio/pumpio.php', 'pumpio_post_local');
+       Hook::register('notifier_normal',      'addon/pumpio/pumpio.php', 'pumpio_send');
+       Hook::register('jot_networks',         'addon/pumpio/pumpio.php', 'pumpio_jot_nets');
+       Hook::register('connector_settings',      'addon/pumpio/pumpio.php', 'pumpio_settings');
+       Hook::register('connector_settings_post', 'addon/pumpio/pumpio.php', 'pumpio_settings_post');
+       Hook::register('cron', 'addon/pumpio/pumpio.php', 'pumpio_cron');
+       Hook::register('check_item_notification', 'addon/pumpio/pumpio.php', 'pumpio_check_item_notification');
 }
 
 function pumpio_uninstall()
 {
-       Addon::unregisterHook('load_config',      'addon/pumpio/pumpio.php', 'pumpio_load_config');
-       Addon::unregisterHook('post_local',       'addon/pumpio/pumpio.php', 'pumpio_post_local');
-       Addon::unregisterHook('notifier_normal',  'addon/pumpio/pumpio.php', 'pumpio_send');
-       Addon::unregisterHook('jot_networks',     'addon/pumpio/pumpio.php', 'pumpio_jot_nets');
-       Addon::unregisterHook('connector_settings',      'addon/pumpio/pumpio.php', 'pumpio_settings');
-       Addon::unregisterHook('connector_settings_post', 'addon/pumpio/pumpio.php', 'pumpio_settings_post');
-       Addon::unregisterHook('cron', 'addon/pumpio/pumpio.php', 'pumpio_cron');
-       Addon::unregisterHook('queue_predeliver', 'addon/pumpio/pumpio.php', 'pumpio_queue_hook');
-       Addon::unregisterHook('check_item_notification', 'addon/pumpio/pumpio.php', 'pumpio_check_item_notification');
+       Hook::unregister('load_config',      'addon/pumpio/pumpio.php', 'pumpio_load_config');
+       Hook::unregister('hook_fork',        'addon/pumpio/pumpio.php', 'pumpio_hook_fork');
+       Hook::unregister('post_local',       'addon/pumpio/pumpio.php', 'pumpio_post_local');
+       Hook::unregister('notifier_normal',  'addon/pumpio/pumpio.php', 'pumpio_send');
+       Hook::unregister('jot_networks',     'addon/pumpio/pumpio.php', 'pumpio_jot_nets');
+       Hook::unregister('connector_settings',      'addon/pumpio/pumpio.php', 'pumpio_settings');
+       Hook::unregister('connector_settings_post', 'addon/pumpio/pumpio.php', 'pumpio_settings_post');
+       Hook::unregister('cron', 'addon/pumpio/pumpio.php', 'pumpio_cron');
+       Hook::unregister('check_item_notification', 'addon/pumpio/pumpio.php', 'pumpio_check_item_notification');
 }
 
 function pumpio_module() {}
@@ -114,7 +115,7 @@ function pumpio_registerclient(App $a, $host)
        $params["logo_url"] = $a->getBaseURL()."/images/friendica-256.png";
        $params["redirect_uris"] = $a->getBaseURL()."/pumpio/connect";
 
-       logger("pumpio_registerclient: ".$url." parameters ".print_r($params, true), LOGGER_DEBUG);
+       Logger::log("pumpio_registerclient: ".$url." parameters ".print_r($params, true), Logger::DEBUG);
 
        $ch = curl_init($url);
        curl_setopt($ch, CURLOPT_HEADER, false);
@@ -128,10 +129,10 @@ function pumpio_registerclient(App $a, $host)
 
        if ($curl_info["http_code"] == "200") {
                $values = json_decode($s);
-               logger("pumpio_registerclient: success ".print_r($values, true), LOGGER_DEBUG);
+               Logger::log("pumpio_registerclient: success ".print_r($values, true), Logger::DEBUG);
                return $values;
        }
-       logger("pumpio_registerclient: failed: ".print_r($curl_info, true), LOGGER_DEBUG);
+       Logger::log("pumpio_registerclient: failed: ".print_r($curl_info, true), Logger::DEBUG);
        return false;
 
 }
@@ -144,7 +145,7 @@ function pumpio_connect(App $a)
        $hostname = PConfig::get(local_user(), 'pumpio', 'host');
 
        if ((($consumer_key == "") || ($consumer_secret == "")) && ($hostname != "")) {
-               logger("pumpio_connect: register client");
+               Logger::log("pumpio_connect: register client");
                $clientdata = pumpio_registerclient($a, $hostname);
                PConfig::set(local_user(), 'pumpio', 'consumer_key', $clientdata->client_id);
                PConfig::set(local_user(), 'pumpio', 'consumer_secret', $clientdata->client_secret);
@@ -152,11 +153,11 @@ function pumpio_connect(App $a)
                $consumer_key = PConfig::get(local_user(), 'pumpio', 'consumer_key');
                $consumer_secret = PConfig::get(local_user(), 'pumpio', 'consumer_secret');
 
-               logger("pumpio_connect: ckey: ".$consumer_key." csecrect: ".$consumer_secret, LOGGER_DEBUG);
+               Logger::log("pumpio_connect: ckey: ".$consumer_key." csecrect: ".$consumer_secret, Logger::DEBUG);
        }
 
        if (($consumer_key == "") || ($consumer_secret == "")) {
-               logger("pumpio_connect: ".sprintf("Unable to register the client at the pump.io server '%s'.", $hostname));
+               Logger::log("pumpio_connect: ".sprintf("Unable to register the client at the pump.io server '%s'.", $hostname));
 
                $o .= L10n::t("Unable to register the client at the pump.io server '%s'.", $hostname);
                return $o;
@@ -186,7 +187,7 @@ function pumpio_connect(App $a)
        if (($success = $client->Initialize())) {
                if (($success = $client->Process())) {
                        if (strlen($client->access_token)) {
-                               logger("pumpio_connect: otoken: ".$client->access_token." osecrect: ".$client->access_token_secret, LOGGER_DEBUG);
+                               Logger::log("pumpio_connect: otoken: ".$client->access_token." osecrect: ".$client->access_token_secret, Logger::DEBUG);
                                PConfig::set(local_user(), "pumpio", "oauth_token", $client->access_token);
                                PConfig::set(local_user(), "pumpio", "oauth_token_secret", $client->access_token_secret);
                        }
@@ -198,30 +199,32 @@ function pumpio_connect(App $a)
        }
 
        if ($success) {
-               logger("pumpio_connect: authenticated");
+               Logger::log("pumpio_connect: authenticated");
                $o = L10n::t("You are now authenticated to pumpio.");
                $o .= '<br /><a href="'.$a->getBaseURL().'/settings/connectors">'.L10n::t("return to the connector page").'</a>';
        } else {
-               logger("pumpio_connect: could not connect");
+               Logger::log("pumpio_connect: could not connect");
                $o = 'Could not connect to pumpio. Refresh the page or try again later.';
        }
 
        return $o;
 }
 
-function pumpio_jot_nets(App $a, &$b)
+function pumpio_jot_nets(App $a, array &$jotnets_fields)
 {
        if (! local_user()) {
                return;
        }
 
-       $pumpio_post = PConfig::get(local_user(), 'pumpio', 'post');
-
-       if (intval($pumpio_post) == 1) {
-               $pumpio_defpost = PConfig::get(local_user(), 'pumpio', 'post_by_default');
-               $selected = ((intval($pumpio_defpost) == 1) ? ' checked="checked" ' : '');
-               $b .= '<div class="profile-jot-net"><input type="checkbox" name="pumpio_enable"' . $selected . ' value="1" /> '
-                       . L10n::t('Post to pumpio') . '</div>';
+       if (PConfig::get(local_user(), 'pumpio', 'post')) {
+               $jotnets_fields[] = [
+                       'type' => 'checkbox',
+                       'field' => [
+                               'pumpio_enable',
+                               L10n::t('Post to pumpio'),
+                               PConfig::get(local_user(), 'pumpio', 'post_by_default')
+                       ]
+               ];
        }
 }
 
@@ -373,9 +376,45 @@ function pumpio_settings_post(App $a, array &$b)
        }
 }
 
-function pumpio_load_config(App $a)
+function pumpio_load_config(App $a, ConfigFileLoader $loader)
+{
+       $a->getConfigCache()->load($loader->loadAddonConfig('pumpio'));
+}
+
+function pumpio_hook_fork(App $a, array &$b)
 {
-       $a->loadConfigFile(__DIR__. '/config/pumpio.ini.php');
+        if ($b['name'] != 'notifier_normal') {
+                return;
+        }
+
+        $post = $b['data'];
+
+        // Deleting and editing is not supported by the addon (deleting could, but isn't by now)
+        if ($post['deleted'] || ($post['created'] !== $post['edited'])) {
+                $b['execute'] = false;
+                return;
+        }
+
+        // if post comes from pump.io don't send it back
+       if ($post['app'] == "pump.io") {
+                $b['execute'] = false;
+                return;
+        }
+
+        if (PConfig::get($post['uid'], 'pumpio', 'import')) {
+                // Don't fork if it isn't a reply to a pump.io post
+                if (($post['parent'] != $post['id']) && !Item::exists(['id' => $post['parent'], 'network' => Protocol::PUMPIO])) {
+                        Logger::log('No pump.io parent found for item ' . $post['id']);
+                        $b['execute'] = false;
+                        return;
+                }
+        } else {
+                // Comments are never exported when we don't import the pumpio timeline
+                if (!strstr($post['postopts'], 'pumpio') || ($post['parent'] != $post['id']) || $post['private']) {
+                        $b['execute'] = false;
+                        return;
+                }
+        }
 }
 
 function pumpio_post_local(App $a, array &$b)
@@ -409,7 +448,7 @@ function pumpio_send(App $a, array &$b)
                return;
        }
 
-       logger("pumpio_send: parameter ".print_r($b, true), LOGGER_DATA);
+       Logger::log("pumpio_send: parameter ".print_r($b, true), Logger::DATA);
 
        if ($b['parent'] != $b['id']) {
                // Looking if its a reply to a pumpio post
@@ -417,7 +456,7 @@ function pumpio_send(App $a, array &$b)
                $orig_post = Item::selectFirst([], $condition);
 
                if (!DBA::isResult($orig_post)) {
-                       logger("pumpio_send: no pumpio post ".$b["parent"]);
+                       Logger::log("pumpio_send: no pumpio post ".$b["parent"]);
                        return;
                } else {
                        $iscomment = true;
@@ -427,7 +466,7 @@ function pumpio_send(App $a, array &$b)
 
                $receiver = pumpio_getreceiver($a, $b);
 
-               logger("pumpio_send: receiver ".print_r($receiver, true));
+               Logger::log("pumpio_send: receiver ".print_r($receiver, true));
 
                if (!count($receiver) && ($b['private'] || !strstr($b['postopts'], 'pumpio'))) {
                        return;
@@ -559,23 +598,14 @@ function pumpio_send(App $a, array &$b)
                        }
 
                        $post_id = $user->object->id;
-                       logger('pumpio_send '.$username.': success '.$post_id);
+                       Logger::log('pumpio_send '.$username.': success '.$post_id);
                        if ($post_id && $iscomment) {
-                               logger('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$b['id']);
+                               Logger::log('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$b['id']);
                                Item::update(['extid' => $post_id], ['id' => $b['id']]);
                        }
                } else {
-                       logger('pumpio_send '.$username.': '.$url.' general error: ' . print_r($user, true));
-
-                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", $b['uid']);
-                       if (DBA::isResult($r)) {
-                               $a->contact = $r[0]["id"];
-                       }
-
-                       $s = serialize(['url' => $url, 'item' => $b['id'], 'post' => $params]);
-
-                       Queue::add($a->contact, Protocol::PUMPIO, $s);
-                       notice(L10n::t('Pump.io post failed. Queued for retry.').EOL);
+                       Logger::log('pumpio_send '.$username.': '.$url.' general error: ' . print_r($user, true));
+                       Worker::defer();
                }
        }
 }
@@ -640,19 +670,10 @@ function pumpio_action(App $a, $uid, $uri, $action, $content = "")
        }
 
        if ($success) {
-               logger('pumpio_action '.$username.' '.$action.': success '.$uri);
+               Logger::log('pumpio_action '.$username.' '.$action.': success '.$uri);
        } else {
-               logger('pumpio_action '.$username.' '.$action.': general error: '.$uri.' '.print_r($user, true));
-
-               $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `self`", $uid);
-               if (DBA::isResult($r)) {
-                       $a->contact = $r[0]["id"];
-               }
-
-               $s = serialize(['url' => $url, 'item' => $orig_post["id"], 'post' => $params]);
-
-               Queue::add($a->contact, Protocol::PUMPIO, $s);
-               notice(L10n::t('Pump.io like failed. Queued for retry.').EOL);
+               Logger::log('pumpio_action '.$username.' '.$action.': general error: '.$uri.' '.print_r($user, true));
+               Worker::defer();
        }
 }
 
@@ -671,16 +692,16 @@ function pumpio_sync(App $a)
        if ($last) {
                $next = $last + ($poll_interval * 60);
                if ($next > time()) {
-                       logger('pumpio: poll intervall not reached');
+                       Logger::log('pumpio: poll intervall not reached');
                        return;
                }
        }
-       logger('pumpio: cron_start');
+       Logger::log('pumpio: cron_start');
 
        $r = q("SELECT * FROM `pconfig` WHERE `cat` = 'pumpio' AND `k` = 'mirror' AND `v` = '1' ORDER BY RAND() ");
        if (DBA::isResult($r)) {
                foreach ($r as $rr) {
-                       logger('pumpio: mirroring user '.$rr['uid']);
+                       Logger::log('pumpio: mirroring user '.$rr['uid']);
                        pumpio_fetchtimeline($a, $rr['uid']);
                }
        }
@@ -698,12 +719,12 @@ function pumpio_sync(App $a)
                        if ($abandon_days != 0) {
                                $user = q("SELECT `login_date` FROM `user` WHERE uid=%d AND `login_date` >= '%s'", $rr['uid'], $abandon_limit);
                                if (!DBA::isResult($user)) {
-                                       logger('abandoned account: timeline from user '.$rr['uid'].' will not be imported');
+                                       Logger::log('abandoned account: timeline from user '.$rr['uid'].' will not be imported');
                                        continue;
                                }
                        }
 
-                       logger('pumpio: importing timeline from user '.$rr['uid']);
+                       Logger::log('pumpio: importing timeline from user '.$rr['uid']);
                        pumpio_fetchinbox($a, $rr['uid']);
 
                        // check for new contacts once a day
@@ -721,7 +742,7 @@ function pumpio_sync(App $a)
                }
        }
 
-       logger('pumpio: cron_end');
+       Logger::log('pumpio: cron_end');
 
        Config::set('pumpio', 'last_poll', time());
 }
@@ -766,7 +787,7 @@ function pumpio_fetchtimeline(App $a, $uid)
 
        $url = 'https://'.$hostname.'/api/user/'.$username.'/feed/major';
 
-       logger('pumpio: fetching for user '.$uid.' '.$url.' C:'.$client->client_id.' CS:'.$client->client_secret.' T:'.$client->access_token.' TS:'.$client->access_token_secret);
+       Logger::log('pumpio: fetching for user '.$uid.' '.$url.' C:'.$client->client_id.' CS:'.$client->client_secret.' T:'.$client->access_token.' TS:'.$client->access_token_secret);
 
        $useraddr = $username.'@'.$hostname;
 
@@ -778,7 +799,7 @@ function pumpio_fetchtimeline(App $a, $uid)
        }
 
        if (!$success) {
-               logger('pumpio: error fetching posts for user '.$uid." ".$useraddr." ".print_r($user, true));
+               Logger::log('pumpio: error fetching posts for user '.$uid." ".$useraddr." ".print_r($user, true));
                return;
        }
 
@@ -847,12 +868,12 @@ function pumpio_fetchtimeline(App $a, $uid)
                                        }
                                }
 
-                               logger('pumpio: posting for user '.$uid);
+                               Logger::log('pumpio: posting for user '.$uid);
 
                                require_once('mod/item.php');
 
                                item_post($a);
-                               logger('pumpio: posting done - user '.$uid);
+                               Logger::log('pumpio: posting done - user '.$uid);
                        }
                }
        }
@@ -876,11 +897,11 @@ function pumpio_dounlike(App $a, $uid, $self, $post, $own_id)
 
        $contactid = 0;
 
-       if (link_compare($post->actor->url, $own_id)) {
+       if (Strings::compareLink($post->actor->url, $own_id)) {
                $contactid = $self[0]['id'];
        } else {
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                       DBA::escape(normalise_link($post->actor->url)),
+                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                        intval($uid)
                );
 
@@ -896,9 +917,9 @@ function pumpio_dounlike(App $a, $uid, $self, $post, $own_id)
        Item::delete(['verb' => ACTIVITY_LIKE, 'uid' => $uid, 'contact-id' => $contactid, 'thr-parent' => $orig_post['uri']]);
 
        if (DBA::isResult($r)) {
-               logger("pumpio_dounlike: unliked existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+               Logger::log("pumpio_dounlike: unliked existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
        } else {
-               logger("pumpio_dounlike: not found. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+               Logger::log("pumpio_dounlike: not found. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
        }
 }
 
@@ -907,7 +928,7 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        require_once('include/items.php');
 
        if (empty($post->object->id)) {
-               logger('Got empty like: '.print_r($post, true), LOGGER_DEBUG);
+               Logger::log('Got empty like: '.print_r($post, true), Logger::DEBUG);
                return;
        }
 
@@ -928,14 +949,14 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
 
        $contactid = 0;
 
-       if (link_compare($post->actor->url, $own_id)) {
+       if (Strings::compareLink($post->actor->url, $own_id)) {
                $contactid = $self[0]['id'];
                $post->actor->displayName = $self[0]['name'];
                $post->actor->url = $self[0]['url'];
                $post->actor->image->url = $self[0]['photo'];
        } else {
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                       DBA::escape(normalise_link($post->actor->url)),
+                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                        intval($uid)
                );
 
@@ -950,7 +971,7 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
 
        $condition = ['verb' => ACTIVITY_LIKE, 'uid' => $uid, 'contact-id' => $contactid, 'thr-parent' => $orig_post['uri']];
        if (Item::exists($condition)) {
-               logger("pumpio_dolike: found existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+               Logger::log("pumpio_dolike: found existing like. User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
                return;
        }
 
@@ -980,33 +1001,15 @@ function pumpio_dolike(App $a, $uid, $self, $post, $own_id, $threadcompletion =
        $likedata['body'] = L10n::t('%1$s likes %2$s\'s %3$s', $author, $objauthor, $plink);
 
        $likedata['object'] = '<object><type>' . ACTIVITY_OBJ_NOTE . '</type><local>1</local>' .
-               '<id>' . $orig_post['uri'] . '</id><link>' . xmlify('<link rel="alternate" type="text/html" href="' . xmlify($orig_post['plink']) . '" />') . '</link><title>' . $orig_post['title'] . '</title><content>' . $orig_post['body'] . '</content></object>';
+               '<id>' . $orig_post['uri'] . '</id><link>' . XML::escape('<link rel="alternate" type="text/html" href="' . XML::escape($orig_post['plink']) . '" />') . '</link><title>' . $orig_post['title'] . '</title><content>' . $orig_post['body'] . '</content></object>';
 
        $ret = Item::insert($likedata);
 
-       logger("pumpio_dolike: ".$ret." User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
+       Logger::log("pumpio_dolike: ".$ret." User ".$own_id." ".$uid." Contact: ".$contactid." Url ".$orig_post['uri']);
 }
 
 function pumpio_get_contact($uid, $contact, $no_insert = false)
 {
-       $gcontact = ["url" => $contact->url, "network" => Protocol::PUMPIO, "generation" => 2,
-               "name" => $contact->displayName,  "hide" => true,
-               "nick" => $contact->preferredUsername,
-               "addr" => str_replace("acct:", "", $contact->id)];
-
-       if (!empty($contact->location->displayName)) {
-               $gcontact["location"] = $contact->location->displayName;
-       }
-
-       if (!empty($contact->summary)) {
-               $gcontact["about"] = $contact->summary;
-       }
-
-       if (!empty($contact->image->url)) {
-               $gcontact["photo"] = $contact->image->url;
-       }
-
-       GContact::update($gcontact);
        $cid = Contact::getIdForURL($contact->url, $uid);
 
        if ($no_insert) {
@@ -1014,7 +1017,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
        }
 
        $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1",
-               intval($uid), DBA::escape(normalise_link($contact->url)));
+               intval($uid), DBA::escape(Strings::normaliseLink($contact->url)));
 
        if (!DBA::isResult($r)) {
                // create contact record
@@ -1025,7 +1028,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
                        intval($uid),
                        DBA::escape(DateTimeFormat::utcNow()),
                        DBA::escape($contact->url),
-                       DBA::escape(normalise_link($contact->url)),
+                       DBA::escape(Strings::normaliseLink($contact->url)),
                        DBA::escape(str_replace("acct:", "", $contact->id)),
                        DBA::escape(''),
                        DBA::escape($contact->id), // What is it for?
@@ -1042,7 +1045,7 @@ function pumpio_get_contact($uid, $contact, $no_insert = false)
                );
 
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d LIMIT 1",
-                       DBA::escape(normalise_link($contact->url)),
+                       DBA::escape(Strings::normaliseLink($contact->url)),
                        intval($uid)
                        );
 
@@ -1162,7 +1165,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
        } else {
                $contact_id = pumpio_get_contact($uid, $post->actor, true);
 
-               if (link_compare($post->actor->url, $own_id)) {
+               if (Strings::compareLink($post->actor->url, $own_id)) {
                        $contact_id = $self[0]['id'];
                        $post->actor->displayName = $self[0]['name'];
                        $post->actor->url = $self[0]['url'];
@@ -1170,7 +1173,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                } elseif ($contact_id == 0) {
                        // Take an existing contact, the contact of the note or - as a fallback - the id of the user
                        $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                               DBA::escape(normalise_link($post->actor->url)),
+                               DBA::escape(Strings::normaliseLink($post->actor->url)),
                                intval($uid)
                        );
 
@@ -1178,7 +1181,7 @@ function pumpio_dopost(App $a, $client, $uid, $self, $post, $own_id, $threadcomp
                                $contact_id = $r[0]['id'];
                        } else {
                                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `blocked` = 0 AND `readonly` = 0 LIMIT 1",
-                                       DBA::escape(normalise_link($post->actor->url)),
+                                       DBA::escape(Strings::normaliseLink($post->actor->url)),
                                        intval($uid)
                                );
 
@@ -1351,7 +1354,7 @@ function pumpio_fetchinbox(App $a, $uid)
                return;
        }
 
-       if ($user->items) {
+       if (!empty($user->items)) {
                $posts = array_reverse($user->items);
 
                if (count($posts)) {
@@ -1417,90 +1420,6 @@ function pumpio_getallusers(App &$a, $uid)
        }
 }
 
-function pumpio_queue_hook(App $a, array &$b)
-{
-       $qi = q("SELECT * FROM `queue` WHERE `network` = '%s'",
-               DBA::escape(Protocol::PUMPIO)
-       );
-
-       if (!DBA::isResult($qi)) {
-               return;
-       }
-
-       foreach ($qi as $x) {
-               if ($x['network'] !== Protocol::PUMPIO) {
-                       continue;
-               }
-
-               logger('pumpio_queue: run');
-
-               $r = q("SELECT `user`.* FROM `user` LEFT JOIN `contact` ON `contact`.`uid` = `user`.`uid`
-                       WHERE `contact`.`self` = 1 AND `contact`.`id` = %d LIMIT 1",
-                       intval($x['cid'])
-               );
-               if (!DBA::isResult($r)) {
-                       continue;
-               }
-
-               $userdata = $r[0];
-
-               //logger('pumpio_queue: fetching userdata '.print_r($userdata, true));
-
-               $oauth_token        = PConfig::get($userdata['uid'], "pumpio", "oauth_token");
-               $oauth_token_secret = PConfig::get($userdata['uid'], "pumpio", "oauth_token_secret");
-               $consumer_key       = PConfig::get($userdata['uid'], "pumpio", "consumer_key");
-               $consumer_secret    = PConfig::get($userdata['uid'], "pumpio", "consumer_secret");
-
-               $host = PConfig::get($userdata['uid'], "pumpio", "host");
-               $user = PConfig::get($userdata['uid'], "pumpio", "user");
-
-               $success = false;
-
-               if ($oauth_token && $oauth_token_secret &&
-                       $consumer_key && $consumer_secret) {
-                       $username = $user.'@'.$host;
-
-                       logger('pumpio_queue: able to post for user '.$username);
-
-                       $z = unserialize($x['content']);
-
-                       $client = new oauth_client_class;
-                       $client->oauth_version = '1.0a';
-                       $client->url_parameters = false;
-                       $client->authorization_header = true;
-                       $client->access_token = $oauth_token;
-                       $client->access_token_secret = $oauth_token_secret;
-                       $client->client_id = $consumer_key;
-                       $client->client_secret = $consumer_secret;
-
-                       if (pumpio_reachable($z['url'])) {
-                               $success = $client->CallAPI($z['url'], 'POST', $z['post'], ['FailOnAccessError'=>true, 'RequestContentType'=>'application/json'], $user);
-                       } else {
-                               $success = false;
-                       }
-
-                       if ($success) {
-                               $post_id = $user->object->id;
-                               logger('pumpio_queue: send '.$username.': success '.$post_id);
-                               if ($post_id && $iscomment) {
-                                       logger('pumpio_send '.$username.': Update extid '.$post_id." for post id ".$z['item']);
-                                       Item::update(['extid' => $post_id], ['id' => $z['item']]);
-                               }
-                               Queue::removeItem($x['id']);
-                       } else {
-                               logger('pumpio_queue: send '.$username.': '.$z['url'].' general error: ' . print_r($user, true));
-                       }
-               } else {
-                       logger("pumpio_queue: Error getting tokens for user ".$userdata['uid']);
-               }
-
-               if (!$success) {
-                       logger('pumpio_queue: delayed');
-                       Queue::updateTime($x['id']);
-               }
-       }
-}
-
 function pumpio_getreceiver(App $a, array $b)
 {
        $receiver = [];
@@ -1595,7 +1514,7 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
        $hostname = PConfig::get($uid, 'pumpio', 'host');
        $username = PConfig::get($uid, "pumpio", "user");
 
-       logger("pumpio_fetchallcomments: completing comment for user ".$uid." post id ".$id);
+       Logger::log("pumpio_fetchallcomments: completing comment for user ".$uid." post id ".$id);
 
        $own_id = "https://".$hostname."/".$username;
 
@@ -1621,7 +1540,7 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
        $client->access_token = $otoken;
        $client->access_token_secret = $osecret;
 
-       logger("pumpio_fetchallcomments: fetching comment for user ".$uid." url ".$url);
+       Logger::log("pumpio_fetchallcomments: fetching comment for user ".$uid." url ".$url);
 
        if (pumpio_reachable($url)) {
                $success = $client->CallAPI($url, 'GET', [], ['FailOnAccessError'=>true], $item);
@@ -1684,14 +1603,14 @@ function pumpio_fetchallcomments(App $a, $uid, $id)
 
                $post->object = $item;
 
-               logger("pumpio_fetchallcomments: posting comment ".$post->object->id." ".print_r($post, true));
+               Logger::log("pumpio_fetchallcomments: posting comment ".$post->object->id." ".print_r($post, true));
                pumpio_dopost($a, $client, $uid, $self, $post, $own_id, false);
        }
 }
 
 function pumpio_reachable($url)
 {
-       return Network::curl($url, false, $redirects, ['timeout'=>10])->isSuccess();
+       return Network::curl($url, false, ['timeout' => 10])->isSuccess();
 }
 
 /*