You should have received a copy of the GNU Library General Public
License along with this library; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
For further information visit http://plib.sourceforge.net
namespace simgear {
-static NetChannel* channels = 0 ;
-
NetChannel::NetChannel ()
{
closed = true ;
accepting = false ;
write_blocked = false ;
should_delete = false ;
-
- next_channel = channels ;
- channels = this ;
+ poller = NULL;
}
NetChannel::~NetChannel ()
{
close();
-
- NetChannel* prev = NULL ;
-
- for ( NetChannel* ch = channels; ch != NULL;
- ch = ch -> next_channel )
- {
- if (ch == this)
- {
- ch = ch -> next_channel ;
- if ( prev != NULL )
- prev -> next_channel = ch ;
- else
- channels = ch ;
- next_channel = 0 ;
- break;
- }
- prev = ch ;
+ if (poller) {
+ poller->removeChannel(this);
}
}
return 0; // not looked up yet, wait longer
}
+ if (!addr.isValid()) {
+ SG_LOG(SG_IO, SG_WARN, "Network: host lookup failed:" << host);
+ handleError (ENOENT);
+ close();
+ return -1;
+ }
+
resolving_host = false;
addr.setPort(port);
int result = Socket::connect ( &addr ) ;
}
}
+void NetChannel::handleRead (void) {
+ SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled read");
+}
+
+void NetChannel::handleWrite (void) {
+ SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled write");
+}
+
+void NetChannel::handleAccept (void) {
+ SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled accept");
+}
+
+void NetChannel::handleError (int error)
+{
+ // warn about address lookup failures seperately, don't warn again.
+ // (and we (ab-)use ENOENT to mean 'name not found'.
+ if (error != ENOENT) {
+ SG_LOG(SG_IO, SG_WARN,"Network:" << getHandle() << ": errno: " << strerror(errno) <<"(" << errno << ")");
+ }
+}
+
+void
+NetChannelPoller::addChannel(NetChannel* channel)
+{
+ assert(channel);
+ assert(channel->poller == NULL);
+
+ channel->poller = this;
+ channels.push_back(channel);
+}
+
+void
+NetChannelPoller::removeChannel(NetChannel* channel)
+{
+ assert(channel);
+ assert(channel->poller == this);
+ channel->poller = NULL;
+
+ // portability: MSVC throws assertion failure when empty
+ if (channels.empty()) {
+ return;
+ }
+
+ ChannelList::iterator it = channels.begin();
+ for (; it != channels.end(); ++it) {
+ if (*it == channel) {
+ channels.erase(it);
+ return;
+ }
+ }
+}
+
bool
-NetChannel::poll (unsigned int timeout)
+NetChannelPoller::poll(unsigned int timeout)
{
- if (!channels)
- return false ;
-
- enum { MAX_SOCKETS = 256 } ;
- Socket* reads [ MAX_SOCKETS+1 ] ;
- Socket* writes [ MAX_SOCKETS+1 ] ;
- Socket* deletes [ MAX_SOCKETS+1 ] ;
- int nreads = 0 ;
- int nwrites = 0 ;
- int ndeletes = 0 ;
- int nopen = 0 ;
- NetChannel* ch;
- for ( ch = channels; ch != NULL; ch = ch -> next_channel )
- {
- if ( ch -> should_delete )
- {
- assert(ndeletes<MAX_SOCKETS);
- deletes[ndeletes++] = ch ;
+ if (channels.empty()) {
+ return false;
}
- else if ( ! ch -> closed )
+
+ enum { MAX_SOCKETS = 256 } ;
+ Socket* reads [ MAX_SOCKETS+1 ] ;
+ Socket* writes [ MAX_SOCKETS+1 ] ;
+ int nreads = 0 ;
+ int nwrites = 0 ;
+ int nopen = 0 ;
+
+ ChannelList::iterator it = channels.begin();
+ while( it != channels.end() )
{
- if (ch -> resolving_host )
- {
- ch -> handleResolve();
- continue;
- }
+ NetChannel* ch = *it;
+ if ( ch -> should_delete )
+ {
+ // avoid the channel trying to remove itself from us, or we get
+ // bug http://code.google.com/p/flightgear-bugs/issues/detail?id=1144
+ ch->poller = NULL;
+ delete ch;
+ it = channels.erase(it);
+ continue;
+ }
+
+ ++it; // we've copied the pointer into ch
+ if ( ch->closed ) {
+ continue;
+ }
+
+ if (ch -> resolving_host )
+ {
+ ch -> handleResolve();
+ continue;
+ }
- nopen++ ;
- if (ch -> readable()) {
- assert(nreads<MAX_SOCKETS);
- reads[nreads++] = ch ;
- }
- if (ch -> writable()) {
- assert(nwrites<MAX_SOCKETS);
- writes[nwrites++] = ch ;
- }
- }
- }
- reads[nreads] = NULL ;
- writes[nwrites] = NULL ;
- deletes[ndeletes] = NULL ;
-
- int i ;
- for ( i=0; deletes[i]; i++ )
- {
- ch = (NetChannel*)deletes[i];
- delete ch ;
- }
+ nopen++ ;
+ if (ch -> readable()) {
+ assert(nreads<MAX_SOCKETS);
+ reads[nreads++] = ch ;
+ }
+ if (ch -> writable()) {
+ assert(nwrites<MAX_SOCKETS);
+ writes[nwrites++] = ch ;
+ }
+ } // of array-filling pass
+
+ reads[nreads] = NULL ;
+ writes[nwrites] = NULL ;
- if (!nopen)
- return false ;
- if (!nreads && !nwrites)
- return true ; //hmmm- should we shutdown?
+ if (!nopen)
+ return false ;
+ if (!nreads && !nwrites)
+ return true ; //hmmm- should we shutdown?
- Socket::select (reads, writes, timeout) ;
+ Socket::select (reads, writes, timeout) ;
- for ( i=0; reads[i]; i++ )
- {
- ch = (NetChannel*)reads[i];
- if ( ! ch -> closed )
- ch -> handleReadEvent();
- }
+ for ( int i=0; reads[i]; i++ )
+ {
+ NetChannel* ch = (NetChannel*)reads[i];
+ if ( ! ch -> closed )
+ ch -> handleReadEvent();
+ }
- for ( i=0; writes[i]; i++ )
- {
- ch = (NetChannel*)writes[i];
- if ( ! ch -> closed )
- ch -> handleWriteEvent();
- }
+ for ( int i=0; writes[i]; i++ )
+ {
+ NetChannel* ch = (NetChannel*)writes[i];
+ if ( ! ch -> closed )
+ ch -> handleWriteEvent();
+ }
- return true ;
+ return true ;
}
void
-NetChannel::loop (unsigned int timeout)
+NetChannelPoller::loop (unsigned int timeout)
{
while ( poll (timeout) ) ;
}
-void NetChannel::handleRead (void) {
- SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled read");
-}
-
-void NetChannel::handleWrite (void) {
- SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled write");
-}
-
-void NetChannel::handleAccept (void) {
- SG_LOG(SG_IO, SG_WARN, "Network:" << getHandle() << ": unhandled accept");
-}
-
-void NetChannel::handleError (int error) {
- SG_LOG(SG_IO, SG_WARN,"Network:" << getHandle() << ": errno: " << strerror(errno) <<"(" << errno << ")");
-}
-
} // of namespace simgear
projects / simgear.git / blobdiff