]> git.mxchange.org Git - flightgear.git/blobdiff - src/ATC/AILocalTraffic.cxx
Fix the nmea and garmin output to a) fake a GSA sentence, b) fix a y2k bug
[flightgear.git] / src / ATC / AILocalTraffic.cxx
index 7cf30c5f3255005b9eed56458a8325bed6296e7d..e427bb382cd5c8fa62f3943a91a3938f1f7a6809 100644 (file)
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
+/*==========================================================
+
+TODO list.
+
+Should get pattern direction from tower.
+
+Need to continually monitor and adjust deviation from glideslope
+during descent to avoid occasionally landing short or long.
+
+============================================================*/
+
 #ifdef HAVE_CONFIG_H
 #  include <config.h>
 #endif
@@ -65,13 +76,13 @@ FGAILocalTraffic::FGAILocalTraffic() {
        nominal_final_speed = 65.0;
        //nominal_approach_speed;
        //stall_speed_landing_config;
-       nominalTaxiSpeed = 8.0;
+       nominalTaxiSpeed = 7.5;
        taxiTurnRadius = 8.0;
        wheelOffset = 1.45;     // Warning - hardwired to the C172 - we need to read this in from file.
        elevInitGood = false;
        // Init the property nodes
        wind_from_hdg = fgGetNode("/environment/wind-from-heading-deg", true);
-       wind_speed_knots = fgGetNode("/environment/wind-speed-kts", true);
+       wind_speed_knots = fgGetNode("/environment/wind-speed-kt", true);
        circuitsToFly = 0;
        liningUp = false;
        taxiRequestPending = false;
@@ -82,6 +93,11 @@ FGAILocalTraffic::FGAILocalTraffic() {
        reportReadyForDeparture = false;
        contactTower = false;
        contactGround = false;
+       
+       descending = false;
+       targetDescentRate = 0.0;
+       goAround = false;
+       goAroundCalled = false;
 }
 
 FGAILocalTraffic::~FGAILocalTraffic() {
@@ -97,13 +113,9 @@ void FGAILocalTraffic::GetRwyDetails() {
        
        // Now we need to get the threshold position and rwy heading
        
-       SGPath path( globals->get_fg_root() );
-       path.append( "Airports" );
-       path.append( "runways.mk4" );
-       FGRunways runways( path.c_str() );
-
        FGRunway runway;
-       bool rwyGood = runways.search(airportID, rwy.rwyID, &runway);
+       bool rwyGood = globals->get_runways()->search(airportID, rwy.rwyID,
+                                                      &runway);
        if(rwyGood) {
                // Get the threshold position
        hdg = runway.heading;   // TODO - check - is this our heading we are setting here, and if so should we be?
@@ -140,6 +152,7 @@ void FGAILocalTraffic::GetRwyDetails() {
        }
 }
 
+
 /* 
 There are two possible scenarios during initialisation:
 The first is that the user is flying towards the airport, and hence the traffic
@@ -149,18 +162,16 @@ The second is that the user has started the sim at or close to the airport, and
 hence the traffic must be initialised with respect to the user as well as each other.
 To a certain extent it's FGAIMgr that has to worry about this, but we need to provide
 sufficient initialisation functionality within the plane classes to allow the manager
-to initialy position them where and how required.
+to initially position them where and how required.
 */
 bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg initialLeg) {
        //cout << "FGAILocalTraffic.Init(...) called" << endl;
        // Hack alert - Hardwired path!!
        string planepath = "Aircraft/c172/Models/c172-dpm.ac";
-       SGPath path = globals->get_fg_root();
-       path.append(planepath);
-        ssgBranch *model = fgLoad3DModel( path.str(),
-                                          planepath.c_str(),
-                                          globals->get_props(),
-                                          globals->get_sim_time_sec() );
+       ssgBranch *model = sgLoad3DModel( globals->get_fg_root(),
+                                         planepath.c_str(),
+                                         globals->get_props(),
+                                         globals->get_sim_time_sec() );
        aip.init( model );
        aip.setVisible(false);          // This will be set to true once a valid ground elevation has been determined
        globals->get_scenery()->get_scene_graph()->addKid(aip.getSceneGraph());
@@ -170,7 +181,7 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
        AirportATC a;
        if(ATC->GetAirportATCDetails(airportID, &a)) {
                if(a.tower_freq) {      // Has a tower
-                       tower = (FGTower*)ATC->GetATCPointer((string)airportID, TOWER); // Maybe need some error checking here
+                       tower = (FGTower*)ATC->GetATCPointer(airportID, TOWER); // Maybe need some error checking here
                        if(tower == NULL) {
                                // Something has gone wrong - abort or carry on with un-towered operation?
                                return(false);
@@ -186,11 +197,14 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
                        }
                        //cout << "AILocalTraffic freq is " << freq << '\n';
                } else {
-                       // Check CTAF, unicom etc
+                       // TODO - Check CTAF, unicom etc
                }
        } else {
                //cout << "Unable to find airport details in FGAILocalTraffic::Init()\n";
        }
+       
+               // Get the active runway details (and copy them into rwy)
+               GetRwyDetails();
 
        // Get the airport elevation
        aptElev = dclGetAirportElev(airportID.c_str()) * SG_FEET_TO_METER;
@@ -202,6 +216,7 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
        operatingState = initialState;
        switch(operatingState) {
        case PARKED:
+               tuned_station = ground;
                ourGate = ground->GetGateNode();
                if(ourGate == NULL) {
                        // Implies no available gates - what shall we do?
@@ -225,6 +240,7 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
                Transform();
                break;
        case TAXIING:
+               tuned_station = ground;
                // FIXME - implement this case properly
                return(false);  // remove this line when fixed!
                break;
@@ -233,26 +249,11 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
                // since we've got the implementation for this case already.
                // TODO - implement proper generic in_pattern startup.
                
-               // Get the active runway details (and copy them into rwy)
-               GetRwyDetails();
-
-               // Initial position on threshold for now
-               pos.setlat(rwy.threshold_pos.lat());
-               pos.setlon(rwy.threshold_pos.lon());
-               pos.setelev(rwy.threshold_pos.elev());
-               hdg = rwy.hdg;
+               // 18/10/03 - adding the ability to start on downwind (mainly to speed testing of the go-around code!!)
                
-               // Now we've set the position we can do the ground elev
-               // This might not always be necessary if we implement in-air start
-               elevInitGood = false;
-               inAir = false;
-               DoGroundElev();
+               //cout << "Starting in pattern...\n";
                
-               pitch = 0.0;
-               roll = 0.0;
-               leg = TAKEOFF_ROLL;
-               vel = 0.0;
-               slope = 0.0;
+               tuned_station = tower;
                
                circuitsToFly = 0;              // ie just fly this circuit and then stop
                touchAndGo = false;
@@ -262,7 +263,42 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
                if(rwy.rwyID.size() == 3) {
                        patternDirection = (rwy.rwyID.substr(2,1) == "R" ? 1 : -1);
                }
-               
+
+               if(initialLeg == DOWNWIND) {
+                       pos = ortho.ConvertFromLocal(Point3D(1000*patternDirection, 800, 0.0));
+                       pos.setelev(rwy.threshold_pos.elev() + 1000 * SG_FEET_TO_METER);
+                       hdg = rwy.hdg + 180.0;
+                       leg = DOWNWIND;
+                       elevInitGood = false;
+                       inAir = true;
+                       track = rwy.hdg - (180 * patternDirection);     //should tend to bring track back into the 0->360 range
+                       slope = 0.0;
+                       pitch = 0.0;
+                       roll = 0.0;
+                       IAS = 90.0;
+                       descending = false;
+                       aip.setVisible(true);
+                       tower->RegisterAIPlane(plane, this, CIRCUIT, DOWNWIND);
+               } else {                        
+                       // Default to initial position on threshold for now
+                       pos.setlat(rwy.threshold_pos.lat());
+                       pos.setlon(rwy.threshold_pos.lon());
+                       pos.setelev(rwy.threshold_pos.elev());
+                       hdg = rwy.hdg;
+                       
+                       // Now we've set the position we can do the ground elev
+                       // This might not always be necessary if we implement in-air start
+                       elevInitGood = false;
+                       inAir = false;
+                       DoGroundElev();
+                       
+                       pitch = 0.0;
+                       roll = 0.0;
+                       leg = TAKEOFF_ROLL;
+                       vel = 0.0;
+                       slope = 0.0;
+               }
+       
                operatingState = IN_PATTERN;
                
                Transform();
@@ -276,6 +312,18 @@ bool FGAILocalTraffic::Init(string ICAO, OperatingState initialState, PatternLeg
        return(true);
 }
 
+
+// Return what type of landing we're doing on this circuit
+LandingType FGAILocalTraffic::GetLandingOption() {
+       //cout << "circuitsToFly = " << circuitsToFly << '\n';
+       if(circuitsToFly) {
+               return(touchAndGo ? TOUCH_AND_GO : STOP_AND_GO);
+       } else {
+               return(FULL_STOP);
+       }
+}
+       
+
 // Commands to do something from higher level logic
 void FGAILocalTraffic::FlyCircuits(int numCircuits, bool tag) {
        //cout << "FlyCircuits called" << endl;
@@ -286,66 +334,12 @@ void FGAILocalTraffic::FlyCircuits(int numCircuits, bool tag) {
                return;
                break;
        case TAXIING:
-               // For now we'll punt this and do nothing
+               // TODO - For now we'll punt this and do nothing
                break;
        case PARKED:
                circuitsToFly = numCircuits;    // Note that one too many circuits gets flown because we only test and decrement circuitsToFly after landing
                                                                                // thus flying one too many circuits.  TODO - Need to sort this out better!
                touchAndGo = tag;
-#if 0  
-               // Get the active runway details (and copy them into rwy)
-               GetRwyDetails();
-               
-               // Get the takeoff node for the active runway, get a path to it and start taxiing
-               path = ground->GetPath(ourGate, rwy.rwyID);
-               if(path.size() < 2) {
-                       // something has gone wrong
-                       SG_LOG(SG_ATC, SG_ALERT, "Invalid path from gate to theshold in FGAILocalTraffic::FlyCircuits\n");
-                       return;
-               }
-               /*
-               cout << "path returned was:" << endl;
-               for(unsigned int i=0; i<path.size(); ++i) {
-                       switch(path[i]->struct_type) {
-                       case NODE:
-                               cout << "NODE " << ((node*)(path[i]))->nodeID << endl;
-                               break;
-                       case ARC:
-                               cout << "ARC\n";
-                               break;
-                       }
-               }
-               */
-               // pop the gate - we're here already!
-               path.erase(path.begin());
-               //path.erase(path.begin());
-               /*
-               cout << "path after popping front is:" << endl;
-               for(unsigned int i=0; i<path.size(); ++i) {
-                       switch(path[i]->struct_type) {
-                       case NODE:
-                               cout << "NODE " << ((node*)(path[i]))->nodeID << endl;
-                               break;
-                       case ARC:
-                               cout << "ARC\n";
-                               break;
-                       }
-               }
-               */
-               
-               taxiState = TD_OUTBOUND;
-               StartTaxi();
-               
-               // Maybe the below should be set when we get to the threshold and prepare for TO?
-               // FIXME TODO - pattern direction is still hardwired
-               patternDirection = -1;          // Left
-               // At the bare minimum we ought to make sure it goes the right way at dual parallel rwy airports!
-               if(rwy.rwyID.size() == 3) {
-                       patternDirection = (rwy.rwyID.substr(2,1) == "R" ? 1 : -1);
-               }
-
-               Transform();
-#endif
                break;
        }
 }   
@@ -353,18 +347,19 @@ void FGAILocalTraffic::FlyCircuits(int numCircuits, bool tag) {
 // Run the internal calculations
 void FGAILocalTraffic::Update(double dt) {
        //cout << "A" << flush;
-       double responseTime = 10.0;             // seconds - this should get more sophisticated at some point
+       //double responseTime = 10.0;           // seconds - this should get more sophisticated at some point
        responseCounter += dt;
        if((contactTower) && (responseCounter >= 8.0)) {
                // Acknowledge request before changing frequency so it gets rendered if the user is on the same freq
                string trns = "Tower ";
                double f = globals->get_ATC_mgr()->GetFrequency(airportID, TOWER) / 100.0;      
                char buf[10];
-               sprintf(buf, "%f", f);
+               sprintf(buf, "%.2f", f);
                trns += buf;
                trns += " ";
                trns += plane.callsign;
-               Transmit(trns);
+               pending_transmission = trns;
+               ConditionalTransmit(30.0);
                responseCounter = 0.0;
                contactTower = false;
                changeFreq = true;
@@ -374,26 +369,33 @@ void FGAILocalTraffic::Update(double dt) {
        if((changeFreq) && (responseCounter > 8.0)) {
                switch(changeFreqType) {
                case TOWER:
+                       tuned_station = tower;
                        freq = (double)tower->get_freq() / 100.0;
                        //Transmit("DING!");
                        // Contact the tower, even if only virtually
                        changeFreq = false;
-                       tower->ContactAtHoldShort(plane, this, CIRCUIT);
+                       pending_transmission = plane.callsign;
+                       pending_transmission += " at hold short for runway ";
+                       pending_transmission += ConvertRwyNumToSpokenString(rwy.rwyID);
+                       pending_transmission += " traffic pattern ";
+                       if(circuitsToFly) {
+                               pending_transmission += ConvertNumToSpokenDigits(circuitsToFly + 1);
+                               pending_transmission += " circuits touch and go";
+                       } else {
+                               pending_transmission += " one circuit to full stop";
+                       }
+                       Transmit(2);
                        break;
                case GROUND:
+                       tuned_station = ground;
                        freq = (double)ground->get_freq() / 100.0;
                        break;
                // And to avoid compiler warnings...
-               case APPROACH:
-                       break;
-               case ATIS:
-                       break;
-               case ENROUTE:
-                       break;
-               case DEPARTURE:
-                       break;
-               case INVALID:
-                       break;
+               case APPROACH:  break;
+               case ATIS:      break;
+               case ENROUTE:   break;
+               case DEPARTURE: break;
+               case INVALID:   break;
                }
        }
        
@@ -402,15 +404,17 @@ void FGAILocalTraffic::Update(double dt) {
        switch(operatingState) {
        case IN_PATTERN:
                //cout << "In IN_PATTERN\n";
-               if(!inAir) DoGroundElev();
-               if(!elevInitGood) {
-                       if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                               pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
-                               //cout << "TAKEOFF_ROLL, POS = " << pos.lon() << ", " << pos.lat() << ", " << pos.elev() << '\n';
-                               //Transform();
-                               aip.setVisible(true);
-                               //cout << "Making plane visible!\n";
-                               elevInitGood = true;
+               if(!inAir) {
+                       DoGroundElev();
+                       if(!elevInitGood) {
+                               if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                                       pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
+                                       //cout << "TAKEOFF_ROLL, POS = " << pos.lon() << ", " << pos.lat() << ", " << pos.elev() << '\n';
+                                       //Transform();
+                                       aip.setVisible(true);
+                                       //cout << "Making plane visible!\n";
+                                       elevInitGood = true;
+                               }
                        }
                }
                FlyTrafficPattern(dt);
@@ -421,8 +425,8 @@ void FGAILocalTraffic::Update(double dt) {
                //cout << "*" << flush;
                if(!elevInitGood) {
                        //DoGroundElev();
-                       if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                               pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+                       if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                               pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                                //Transform();
                                aip.setVisible(true);
                                //Transform();
@@ -459,18 +463,19 @@ void FGAILocalTraffic::Update(double dt) {
                        holdingShort = false;
                        string trns = "Cleared for take-off ";
                        trns += plane.callsign;
-                       Transmit(trns);
+                       pending_transmission = trns;
+                       Transmit();
                        StartTaxi();
                }
                //cout << "^" << flush;
                Transform();
                break;
-               case PARKED:
+       case PARKED:
                //cout << "In PARKED\n";
                if(!elevInitGood) {
                        DoGroundElev();
-                       if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                               pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+                       if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                               pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                                //Transform();
                                aip.setVisible(true);
                                //Transform();
@@ -482,7 +487,7 @@ void FGAILocalTraffic::Update(double dt) {
                if(circuitsToFly) {
                        if((taxiRequestPending) && (taxiRequestCleared)) {
                                //cout << "&" << flush;
-                               // Get the active runway details (and copy them into rwy)
+                               // Get the active runway details (in case they've changed since init)
                                GetRwyDetails();
                                
                                // Get the takeoff node for the active runway, get a path to it and start taxiing
@@ -512,7 +517,6 @@ void FGAILocalTraffic::Update(double dt) {
                                StartTaxi();
                        } else if(!taxiRequestPending) {
                                //cout << "(" << flush;
-                               ground->RequestDeparture(plane, this);
                                // Do some communication
                                // airport name + tower + airplane callsign + location + request taxi for + operation type + ?
                                string trns = "";
@@ -521,7 +525,8 @@ void FGAILocalTraffic::Update(double dt) {
                                trns += plane.callsign;
                                trns += " on apron parking request taxi for traffic pattern";
                                //cout << "trns = " << trns << endl;
-                               Transmit(trns);
+                               pending_transmission = trns;
+                               Transmit(1);
                                taxiRequestCleared = false;
                                taxiRequestPending = true;
                        }
@@ -544,6 +549,14 @@ void FGAILocalTraffic::Update(double dt) {
                break;
        }
        //cout << "I " << flush;
+       
+       // Convienience output for AI debugging user the property logger
+       fgSetDouble("/AI/Local1/ortho-x", (ortho.ConvertToLocal(pos)).x());
+       fgSetDouble("/AI/Local1/ortho-y", (ortho.ConvertToLocal(pos)).y());
+       fgSetDouble("/AI/Local1/elev", pos.elev() * SG_METER_TO_FEET);
+       
+       // And finally, call parent for transmission rendering
+       FGAIPlane::Update(dt);
 }
 
 void FGAILocalTraffic::RegisterTransmission(int code) {
@@ -567,6 +580,11 @@ void FGAILocalTraffic::RegisterTransmission(int code) {
                clearedToTakeOff = true;
                SG_LOG(SG_ATC, SG_INFO, "AI local traffic " << plane.callsign << " cleared to take-off...");
                break;
+       case 13: // Go around!
+               responseCounter = 0;
+               goAround = true;
+               SG_LOG(SG_ATC, SG_INFO, "AI local traffic " << plane.callsign << " told to go-around!!");
+               break;
        default:
                break;
        }
@@ -605,6 +623,8 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
        double wind_from = wind_from_hdg->getDoubleValue();
        double wind_speed = wind_speed_knots->getDoubleValue();
 
+       double dveldt;
+       
        switch(leg) {
        case TAKEOFF_ROLL:
                //inAir = false;
@@ -613,24 +633,53 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                        double dveldt = 5.0;
                        vel += dveldt * dt;
                }
-               if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                       pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+               if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                       pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                }
                IAS = vel + (cos((hdg - wind_from) * DCL_DEGREES_TO_RADIANS) * wind_speed);
                if(IAS >= 70) {
                        leg = CLIMBOUT;
                        pitch = 10.0;
                        IAS = best_rate_of_climb_speed;
-                       slope = 7.0;
+                       //slope = 7.0;  
+                       slope = 6.0;    // Reduced it slightly since it's climbing a lot steeper than I can in the JSBSim C172.
                        inAir = true;
                }
                break;
        case CLIMBOUT:
                track = rwy.hdg;
-               if((pos.elev() - rwy.threshold_pos.elev()) * SG_METER_TO_FEET > 600) {
-                       cout << "Turning to crosswind, distance from threshold = " << orthopos.y() << '\n'; 
-                       leg = TURN1;
+               // Turn to crosswind if above 700ft AND if other traffic allows
+               // (decided in FGTower and accessed through GetCrosswindConstraint(...)).
+               // According to AIM, traffic should climb to within 300ft of pattern altitude before commencing crosswind turn.
+               // TODO - At hot 'n high airports this may be 500ft AGL though - need to make this a variable.
+               if((pos.elev() - rwy.threshold_pos.elev()) * SG_METER_TO_FEET > 700) {
+                       double cc = 0.0;
+                       if(tower->GetCrosswindConstraint(cc)) {
+                               if(orthopos.y() > cc) {
+                                       cout << "Turning to crosswind, distance from threshold = " << orthopos.y() << '\n'; 
+                                       leg = TURN1;
+                               }
+                       } else if(orthopos.y() > 1500.0) {   // Added this constraint as a hack to prevent turning too early when going around.
+                               // TODO - We should be doing it as a distance from takeoff end, not theshold end though.
+                               cout << "Turning to crosswind, distance from threshold = " << orthopos.y() << '\n'; 
+                               leg = TURN1;
+                       }
                }
+               // Need to check for levelling off in case we can't turn crosswind as soon
+               // as we would like due to other traffic.
+               if((pos.elev() - rwy.threshold_pos.elev()) * SG_METER_TO_FEET > 1000) {
+                       slope = 0.0;
+                       pitch = 0.0;
+                       IAS = 80.0;             // FIXME - use smooth transistion to new speed and attitude.
+               }
+               if(goAround && !goAroundCalled) {
+                       if(responseCounter > 5.5) {
+                               pending_transmission = plane.callsign;
+                               pending_transmission += " going around";
+                               Transmit();
+                               goAroundCalled = true;
+                       }
+               }               
                break;
        case TURN1:
                track += (360.0 / turn_time) * dt * patternDirection;
@@ -640,6 +689,7 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                }
                break;
        case CROSSWIND:
+               goAround = false;
                LevelWings();
                track = rwy.hdg + (90.0 * patternDirection);
                if((pos.elev() - rwy.threshold_pos.elev()) * SG_METER_TO_FEET > 1000) {
@@ -647,9 +697,18 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                        pitch = 0.0;
                        IAS = 80.0;             // FIXME - use smooth transistion to new speed
                }
-               // turn 1000m out for now
+               // turn 1000m out for now, taking other traffic into accout
                if(fabs(orthopos.x()) > 980) {
-                       leg = TURN2;
+                       double dd = 0.0;
+                       if(tower->GetDownwindConstraint(dd)) {
+                               if(fabs(orthopos.x()) > fabs(dd)) {
+                                       cout << "Turning to downwind, distance from centerline = " << fabs(orthopos.x()) << '\n'; 
+                                       leg = TURN2;
+                               }
+                       } else {
+                               cout << "Turning to downwind, distance from centerline = " << fabs(orthopos.x()) << '\n'; 
+                               leg = TURN2;
+                       }
                }
                break;
        case TURN2:
@@ -680,16 +739,44 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                        TransmitPatternPositionReport();
                        transmitted = true;
                }
-               if(orthopos.y() < -480) {
-                       slope = -4.0;   // FIXME - calculate to descent at 500fpm and hit the threshold (taking wind into account as well!!)
+               if((orthopos.y() < -100) && (!descending)) {
+                       // Maybe we should think about when to start descending.
+                       // For now we're assuming that we aim to follow the same glidepath regardless of wind.
+                       double d1;
+                       double d2;
+                       CalculateSoD((tower->GetBaseConstraint(d1) ? d1 : -1000.0), (tower->GetDownwindConstraint(d2) ? d2 : 1000.0 * patternDirection), (patternDirection ? true : false));
+                       if(SoD.leg == DOWNWIND) {
+                               descending = (orthopos.y() < SoD.y ? true : false);
+                       }
+
+               }
+               if(descending) {
+                       slope = -5.5;   // FIXME - calculate to descent at 500fpm and hit the desired point on the runway (taking wind into account as well!!)
                        pitch = -3.0;
                        IAS = 85.0;
                }
-               if(orthopos.y() < -980) {
-                       //roll = -20;
-                       leg = TURN3;
-                       transmitted = false;
-                       IAS = 80.0;
+               
+               // Try and arrange to turn nicely onto base
+               turn_circumference = IAS * 0.514444 * turn_time;        
+               //Hmmm - this is an interesting one - ground vs airspeed in relation to turn radius
+               //We'll leave it as a hack with IAS for now but it needs revisiting.            
+               turn_radius = turn_circumference / (2.0 * DCL_PI);
+               if(orthopos.y() < -1000.0 + turn_radius) {
+               //if(orthopos.y() < -980) {
+                       double bb = 0.0;
+                       if(tower->GetBaseConstraint(bb)) {
+                               if(fabs(orthopos.y()) > fabs(bb)) {
+                                       cout << "Turning to base, distance from threshold = " << fabs(orthopos.y()) << '\n'; 
+                                       leg = TURN3;
+                                       transmitted = false;
+                                       IAS = 80.0;
+                               }
+                       } else {
+                               cout << "Turning to base, distance from threshold = " << fabs(orthopos.y()) << '\n'; 
+                               leg = TURN3;
+                               transmitted = false;
+                               IAS = 80.0;
+                       }
                }
                break;
        case TURN3:
@@ -705,15 +792,29 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                        TransmitPatternPositionReport();
                        transmitted = true;
                }
+               
+               if(!descending) {
+                       double d1;
+                       // Make downwind leg position artifically large to avoid any chance of SoD being returned as
+                       // on downwind when we are already on base.
+                       CalculateSoD((tower->GetBaseConstraint(d1) ? d1 : -1000.0), (10000.0 * patternDirection), (patternDirection ? true : false));
+                       if(SoD.leg == BASE) {
+                               descending = (fabs(orthopos.y()) < fabs(SoD.y) ? true : false);
+                       }
+
+               }
+               if(descending) {
+                       slope = -5.5;   // FIXME - calculate to descent at 500fpm and hit the threshold (taking wind into account as well!!)
+                       pitch = -4.0;
+                       IAS = 70.0;
+               }
+               
                track = rwy.hdg - (90 * patternDirection);
-               slope = -6.0;   // FIXME - calculate to descent at 500fpm and hit the threshold
-               pitch = -4.0;
-               IAS = 70.0;     // FIXME - slowdown gradually
-               // Try and arrange to turn nicely onto base
+
+               // Try and arrange to turn nicely onto final
                turn_circumference = IAS * 0.514444 * turn_time;        
                //Hmmm - this is an interesting one - ground vs airspeed in relation to turn radius
-               //We'll leave it as a hack with IAS for now but it needs revisiting.
-               
+               //We'll leave it as a hack with IAS for now but it needs revisiting.            
                turn_radius = turn_circumference / (2.0 * DCL_PI);
                if(fabs(orthopos.x()) < (turn_radius + 50)) {
                        leg = TURN4;
@@ -730,11 +831,34 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                }
                break;
        case FINAL:
+               if(goAround && responseCounter > 2.0) {
+                       leg = CLIMBOUT;
+                       pitch = 8.0;
+                       IAS = best_rate_of_climb_speed;
+                       slope = 5.0;    // A bit less steep than the initial climbout.
+                       inAir = true;
+                       goAroundCalled = false;
+                       break;
+               }
                LevelWings();
                if(!transmitted) {
                        TransmitPatternPositionReport();
                        transmitted = true;
                }
+               if(!descending) {
+                       // Make base leg position artifically large to avoid any chance of SoD being returned as
+                       // on base or downwind when we are already on final.
+                       CalculateSoD(-10000.0, (1000.0 * patternDirection), (patternDirection ? true : false));
+                       if(SoD.leg == FINAL) {
+                               descending = (fabs(orthopos.y()) < fabs(SoD.y) ? true : false);
+                       }
+
+               }
+               if(descending) {
+                       slope = -5.5;   // FIXME - calculate to descent at 500fpm and hit the threshold (taking wind into account as well!!)
+                       pitch = -4.0;
+                       IAS = 70.0;
+               }
                // Try and track the extended centreline
                track = rwy.hdg - (0.2 * orthopos.x());
                //cout << "orthopos.x() = " << orthopos.x() << " hdg = " << hdg << '\n';
@@ -743,8 +867,8 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                                        // for us in update(...) when the inAir flag is false.
                }
                if(pos.elev() < (rwy.threshold_pos.elev()+10.0+wheelOffset)) {
-                       if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                               if((aip.getFGLocation()->get_cur_elev_m() + wheelOffset) > pos.elev()) {
+                       if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                               if((aip.getSGLocation()->get_cur_elev_m() + wheelOffset) > pos.elev()) {
                                        slope = 0.0;
                                        pitch = 0.0;
                                        leg = LANDING_ROLL;
@@ -755,11 +879,12 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                break;
        case LANDING_ROLL:
                //inAir = false;
-               if(aip.getFGLocation()->get_cur_elev_m() > -9990.0) {
-                       pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+               descending = false;
+               if(aip.getSGLocation()->get_cur_elev_m() > -9990.0) {
+                       pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                }
                track = rwy.hdg;
-               double dveldt = -5.0;
+               dveldt = -5.0;
                vel += dveldt * dt;
                // FIXME - differentiate between touch and go and full stops
                if(vel <= 15.0) {
@@ -775,6 +900,8 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
                        }
                }
                break;
+       case LEG_UNKNOWN:
+               break;
     }
 
        if(inAir) {
@@ -824,9 +951,40 @@ void FGAILocalTraffic::FlyTrafficPattern(double dt) {
        pos = dclUpdatePosition(pos, track, slope, dist);
 }
 
+// Pattern direction is true for right, false for left
+void FGAILocalTraffic::CalculateSoD(double base_leg_pos, double downwind_leg_pos, bool pattern_direction) {
+       // For now we'll ignore wind and hardwire the glide angle.
+       double ga = 5.5;        //degrees
+       double pa = 1000.0 * SG_FEET_TO_METER;  // pattern altitude in meters
+       // FIXME - get glideslope angle and pattern altitude agl from airport details if available
+       
+       // For convienience, we'll have +ve versions of the input distances
+       double blp = fabs(base_leg_pos);
+       double dlp = fabs(downwind_leg_pos);
+       
+       //double turn_allowance = 150.0;        // Approximate distance in meters that a 90deg corner is shortened by turned in a light plane.
+       
+       double stod = pa / tan(ga * DCL_DEGREES_TO_RADIANS);    // distance in meters from touchdown point to start descent
+       //cout << "Descent to start = " << stod << " meters out\n";
+       if(stod < blp) {        // Start descending on final
+               SoD.leg = FINAL;
+               SoD.y = stod * -1.0;
+               SoD.x = 0.0;
+       } else if(stod < (blp + dlp)) { // Start descending on base leg
+               SoD.leg = BASE;
+               SoD.y = blp * -1.0;
+               SoD.x = (pattern_direction ? (stod - dlp) : (stod - dlp) * -1.0);
+       } else {        // Start descending on downwind leg
+               SoD.leg = DOWNWIND;
+               SoD.x = (pattern_direction ? dlp : dlp * -1.0);
+               SoD.y = (blp - (stod - (blp + dlp))) * -1.0;
+       }
+}
+
 void FGAILocalTraffic::TransmitPatternPositionReport(void) {
        // airport name + "traffic" + airplane callsign + pattern direction + pattern leg + rwy + ?
        string trns = "";
+       int code = 0;
        
        trns += tower->get_name();
        trns += " Traffic ";
@@ -848,6 +1006,7 @@ void FGAILocalTraffic::TransmitPatternPositionReport(void) {
                // Fall through to DOWNWIND
        case DOWNWIND:
                trns += "downwind ";
+               code = 11;
                break;
        case TURN3:
                // Fall through to BASE
@@ -858,18 +1017,39 @@ void FGAILocalTraffic::TransmitPatternPositionReport(void) {
                // Fall through to FINAL
        case FINAL:             // maybe this should include long/short final if appropriate?
                trns += "final ";
+               code = 13;
                break;
        default:                // Hopefully this won't be used
                trns += "pattern ";
                break;
        }
-       // FIXME - I've hardwired the runway call as well!! (We could work this out from rwy heading and mag deviation)
-       trns += ConvertRwyNumToSpokenString(1);
+       trns += ConvertRwyNumToSpokenString(rwy.rwyID);
        
        // And add the airport name again
        trns += tower->get_name();
        
-       Transmit(trns);
+       pending_transmission = trns;    // FIXME - make up pending_transmission natively        
+       ConditionalTransmit(90.0, code);                // Assume a report of this leg will be invalid if we can't transmit within a minute and a half.
+}
+
+// Callback handler
+// TODO - Really should enumerate these coded values.
+void FGAILocalTraffic::ProcessCallback(int code) {
+       // 1 - Request Departure from ground
+       // 2 - Report at hold short
+       // 10 - report crosswind
+       // 11 - report downwind
+       // 12 - report base
+       // 13 - report final
+       if(code == 1) {
+               ground->RequestDeparture(plane, this);
+       } else if(code == 2) {
+               tower->ContactAtHoldShort(plane, this, CIRCUIT);
+       } else if(code == 11) {
+               tower->ReportDownwind(plane.callsign);
+       } else if(code == 13) {
+               tower->ReportFinal(plane.callsign);
+       }
 }
 
 void FGAILocalTraffic::ExitRunway(Point3D orthopos) {
@@ -1063,8 +1243,8 @@ void FGAILocalTraffic::Taxi(double dt) {
                double slope = 0.0;
                pos = dclUpdatePosition(pos, track, slope, dist);
                //cout << "Updated position...\n";
-               if(aip.getFGLocation()->get_cur_elev_m() > -9990) {
-                       pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+               if(aip.getSGLocation()->get_cur_elev_m() > -9990) {
+                       pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                } // else don't change the elev until we get a valid ground elev again!
        } else if(lastNode) {
                if(taxiState == TD_LINING_UP) {
@@ -1082,8 +1262,8 @@ void FGAILocalTraffic::Taxi(double dt) {
                                double slope = 0.0;
                                pos = dclUpdatePosition(pos, track, slope, dist);
                                //cout << "Updated position...\n";
-                               if(aip.getFGLocation()->get_cur_elev_m() > -9990) {
-                                       pos.setelev(aip.getFGLocation()->get_cur_elev_m() + wheelOffset);
+                               if(aip.getSGLocation()->get_cur_elev_m() > -9990) {
+                                       pos.setelev(aip.getSGLocation()->get_cur_elev_m() + wheelOffset);
                                } // else don't change the elev until we get a valid ground elev again!
                                if(fabs(hdg - rwy.hdg) <= 1.0) {
                                        operatingState = IN_PATTERN;
@@ -1117,14 +1297,14 @@ void FGAILocalTraffic::DoGroundElev() {
        // answer with one call to the function, but what I tried in the two commented-out lines
        // below only intermittently worked, and I haven't quite groked why yet.
        //SGBucket buck(pos.lon(), pos.lat());
-       //aip.getFGLocation()->set_tile_center(Point3D(buck.get_center_lon(), buck.get_center_lat(), 0.0));
+       //aip.getSGLocation()->set_tile_center(Point3D(buck.get_center_lon(), buck.get_center_lat(), 0.0));
        
        double visibility_meters = fgGetDouble("/environment/visibility-m");
        //globals->get_tile_mgr()->prep_ssg_nodes( acmodel_location,
-       globals->get_tile_mgr()->prep_ssg_nodes( aip.getFGLocation(),   visibility_meters );
+       globals->get_tile_mgr()->prep_ssg_nodes( aip.getSGLocation(),   visibility_meters );
         Point3D scenery_center = globals->get_scenery()->get_center();
-       globals->get_tile_mgr()->update( aip.getFGLocation(), visibility_meters, (aip.getFGLocation())->get_absolute_view_pos( scenery_center ) );
-       // save results of update in FGLocation for fdm...
+       globals->get_tile_mgr()->update( aip.getSGLocation(), visibility_meters, (aip.getSGLocation())->get_absolute_view_pos( scenery_center ) );
+       // save results of update in SGLocation for fdm...
        
        //if ( globals->get_scenery()->get_cur_elev() > -9990 ) {
        //      acmodel_location->
@@ -1132,10 +1312,10 @@ void FGAILocalTraffic::DoGroundElev() {
        //}
        
        // The need for this here means that at least 2 consecutive passes are needed :-(
-       aip.getFGLocation()->set_tile_center( globals->get_scenery()->get_next_center() );
+       aip.getSGLocation()->set_tile_center( globals->get_scenery()->get_next_center() );
        
        //cout << "Transform Elev is " << globals->get_scenery()->get_cur_elev() << '\n';
-       aip.getFGLocation()->set_cur_elev_m(globals->get_scenery()->get_cur_elev());
+       aip.getSGLocation()->set_cur_elev_m(globals->get_scenery()->get_cur_elev());
        //return(globals->get_scenery()->get_cur_elev());
 }