]> git.mxchange.org Git - friendica.git/blobdiff - src/App/Router.php
API: Accept "redirect_uris" as both array and string
[friendica.git] / src / App / Router.php
index 880f9a2f885631ae70f333be55a402d64aa943b5..0bd66d40f94aedd84983af88f81fd71e5097f4c8 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2023, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -34,12 +34,17 @@ use Friendica\Core\Config\Capability\IManageConfigValues;
 use Friendica\Core\Hook;
 use Friendica\Core\L10n;
 use Friendica\Core\Lock\Capability\ICanLock;
+use Friendica\Core\Session\Capability\IHandleUserSessions;
 use Friendica\LegacyModule;
 use Friendica\Module\HTTPException\MethodNotAllowed;
 use Friendica\Module\HTTPException\PageNotFound;
+use Friendica\Module\Special\Options;
 use Friendica\Network\HTTPException;
+use Friendica\Network\HTTPException\InternalServerErrorException;
 use Friendica\Network\HTTPException\MethodNotAllowedException;
 use Friendica\Network\HTTPException\NotFoundException;
+use Friendica\Util\Router\FriendicaGroupCountBased;
+use Psr\Log\LoggerInterface;
 
 /**
  * Wrapper for FastRoute\Router
@@ -72,15 +77,10 @@ class Router
        /** @var RouteCollector */
        protected $routeCollector;
 
-       /**
-        * @var string The HTTP method
-        */
-       private $httpMethod;
-
        /**
         * @var array Module parameters
         */
-       private $parameters = [];
+       protected $parameters = [];
 
        /** @var L10n */
        private $l10n;
@@ -97,12 +97,27 @@ class Router
        /** @var IManageConfigValues */
        private $config;
 
+       /** @var LoggerInterface */
+       private $logger;
+
+       /** @var bool */
+       private $isLocalUser;
+
+       /** @var float */
+       private $dice_profiler_threshold;
+
        /** @var Dice */
        private $dice;
 
        /** @var string */
        private $baseRoutesFilepath;
 
+       /** @var array */
+       private $server;
+
+       /** @var string|null */
+       protected $moduleClass = null;
+
        /**
         * @param array               $server             The $_SERVER variable
         * @param string              $baseRoutesFilepath The path to a base routes file to leverage cache, can be empty
@@ -111,29 +126,32 @@ class Router
         * @param ICanLock            $lock
         * @param IManageConfigValues $config
         * @param Arguments           $args
+        * @param LoggerInterface     $logger
         * @param Dice                $dice
+        * @param IHandleUserSessions $userSession
         * @param RouteCollector|null $routeCollector
         */
-       public function __construct(array $server, string $baseRoutesFilepath, L10n $l10n, ICanCache $cache, ICanLock $lock, IManageConfigValues $config, Arguments $args, Dice $dice, RouteCollector $routeCollector = null)
+       public function __construct(array $server, string $baseRoutesFilepath, L10n $l10n, ICanCache $cache, ICanLock $lock, IManageConfigValues $config, Arguments $args, LoggerInterface $logger, Dice $dice, IHandleUserSessions $userSession, RouteCollector $routeCollector = null)
        {
-               $this->baseRoutesFilepath = $baseRoutesFilepath;
-               $this->l10n = $l10n;
-               $this->cache = $cache;
-               $this->lock = $lock;
-               $this->args = $args;
-               $this->config = $config;
-               $this->dice = $dice;
-
-               $httpMethod = $server['REQUEST_METHOD'] ?? self::GET;
-               $this->httpMethod = in_array($httpMethod, self::ALLOWED_METHODS) ? $httpMethod : self::GET;
-
-               $this->routeCollector = isset($routeCollector) ?
-                       $routeCollector :
-                       new RouteCollector(new Std(), new GroupCountBased());
+               $this->baseRoutesFilepath      = $baseRoutesFilepath;
+               $this->l10n                    = $l10n;
+               $this->cache                   = $cache;
+               $this->lock                    = $lock;
+               $this->args                    = $args;
+               $this->config                  = $config;
+               $this->dice                    = $dice;
+               $this->server                  = $server;
+               $this->logger                  = $logger;
+               $this->isLocalUser             = !empty($userSession->getLocalUserId());
+               $this->dice_profiler_threshold = $config->get('system', 'dice_profiler_threshold', 0);
+
+               $this->routeCollector = $routeCollector ?? new RouteCollector(new Std(), new GroupCountBased());
 
                if ($this->baseRoutesFilepath && !file_exists($this->baseRoutesFilepath)) {
                        throw new HTTPException\InternalServerErrorException('Routes file path does\'n exist.');
                }
+
+               $this->parameters = [$this->server];
        }
 
        /**
@@ -146,11 +164,9 @@ class Router
         *
         * @throws HTTPException\InternalServerErrorException In case of invalid configs
         */
-       public function loadRoutes(array $routes)
+       public function loadRoutes(array $routes): Router
        {
-               $routeCollector = (isset($this->routeCollector) ?
-                       $this->routeCollector :
-                       new RouteCollector(new Std(), new GroupCountBased()));
+               $routeCollector = ($this->routeCollector ?? new RouteCollector(new Std(), new GroupCountBased()));
 
                $this->addRoutes($routeCollector, $routes);
 
@@ -162,13 +178,23 @@ class Router
                return $this;
        }
 
+       /**
+        * Adds multiple routes to a route collector
+        *
+        * @param RouteCollector $routeCollector Route collector instance
+        * @param array $routes Multiple routes to be added
+        * @throws HTTPException\InternalServerErrorException If route was wrong (somehow)
+        */
        private function addRoutes(RouteCollector $routeCollector, array $routes)
        {
                foreach ($routes as $route => $config) {
                        if ($this->isGroup($config)) {
                                $this->addGroup($route, $config, $routeCollector);
                        } elseif ($this->isRoute($config)) {
-                               $routeCollector->addRoute($config[1], $route, $config[0]);
+                               // Always add the OPTIONS endpoint to a route
+                               $httpMethods   = (array) $config[1];
+                               $httpMethods[] = Router::OPTIONS;
+                               $routeCollector->addRoute($httpMethods, $route, $config[0]);
                        } else {
                                throw new HTTPException\InternalServerErrorException("Wrong route config for route '" . print_r($route, true) . "'");
                        }
@@ -196,7 +222,7 @@ class Router
         *
         * @return bool
         */
-       private function isGroup(array $config)
+       private function isGroup(array $config): bool
        {
                return
                        is_array($config) &&
@@ -214,7 +240,7 @@ class Router
         *
         * @return bool
         */
-       private function isRoute(array $config)
+       private function isRoute(array $config): bool
        {
                return
                        // The config array should at least have one entry
@@ -232,70 +258,74 @@ class Router
         *
         * @return RouteCollector|null
         */
-       public function getRouteCollector()
+       public function getRouteCollector(): ?RouteCollector
        {
                return $this->routeCollector;
        }
 
        /**
-        * Returns the relevant module class name for the given page URI or NULL if no route rule matched.
+        * Returns the Friendica\BaseModule-extending class name if a route rule matched
         *
-        * @return string A Friendica\BaseModule-extending class name if a route rule matched
+        * @return string
         *
-        * @throws HTTPException\InternalServerErrorException
-        * @throws HTTPException\MethodNotAllowedException    If a rule matched but the method didn't
-        * @throws HTTPException\NotFoundException            If no rule matched
+        * @throws InternalServerErrorException
+        * @throws MethodNotAllowedException
         */
-       private function getModuleClass()
+       public function getModuleClass(): string
        {
-               $cmd = $this->args->getCommand();
-               $cmd = '/' . ltrim($cmd, '/');
-
-               $dispatcher = new Dispatcher\GroupCountBased($this->getCachedDispatchData());
-
-               $this->parameters = [];
-
-               $routeInfo  = $dispatcher->dispatch($this->httpMethod, $cmd);
-               if ($routeInfo[0] === Dispatcher::FOUND) {
-                       $moduleClass = $routeInfo[1];
-                       $this->parameters = $routeInfo[2];
-               } elseif ($routeInfo[0] === Dispatcher::METHOD_NOT_ALLOWED) {
-                       throw new HTTPException\MethodNotAllowedException($this->l10n->t('Method not allowed for this module. Allowed method(s): %s', implode(', ', $routeInfo[1])));
-               } else {
-                       throw new HTTPException\NotFoundException($this->l10n->t('Page not found.'));
+               if (empty($this->moduleClass)) {
+                       $this->determineModuleClass();
                }
 
-               return $moduleClass;
+               return $this->moduleClass;
        }
 
-       public function getModule(): ICanHandleRequests
+       /**
+        * Returns the relevant module class name for the given page URI or NULL if no route rule matched.
+        *
+        * @return void
+        *
+        * @throws HTTPException\InternalServerErrorException Unexpected exceptions
+        * @throws HTTPException\MethodNotAllowedException    If a rule is private only
+        */
+       private function determineModuleClass(): void
        {
-               $module_class      = null;
-               $module_parameters = [];
-               /**
-                * ROUTING
-                *
-                * From the request URL, routing consists of obtaining the name of a BaseModule-extending class of which the
-                * post() and/or content() static methods can be respectively called to produce a data change or an output.
-                **/
+               $cmd = $this->args->getCommand();
+               $cmd = '/' . ltrim($cmd, '/');
+
+               $dispatcher = new FriendicaGroupCountBased($this->getCachedDispatchData());
+
                try {
-                       $module_class        = $this->getModuleClass();
-                       $module_parameters[] = $this->parameters;
+                       // Check if the HTTP method is OPTIONS and return the special Options Module with the possible HTTP methods
+                       if ($this->args->getMethod() === static::OPTIONS) {
+                               $this->moduleClass = Options::class;
+                               $this->parameters[] = ['AllowedMethods' => $dispatcher->getOptions($cmd)];
+                       } else {
+                               $routeInfo = $dispatcher->dispatch($this->args->getMethod(), $cmd);
+                               if ($routeInfo[0] === Dispatcher::FOUND) {
+                                       $this->moduleClass = $routeInfo[1];
+                                       $this->parameters[] = $routeInfo[2];
+                               } else if ($routeInfo[0] === Dispatcher::METHOD_NOT_ALLOWED) {
+                                       throw new HTTPException\MethodNotAllowedException($this->l10n->t('Method not allowed for this module. Allowed method(s): %s', implode(', ', $routeInfo[1])));
+                               } else {
+                                       throw new HTTPException\NotFoundException($this->l10n->t('Page not found.'));
+                               }
+                       }
                } catch (MethodNotAllowedException $e) {
-                       $module_class = MethodNotAllowed::class;
+                       $this->moduleClass = MethodNotAllowed::class;
                } catch (NotFoundException $e) {
                        $moduleName = $this->args->getModuleName();
                        // Then we try addon-provided modules that we wrap in the LegacyModule class
                        if (Addon::isEnabled($moduleName) && file_exists("addon/{$moduleName}/{$moduleName}.php")) {
                                //Check if module is an app and if public access to apps is allowed or not
                                $privateapps = $this->config->get('config', 'private_addons', false);
-                               if ((!local_user()) && Hook::isAddonApp($moduleName) && $privateapps) {
+                               if (!$this->isLocalUser && Hook::isAddonApp($moduleName) && $privateapps) {
                                        throw new MethodNotAllowedException($this->l10n->t("You must be logged in to use addons. "));
                                } else {
                                        include_once "addon/{$moduleName}/{$moduleName}.php";
                                        if (function_exists($moduleName . '_module')) {
-                                               $module_parameters[] = "addon/{$moduleName}/{$moduleName}.php";
-                                               $module_class        = LegacyModule::class;
+                                               $this->parameters[] = "addon/{$moduleName}/{$moduleName}.php";
+                                               $this->moduleClass  = LegacyModule::class;
                                        }
                                }
                        }
@@ -303,16 +333,32 @@ class Router
                        /* Finally, we look for a 'standard' program module in the 'mod' directory
                         * We emulate a Module class through the LegacyModule class
                         */
-                       if (!$module_class && file_exists("mod/{$moduleName}.php")) {
-                               $module_parameters[] = "mod/{$moduleName}.php";
-                               $module_class        = LegacyModule::class;
+                       if (!$this->moduleClass && file_exists("mod/{$moduleName}.php")) {
+                               $this->parameters[] = "mod/{$moduleName}.php";
+                               $this->moduleClass  = LegacyModule::class;
                        }
 
-                       $module_class = $module_class ?: PageNotFound::class;
+                       $this->moduleClass = $this->moduleClass ?: PageNotFound::class;
                }
+       }
+
+       public function getModule(?string $module_class = null): ICanHandleRequests
+       {
+               $moduleClass = $module_class ?? $this->getModuleClass();
 
-               /** @var ICanHandleRequests $module */
-               return $this->dice->create($module_class, $module_parameters);
+               $stamp = microtime(true);
+
+               try {
+                       /** @var ICanHandleRequests $module */
+                       return $this->dice->create($moduleClass, $this->parameters);
+               } finally {
+                       if ($this->dice_profiler_threshold > 0) {
+                               $dur = floatval(microtime(true) - $stamp);
+                               if ($dur >= $this->dice_profiler_threshold) {
+                                       $this->logger->notice('Dice module creation lasts too long.', ['duration' => round($dur, 3), 'module' => $moduleClass, 'parameters' => $this->parameters]);
+                               }
+                       }
+               }
        }
 
        /**
@@ -352,13 +398,13 @@ class Router
         */
        private function getCachedDispatchData()
        {
-               $routerDispatchData = $this->cache->get('routerDispatchData');
+               $routerDispatchData         = $this->cache->get('routerDispatchData');
                $lastRoutesFileModifiedTime = $this->cache->get('lastRoutesFileModifiedTime');
-               $forceRecompute = false;
+               $forceRecompute             = false;
 
                if ($this->baseRoutesFilepath) {
                        $routesFileModifiedTime = filemtime($this->baseRoutesFilepath);
-                       $forceRecompute = $lastRoutesFileModifiedTime != $routesFileModifiedTime;
+                       $forceRecompute         = $lastRoutesFileModifiedTime != $routesFileModifiedTime;
                }
 
                if (!$forceRecompute && $routerDispatchData) {