Set item permissions on reshare

[friendica.git] / src / BaseModule.php

diff --git a/src/BaseModule.php b/src/BaseModule.php
index c68af875d7aae46bb388c9928b7c4186359ce22b..86dd5e7c064d1d83b035da29ba91ec6ccc5e5543 100644 (file)
--- a/src/BaseModule.php
+++ b/src/BaseModule.php
@@ -23,8 +23,7 @@ namespace Friendica;
 
 use Friendica\App\Router;
 use Friendica\Capabilities\ICanHandleRequests;
-use Friendica\Capabilities\ICanReadAndWriteToResponds;
-use Friendica\Capabilities\IRespondToRequests;
+use Friendica\Capabilities\ICanCreateResponses;
 use Friendica\Core\Hook;
 use Friendica\Core\L10n;
 use Friendica\Core\Logger;
@@ -33,6 +32,7 @@ use Friendica\Module\Response;
 use Friendica\Module\Special\HTTPException as ModuleHTTPException;
 use Friendica\Network\HTTPException;
 use Friendica\Util\Profiler;
+use Psr\Http\Message\ResponseInterface;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -60,7 +60,7 @@ abstract class BaseModule implements ICanHandleRequests
        protected $profiler;
        /** @var array */
        protected $server;
-       /** @var ICanReadAndWriteToResponds */
+       /** @var ICanCreateResponses */
        protected $response;
 
        public function __construct(L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, Response $response, array $server, array $parameters = [])
@@ -168,39 +168,33 @@ abstract class BaseModule implements ICanHandleRequests
        {
        }
 
-       /** Gets the name of the current class */
-       public function getClassName(): string
-       {
-               return static::class;
-       }
-
        /**
         * {@inheritDoc}
         */
-       public function run(array $post = [], array $request = []): IRespondToRequests
+       public function run(array $post = [], array $request = []): ResponseInterface
        {
                // @see https://github.com/tootsuite/mastodon/blob/c3aef491d66aec743a3a53e934a494f653745b61/config/initializers/cors.rb
                if (substr($request['pagename'] ?? '', 0, 12) == '.well-known/') {
-                       header('Access-Control-Allow-Origin: *');
-                       header('Access-Control-Allow-Headers: *');
-                       header('Access-Control-Allow-Methods: ' . Router::GET);
-                       header('Access-Control-Allow-Credentials: false');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Origin');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Headers');
+                       $this->response->setHeader(Router::GET, 'Access-Control-Allow-Methods');
+                       $this->response->setHeader('false', 'Access-Control-Allow-Credentials');
                } elseif (substr($request['pagename'] ?? '', 0, 8) == 'profile/') {
-                       header('Access-Control-Allow-Origin: *');
-                       header('Access-Control-Allow-Headers: *');
-                       header('Access-Control-Allow-Methods: ' . Router::GET);
-                       header('Access-Control-Allow-Credentials: false');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Origin');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Headers');
+                       $this->response->setHeader(Router::GET, 'Access-Control-Allow-Methods');
+                       $this->response->setHeader('false', 'Access-Control-Allow-Credentials');
                } elseif (substr($request['pagename'] ?? '', 0, 4) == 'api/') {
-                       header('Access-Control-Allow-Origin: *');
-                       header('Access-Control-Allow-Headers: *');
-                       header('Access-Control-Allow-Methods: ' . implode(',', Router::ALLOWED_METHODS));
-                       header('Access-Control-Allow-Credentials: false');
-                       header('Access-Control-Expose-Headers: Link');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Origin');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Headers');
+                       $this->response->setHeader(implode(',', Router::ALLOWED_METHODS), 'Access-Control-Allow-Methods');
+                       $this->response->setHeader('false', 'Access-Control-Allow-Credentials');
+                       $this->response->setHeader('Link', 'Access-Control-Expose-Headers');
                } elseif (substr($request['pagename'] ?? '', 0, 11) == 'oauth/token') {
-                       header('Access-Control-Allow-Origin: *');
-                       header('Access-Control-Allow-Headers: *');
-                       header('Access-Control-Allow-Methods: ' . Router::POST);
-                       header('Access-Control-Allow-Credentials: false');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Origin');
+                       $this->response->setHeader('*', 'Access-Control-Allow-Headers');
+                       $this->response->setHeader(Router::POST, 'Access-Control-Allow-Methods');
+                       $this->response->setHeader('false', 'Access-Control-Allow-Credentials');
                }
 
                $placeholder = '';
@@ -211,43 +205,40 @@ abstract class BaseModule implements ICanHandleRequests
                Core\Hook::callAll($this->args->getModuleName() . '_mod_init', $placeholder);
 
                $this->profiler->set(microtime(true) - $timestamp, 'init');
-               $this->response->setType(IRespondToRequests::TYPE_CONTENT);
 
-               switch ($this->server['REQUEST_METHOD']) {
+               switch ($this->server['REQUEST_METHOD'] ?? Router::GET) {
                        case Router::DELETE:
-                               $this->response->setType(IRespondToRequests::TYPE_DELETE);
                                $this->delete();
                                break;
                        case Router::PATCH:
-                               $this->response->setType(IRespondToRequests::TYPE_PATCH);
                                $this->patch();
                                break;
                        case Router::POST:
                                Core\Hook::callAll($this->args->getModuleName() . '_mod_post', $post);
-                               $this->response->setType(IRespondToRequests::TYPE_POST);
                                $this->post($request, $post);
                                break;
                        case Router::PUT:
-                               $this->response->setType(IRespondToRequests::TYPE_PUT);
                                $this->put();
                                break;
-                       default:
-                               // "rawContent" is especially meant for technical endpoints.
-                               // This endpoint doesn't need any theme initialization or other comparable stuff.
-                               $this->rawContent($request);
-
-                               try {
-                                       $arr = ['content' => ''];
-                                       Hook::callAll(static::class . '_mod_content', $arr);
-                                       $this->response->addContent($arr['content']);
-                                       $this->response->addContent($this->content($_REQUEST));
-                               } catch (HTTPException $e) {
-                                       $this->response->addContent((new ModuleHTTPException())->content($e));
-                               }
-                               break;
                }
 
-               return $this->response;
+               $timestamp = microtime(true);
+               // "rawContent" is especially meant for technical endpoints.
+               // This endpoint doesn't need any theme initialization or other comparable stuff.
+               $this->rawContent($request);
+
+               try {
+                       $arr = ['content' => ''];
+                       Hook::callAll(static::class . '_mod_content', $arr);
+                       $this->response->addContent($arr['content']);
+                       $this->response->addContent($this->content($_REQUEST));
+               } catch (HTTPException $e) {
+                       $this->response->addContent((new ModuleHTTPException())->content($e));
+               } finally {
+                       $this->profiler->set(microtime(true) - $timestamp, 'content');
+               }
+
+               return $this->response->generate();
        }
 
        /*