Andy Ross:

[flightgear.git] / src / Cockpit / panel.cxx

diff --git a/src/Cockpit/panel.cxx b/src/Cockpit/panel.cxx
index 6ec50fd59f57f242085fec72db8e359f731aea1d..d2332b9d8fc54e2903a605723163f5b55302fbef 100644 (file)
--- a/src/Cockpit/panel.cxx
+++ b/src/Cockpit/panel.cxx
@@ -279,14 +279,7 @@ FGPanel::update (double dt)
         return;
     }
 
-                               // If the mouse is down, do something
-    if (_mouseDown) {
-        _mouseDelay--;
-        if (_mouseDelay < 0) {
-            _mouseInstrument->doMouseAction(_mouseButton, _mouseX, _mouseY);
-            _mouseDelay = 2;
-        }
-    }
+    updateMouseDelay();
 
                                // Now, draw the panel
     float aspect_adjust = get_aspect_adjust(_xsize_node->getIntValue(),
@@ -297,6 +290,22 @@ FGPanel::update (double dt)
         update(WIN_X, WIN_W, WIN_Y, int(WIN_H / aspect_adjust));
 }
 
+/**
+ * Handle repeatable mouse events.  Called from update() and from
+ * fgUpdate3DPanels().  This functionality needs to move into the
+ * input subsystem.  Counting a tick every two frames is clumsy...
+ */
+void FGPanel::updateMouseDelay()
+{
+    if (_mouseDown) {
+        _mouseDelay--;
+        if (_mouseDelay < 0) {
+            _mouseInstrument->doMouseAction(_mouseButton, _mouseX, _mouseY);
+            _mouseDelay = 2;
+        }
+    }
+}
+
 
 void
 FGPanel::update (GLfloat winx, GLfloat winw, GLfloat winy, GLfloat winh)
@@ -494,38 +503,21 @@ FGPanel::setYOffset (int offset)
 }
 
 /**
- * Perform a mouse action.
+ * Handle a mouse action in panel-local (not screen) coordinates.
+ * Used by the 3D panel code in Model/panelnode.cxx, in situations
+ * where the panel doesn't control its own screen location.
  */
 bool
-FGPanel::doMouseAction (int button, int updown, int x, int y)
+FGPanel::doLocalMouseAction(int button, int updown, int x, int y)
 {
-                               // FIXME: this same code appears in update()
-  int xsize = _xsize_node->getIntValue();
-  int ysize = _ysize_node->getIntValue();
-  float aspect_adjust = get_aspect_adjust(xsize, ysize);
-
-                               // Note a released button and return
-  // cerr << "Doing mouse action\n";
+  // Note a released button and return
   if (updown == 1) {
     _mouseDown = false;
     _mouseInstrument = 0;
     return false;
   }
 
-                               // Scale for the real window size.
-  if (aspect_adjust < 1.0) {
-    x = int(((float)x / xsize) * WIN_W * aspect_adjust);
-    y = int(WIN_H - ((float(y) / ysize) * WIN_H));
-  } else {
-    x = int(((float)x / xsize) * WIN_W);
-    y = int((WIN_H - ((float(y) / ysize) * WIN_H)) / aspect_adjust);
-  }
-
-                               // Adjust for offsets.
-  x -= _x_offset;
-  y -= _y_offset;
-
-                               // Search for a matching instrument.
+  // Search for a matching instrument.
   for (int i = 0; i < (int)_instruments.size(); i++) {
     FGPanelInstrument *inst = _instruments[i];
     int ix = inst->getXPos();
@@ -539,13 +531,42 @@ FGPanel::doMouseAction (int button, int updown, int x, int y)
       _mouseButton = button;
       _mouseX = x - ix;
       _mouseY = y - iy;
-                               // Always do the action once.
+      // Always do the action once.
       return _mouseInstrument->doMouseAction(_mouseButton, _mouseX, _mouseY);
     }
   }
   return false;
 }
 
+/**
+ * Perform a mouse action.
+ */
+bool
+FGPanel::doMouseAction (int button, int updown, int x, int y)
+{
+                               // FIXME: this same code appears in update()
+  int xsize = _xsize_node->getIntValue();
+  int ysize = _ysize_node->getIntValue();
+  float aspect_adjust = get_aspect_adjust(xsize, ysize);
+
+                               // Scale for the real window size.
+  if (aspect_adjust < 1.0) {
+    x = int(((float)x / xsize) * WIN_W * aspect_adjust);
+    y = int(WIN_H - ((float(y) / ysize) * WIN_H));
+  } else {
+    x = int(((float)x / xsize) * WIN_W);
+    y = int((WIN_H - ((float(y) / ysize) * WIN_H)) / aspect_adjust);
+  }
+
+                               // Adjust for offsets.
+  x -= _x_offset;
+  y -= _y_offset;
+
+  // Having fixed up the coordinates, fall through to the local
+  // coordinate handler.
+  doLocalMouseAction(button, updown, x, y);
+} 
+
 
 \f
 ////////////////////////////////////////////////////////////////////////.