Creating interfaces for Config/PConfig & fix tests

[friendica.git] / src / Console / ServerBlock.php

diff --git a/src/Console/ServerBlock.php b/src/Console/ServerBlock.php
index 7e45f108bb87309b2fa369067126a8ba473a19e9..f94c24dbd9eaf1f7fe4a42ec9a3ef843e8b0ddec 100644 (file)
--- a/src/Console/ServerBlock.php
+++ b/src/Console/ServerBlock.php
@@ -5,8 +5,7 @@ namespace Friendica\Console;
 use Asika\SimpleConsole\CommandArgsException;
 use Asika\SimpleConsole\Console;
 use Console_Table;
-use Friendica\BaseObject;
-use Friendica\Core\Config\Configuration;
+use Friendica\Core\Config\IConfiguration;
 
 /**
  * @brief Manage blocked servers
@@ -20,18 +19,28 @@ class ServerBlock extends Console
 
        protected $helpOptions = ['h', 'help', '?'];
 
+       /**
+        * @var IConfiguration
+        */
+       private $config;
+
        protected function getHelp()
        {
                $help = <<<HELP
-console serverblock - Manage blocked servers
+console serverblock - Manage blocked server domain patterns
 Usage
        bin/console serverblock [-h|--help|-?] [-v]
-       bin/console serverblock add <server> <reason> [-h|--help|-?] [-v]
-       bin/console serverblock remove <server> [-h|--help|-?] [-v]
+       bin/console serverblock add <pattern> <reason> [-h|--help|-?] [-v]
+       bin/console serverblock remove <pattern> [-h|--help|-?] [-v]
 
 Description
-       With this tool, you can list the current blocked servers
-    or you can add / remove a blocked server from the list
+       With this tool, you can list the current blocked server domain patterns
+    or you can add / remove a blocked server domain pattern from the list.
+    
+    Patterns are case-insensitive shell wildcard comprising the following special characters:
+    - * : Any number of characters
+    - ? : Any single character
+    - [<char1><char2>...] : char1 or char2 or...
 
 Options
     -h|--help|-? Show help information
@@ -40,20 +49,25 @@ HELP;
                return $help;
        }
 
-       protected function doExecute()
+       public function __construct(IConfiguration $config, $argv = null)
        {
-               $a = BaseObject::getApp();
+               parent::__construct($argv);
 
+               $this->config = $config;
+       }
+
+       protected function doExecute()
+       {
                if (count($this->args) == 0) {
-                       $this->printBlockedServers($a->getConfig());
+                       $this->printBlockedServers($this->config);
                        return 0;
                }
 
                switch ($this->getArgument(0)) {
                        case 'add':
-                               return $this->addBlockedServer($a->getConfig());
+                               return $this->addBlockedServer($this->config);
                        case 'remove':
-                               return $this->removeBlockedServer($a->getConfig());
+                               return $this->removeBlockedServer($this->config);
                        default:
                                throw new CommandArgsException('Unknown command.');
                                break;
@@ -63,13 +77,13 @@ HELP;
        /**
         * Prints the whole list of blocked domains including the reason
         *
-        * @param Configuration $config
+        * @param IConfiguration $config
         */
-       private function printBlockedServers(Configuration $config)
+       private function printBlockedServers(IConfiguration $config)
        {
                $table = new Console_Table();
                $table->setHeaders(['Domain', 'Reason']);
-               $blocklist = $config->get('system', 'blocklist');
+               $blocklist = $config->get('system', 'blocklist', []);
                foreach ($blocklist as $domain) {
                        $table->addRow($domain);
                }
@@ -79,11 +93,11 @@ HELP;
        /**
         * Adds a server to the blocked list
         *
-        * @param Configuration $config
+        * @param IConfiguration $config
         *
         * @return int The return code (0 = success, 1 = failed)
         */
-       private function addBlockedServer(Configuration $config)
+       private function addBlockedServer(IConfiguration $config)
        {
                if (count($this->args) < 2 || count($this->args) > 3) {
                        throw new CommandArgsException('Add needs a domain and optional a reason.');
@@ -94,7 +108,7 @@ HELP;
 
                $update = false;
 
-               $currBlocklist = $config->get('system', 'blocklist');
+               $currBlocklist = $config->get('system', 'blocklist', []);
                $newBlockList = [];
                foreach ($currBlocklist  as $blocked) {
                        if ($blocked['domain'] === $domain) {
@@ -131,11 +145,11 @@ HELP;
        /**
         * Removes a server from the blocked list
         *
-        * @param Configuration $config
+        * @param IConfiguration $config
         *
         * @return int The return code (0 = success, 1 = failed)
         */
-       private function removeBlockedServer(Configuration $config)
+       private function removeBlockedServer(IConfiguration $config)
        {
                if (count($this->args) !== 2) {
                        throw new CommandArgsException('Remove needs a second parameter.');
@@ -145,7 +159,7 @@ HELP;
 
                $found = false;
 
-               $currBlocklist = $config->get('system', 'blocklist');
+               $currBlocklist = $config->get('system', 'blocklist', []);
                $newBlockList = [];
                foreach ($currBlocklist as $blocked) {
                        if ($blocked['domain'] === $domain) {