]> git.mxchange.org Git - friendica.git/blobdiff - src/Content/Text/BBCode.php
Merge pull request #7973 from tobiasd/2019.12-CHANGELOG
[friendica.git] / src / Content / Text / BBCode.php
index c5f9986f1fb55c0137148473c042f5ea4422fab2..e5622d14b43e478107345dcfe4f3890313a007d3 100644 (file)
@@ -24,6 +24,8 @@ use Friendica\Model\Event;
 use Friendica\Model\Photo;
 use Friendica\Network\Probe;
 use Friendica\Object\Image;
+use Friendica\Protocol\Activity;
+use Friendica\Util\Images;
 use Friendica\Util\Map;
 use Friendica\Util\Network;
 use Friendica\Util\ParseUrl;
@@ -38,7 +40,7 @@ class BBCode extends BaseObject
         *
         * @param string $body Message body
         * @return array
-        *                     'type' -> Message type ("link", "video", "photo")
+        *                     'type' -> Message type ('link', 'video', 'photo')
         *                     'text' -> Text before the shared message
         *                     'after' -> Text after the shared message
         *                     'image' -> Preview image of the message
@@ -56,48 +58,48 @@ class BBCode extends BaseObject
 
                if (preg_match_all("(\[class=(.*?)\](.*?)\[\/class\])ism", $body, $attached, PREG_SET_ORDER)) {
                        foreach ($attached as $data) {
-                               if (!in_array($data[1], ["type-link", "type-video", "type-photo"])) {
+                               if (!in_array($data[1], ['type-link', 'type-video', 'type-photo'])) {
                                        continue;
                                }
 
-                               $post["type"] = substr($data[1], 5);
+                               $post['type'] = substr($data[1], 5);
 
                                $pos = strpos($body, $data[0]);
                                if ($pos > 0) {
-                                       $post["text"] = trim(substr($body, 0, $pos));
-                                       $post["after"] = trim(substr($body, $pos + strlen($data[0])));
+                                       $post['text'] = trim(substr($body, 0, $pos));
+                                       $post['after'] = trim(substr($body, $pos + strlen($data[0])));
                                } else {
-                                       $post["text"] = trim(str_replace($data[0], "", $body));
-                                       $post["after"] = '';
+                                       $post['text'] = trim(str_replace($data[0], '', $body));
+                                       $post['after'] = '';
                                }
 
                                $attacheddata = $data[2];
 
                                if (preg_match("/\[img\](.*?)\[\/img\]/ism", $attacheddata, $matches)) {
 
-                                       $picturedata = Image::getInfoFromURL($matches[1]);
+                                       $picturedata = Images::getInfoFromURLCached($matches[1]);
 
                                        if ($picturedata) {
                                                if (($picturedata[0] >= 500) && ($picturedata[0] >= $picturedata[1])) {
-                                                       $post["image"] = $matches[1];
+                                                       $post['image'] = $matches[1];
                                                } else {
-                                                       $post["preview"] = $matches[1];
+                                                       $post['preview'] = $matches[1];
                                                }
                                        }
                                }
 
                                if (preg_match("/\[bookmark\=(.*?)\](.*?)\[\/bookmark\]/ism", $attacheddata, $matches)) {
-                                       $post["url"] = $matches[1];
-                                       $post["title"] = $matches[2];
+                                       $post['url'] = $matches[1];
+                                       $post['title'] = $matches[2];
                                }
-                               if (!empty($post["url"]) && (in_array($post["type"], ["link", "video"]))
+                               if (!empty($post['url']) && (in_array($post['type'], ['link', 'video']))
                                        && preg_match("/\[url\=(.*?)\](.*?)\[\/url\]/ism", $attacheddata, $matches)) {
-                                       $post["url"] = $matches[1];
+                                       $post['url'] = $matches[1];
                                }
 
                                // Search for description
                                if (preg_match("/\[quote\](.*?)\[\/quote\]/ism", $attacheddata, $matches)) {
-                                       $post["description"] = $matches[1];
+                                       $post['description'] = $matches[1];
                                }
                        }
                }
@@ -109,7 +111,7 @@ class BBCode extends BaseObject
         *
         * @param string $body Message body
         * @return array
-        *                     'type' -> Message type ("link", "video", "photo")
+        *                     'type' -> Message type ('link', 'video', 'photo')
         *                     'text' -> Text before the shared message
         *                     'after' -> Text after the shared message
         *                     'image' -> Preview image of the message
@@ -136,9 +138,9 @@ class BBCode extends BaseObject
 
                $attributes = $match[2];
 
-               $data["text"] = trim($match[1]);
+               $data['text'] = trim($match[1]);
 
-               $type = "";
+               $type = '';
                preg_match("/type='(.*?)'/ism", $attributes, $matches);
                if (!empty($matches[1])) {
                        $type = strtolower($matches[1]);
@@ -149,19 +151,19 @@ class BBCode extends BaseObject
                        $type = strtolower($matches[1]);
                }
 
-               if ($type == "") {
+               if ($type == '') {
                        return [];
                }
 
-               if (!in_array($type, ["link", "audio", "photo", "video"])) {
+               if (!in_array($type, ['link', 'audio', 'photo', 'video'])) {
                        return [];
                }
 
-               if ($type != "") {
-                       $data["type"] = $type;
+               if ($type != '') {
+                       $data['type'] = $type;
                }
 
-               $url = "";
+               $url = '';
                preg_match("/url='(.*?)'/ism", $attributes, $matches);
                if (!empty($matches[1])) {
                        $url = $matches[1];
@@ -172,11 +174,11 @@ class BBCode extends BaseObject
                        $url = $matches[1];
                }
 
-               if ($url != "") {
-                       $data["url"] = html_entity_decode($url, ENT_QUOTES, 'UTF-8');
+               if ($url != '') {
+                       $data['url'] = html_entity_decode($url, ENT_QUOTES, 'UTF-8');
                }
 
-               $title = "";
+               $title = '';
                preg_match("/title='(.*?)'/ism", $attributes, $matches);
                if (!empty($matches[1])) {
                        $title = $matches[1];
@@ -187,14 +189,14 @@ class BBCode extends BaseObject
                        $title = $matches[1];
                }
 
-               if ($title != "") {
+               if ($title != '') {
                        $title = self::convert(html_entity_decode($title, ENT_QUOTES, 'UTF-8'), false, true);
                        $title = html_entity_decode($title, ENT_QUOTES, 'UTF-8');
-                       $title = str_replace(["[", "]"], ["[", "]"], $title);
-                       $data["title"] = $title;
+                       $title = str_replace(['[', ']'], ['[', ']'], $title);
+                       $data['title'] = $title;
                }
 
-               $image = "";
+               $image = '';
                preg_match("/image='(.*?)'/ism", $attributes, $matches);
                if (!empty($matches[1])) {
                        $image = $matches[1];
@@ -205,11 +207,11 @@ class BBCode extends BaseObject
                        $image = $matches[1];
                }
 
-               if ($image != "") {
-                       $data["image"] = html_entity_decode($image, ENT_QUOTES, 'UTF-8');
+               if ($image != '') {
+                       $data['image'] = html_entity_decode($image, ENT_QUOTES, 'UTF-8');
                }
 
-               $preview = "";
+               $preview = '';
                preg_match("/preview='(.*?)'/ism", $attributes, $matches);
                if (!empty($matches[1])) {
                        $preview = $matches[1];
@@ -220,13 +222,13 @@ class BBCode extends BaseObject
                        $preview = $matches[1];
                }
 
-               if ($preview != "") {
-                       $data["preview"] = html_entity_decode($preview, ENT_QUOTES, 'UTF-8');
+               if ($preview != '') {
+                       $data['preview'] = html_entity_decode($preview, ENT_QUOTES, 'UTF-8');
                }
 
-               $data["description"] = trim($match[3]);
+               $data['description'] = trim($match[3]);
 
-               $data["after"] = trim($match[4]);
+               $data['after'] = trim($match[4]);
 
                return $data;
        }
@@ -244,7 +246,7 @@ class BBCode extends BaseObject
                */
 
                $has_title = !empty($item['title']);
-               $plink = defaults($item, 'plink', '');
+               $plink = $item['plink'] ?? '';
                $post = self::getAttachmentData($body);
 
                // Get all linked images with alternative image description
@@ -268,15 +270,15 @@ class BBCode extends BaseObject
                }
 
                // if nothing is found, it maybe having an image.
-               if (!isset($post["type"])) {
+               if (!isset($post['type'])) {
                        // Simplify image codes
                        $body = preg_replace("/\[img\=([0-9]*)x([0-9]*)\](.*?)\[\/img\]/ism", '[img]$3[/img]', $body);
                        $body = preg_replace("/\[img\=(.*?)\](.*?)\[\/img\]/ism", '[img]$1[/img]', $body);
-                       $post["text"] = $body;
+                       $post['text'] = $body;
 
                        if (preg_match_all("(\[url=(.*?)\]\s*\[img\](.*?)\[\/img\]\s*\[\/url\])ism", $body, $pictures, PREG_SET_ORDER)) {
                                if ((count($pictures) == 1) && !$has_title) {
-                                       if (!empty($item['object-type']) && ($item['object-type'] == ACTIVITY_OBJ_IMAGE)) {
+                                       if (!empty($item['object-type']) && ($item['object-type'] == Activity\ObjectType::IMAGE)) {
                                                // Replace the preview picture with the real picture
                                                $url = str_replace('-1.', '-0.', $pictures[0][2]);
                                                $data = ['url' => $url, 'type' => 'photo'];
@@ -288,75 +290,78 @@ class BBCode extends BaseObject
                                        // Workaround:
                                        // Sometimes photo posts to the own album are not detected at the start.
                                        // So we seem to cannot use the cache for these cases. That's strange.
-                                       if (($data["type"] != "photo") && strstr($pictures[0][1], "/photos/")) {
+                                       if (($data['type'] != 'photo') && strstr($pictures[0][1], "/photos/")) {
                                                $data = ParseUrl::getSiteinfo($pictures[0][1], true);
                                        }
 
-                                       if ($data["type"] == "photo") {
-                                               $post["type"] = "photo";
-                                               if (isset($data["images"][0])) {
-                                                       $post["image"] = $data["images"][0]["src"];
-                                                       $post["url"] = $data["url"];
+                                       if ($data['type'] == 'photo') {
+                                               $post['type'] = 'photo';
+                                               if (isset($data['images'][0])) {
+                                                       $post['image'] = $data['images'][0]['src'];
+                                                       $post['url'] = $data['url'];
                                                } else {
-                                                       $post["image"] = $data["url"];
+                                                       $post['image'] = $data['url'];
                                                }
 
-                                               $post["preview"] = $pictures[0][2];
-                                               $post["text"] = trim(str_replace($pictures[0][0], "", $body));
+                                               $post['preview'] = $pictures[0][2];
+                                               $post['text'] = trim(str_replace($pictures[0][0], '', $body));
                                        } else {
-                                               $imgdata = Image::getInfoFromURL($pictures[0][1]);
-                                               if ($imgdata && substr($imgdata["mime"], 0, 6) == "image/") {
-                                                       $post["type"] = "photo";
-                                                       $post["image"] = $pictures[0][1];
-                                                       $post["preview"] = $pictures[0][2];
-                                                       $post["text"] = trim(str_replace($pictures[0][0], "", $body));
+                                               $imgdata = Images::getInfoFromURLCached($pictures[0][1]);
+                                               if ($imgdata && substr($imgdata['mime'], 0, 6) == 'image/') {
+                                                       $post['type'] = 'photo';
+                                                       $post['image'] = $pictures[0][1];
+                                                       $post['preview'] = $pictures[0][2];
+                                                       $post['text'] = trim(str_replace($pictures[0][0], '', $body));
                                                }
                                        }
                                } elseif (count($pictures) > 0) {
-                                       $post["type"] = "link";
-                                       $post["url"] = $plink;
-                                       $post["image"] = $pictures[0][2];
-                                       $post["text"] = $body;
+                                       $post['type'] = 'link';
+                                       $post['url'] = $plink;
+                                       $post['image'] = $pictures[0][2];
+                                       $post['text'] = $body;
 
                                        foreach ($pictures as $picture) {
-                                               $post["text"] = trim(str_replace($picture[0], "", $post["text"]));
+                                               $post['text'] = trim(str_replace($picture[0], '', $post['text']));
                                        }
                                }
                        } elseif (preg_match_all("(\[img\](.*?)\[\/img\])ism", $body, $pictures, PREG_SET_ORDER)) {
                                if ((count($pictures) == 1) && !$has_title) {
-                                       $post["type"] = "photo";
-                                       $post["image"] = $pictures[0][1];
-                                       $post["text"] = str_replace($pictures[0][0], "", $body);
+                                       $post['type'] = 'photo';
+                                       $post['image'] = $pictures[0][1];
+                                       $post['text'] = str_replace($pictures[0][0], '', $body);
                                } elseif (count($pictures) > 0) {
-                                       $post["type"] = "link";
-                                       $post["url"] = $plink;
-                                       $post["image"] = $pictures[0][1];
-                                       $post["text"] = $body;
+                                       $post['type'] = 'link';
+                                       $post['url'] = $plink;
+                                       $post['image'] = $pictures[0][1];
+                                       $post['text'] = $body;
 
                                        foreach ($pictures as $picture) {
-                                               $post["text"] = trim(str_replace($picture[0], "", $post["text"]));
+                                               $post['text'] = trim(str_replace($picture[0], '', $post['text']));
                                        }
                                }
                        }
 
                        // Test for the external links
-                       preg_match_all("(\[url\](.*?)\[\/url\])ism", $post["text"], $links1, PREG_SET_ORDER);
-                       preg_match_all("(\[url\=(.*?)\].*?\[\/url\])ism", $post["text"], $links2, PREG_SET_ORDER);
+                       preg_match_all("(\[url\](.*?)\[\/url\])ism", $post['text'], $links1, PREG_SET_ORDER);
+                       preg_match_all("(\[url\=(.*?)\].*?\[\/url\])ism", $post['text'], $links2, PREG_SET_ORDER);
 
                        $links = array_merge($links1, $links2);
 
                        // If there is only a single one, then use it.
                        // This should cover link posts via API.
-                       if ((count($links) == 1) && !isset($post["preview"]) && !$has_title) {
-                               $post["type"] = "link";
-                               $post["url"] = $links[0][1];
+                       if ((count($links) == 1) && !isset($post['preview']) && !$has_title) {
+                               $post['type'] = 'link';
+                               $post['url'] = $links[0][1];
                        }
 
+                       // Simplify "video" element
+                       $post['text'] = preg_replace('(\[video.*?\ssrc\s?=\s?([^\s\]]+).*?\].*?\[/video\])ism', '[video]$1[/video]', $post['text']);
+
                        // Now count the number of external media links
-                       preg_match_all("(\[vimeo\](.*?)\[\/vimeo\])ism", $post["text"], $links1, PREG_SET_ORDER);
-                       preg_match_all("(\[youtube\\](.*?)\[\/youtube\\])ism", $post["text"], $links2, PREG_SET_ORDER);
-                       preg_match_all("(\[video\\](.*?)\[\/video\\])ism", $post["text"], $links3, PREG_SET_ORDER);
-                       preg_match_all("(\[audio\\](.*?)\[\/audio\\])ism", $post["text"], $links4, PREG_SET_ORDER);
+                       preg_match_all("(\[vimeo\](.*?)\[\/vimeo\])ism", $post['text'], $links1, PREG_SET_ORDER);
+                       preg_match_all("(\[youtube\\](.*?)\[\/youtube\\])ism", $post['text'], $links2, PREG_SET_ORDER);
+                       preg_match_all("(\[video\\](.*?)\[\/video\\])ism", $post['text'], $links3, PREG_SET_ORDER);
+                       preg_match_all("(\[audio\\](.*?)\[\/audio\\])ism", $post['text'], $links4, PREG_SET_ORDER);
 
                        // Add them to the other external links
                        $links = array_merge($links, $links1, $links2, $links3, $links4);
@@ -364,25 +369,48 @@ class BBCode extends BaseObject
                        // Are there more than one?
                        if (count($links) > 1) {
                                // The post will be the type "text", which means a blog post
-                               unset($post["type"]);
-                               $post["url"] = $plink;
+                               unset($post['type']);
+                               $post['url'] = $plink;
                        }
 
-                       if (!isset($post["type"])) {
-                               $post["type"] = "text";
-                               $post["text"] = trim($body);
+                       if (!isset($post['type'])) {
+                               $post['type'] = "text";
+                               $post['text'] = trim($body);
                        }
-               } elseif (isset($post["url"]) && ($post["type"] == "video")) {
-                       $data = ParseUrl::getSiteinfoCached($post["url"], true);
+               } elseif (isset($post['url']) && ($post['type'] == 'video')) {
+                       $data = ParseUrl::getSiteinfoCached($post['url'], true);
 
-                       if (isset($data["images"][0])) {
-                               $post["image"] = $data["images"][0]["src"];
+                       if (isset($data['images'][0])) {
+                               $post['image'] = $data['images'][0]['src'];
                        }
                }
 
                return $post;
        }
 
+       /**
+        * Remove [attachment] BBCode and replaces it with a regular [url]
+        *
+        * @param string  $body
+        * @param boolean $no_link_desc No link description
+        *
+        * @return string with replaced body
+        */
+       public static function removeAttachment($body, $no_link_desc = false)
+       {
+               return preg_replace_callback("/\s*\[attachment (.*)\](.*?)\[\/attachment\]\s*/ism",
+                       function ($match) use ($no_link_desc) {
+                               $attach_data = self::getAttachmentData($match[0]);
+                               if (empty($attach_data['url'])) {
+                                       return $match[0];
+                               } elseif (empty($attach_data['title']) || $no_link_desc) {
+                                       return "\n[url]" . $attach_data['url'] . "[/url]\n";
+                               } else {
+                                       return "\n[url=" . $attach_data['url'] . ']' . $attach_data['title'] . "[/url]\n";
+                               }
+               }, $body);
+       }
+
        /**
         * @brief Converts a BBCode text into plaintext
         *
@@ -445,7 +473,7 @@ class BBCode extends BaseObject
                                }
 
                                // guess mimetype from headers or filename
-                               $type = Image::guessType($mtch[1], true);
+                               $type = Images::guessType($mtch[1], true);
 
                                if ($i) {
                                        $Image = new Image($i, $type);
@@ -572,80 +600,74 @@ class BBCode extends BaseObject
         * Note: Can produce a [bookmark] tag in the returned string
         *
         * @brief Processes [attachment] tags
-        * @param string   $return
+        * @param string   $text
         * @param bool|int $simplehtml
         * @param bool     $tryoembed
         * @return string
         * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
-       private static function convertAttachment($return, $simplehtml = false, $tryoembed = true)
+       private static function convertAttachment($text, $simplehtml = false, $tryoembed = true)
        {
-               $data = self::getAttachmentData($return);
-               if (empty($data) || empty($data["url"])) {
-                       return $return;
+               $data = self::getAttachmentData($text);
+               if (empty($data) || empty($data['url'])) {
+                       return $text;
                }
 
-               if (isset($data["title"])) {
-                       $data["title"] = strip_tags($data["title"]);
-                       $data["title"] = str_replace(["http://", "https://"], "", $data["title"]);
+               if (isset($data['title'])) {
+                       $data['title'] = strip_tags($data['title']);
+                       $data['title'] = str_replace(['http://', 'https://'], '', $data['title']);
                } else {
-                       $data["title"] = null;
+                       $data['title'] = null;
                }
 
-               if (((strpos($data["text"], "[img=") !== false) || (strpos($data["text"], "[img]") !== false) || Config::get('system', 'always_show_preview')) && !empty($data["image"])) {
-                       $data["preview"] = $data["image"];
-                       $data["image"] = "";
+               if (((strpos($data['text'], "[img=") !== false) || (strpos($data['text'], "[img]") !== false) || Config::get('system', 'always_show_preview')) && !empty($data['image'])) {
+                       $data['preview'] = $data['image'];
+                       $data['image'] = '';
                }
 
                $return = '';
-               if (in_array($simplehtml, [7, 9])) {
-                       $return = self::convertUrlForOStatus($data["url"]);
-               } elseif (($simplehtml != 4) && ($simplehtml != 0)) {
-                       $return = sprintf('<a href="%s" target="_blank">%s</a><br>', $data["url"], $data["title"]);
-               } else {
-                       try {
-                               if ($tryoembed && OEmbed::isAllowedURL($data['url'])) {
-                                       $return = OEmbed::getHTML($data['url'], $data['title']);
-                               } else {
-                                       throw new Exception('OEmbed is disabled for this attachment.');
-                               }
-                       } catch (Exception $e) {
-                               $data["title"] = defaults($data, 'title', $data['url']);
+               try {
+                       if ($tryoembed && OEmbed::isAllowedURL($data['url'])) {
+                               $return = OEmbed::getHTML($data['url'], $data['title']);
+                       } else {
+                               throw new Exception('OEmbed is disabled for this attachment.');
+                       }
+               } catch (Exception $e) {
+                       $data['title'] = ($data['title'] ?? '') ?: $data['url'];
 
-                               if ($simplehtml != 4) {
-                                       $return = sprintf('<div class="type-%s">', $data["type"]);
-                               }
+                       if ($simplehtml != 4) {
+                               $return = sprintf('<div class="type-%s">', $data['type']);
+                       }
 
-                               if (!empty($data['title']) && !empty($data['url'])) {
-                                       if (!empty($data["image"]) && empty($data["text"]) && ($data["type"] == "photo")) {
-                                               $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-image" /></a>', $data["url"], self::proxyUrl($data["image"], $simplehtml), $data["title"]);
-                                       } else {
-                                               if (!empty($data["image"])) {
-                                                       $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-image" /></a><br />', $data["url"], self::proxyUrl($data["image"], $simplehtml), $data["title"]);
-                                               } elseif (!empty($data["preview"])) {
-                                                       $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-preview" /></a><br />', $data["url"], self::proxyUrl($data["preview"], $simplehtml), $data["title"]);
-                                               }
-                                               $return .= sprintf('<h4><a href="%s">%s</a></h4>', $data['url'], $data['title']);
+                       if (!empty($data['title']) && !empty($data['url'])) {
+                               if (!empty($data['image']) && empty($data['text']) && ($data['type'] == 'photo')) {
+                                       $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-image" /></a>', $data['url'], self::proxyUrl($data['image'], $simplehtml), $data['title']);
+                               } else {
+                                       if (!empty($data['image'])) {
+                                               $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-image" /></a><br />', $data['url'], self::proxyUrl($data['image'], $simplehtml), $data['title']);
+                                       } elseif (!empty($data['preview'])) {
+                                               $return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-preview" /></a><br />', $data['url'], self::proxyUrl($data['preview'], $simplehtml), $data['title']);
                                        }
+                                       $return .= sprintf('<h4><a href="%s">%s</a></h4>', $data['url'], $data['title']);
                                }
+                       }
 
-                               if (!empty($data["description"]) && $data["description"] != $data["title"]) {
-                                       // Sanitize the HTML by converting it to BBCode
-                                       $bbcode = HTML::toBBCode($data["description"]);
-                                       $return .= sprintf('<blockquote>%s</blockquote>', trim(self::convert($bbcode)));
-                               }
+                       if (!empty($data['description']) && $data['description'] != $data['title']) {
+                               // Sanitize the HTML by converting it to BBCode
+                               $bbcode = HTML::toBBCode($data['description']);
+                               $return .= sprintf('<blockquote>%s</blockquote>', trim(self::convert($bbcode)));
+                       }
 
-                               if (!empty($data['url'])) {
-                                       $return .= sprintf('<sup><a href="%s">%s</a></sup>', $data['url'], parse_url($data['url'], PHP_URL_HOST));
-                               }
+                       if (!empty($data['url'])) {
+                               $return .= sprintf('<sup><a href="%s">%s</a></sup>', $data['url'], parse_url($data['url'], PHP_URL_HOST));
+                       }
 
-                               if ($simplehtml != 4) {
-                                       $return .= '</div>';
-                               }
+                       if ($simplehtml != 4) {
+                               $return .= '</div>';
                        }
                }
 
-               return trim(defaults($data, 'text', '') . ' ' . $return . ' ' . defaults($data, 'after', ''));
+               return trim(($data['text'] ?? '') . ' ' . $return . ' ' . ($data['after'] ?? ''));
        }
 
        public static function removeShareInformation($Text, $plaintext = false, $nolink = false)
@@ -655,36 +677,36 @@ class BBCode extends BaseObject
                if (!$data) {
                        return $Text;
                } elseif ($nolink) {
-                       return $data["text"] . defaults($data, 'after', '');
+                       return $data['text'] . ($data['after'] ?? '');
                }
 
-               $title = htmlentities(defaults($data, 'title', ''), ENT_QUOTES, 'UTF-8', false);
-               $text = htmlentities($data["text"], ENT_QUOTES, 'UTF-8', false);
-               if ($plaintext || (($title != "") && strstr($text, $title))) {
-                       $data["title"] = $data["url"];
-               } elseif (($text != "") && strstr($title, $text)) {
-                       $data["text"] = $data["title"];
-                       $data["title"] = $data["url"];
+               $title = htmlentities($data['title'] ?? '', ENT_QUOTES, 'UTF-8', false);
+               $text = htmlentities($data['text'], ENT_QUOTES, 'UTF-8', false);
+               if ($plaintext || (($title != '') && strstr($text, $title))) {
+                       $data['title'] = $data['url'];
+               } elseif (($text != '') && strstr($title, $text)) {
+                       $data['text'] = $data['title'];
+                       $data['title'] = $data['url'];
                }
 
-               if (empty($data["text"]) && !empty($data["title"]) && empty($data["url"])) {
-                       return $data["title"] . $data["after"];
+               if (empty($data['text']) && !empty($data['title']) && empty($data['url'])) {
+                       return $data['title'] . $data['after'];
                }
 
                // If the link already is included in the post, don't add it again
-               if (!empty($data["url"]) && strpos($data["text"], $data["url"])) {
-                       return $data["text"] . $data["after"];
+               if (!empty($data['url']) && strpos($data['text'], $data['url'])) {
+                       return $data['text'] . $data['after'];
                }
 
-               $text = $data["text"];
+               $text = $data['text'];
 
-               if (!empty($data["url"]) && !empty($data["title"])) {
-                       $text .= "\n[url=" . $data["url"] . "]" . $data["title"] . "[/url]";
-               } elseif (!empty($data["url"])) {
-                       $text .= "\n[url]" . $data["url"] . "[/url]";
+               if (!empty($data['url']) && !empty($data['title'])) {
+                       $text .= "\n[url=" . $data['url'] . ']' . $data['title'] . '[/url]';
+               } elseif (!empty($data['url'])) {
+                       $text .= "\n[url]" . $data['url'] . '[/url]';
                }
 
-               return $text . "\n" . $data["after"];
+               return $text . "\n" . $data['after'];
        }
 
        /**
@@ -694,7 +716,7 @@ class BBCode extends BaseObject
         * @param array $match Array with the matching values
         * @return string reformatted link including HTML codes
         */
-       private static function convertUrlForOStatusCallback($match)
+       private static function convertUrlForActivityPubCallback($match)
        {
                $url = $match[1];
 
@@ -707,15 +729,26 @@ class BBCode extends BaseObject
                        return $match[0];
                }
 
-               return self::convertUrlForOStatus($url);
+               return self::convertUrlForActivityPub($url);
        }
 
        /**
-        * @brief Converts [url] BBCodes in a format that looks fine on OStatus systems.
+        * @brief Converts [url] BBCodes in a format that looks fine on ActivityPub systems.
         * @param string $url URL that is about to be reformatted
         * @return string reformatted link including HTML codes
         */
-       private static function convertUrlForOStatus($url)
+       private static function convertUrlForActivityPub($url)
+       {
+               $html = '<a href="%s" target="_blank">%s</a>';
+               return sprintf($html, $url, self::getStyledURL($url));
+       }
+
+       /**
+        * Converts an URL in a nicer format (without the scheme and possibly shortened)
+        * @param string $url URL that is about to be reformatted
+        * @return string reformatted link
+        */
+       private static function getStyledURL($url)
        {
                $parts = parse_url($url);
                $scheme = $parts['scheme'] . '://';
@@ -725,9 +758,7 @@ class BBCode extends BaseObject
                        $styled_url = substr($styled_url, 0, 30) . "…";
                }
 
-               $html = '<a href="%s" target="_blank">%s</a>';
-
-               return sprintf($html, $url, $styled_url);
+               return $styled_url;
        }
 
        /*
@@ -925,14 +956,13 @@ class BBCode extends BaseObject
        public static function convertShare($text, callable $callback)
        {
                $return = preg_replace_callback(
-                       "/(.*?)\[share(.*?)\](.*?)\[\/share\]/ism",
+                       "/(.*?)\[share(.*?)\](.*)\[\/share\]/ism",
                        function ($match) use ($callback) {
                                $attribute_string = $match[2];
-
                                $attributes = [];
-                               foreach(['author', 'profile', 'avatar', 'link', 'posted'] as $field) {
+                               foreach (['author', 'profile', 'avatar', 'link', 'posted'] as $field) {
                                        preg_match("/$field=(['\"])(.+?)\\1/ism", $attribute_string, $matches);
-                                       $attributes[$field] = html_entity_decode(defaults($matches, 2, ''), ENT_QUOTES, 'UTF-8');
+                                       $attributes[$field] = html_entity_decode($matches[2] ?? '', ENT_QUOTES, 'UTF-8');
                                }
 
                                // We only call this so that a previously unknown contact can be added.
@@ -951,11 +981,11 @@ class BBCode extends BaseObject
                                Contact::getIdForURL($attributes['profile'], 0, true, $default);
 
                                $author_contact = Contact::getDetailsByURL($attributes['profile']);
-                               $author_contact['addr'] = defaults($author_contact, 'addr' , Protocol::getAddrFromProfileUrl($attributes['profile']));
+                               $author_contact['addr'] = ($author_contact['addr']  ?? '') ?: Protocol::getAddrFromProfileUrl($attributes['profile']);
 
-                               $attributes['author']   = defaults($author_contact, 'name' , $attributes['author']);
-                               $attributes['avatar']   = defaults($author_contact, 'micro', $attributes['avatar']);
-                               $attributes['profile']  = defaults($author_contact, 'url'  , $attributes['profile']);
+                               $attributes['author']   = ($author_contact['name']  ?? '') ?: $attributes['author'];
+                               $attributes['avatar']   = ($author_contact['micro'] ?? '') ?: $attributes['avatar'];
+                               $attributes['profile']  = ($author_contact['url']   ?? '') ?: $attributes['profile'];
 
                                if ($attributes['avatar']) {
                                        $attributes['avatar'] = ProxyUtils::proxifyUrl($attributes['avatar'], false, ProxyUtils::SIZE_THUMB);
@@ -1024,9 +1054,12 @@ class BBCode extends BaseObject
                                $text = ($is_quote_share? '<br />' : '') . '<p>' . html_entity_decode('&#x2672; ', ENT_QUOTES, 'UTF-8') . ' ' . $author_contact['addr'] . ': </p>' . "\n" . $content;
                                break;
                        case 7: // statusnet/GNU Social
-                       case 9: // ActivityPub
                                $text = ($is_quote_share? '<br />' : '') . '<p>' . html_entity_decode('&#x2672; ', ENT_QUOTES, 'UTF-8') . ' @' . $author_contact['addr'] . ': ' . $content . '</p>' . "\n";
                                break;
+                       case 9: // ActivityPub
+                               $author = '@<span class="vcard"><a href="' . $author_contact['url'] . '" class="url u-url mention" title="' . $author_contact['addr'] . '"><span class="fn nickname mention">' . $author_contact['addr'] . '</span></a>:</span>';
+                               $text = '<div><a href="' . $attributes['link'] . '">' . html_entity_decode('&#x2672;', ENT_QUOTES, 'UTF-8') . '</a> ' . $author . '<blockquote>' . $content . '</blockquote></div>' . "\n";
+                               break;
                        default:
                                // Transforms quoted tweets in rich attachments to avoid nested tweets
                                if (stripos(Strings::normaliseLink($attributes['link']), 'http://twitter.com/') === 0 && OEmbed::isAllowedURL($attributes['link'])) {
@@ -1073,10 +1106,10 @@ class BBCode extends BaseObject
 
                        $a->getProfiler()->saveTimestamp($stamp1, "network", System::callstack());
 
-                       if (substr($curl_info["content_type"], 0, 6) == "image/") {
-                               $text = "[url=" . $match[1] . "]" . $match[1] . "[/url]";
+                       if (substr($curl_info['content_type'], 0, 6) == 'image/') {
+                               $text = "[url=" . $match[1] . ']' . $match[1] . "[/url]";
                        } else {
-                               $text = "[url=" . $match[2] . "]" . $match[2] . "[/url]";
+                               $text = "[url=" . $match[2] . ']' . $match[2] . "[/url]";
 
                                // if its not a picture then look if its a page that contains a picture link
                                $body = Network::fetchUrl($match[1]);
@@ -1094,8 +1127,8 @@ class BBCode extends BaseObject
                                                }
                                        }
 
-                                       if (strtolower($attr["name"]) == "twitter:image") {
-                                               $text = "[url=" . $attr["content"] . "]" . $attr["content"] . "[/url]";
+                                       if (strtolower($attr['name']) == 'twitter:image') {
+                                               $text = '[url=' . $attr['content'] . ']' . $attr['content'] . '[/url]';
                                        }
                                }
                        }
@@ -1107,7 +1140,7 @@ class BBCode extends BaseObject
 
        private static function expandLinksCallback($match)
        {
-               if (($match[3] == "") || ($match[2] == $match[3]) || stristr($match[2], $match[3])) {
+               if (($match[3] == '') || ($match[2] == $match[3]) || stristr($match[2], $match[3])) {
                        return ($match[1] . "[url]" . $match[2] . "[/url]");
                } else {
                        return ($match[1] . $match[3] . " [url]" . $match[2] . "[/url]");
@@ -1122,9 +1155,9 @@ class BBCode extends BaseObject
                $own_photo_url = preg_quote(Strings::normaliseLink($a->getBaseURL()) . '/photos/');
                if (preg_match('|' . $own_photo_url . '.*?/image/|', Strings::normaliseLink($match[1]))) {
                        if (!empty($match[3])) {
-                               $text = "[img=" . str_replace('-1.', '-0.', $match[2]) . "]" . $match[3] . "[/img]";
+                               $text = '[img=' . str_replace('-1.', '-0.', $match[2]) . ']' . $match[3] . '[/img]';
                        } else {
-                               $text = "[img]" . str_replace('-1.', '-0.', $match[2]) . "[/img]";
+                               $text = '[img]' . str_replace('-1.', '-0.', $match[2]) . '[/img]';
                        }
                        return $text;
                }
@@ -1148,13 +1181,13 @@ class BBCode extends BaseObject
                $a->getProfiler()->saveTimestamp($stamp1, "network", System::callstack());
 
                // if its a link to a picture then embed this picture
-               if (substr($curl_info["content_type"], 0, 6) == "image/") {
-                       $text = "[img]" . $match[1] . "[/img]";
+               if (substr($curl_info['content_type'], 0, 6) == 'image/') {
+                       $text = '[img]' . $match[1] . '[/img]';
                } else {
                        if (!empty($match[3])) {
-                               $text = "[img=" . $match[2] . "]" . $match[3] . "[/img]";
+                               $text = '[img=' . $match[2] . ']' . $match[3] . '[/img]';
                        } else {
-                               $text = "[img]" . $match[2] . "[/img]";
+                               $text = '[img]' . $match[2] . '[/img]';
                        }
 
                        // if its not a picture then look if its a page that contains a picture link
@@ -1172,11 +1205,11 @@ class BBCode extends BaseObject
                                        }
                                }
 
-                               if (strtolower($attr["name"]) == "twitter:image") {
+                               if (strtolower($attr['name']) == "twitter:image") {
                                        if (!empty($match[3])) {
-                                               $text = "[img=" . $attr["content"] . "]" . $match[3] . "[/img]";
+                                               $text = "[img=" . $attr['content'] . "]" . $match[3] . "[/img]";
                                        } else {
-                                               $text = "[img]" . $attr["content"] . "[/img]";
+                                               $text = "[img]" . $attr['content'] . "[/img]";
                                        }
                                }
                        }
@@ -1208,7 +1241,7 @@ class BBCode extends BaseObject
         * - 5: Unused
         * - 6: Unused
         * - 7: Used for dfrn, OStatus
-        * - 8: Used for WP backlink text setting
+        * - 8: Used for Twitter, WP backlink text setting
         * - 9: ActivityPub
         *
         * @param string $text
@@ -1232,7 +1265,7 @@ class BBCode extends BaseObject
                $try_oembed_callback = function ($match)
                {
                        $url = $match[1];
-                       $title = defaults($match, 2, null);
+                       $title = $match[2] ?? null;
 
                        try {
                                $return = OEmbed::getHTML($url, $title);
@@ -1333,7 +1366,7 @@ class BBCode extends BaseObject
                $text = str_replace($search, $replace, $text);
 
                // removing multiplicated newlines
-               if (Config::get("system", "remove_multiplicated_lines")) {
+               if (Config::get('system', 'remove_multiplicated_lines')) {
                        $search = ["\n\n\n", "\n ", " \n", "[/quote]\n\n", "\n[/quote]", "[/li]\n", "\n[li]", "\n[ul]", "[/ul]\n", "\n\n[share ", "[/attachment]\n",
                                        "\n[h1]", "[/h1]\n", "\n[h2]", "[/h2]\n", "\n[h3]", "[/h3]\n", "\n[h4]", "[/h4]\n", "\n[h5]", "[/h5]\n", "\n[h6]", "[/h6]\n"];
                        $replace = ["\n\n", "\n", "\n", "[/quote]\n", "[/quote]", "[/li]", "[li]", "[ul]", "[/ul]", "\n[share ", "[/attachment]",
@@ -1344,8 +1377,15 @@ class BBCode extends BaseObject
                        } while ($oldtext != $text);
                }
 
+               /// @todo Have a closer look at the different html modes
                // Handle attached links or videos
-               $text = self::convertAttachment($text, $simple_html, $try_oembed);
+               if (in_array($simple_html, [9])) {
+                       $text = self::removeAttachment($text);
+               } elseif (!in_array($simple_html, [0, 4])) {
+                       $text = self::removeAttachment($text, true);
+               } else {
+                       $text = self::convertAttachment($text, $simple_html, $try_oembed);
+               }
 
                // leave open the posibility of [map=something]
                // this is replaced in Item::prepareBody() which has knowledge of the item location
@@ -1467,8 +1507,29 @@ class BBCode extends BaseObject
                $text = str_replace('[hr]', '<hr />', $text);
 
                if (!$for_plaintext) {
+                       $escaped = [];
+
+                       // Escaping BBCodes susceptible to contain rogue URL we don'' want the autolinker to catch
+                       $text = preg_replace_callback('#\[(url|img|audio|video|youtube|vimeo|share|attachment|iframe|bookmark).+?\[/\1\]#ism',
+                               function ($matches) use (&$escaped) {
+                                       $return = '{escaped-' . count($escaped) . '}';
+                                       $escaped[] = $matches[0];
+
+                                       return $return;
+                               },
+                               $text
+                       );
+
                        // Autolinker for isolated URLs
                        $text = preg_replace(Strings::autoLinkRegEx(), '[url]$1[/url]', $text);
+
+                       // Restoring escaped blocks
+                       $text = preg_replace_callback('/{escaped-([0-9]+)}/iU',
+                               function ($matches) use ($escaped) {
+                                       return $escaped[intval($matches[1])] ?? $matches[0];
+                               },
+                               $text
+                       );
                }
 
                // This is actually executed in Item::prepareBody()
@@ -1543,7 +1604,7 @@ class BBCode extends BaseObject
                        function ($matches) use ($simple_html) {
                                $matches[1] = self::proxyUrl($matches[1], $simple_html);
                                $matches[2] = htmlspecialchars($matches[2], ENT_COMPAT);
-                               return '<img src="' . $matches[1] . '" alt="' . $matches[2] . '">';
+                               return '<img src="' . $matches[1] . '" alt="' . $matches[2] . '" title="' . $matches[2] . '">';
                        },
                        $text);
 
@@ -1569,6 +1630,9 @@ class BBCode extends BaseObject
                $text = preg_replace("/\[crypt(.*?)\](.*?)\[\/crypt\]/ism", '<br/><img src="' .System::baseUrl() . '/images/lock_icon.gif" alt="' . L10n::t('Encrypted content') . '" title="' . '$1' . ' ' . L10n::t('Encrypted content') . '" /><br />', $text);
                //$Text = preg_replace("/\[crypt=(.*?)\](.*?)\[\/crypt\]/ism", '<br/><img src="' .System::baseUrl() . '/images/lock_icon.gif" alt="' . L10n::t('Encrypted content') . '" title="' . '$1' . ' ' . L10n::t('Encrypted content') . '" /><br />', $Text);
 
+               // Simplify "video" element
+               $text = preg_replace('(\[video.*?\ssrc\s?=\s?([^\s\]]+).*?\].*?\[/video\])ism', '[video]$1[/video]', $text);
+
                // Try to Oembed
                if ($try_oembed) {
                        $text = preg_replace("/\[video\](.*?\.(ogg|ogv|oga|ogm|webm|mp4).*?)\[\/video\]/ism", '<video src="$1" controls="controls" width="' . $a->videowidth . '" height="' . $a->videoheight . '" loop="true"><a href="$1">$1</a></video>', $text);
@@ -1655,8 +1719,8 @@ class BBCode extends BaseObject
 
                if (!$for_plaintext) {
                        if (in_array($simple_html, [7, 9])) {
-                               $text = preg_replace_callback("/\[url\](.*?)\[\/url\]/ism", 'self::convertUrlForOStatusCallback', $text);
-                               $text = preg_replace_callback("/\[url\=(.*?)\](.*?)\[\/url\]/ism", 'self::convertUrlForOStatusCallback', $text);
+                               $text = preg_replace_callback("/\[url\](.*?)\[\/url\]/ism", 'self::convertUrlForActivityPubCallback', $text);
+                               $text = preg_replace_callback("/\[url\=(.*?)\](.*?)\[\/url\]/ism", 'self::convertUrlForActivityPubCallback', $text);
                        }
                } else {
                        $text = preg_replace("(\[url\](.*?)\[\/url\])ism", " $1 ", $text);
@@ -1666,7 +1730,7 @@ class BBCode extends BaseObject
                $text = str_replace(["\r","\n"], ['<br />', '<br />'], $text);
 
                // Remove all hashtag addresses
-               if ((!$try_oembed || $simple_html) && !in_array($simple_html, [3, 7, 9])) {
+               if ($simple_html && !in_array($simple_html, [3, 7, 9])) {
                        $text = preg_replace("/([#@!])\[url\=(.*?)\](.*?)\[\/url\]/ism", '$1$3', $text);
                } elseif ($simple_html == 3) {
                        // The ! is converted to @ since Diaspora only understands the @
@@ -1735,10 +1799,10 @@ class BBCode extends BaseObject
                 * - #[url=<anything>]<term>[/url]
                 * - [url=<anything>]#<term>[/url]
                 */
-               $text = preg_replace_callback("/(?:#\[url\=.*?\]|\[url\=.*?\]#)(.*?)\[\/url\]/ism", function($matches) {
+               $text = preg_replace_callback("/(?:#\[url\=[^\[\]]*\]|\[url\=[^\[\]]*\]#)(.*?)\[\/url\]/ism", function($matches) {
                        return '#<a href="'
                                . System::baseUrl()     . '/search?tag=' . rawurlencode($matches[1])
-                               . '" class="tag" title="' . XML::escape($matches[1]) . '">'
+                               . '" class="tag" rel="tag" title="' . XML::escape($matches[1]) . '">'
                                . XML::escape($matches[1])
                                . '</a>';
                }, $text);
@@ -1832,7 +1896,7 @@ class BBCode extends BaseObject
                // Clean up the HTML by loading and saving the HTML with the DOM.
                // Bad structured html can break a whole page.
                // For performance reasons do it only with activated item cache or at export.
-               if (!$try_oembed || (get_itemcachepath() != "")) {
+               if (!$try_oembed || (get_itemcachepath() != '')) {
                        $doc = new DOMDocument();
                        $doc->preserveWhiteSpace = false;
 
@@ -1840,10 +1904,10 @@ class BBCode extends BaseObject
 
                        $doctype = '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">';
                        $encoding = '<?xml encoding="UTF-8">';
-                       @$doc->loadHTML($encoding.$doctype."<html><body>".$text."</body></html>");
+                       @$doc->loadHTML($encoding . $doctype . '<html><body>' . $text . '</body></html>');
                        $doc->encoding = 'UTF-8';
                        $text = $doc->saveHTML();
-                       $text = str_replace(["<html><body>", "</body></html>", $doctype, $encoding], ["", "", "", ""], $text);
+                       $text = str_replace(['<html><body>', '</body></html>', $doctype, $encoding], ['', '', '', ''], $text);
 
                        $text = str_replace('<br></li>', '</li>', $text);
 
@@ -1883,9 +1947,9 @@ class BBCode extends BaseObject
         * @param string $addon The addon for which the abstract is meant for
         * @return string The abstract
         */
-       public static function getAbstract($text, $addon = "")
+       public static function getAbstract($text, $addon = '')
        {
-               $abstract = "";
+               $abstract = '';
                $abstracts = [];
                $addon = strtolower($addon);
 
@@ -1899,7 +1963,7 @@ class BBCode extends BaseObject
                        $abstract = $abstracts[$addon];
                }
 
-               if ($abstract == "" && preg_match("/\[abstract\](.*?)\[\/abstract\]/ism", $text, $result)) {
+               if ($abstract == '' && preg_match("/\[abstract\](.*?)\[\/abstract\]/ism", $text, $result)) {
                        $abstract = $result[1];
                }
 
@@ -1975,7 +2039,7 @@ class BBCode extends BaseObject
 
                        // Add all tags that maybe were removed
                        if (preg_match_all("/#\[url\=([$url_search_string]*)\](.*?)\[\/url\]/ism", $original_text, $tags)) {
-                               $tagline = "";
+                               $tagline = '';
                                foreach ($tags[2] as $tag) {
                                        $tag = html_entity_decode($tag, ENT_QUOTES, 'UTF-8');
                                        if (!strpos(html_entity_decode($text, ENT_QUOTES, 'UTF-8'), '#' . $tag)) {
@@ -1993,7 +2057,7 @@ class BBCode extends BaseObject
 
                // If a link is followed by a quote then there should be a newline before it
                // Maybe we should make this newline at every time before a quote.
-               $text = str_replace(["</a><blockquote>"], ["</a><br><blockquote>"], $text);
+               $text = str_replace(['</a><blockquote>'], ['</a><br><blockquote>'], $text);
 
                $stamp1 = microtime(true);