<?php
/**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2022, the Friendica project
*
* @license GNU AGPL version 3 or any later version
*
use Friendica\Database\DBA;
use Friendica\DI;
+use Friendica\Model\Contact;
use Friendica\Util\Strings;
/**
{
$addon = Strings::sanitizeFilePathItem($addon);
+ $addon_file_path = 'addon/' . $addon . '/' . $addon . '.php';
+
// silently fail if addon was removed of if $addon is funky
- if (!file_exists('addon/' . $addon . '/' . $addon . '.php')) {
+ if (!file_exists($addon_file_path)) {
return false;
}
Logger::notice("Addon {addon}: {action}", ['action' => 'install', 'addon' => $addon]);
- $t = @filemtime('addon/' . $addon . '/' . $addon . '.php');
- @include_once('addon/' . $addon . '/' . $addon . '.php');
+ $t = @filemtime($addon_file_path);
+ @include_once($addon_file_path);
if (function_exists($addon . '_install')) {
$func = $addon . '_install';
$func(DI::app());
+ }
- $addon_admin = (function_exists($addon . "_addon_admin") ? 1 : 0);
-
- DBA::insert('addon', ['name' => $addon, 'installed' => true,
- 'timestamp' => $t, 'plugin_admin' => $addon_admin]);
-
- // we can add the following with the previous SQL
- // once most site tables have been updated.
- // This way the system won't fall over dead during the update.
-
- if (file_exists('addon/' . $addon . '/.hidden')) {
- DBA::update('addon', ['hidden' => true], ['name' => $addon]);
- }
-
- if (!self::isEnabled($addon)) {
- self::$addons[] = $addon;
- }
-
- return true;
- } else {
- Logger::error("Addon {addon}: {action} failed", ['action' => 'install', 'addon' => $addon]);
- return false;
+ DBA::insert('addon', [
+ 'name' => $addon,
+ 'installed' => true,
+ 'timestamp' => $t,
+ 'plugin_admin' => function_exists($addon . '_addon_admin'),
+ 'hidden' => file_exists('addon/' . $addon . '/.hidden')
+ ]);
+
+ if (!self::isEnabled($addon)) {
+ self::$addons[] = $addon;
}
+
+ return true;
}
/**
foreach ($addons as $addon) {
$addonname = Strings::sanitizeFilePathItem(trim($addon['name']));
- $fname = 'addon/' . $addonname . '/' . $addonname . '.php';
- $t = @filemtime($fname);
- if (!file_exists($fname) || ($addon['timestamp'] == $t)) {
+ $addon_file_path = 'addon/' . $addonname . '/' . $addonname . '.php';
+ if (file_exists($addon_file_path) && $addon['timestamp'] == filemtime($addon_file_path)) {
+ // Addon unmodified, skipping
continue;
}
Logger::notice("Addon {addon}: {action}", ['action' => 'reload', 'addon' => $addon['name']]);
- self::uninstall($fname);
- self::install($fname);
+ self::uninstall($addon['name']);
+ self::install($addon['name']);
}
}
return $info;
}
- $stamp1 = microtime(true);
+ DI::profiler()->startRecording('file');
$f = file_get_contents("addon/$addon/$addon.php");
- DI::profiler()->saveTimestamp($stamp1, "file");
+ DI::profiler()->stopRecording();
$r = preg_match("|/\*.*\*/|msU", $f, $m);
if ($type == "author" || $type == "maintainer") {
$r = preg_match("|([^<]+)<([^>]+)>|", $v, $m);
if ($r) {
+ if (!empty($m[2]) && empty(parse_url($m[2], PHP_URL_SCHEME))) {
+ $contact = Contact::getByURL($m[2], false);
+ if (!empty($contact['url'])) {
+ $m[2] = $contact['url'];
+ }
+ }
$info[$type][] = ['name' => $m[1], 'link' => $m[2]];
} else {
$info[$type][] = ['name' => $v];
return $visible_addons;
}
-
- /**
- * Shim of Hook::register left for backward compatibility purpose.
- *
- * @see Hook::register
- * @deprecated since version 2018.12
- * @param string $hook the name of the hook
- * @param string $file the name of the file that hooks into
- * @param string $function the name of the function that the hook will call
- * @param int $priority A priority (defaults to 0)
- * @return mixed|bool
- * @throws \Friendica\Network\HTTPException\InternalServerErrorException
- */
- public static function registerHook($hook, $file, $function, $priority = 0)
- {
- return Hook::register($hook, $file, $function, $priority);
- }
-
- /**
- * Shim of Hook::unregister left for backward compatibility purpose.
- *
- * @see Hook::unregister
- * @deprecated since version 2018.12
- * @param string $hook the name of the hook
- * @param string $file the name of the file that hooks into
- * @param string $function the name of the function that the hook called
- * @return boolean
- * @throws \Friendica\Network\HTTPException\InternalServerErrorException
- */
- public static function unregisterHook($hook, $file, $function)
- {
- return Hook::unregister($hook, $file, $function);
- }
-
- /**
- * Shim of Hook::callAll left for backward-compatibility purpose.
- *
- * @see Hook::callAll
- * @deprecated since version 2018.12
- * @param string $name of the hook to call
- * @param string|array &$data to transmit to the callback handler
- * @throws \Friendica\Network\HTTPException\InternalServerErrorException
- */
- public static function callHooks($name, &$data = null)
- {
- Hook::callAll($name, $data);
- }
}