Avoid memory issue in exception

[friendica.git] / src / Core / Hook.php

diff --git a/src/Core/Hook.php b/src/Core/Hook.php
index d221933daeaffc7ba149c15cb78dd7a16a06768a..7f0c015b3db155ae500b3ded2d06ecf0837c20d7 100644 (file)
--- a/src/Core/Hook.php
+++ b/src/Core/Hook.php
@@ -7,7 +7,6 @@ namespace Friendica\Core;
 use Friendica\App;
 use Friendica\BaseObject;
 use Friendica\Database\DBA;
-use Friendica\Core\Logger;
 
 /**
  * Some functions to handle hooks
@@ -49,9 +48,9 @@ class Hook extends BaseObject
         *
         * This function is meant to be called by modules on each page load as it works after loadHooks has been called.
         *
-        * @param type $hook
-        * @param type $file
-        * @param type $function
+        * @param string $hook
+        * @param string $file
+        * @param string $function
         */
        public static function add($hook, $file, $function)
        {
@@ -71,6 +70,7 @@ class Hook extends BaseObject
         * @param string $function the name of the function that the hook will call
         * @param int    $priority A priority (defaults to 0)
         * @return mixed|bool
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function register($hook, $file, $function, $priority = 0)
        {
@@ -93,6 +93,7 @@ class Hook extends BaseObject
         * @param string $file     the name of the file that hooks into
         * @param string $function the name of the function that the hook called
         * @return boolean
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function unregister($hook, $file, $function)
        {
@@ -132,25 +133,26 @@ class Hook extends BaseObject
         * @param integer $priority of the hook
         * @param string  $name     of the hook to call
         * @param mixed   $data     to transmit to the callback handler
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function fork($priority, $name, $data = null)
        {
                if (array_key_exists($name, self::$hooks)) {
                        foreach (self::$hooks[$name] as $hook) {
                                // Call a hook to check if this hook call needs to be forked
-                               $hookdata = ['name' => $name, 'data' => $data, 'execute' => true];
-
                                if (array_key_exists('hook_fork', self::$hooks)) {
+                                       $hookdata = ['name' => $name, 'data' => $data, 'execute' => true];
+
                                        foreach (self::$hooks['hook_fork'] as $fork_hook) {
                                                if ($hook[0] != $fork_hook[0]) {
                                                        continue;
                                                }
                                                self::callSingle(self::getApp(), 'hook_fork', $fork_hook, $hookdata);
                                        }
-                               }
 
-                               if (!$hookdata['execute']) {
-                                       continue;
+                                       if (!$hookdata['execute']) {
+                                               continue;
+                                       }
                                }
 
                                Worker::add($priority, 'ForkHook', $name, $hook, $data);
@@ -164,8 +166,9 @@ class Hook extends BaseObject
         * Use this function when you want to be able to allow a hook to manipulate
         * the provided data.
         *
-        * @param string       $name  of the hook to call
+        * @param string        $name of the hook to call
         * @param string|array &$data to transmit to the callback handler
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function callAll($name, &$data = null)
        {
@@ -179,10 +182,11 @@ class Hook extends BaseObject
        /**
         * @brief Calls a single hook.
         *
-        * @param App $a
-        * @param string         $name of the hook to call
-        * @param array          $hook Hook data
+        * @param App             $a
+        * @param string          $name of the hook to call
+        * @param array           $hook Hook data
         * @param string|array   &$data to transmit to the callback handler
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function callSingle(App $a, $name, $hook, &$data = null)
        {