Fixup command argument

[friendica.git] / src / Core / Renderer.php

diff --git a/src/Core/Renderer.php b/src/Core/Renderer.php
index 4dab3184c77eb956c8e20830b25b85aad56746d6..608c707434ca539c295b68425c943c99c757da88 100644 (file)
--- a/src/Core/Renderer.php
+++ b/src/Core/Renderer.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -23,6 +23,7 @@ namespace Friendica\Core;
 
 use Exception;
 use Friendica\DI;
+use Friendica\Network\HTTPException\ServiceUnavailableException;
 use Friendica\Render\TemplateEngine;
 
 /**
@@ -47,10 +48,8 @@ class Renderer
         * beyond are used.
         */
        public static $theme = [
-               'sourcename' => '',
                'videowidth' => 425,
                'videoheight' => 350,
-               'force_max_items' => 0,
                'stylesheet' => '',
                'template_engine' => 'smarty3',
        ];
@@ -70,10 +69,11 @@ class Renderer
         * @param string $template
         * @param array  $vars
         * @return string
+        * @throws ServiceUnavailableException
         */
-       public static function replaceMacros(string $template, array $vars)
+       public static function replaceMacros(string $template, array $vars = [])
        {
-               $stamp1 = microtime(true);
+               DI::profiler()->startRecording('rendering');
 
                // pass $baseurl to all templates if it isn't set
                $vars = array_merge(['$baseurl' => DI::baseUrl()->get(), '$APP' => DI::app()], $vars);
@@ -83,11 +83,14 @@ class Renderer
                try {
                        $output = $t->replaceMacros($template, $vars);
                } catch (Exception $e) {
-                       echo "<pre><b>" . __FUNCTION__ . "</b>: " . $e->getMessage() . "</pre>";
-                       exit();
+                       DI::logger()->critical($e->getMessage(), ['template' => $template, 'vars' => $vars]);
+                       $message = DI::app()->isSiteAdmin() ?
+                               $e->getMessage() :
+                               DI::l10n()->t('Friendica can\'t display this page at the moment, please contact the administrator.');
+                       throw new ServiceUnavailableException($message);
                }
 
-               DI::profiler()->saveTimestamp($stamp1, "rendering", System::callstack());
+               DI::profiler()->stopRecording();
 
                return $output;
        }
@@ -99,21 +102,24 @@ class Renderer
         * @param string $subDir Subdirectory (Optional)
         *
         * @return string template.
-        * @throws Exception
+        * @throws ServiceUnavailableException
         */
        public static function getMarkupTemplate($file, $subDir = '')
        {
-               $stamp1 = microtime(true);
+               DI::profiler()->startRecording('file');
                $t = self::getTemplateEngine();
 
                try {
                        $template = $t->getTemplateFile($file, $subDir);
                } catch (Exception $e) {
-                       echo "<pre><b>" . __FUNCTION__ . "</b>: " . $e->getMessage() . "</pre>";
-                       exit();
+                       DI::logger()->critical($e->getMessage(), ['file' => $file, 'subDir' => $subDir]);
+                       $message = DI::app()->isSiteAdmin() ?
+                               $e->getMessage() :
+                               DI::l10n()->t('Friendica can\'t display this page at the moment, please contact the administrator.');
+                       throw new ServiceUnavailableException($message);
                }
 
-               DI::profiler()->saveTimestamp($stamp1, "file", System::callstack());
+               DI::profiler()->stopRecording();
 
                return $template;
        }
@@ -122,6 +128,7 @@ class Renderer
         * Register template engine class
         *
         * @param string $class
+        * @throws ServiceUnavailableException
         */
        public static function registerTemplateEngine($class)
        {
@@ -131,8 +138,12 @@ class Renderer
                        $name = $v['name'];
                        self::$template_engines[$name] = $class;
                } else {
-                       echo "template engine <tt>$class</tt> cannot be registered without a name.\n";
-                       die();
+                       $admin_message = DI::l10n()->t('template engine cannot be registered without a name.');
+                       DI::logger()->critical($admin_message, ['class' => $class]);
+                       $message = DI::app()->isSiteAdmin() ?
+                               $admin_message :
+                               DI::l10n()->t('Friendica can\'t display this page at the moment, please contact the administrator.');
+                       throw new ServiceUnavailableException($message);
                }
        }
 
@@ -143,6 +154,7 @@ class Renderer
         * or default
         *
         * @return TemplateEngine Template Engine instance
+        * @throws ServiceUnavailableException
         */
        public static function getTemplateEngine()
        {
@@ -154,14 +166,18 @@ class Renderer
                        } else {
                                $a = DI::app();
                                $class = self::$template_engines[$template_engine];
-                               $obj = new $class($a->getCurrentTheme(), $a->theme_info);
+                               $obj = new $class($a->getCurrentTheme(), $a->getThemeInfo());
                                self::$template_engine_instance[$template_engine] = $obj;
                                return $obj;
                        }
                }
 
-               echo "template engine <tt>$template_engine</tt> is not registered!\n";
-               exit();
+               $admin_message = DI::l10n()->t('template engine is not registered!');
+               DI::logger()->critical($admin_message, ['template_engine' => $template_engine]);
+               $message = DI::app()->isSiteAdmin() ?
+                       $admin_message :
+                       DI::l10n()->t('Friendica can\'t display this page at the moment, please contact the administrator.');
+               throw new ServiceUnavailableException($message);
        }
 
        /**