Merge pull request #10446 from MrPetovan/bug/10439-addon-settings-forms

[friendica.git] / src / Core / Update.php

diff --git a/src/Core/Update.php b/src/Core/Update.php
index b2dc1a383a365caec78986463fbeb3d83b27a1b2..fa3c6b62d0fa15121791e04d85686ccffd292176 100644 (file)
--- a/src/Core/Update.php
+++ b/src/Core/Update.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -22,9 +22,12 @@
 namespace Friendica\Core;
 
 use Friendica\App;
+use Friendica\App\Mode;
 use Friendica\Database\DBA;
 use Friendica\Database\DBStructure;
 use Friendica\DI;
+use Friendica\Network\HTTPException\InternalServerErrorException;
+use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Strings;
 
 class Update
@@ -60,8 +63,24 @@ class Update
                }
 
                // We don't support upgrading from very old versions anymore
-               if ($build < NEW_UPDATE_ROUTINE_VERSION) {
-                       die('You try to update from a version prior to database version 1170. The direct upgrade path is not supported. Please update to version 3.5.4 before updating to this version.');
+               if ($build < NEW_TABLE_STRUCTURE_VERSION) {
+                       $error = DI::l10n()->t('Updates from version %s are not supported. Please update at least to version 2021.01 and wait until the postupdate finished version 1383.', $build);
+                       if (DI::mode()->getExecutor() == Mode::INDEX) {
+                               die($error);
+                       } else {
+                               throw new InternalServerErrorException($error);
+                       }
+               }
+
+               // The postupdate has to completed version 1288 for the new post views to take over
+               $postupdate = DI::config()->get("system", "post_update_version", NEW_TABLE_STRUCTURE_VERSION);
+               if ($postupdate < NEW_TABLE_STRUCTURE_VERSION) {
+                       $error = DI::l10n()->t('Updates from postupdate version %s are not supported. Please update at least to version 2021.01 and wait until the postupdate finished version 1383.', $postupdate);
+                       if (DI::mode()->getExecutor() == Mode::INDEX) {
+                               die($error);
+                       } else {
+                               throw new InternalServerErrorException($error);
+                       }
                }
 
                if ($build < DB_UPDATE_VERSION) {
@@ -125,14 +144,20 @@ class Update
                                                return '';
                                        }
 
+                                       DI::config()->set('system', 'maintenance', 1);
+               
                                        // run the pre_update_nnnn functions in update.php
                                        for ($version = $stored + 1; $version <= $current; $version++) {
                                                Logger::notice('Execute pre update.', ['version' => $version]);
+                                               DI::config()->set('system', 'maintenance_reason', DI::l10n()->t('%s: executing pre update %d',
+                                                       DateTimeFormat::utcNow() . ' ' . date('e'), $version));
                                                $r = self::runUpdateFunction($version, 'pre_update', $sendMail);
                                                if (!$r) {
                                                        Logger::warning('Pre update failed', ['version' => $version]);
                                                        DI::config()->set('system', 'update', Update::FAILED);
                                                        DI::lock()->release('dbupdate');
+                                                       DI::config()->set('system', 'maintenance', 0);
+                                                       DI::config()->set('system', 'maintenance_reason', '');
                                                        return $r;
                                                } else {
                                                        Logger::notice('Pre update executed.', ['version' => $version]);
@@ -141,7 +166,7 @@ class Update
 
                                        // update the structure in one call
                                        Logger::notice('Execute structure update');
-                                       $retval = DBStructure::update($basePath, $verbose, true);
+                                       $retval = DBStructure::performUpdate(false, $verbose);
                                        if (!empty($retval)) {
                                                if ($sendMail) {
                                                        self::updateFailed(
@@ -152,21 +177,25 @@ class Update
                                                Logger::error('Update ERROR.', ['from' => $stored, 'to' => $current, 'retval' => $retval]);
                                                DI::config()->set('system', 'update', Update::FAILED);
                                                DI::lock()->release('dbupdate');
+                                               DI::config()->set('system', 'maintenance', 0);
+                                               DI::config()->set('system', 'maintenance_reason', '');
                                                return $retval;
                                        } else {
-                                               DI::config()->set('database', 'last_successful_update', $current);
-                                               DI::config()->set('database', 'last_successful_update_time', time());
                                                Logger::notice('Database structure update finished.', ['from' => $stored, 'to' => $current]);
                                        }
 
                                        // run the update_nnnn functions in update.php
                                        for ($version = $stored + 1; $version <= $current; $version++) {
                                                Logger::notice('Execute post update.', ['version' => $version]);
+                                               DI::config()->set('system', 'maintenance_reason', DI::l10n()->t('%s: executing post update %d',
+                                                       DateTimeFormat::utcNow() . ' ' . date('e'), $version));
                                                $r = self::runUpdateFunction($version, 'update', $sendMail);
                                                if (!$r) {
                                                        Logger::warning('Post update failed', ['version' => $version]);
                                                        DI::config()->set('system', 'update', Update::FAILED);
                                                        DI::lock()->release('dbupdate');
+                                                       DI::config()->set('system', 'maintenance', 0);
+                                                       DI::config()->set('system', 'maintenance_reason', '');
                                                        return $r;
                                                } else {
                                                        DI::config()->set('system', 'build', $version);
@@ -177,11 +206,15 @@ class Update
                                        DI::config()->set('system', 'build', $current);
                                        DI::config()->set('system', 'update', Update::SUCCESS);
                                        DI::lock()->release('dbupdate');
+                                       DI::config()->set('system', 'maintenance', 0);
+                                       DI::config()->set('system', 'maintenance_reason', '');
 
                                        Logger::notice('Update success.', ['from' => $stored, 'to' => $current]);
                                        if ($sendMail) {
                                                self::updateSuccessful($stored, $current);
                                        }
+                               } else {
+                                       Logger::warning('Update lock could not be acquired');
                                }
                        }
                }