Merge pull request #10318 from annando/issue-9926

[friendica.git] / src / Database / DBStructure.php

diff --git a/src/Database/DBStructure.php b/src/Database/DBStructure.php
index 9b69f7b1114143107a50fa15991666f7d58342ea..914846590be264ed833d1b683013d997fc813031 100644 (file)
--- a/src/Database/DBStructure.php
+++ b/src/Database/DBStructure.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2021, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -72,8 +72,15 @@ class DBStructure
         */
        public static function dropTables(bool $execute)
        {
+               $postupdate = DI::config()->get("system", "post_update_version", PostUpdate::VERSION);
+               if ($postupdate < PostUpdate::VERSION) {
+                       echo DI::l10n()->t('The post update is at version %d, it has to be at %d to safely drop the tables.', $postupdate, PostUpdate::VERSION);
+                       return;
+               }
+
                $old_tables = ['fserver', 'gcign', 'gcontact', 'gcontact-relation', 'gfollower' ,'glink', 'item-delivery-data',
-               'item_id', 'poll', 'poll_result', 'queue', 'retriever_rule', 'sign', 'spam', 'term'];
+                       'item-activity', 'item-content', 'item_id', 'participation', 'poll', 'poll_result', 'queue', 'retriever_rule',
+                       'deliverq', 'dsprphotoq', 'ffinder', 'sign', 'spam', 'term', 'user-item', 'thread', 'item'];
 
                $tables = DBA::selectToArray(['INFORMATION_SCHEMA' => 'TABLES'], ['TABLE_NAME'],
                        ['TABLE_SCHEMA' => DBA::databaseName(), 'TABLE_TYPE' => 'BASE TABLE']);
@@ -185,6 +192,9 @@ class DBStructure
        public static function definition($basePath, $with_addons_structure = true)
        {
                if (!self::$definition) {
+                       if (empty($basePath)) {
+                               $basePath = DI::app()->getBasePath();
+                       }
 
                        $filename = $basePath . '/static/dbstructure.config.php';
 
@@ -231,6 +241,12 @@ class DBStructure
                // Assign all field that are present in the table
                foreach ($fieldnames as $field) {
                        if (isset($data[$field])) {
+                               // Limit the length of varchar, varbinary, char and binrary fields
+                               if (is_string($data[$field]) && preg_match("/char\((\d*)\)/", $definition[$table]['fields'][$field]['type'], $result)) {
+                                       $data[$field] = mb_substr($data[$field], 0, $result[1]);
+                               } elseif (is_string($data[$field]) && preg_match("/binary\((\d*)\)/", $definition[$table]['fields'][$field]['type'], $result)) {
+                                       $data[$field] = substr($data[$field], 0, $result[1]);
+                               }
                                $fields[$field] = $data[$field];
                        }
                }
@@ -361,6 +377,54 @@ class DBStructure
                return ($sql);
        }
 
+       /**
+        * Perform a database structure dryrun (means: just simulating)
+        *
+        * @throws Exception
+        */
+       public static function dryRun()
+       {
+               self::update(DI::app()->getBasePath(), true, false);
+       }
+
+       /**
+        * Updates DB structure and returns eventual errors messages
+        *
+        * @param bool $enable_maintenance_mode Set the maintenance mode
+        * @param bool $verbose                 Display the SQL commands
+        *
+        * @return string Empty string if the update is successful, error messages otherwise
+        * @throws Exception
+        */
+       public static function performUpdate(bool $enable_maintenance_mode = true, bool $verbose = false)
+       {
+               if ($enable_maintenance_mode) {
+                       DI::config()->set('system', 'maintenance', 1);
+               }
+
+               $status = self::update(DI::app()->getBasePath(), $verbose, true);
+
+               if ($enable_maintenance_mode) {
+                       DI::config()->set('system', 'maintenance', 0);
+                       DI::config()->set('system', 'maintenance_reason', '');
+               }
+
+               return $status;
+       }
+
+       /**
+        * Updates DB structure from the installation and returns eventual errors messages
+        *
+        * @param string $basePath   The base path of this application
+        *
+        * @return string Empty string if the update is successful, error messages otherwise
+        * @throws Exception
+        */
+       public static function install(string $basePath)
+       {
+               return self::update($basePath, false, true, true);
+       }
+
        /**
         * Updates DB structure and returns eventual errors messages
         *
@@ -373,14 +437,15 @@ class DBStructure
         * @return string Empty string if the update is successful, error messages otherwise
         * @throws Exception
         */
-       public static function update($basePath, $verbose, $action, $install = false, array $tables = null, array $definition = null)
+       private static function update($basePath, $verbose, $action, $install = false, array $tables = null, array $definition = null)
        {
-               if ($action && !$install) {
-                       if (self::isUpdating()) {
-                               return DI::l10n()->t('Another database update is currently running.');
-                       }
+               $in_maintenance_mode = DI::config()->get('system', 'maintenance');
 
-                       DI::config()->set('system', 'maintenance', 1);
+               if ($action && !$install && self::isUpdating()) {
+                       return DI::l10n()->t('Another database update is currently running.');
+               }
+
+               if ($in_maintenance_mode) {
                        DI::config()->set('system', 'maintenance_reason', DI::l10n()->t('%s: Database update', DateTimeFormat::utcNow() . ' ' . date('e')));
                }
 
@@ -680,7 +745,7 @@ class DBStructure
                                }
 
                                if ($action) {
-                                       if (!$install) {
+                                       if ($in_maintenance_mode) {
                                                DI::config()->set('system', 'maintenance_reason', DI::l10n()->t('%s: updating %s table.', DateTimeFormat::utcNow() . ' ' . date('e'), $name));
                                        }
 
@@ -737,9 +802,6 @@ class DBStructure
                self::checkInitialValues();
 
                if ($action && !$install) {
-                       DI::config()->set('system', 'maintenance', 0);
-                       DI::config()->set('system', 'maintenance_reason', '');
-
                        if ($errors) {
                                DI::config()->set('system', 'dbupdate', self::UPDATE_FAILED);
                        } else {
@@ -1179,7 +1241,7 @@ class DBStructure
                        } elseif ($verbose) {
                                echo "Zero permissionset already added\n";
                        }
-                       if (!self::existsForeignKeyForField('item', 'psid')) {
+                       if (self::existsTable('item') && !self::existsForeignKeyForField('item', 'psid')) {
                                $sets = DBA::p("SELECT `psid`, `item`.`uid`, `item`.`private` FROM `item`
                                        LEFT JOIN `permissionset` ON `permissionset`.`id` = `item`.`psid`
                                        WHERE `permissionset`.`id` IS NULL AND NOT `psid` IS NULL");