]> git.mxchange.org Git - friendica.git/blobdiff - src/Database/Database.php
Issue 11893: Postupdate to fix wrong parents
[friendica.git] / src / Database / Database.php
index f94e03f92a8b48e95ada041c7a68a6ebffc95018..fde5bd9f10133b20fd63f8bc4a12add3a8e77d99 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2010-2021, the Friendica project
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
 
 namespace Friendica\Database;
 
-use Friendica\Core\Config\Cache;
+use Friendica\Core\Config\ValueObject\Cache;
 use Friendica\Core\System;
-use Friendica\Network\HTTPException\InternalServerErrorException;
+use Friendica\Database\Definition\DbaDefinition;
+use Friendica\Database\Definition\ViewDefinition;
+use Friendica\Network\HTTPException\ServiceUnavailableException;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Profiler;
+use InvalidArgumentException;
 use mysqli;
 use mysqli_result;
 use mysqli_stmt;
@@ -49,7 +52,7 @@ class Database
        protected $connected = false;
 
        /**
-        * @var Cache
+        * @var \Friendica\Core\Config\ValueObject\Cache
         */
        protected $configCache;
        /**
@@ -63,32 +66,38 @@ class Database
        protected $server_info    = '';
        /** @var PDO|mysqli */
        protected $connection;
-       protected $driver;
+       protected $driver = '';
        protected $pdo_emulate_prepares = false;
-       private $error          = false;
+       private $error          = '';
        private $errorno        = 0;
        private $affected_rows  = 0;
        protected $in_transaction = false;
        protected $in_retrial     = false;
        protected $testmode       = false;
        private $relation       = [];
+       /** @var DbaDefinition */
+       protected $dbaDefinition;
+       /** @var ViewDefinition */
+       protected $viewDefinition;
 
-       public function __construct(Cache $configCache, Profiler $profiler, LoggerInterface $logger)
+       public function __construct(Cache $configCache, Profiler $profiler, DbaDefinition $dbaDefinition, ViewDefinition $viewDefinition, LoggerInterface $logger)
        {
                // We are storing these values for being able to perform a reconnect
-               $this->configCache   = $configCache;
-               $this->profiler      = $profiler;
-               $this->logger        = $logger;
+               $this->configCache    = $configCache;
+               $this->profiler       = $profiler;
+               $this->logger         = $logger;
+               $this->dbaDefinition  = $dbaDefinition;
+               $this->viewDefinition = $viewDefinition;
 
                $this->connect();
-
-               if ($this->isConnected()) {
-                       // Loads DB_UPDATE_VERSION constant
-                       DBStructure::definition($configCache->get('system', 'basepath'), false);
-               }
        }
 
-       public function connect()
+       /**
+        * Tries to connect to database
+        *
+        * @return bool Success
+        */
+       public function connect(): bool
        {
                if (!is_null($this->connection) && $this->connected()) {
                        return $this->connected;
@@ -114,6 +123,7 @@ class Database
                $pass    = trim($this->configCache->get('database', 'password'));
                $db      = trim($this->configCache->get('database', 'database'));
                $charset = trim($this->configCache->get('database', 'charset'));
+               $socket  = trim($this->configCache->get('database', 'socket')); 
 
                if (!(strlen($server) && strlen($user))) {
                        return false;
@@ -135,9 +145,14 @@ class Database
                                $connect .= ";charset=" . $charset;
                        }
 
+                       if ($socket) {
+                               $connect .= ";$unix_socket=" . $socket;
+                       }
+
                        try {
                                $this->connection = @new PDO($connect, $user, $pass, [PDO::ATTR_PERSISTENT => $persistent]);
                                $this->connection->setAttribute(PDO::ATTR_EMULATE_PREPARES, $this->pdo_emulate_prepares);
+                               $this->connection->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_SILENT);
                                $this->connected = true;
                        } catch (PDOException $e) {
                                $this->connected = false;
@@ -159,12 +174,17 @@ class Database
                                if ($charset) {
                                        $this->connection->set_charset($charset);
                                }
+
+                               if ($socket) {
+                                       $this->connection->set_socket($socket);
+                               }
+
                        }
                }
 
                // No suitable SQL driver was found.
                if (!$this->connected) {
-                       $this->driver     = null;
+                       $this->driver     = '';
                        $this->connection = null;
                }
 
@@ -216,7 +236,7 @@ class Database
                        }
                }
 
-               $this->driver    = null;
+               $this->driver    = '';
                $this->connected = false;
        }
 
@@ -244,7 +264,7 @@ class Database
         *
         * @return string with either "pdo" or "mysqli"
         */
-       public function getDriver()
+       public function getDriver(): string
        {
                return $this->driver;
        }
@@ -255,9 +275,9 @@ class Database
         * This function discriminate between the deprecated mysql API and the current
         * object-oriented mysqli API. Example of returned string: 5.5.46-0+deb8u1
         *
-        * @return string
+        * @return string Database server information
         */
-       public function serverInfo()
+       public function serverInfo(): string
        {
                if ($this->server_info == '') {
                        switch ($this->driver) {
@@ -275,10 +295,10 @@ class Database
        /**
         * Returns the selected database name
         *
-        * @return string
+        * @return string Database name
         * @throws \Exception
         */
-       public function databaseName()
+       public function databaseName(): string
        {
                $ret  = $this->p("SELECT DATABASE() AS `db`");
                $data = $this->toArray($ret);
@@ -289,10 +309,10 @@ class Database
         * Analyze a database query and log this if some conditions are met.
         *
         * @param string $query The database query that will be analyzed
-        *
+        * @return void
         * @throws \Exception
         */
-       private function logIndex($query)
+       private function logIndex(string $query)
        {
 
                if (!$this->configCache->get('system', 'db_log_index')) {
@@ -348,11 +368,10 @@ class Database
         * Removes every not allowlisted character from the identifier string
         *
         * @param string $identifier
-        *
         * @return string sanitized identifier
         * @throws \Exception
         */
-       private function sanitizeIdentifier($identifier)
+       private function sanitizeIdentifier(string $identifier): string
        {
                return preg_replace('/[^A-Za-z0-9_\-]+/', '', $identifier);
        }
@@ -372,11 +391,21 @@ class Database
                }
        }
 
-       public function isConnected()
+       /**
+        * Returns connected flag
+        *
+        * @return bool Whether connection to database was success
+        */
+       public function isConnected(): bool
        {
                return $this->connected;
        }
 
+       /**
+        * Checks connection status
+        *
+        * @return bool Whether connection to database was success
+        */
        public function connected()
        {
                $connected = false;
@@ -413,7 +442,7 @@ class Database
         *
         * @return string The input SQL string modified if necessary.
         */
-       public function anyValueFallback($sql)
+       public function anyValueFallback(string $sql): string
        {
                $server_info = $this->serverInfo();
                if (version_compare($server_info, '5.7.5', '<') ||
@@ -431,7 +460,7 @@ class Database
         *
         * @return string The replaced SQL query
         */
-       private function replaceParameters($sql, $args)
+       private function replaceParameters(string $sql, array $args): string
        {
                $offset = 0;
                foreach ($args as $param => $value) {
@@ -465,7 +494,7 @@ class Database
         * @return bool|object statement object or result object
         * @throws \Exception
         */
-       public function p($sql)
+       public function p(string $sql)
        {
 
                $this->profiler->startRecording('database');
@@ -520,7 +549,7 @@ class Database
                $called_from_e = ($called_from['function'] == 'e');
 
                if (!isset($this->connection)) {
-                       throw new InternalServerErrorException('The Connection is empty, although connected is set true.');
+                       throw new ServiceUnavailableException('The Connection is empty, although connected is set true.');
                }
 
                switch ($this->driver) {
@@ -529,8 +558,8 @@ class Database
                                if (count($args) == 0) {
                                        if (!$retval = $this->connection->query($this->replaceParameters($sql, $args))) {
                                                $errorInfo     = $this->connection->errorInfo();
-                                               $this->error   = $errorInfo[2];
-                                               $this->errorno = $errorInfo[1];
+                                               $this->error   = (string)$errorInfo[2];
+                                               $this->errorno = (int)$errorInfo[1];
                                                $retval        = false;
                                                $is_error      = true;
                                                break;
@@ -542,26 +571,28 @@ class Database
                                /** @var $stmt mysqli_stmt|PDOStatement */
                                if (!$stmt = $this->connection->prepare($sql)) {
                                        $errorInfo     = $this->connection->errorInfo();
-                                       $this->error   = $errorInfo[2];
-                                       $this->errorno = $errorInfo[1];
+                                       $this->error   = (string)$errorInfo[2];
+                                       $this->errorno = (int)$errorInfo[1];
                                        $retval        = false;
                                        $is_error      = true;
                                        break;
                                }
 
-                               foreach ($args as $param => $value) {
+                               foreach (array_keys($args) as $param) {
+                                       $data_type = PDO::PARAM_STR;
                                        if (is_int($args[$param])) {
                                                $data_type = PDO::PARAM_INT;
-                                       } else {
-                                               $data_type = PDO::PARAM_STR;
+                                       } elseif ($args[$param] !== null) {
+                                               $args[$param] = (string)$args[$param];
                                        }
+
                                        $stmt->bindParam($param, $args[$param], $data_type);
                                }
 
                                if (!$stmt->execute()) {
                                        $errorInfo     = $stmt->errorInfo();
-                                       $this->error   = $errorInfo[2];
-                                       $this->errorno = $errorInfo[1];
+                                       $this->error   = (string)$errorInfo[2];
+                                       $this->errorno = (int)$errorInfo[1];
                                        $retval        = false;
                                        $is_error      = true;
                                } else {
@@ -579,8 +610,8 @@ class Database
                                if (!$can_be_prepared || (count($args) == 0)) {
                                        $retval = $this->connection->query($this->replaceParameters($sql, $args));
                                        if ($this->connection->errno) {
-                                               $this->error   = $this->connection->error;
-                                               $this->errorno = $this->connection->errno;
+                                               $this->error   = (string)$this->connection->error;
+                                               $this->errorno = (int)$this->connection->errno;
                                                $retval        = false;
                                                $is_error      = true;
                                        } else {
@@ -596,8 +627,8 @@ class Database
                                $stmt = $this->connection->stmt_init();
 
                                if (!$stmt->prepare($sql)) {
-                                       $this->error   = $stmt->error;
-                                       $this->errorno = $stmt->errno;
+                                       $this->error   = (string)$stmt->error;
+                                       $this->errorno = (int)$stmt->errno;
                                        $retval        = false;
                                        $is_error      = true;
                                        break;
@@ -605,13 +636,16 @@ class Database
 
                                $param_types = '';
                                $values      = [];
-                               foreach ($args as $param => $value) {
+                               foreach (array_keys($args) as $param) {
                                        if (is_int($args[$param])) {
                                                $param_types .= 'i';
                                        } elseif (is_float($args[$param])) {
                                                $param_types .= 'd';
                                        } elseif (is_string($args[$param])) {
                                                $param_types .= 's';
+                                       } elseif (is_object($args[$param]) && method_exists($args[$param], '__toString')) {
+                                               $param_types .= 's';
+                                               $args[$param] = (string)$args[$param];
                                        } else {
                                                $param_types .= 'b';
                                        }
@@ -624,8 +658,8 @@ class Database
                                }
 
                                if (!$stmt->execute()) {
-                                       $this->error   = $this->connection->error;
-                                       $this->errorno = $this->connection->errno;
+                                       $this->error   = (string)$this->connection->error;
+                                       $this->errorno = (int)$this->connection->errno;
                                        $retval        = false;
                                        $is_error      = true;
                                } else {
@@ -692,8 +726,8 @@ class Database
                                }
                        }
 
-                       $this->error   = $error;
-                       $this->errorno = $errorno;
+                       $this->error   = (string)$error;
+                       $this->errorno = (int)$errorno;
                }
 
                $this->profiler->stopRecording();
@@ -725,8 +759,9 @@ class Database
         * @return boolean Was the query successfull? False is returned only if an error occurred
         * @throws \Exception
         */
-       public function e($sql)
+       public function e(string $sql): bool
        {
+               $retval = false;
 
                $this->profiler->startRecording('database_write');
 
@@ -788,13 +823,14 @@ class Database
        /**
         * Check if data exists
         *
-        * @param string|array $table     Table name or array [schema => table]
-        * @param array        $condition array of fields for condition
+        * @param string $table     Table name in format schema.table (while scheme is optiona)
+        * @param array  $condition Array of fields for condition
         *
         * @return boolean Are there rows for that condition?
         * @throws \Exception
+        * @todo Please unwrap the DBStructure::existsTable() call so this method has one behavior only: checking existence on records
         */
-       public function exists($table, $condition)
+       public function exists(string $table, array $condition): bool
        {
                if (empty($table)) {
                        return false;
@@ -834,10 +870,10 @@ class Database
         *
         * @param string $sql SQL statement
         *
-        * @return array first row of query
+        * @return array|bool first row of query or false on failure
         * @throws \Exception
         */
-       public function fetchFirst($sql)
+       public function fetchFirst(string $sql)
        {
                $params = DBA::getParam(func_get_args());
 
@@ -859,7 +895,7 @@ class Database
         *
         * @return int Number of rows
         */
-       public function affectedRows()
+       public function affectedRows(): int
        {
                return $this->affected_rows;
        }
@@ -871,7 +907,7 @@ class Database
         *
         * @return int Number of columns
         */
-       public function columnCount($stmt)
+       public function columnCount($stmt): int
        {
                if (!is_object($stmt)) {
                        return 0;
@@ -892,7 +928,7 @@ class Database
         *
         * @return int Number of rows
         */
-       public function numRows($stmt)
+       public function numRows($stmt): int
        {
                if (!is_object($stmt)) {
                        return 0;
@@ -909,9 +945,9 @@ class Database
        /**
         * Fetch a single row
         *
-        * @param PDOStatement|mysqli_stmt $stmt statement object
+        * @param bool|PDOStatement|mysqli_stmt $stmt statement object
         *
-        * @return array|false current row
+        * @return array|bool Current row or false on failure
         */
        public function fetch($stmt)
        {
@@ -969,16 +1005,16 @@ class Database
        }
 
        /**
-        * Insert a row into a table
+        * Insert a row into a table. Field value objects will be cast as string.
         *
-        * @param string|array $table          Table name or array [schema => table]
-        * @param array        $param          parameter array
-        * @param int          $duplicate_mode What to do on a duplicated entry
+        * @param string $table          Table name in format schema.table (while scheme is optiona)
+        * @param array  $param          parameter array
+        * @param int    $duplicate_mode What to do on a duplicated entry
         *
         * @return boolean was the insert successful?
         * @throws \Exception
         */
-       public function insert($table, array $param, int $duplicate_mode = self::INSERT_DEFAULT)
+       public function insert(string $table, array $param, int $duplicate_mode = self::INSERT_DEFAULT): bool
        {
                if (empty($table) || empty($param)) {
                        $this->logger->info('Table and fields have to be set');
@@ -987,7 +1023,7 @@ class Database
 
                $param = $this->castFields($table, $param);
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $fields_string = implode(', ', array_map([DBA::class, 'quoteIdentifier'], array_keys($param)));
 
@@ -1022,13 +1058,12 @@ class Database
         * Inserts a row with the provided data in the provided table.
         * If the data corresponds to an existing row through a UNIQUE or PRIMARY index constraints, it updates the row instead.
         *
-        * @param string|array $table Table name or array [schema => table]
-        * @param array        $param parameter array
-        *
+        * @param string $table Table name in format schema.table (while scheme is optiona)
+        * @param array  $param parameter array
         * @return boolean was the insert successful?
         * @throws \Exception
         */
-       public function replace($table, array $param)
+       public function replace(string $table, array $param): bool
        {
                if (empty($table) || empty($param)) {
                        $this->logger->info('Table and fields have to be set');
@@ -1037,7 +1072,7 @@ class Database
 
                $param = $this->castFields($table, $param);
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $fields_string = implode(', ', array_map([DBA::class, 'quoteIdentifier'], array_keys($param)));
 
@@ -1053,7 +1088,7 @@ class Database
         *
         * @return integer Last inserted id
         */
-       public function lastInsertId()
+       public function lastInsertId(): int
        {
                switch ($this->driver) {
                        case self::PDO:
@@ -1071,12 +1106,11 @@ class Database
         *
         * This function can be extended in the future to accept a table array as well.
         *
-        * @param string|array $table Table name or array [schema => table]
-        *
+        * @param string $table Table name in format schema.table (while scheme is optiona)
         * @return boolean was the lock successful?
         * @throws \Exception
         */
-       public function lock($table)
+       public function lock(string $table): bool
        {
                // See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
                if ($this->driver == self::PDO) {
@@ -1086,7 +1120,7 @@ class Database
                        $this->connection->autocommit(false);
                }
 
-               $success = $this->e("LOCK TABLES " . DBA::buildTableString($table) . " WRITE");
+               $success = $this->e("LOCK TABLES " . DBA::buildTableString([$table]) . " WRITE");
 
                if ($this->driver == self::PDO) {
                        $this->connection->setAttribute(PDO::ATTR_EMULATE_PREPARES, $this->pdo_emulate_prepares);
@@ -1110,7 +1144,7 @@ class Database
         * @return boolean was the unlock successful?
         * @throws \Exception
         */
-       public function unlock()
+       public function unlock(): bool
        {
                // See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
                $this->performCommit();
@@ -1137,7 +1171,7 @@ class Database
         *
         * @return boolean Was the command executed successfully?
         */
-       public function transaction()
+       public function transaction(): bool
        {
                if (!$this->performCommit()) {
                        return false;
@@ -1161,7 +1195,12 @@ class Database
                return true;
        }
 
-       protected function performCommit()
+       /**
+        * Performs the commit
+        *
+        * @return boolean Was the command executed successfully?
+        */
+       protected function performCommit(): bool
        {
                switch ($this->driver) {
                        case self::PDO:
@@ -1183,7 +1222,7 @@ class Database
         *
         * @return boolean Was the command executed successfully?
         */
-       public function commit()
+       public function commit(): bool
        {
                if (!$this->performCommit()) {
                        return false;
@@ -1197,7 +1236,7 @@ class Database
         *
         * @return boolean Was the command executed successfully?
         */
-       public function rollback()
+       public function rollback(): bool
        {
                $ret = false;
 
@@ -1214,6 +1253,7 @@ class Database
                                $ret = $this->connection->rollback();
                                break;
                }
+
                $this->in_transaction = false;
                return $ret;
        }
@@ -1227,14 +1267,14 @@ class Database
         * @return boolean was the delete successful?
         * @throws \Exception
         */
-       public function delete($table, array $conditions)
+       public function delete(string $table, array $conditions): bool
        {
                if (empty($table) || empty($conditions)) {
                        $this->logger->info('Table and conditions have to be set');
                        return false;
                }
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $condition_string = DBA::buildCondition($conditions);
 
@@ -1244,9 +1284,9 @@ class Database
        }
 
        /**
-        * Updates rows
+        * Updates rows in the database. Field value objects will be cast as string.
         *
-        * Updates rows in the database. When $old_fields is set to an array,
+        * When $old_fields is set to an array,
         * the system will only do an update if the fields in that array changed.
         *
         * Attention:
@@ -1264,15 +1304,17 @@ class Database
         * Only set $old_fields to a boolean value when you are sure that you will update a single row.
         * When you set $old_fields to "true" then $fields must contain all relevant fields!
         *
-        * @param string|array  $table      Table name or array [schema => table]
+        * @param string        $table      Table name in format schema.table (while scheme is optiona)
         * @param array         $fields     contains the fields that are updated
         * @param array         $condition  condition array with the key values
         * @param array|boolean $old_fields array with the old field values that are about to be replaced (true = update on duplicate, false = don't update identical fields)
+        * @param array         $params     Parameters: "ignore" If set to "true" then the update is done with the ignore parameter
         *
         * @return boolean was the update successfull?
         * @throws \Exception
+        * @todo Implement "bool $update_on_duplicate" to avoid mixed type for $old_fields
         */
-       public function update($table, $fields, $condition, $old_fields = [])
+       public function update(string $table, array $fields, array $condition, $old_fields = [], array $params = [])
        {
                if (empty($table) || empty($fields) || empty($condition)) {
                        $this->logger->info('Table, fields and condition have to be set');
@@ -1305,11 +1347,17 @@ class Database
 
                $fields = $this->castFields($table, $fields);
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $condition_string = DBA::buildCondition($condition);
 
-               $sql = "UPDATE " . $table_string . " SET "
+               if (!empty($params['ignore'])) {
+                       $ignore = 'IGNORE ';
+               } else {
+                       $ignore = '';
+               }
+
+               $sql = "UPDATE " . $ignore . $table_string . " SET "
                        . implode(" = ?, ", array_map([DBA::class, 'quoteIdentifier'], array_keys($fields))) . " = ?"
                        . $condition_string;
 
@@ -1322,16 +1370,16 @@ class Database
        /**
         * Retrieve a single record from a table and returns it in an associative array
         *
-        * @param string|array $table
-        * @param array        $fields
-        * @param array        $condition
-        * @param array        $params
+        * @param string $table     Table name in format schema.table (while scheme is optiona)
+        * @param array  $fields    Array of selected fields, empty for all
+        * @param array  $condition Array of fields for condition
+        * @param array  $params    Array of several parameters
         *
         * @return bool|array
         * @throws \Exception
         * @see   $this->select
         */
-       public function selectFirst($table, array $fields = [], array $condition = [], $params = [])
+       public function selectFirst(string $table, array $fields = [], array $condition = [], array $params = [])
        {
                $params['limit'] = 1;
                $result          = $this->select($table, $fields, $condition, $params);
@@ -1348,20 +1396,58 @@ class Database
        /**
         * Select rows from a table and fills an array with the data
         *
-        * @param string|array $table     Table name or array [schema => table]
-        * @param array        $fields    Array of selected fields, empty for all
-        * @param array        $condition Array of fields for condition
-        * @param array        $params    Array of several parameters
-        *
+        * @param string $table     Table name in format schema.table (while scheme is optiona)
+        * @param array  $fields    Array of selected fields, empty for all
+        * @param array  $condition Array of fields for condition
+        * @param array  $params    Array of several parameters
         * @return array Data array
         * @throws \Exception
         * @see   self::select
         */
-       public function selectToArray($table, array $fields = [], array $condition = [], array $params = [])
+       public function selectToArray(string $table, array $fields = [], array $condition = [], array $params = [])
        {
                return $this->toArray($this->select($table, $fields, $condition, $params));
        }
 
+       /**
+        * Escape fields, adding special treatment for "group by" handling
+        *
+        * @param array $fields 
+        * @param array $options 
+        * @return array Escaped fields
+        */
+       private function escapeFields(array $fields, array $options): array
+       {
+               // In the case of a "GROUP BY" we have to add all the ORDER fields to the fieldlist.
+               // This needs to done to apply the "ANY_VALUE(...)" treatment from below to them.
+               // Otherwise MySQL would report errors.
+               if (!empty($options['group_by']) && !empty($options['order'])) {
+                       foreach ($options['order'] as $key => $field) {
+                               if (!is_int($key)) {
+                                       if (!in_array($key, $fields)) {
+                                               $fields[] = $key;
+                                       }
+                               } else {
+                                       if (!in_array($field, $fields)) {
+                                               $fields[] = $field;
+                                       }
+                               }
+                       }
+               }
+
+               array_walk($fields, function(&$value, $key) use ($options)
+               {
+                       $field = $value;
+                       $value = DBA::quoteIdentifier($field);
+
+                       if (!empty($options['group_by']) && !in_array($field, $options['group_by'])) {
+                               $value = 'ANY_VALUE(' . $value . ') AS ' . $value;
+                       }
+               });
+
+               return $fields;
+       }
+
        /**
         * Select rows from a table
         *
@@ -1384,26 +1470,27 @@ class Database
         *
         * $data = DBA::select($table, $fields, $condition, $params);
         *
-        * @param string|array $table     Table name or array [schema => table]
-        * @param array        $fields    Array of selected fields, empty for all
-        * @param array        $condition Array of fields for condition
-        * @param array        $params    Array of several parameters
+        * @param string $table     Table name in format schema.table (while scheme is optiona)
+        * @param array  $fields    Array of selected fields, empty for all
+        * @param array  $condition Array of fields for condition
+        * @param array  $params    Array of several parameters
         * @return boolean|object
         * @throws \Exception
         */
-       public function select($table, array $fields = [], array $condition = [], array $params = [])
+       public function select(string $table, array $fields = [], array $condition = [], array $params = [])
        {
                if (empty($table)) {
                        return false;
                }
 
                if (count($fields) > 0) {
-                       $select_string = implode(', ', array_map([DBA::class, 'quoteIdentifier'], $fields));
+                       $fields = $this->escapeFields($fields, $params);
+                       $select_string = implode(', ', $fields);
                } else {
                        $select_string = '*';
                }
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $condition_string = DBA::buildCondition($condition);
 
@@ -1423,11 +1510,11 @@ class Database
        /**
         * Counts the rows from a table satisfying the provided condition
         *
-        * @param string|array $table     Table name or array [schema => table]
-        * @param array        $condition Array of fields for condition
-        * @param array        $params    Array of several parameters
+        * @param string $table     Table name in format schema.table (while scheme is optiona)
+        * @param array  $condition Array of fields for condition
+        * @param array  $params    Array of several parameters
         *
-        * @return int
+        * @return int Count of rows
         *
         * Example:
         * $table = "post";
@@ -1439,13 +1526,13 @@ class Database
         * $count = DBA::count($table, $condition);
         * @throws \Exception
         */
-       public function count($table, array $condition = [], array $params = [])
+       public function count(string $table, array $condition = [], array $params = []): int
        {
                if (empty($table)) {
-                       return false;
+                       throw new InvalidArgumentException('Parameter "table" cannot be empty.');
                }
 
-               $table_string = DBA::buildTableString($table);
+               $table_string = DBA::buildTableString([$table]);
 
                $condition_string = DBA::buildCondition($condition);
 
@@ -1478,7 +1565,7 @@ class Database
         *
         * @return array Data array
         */
-       public function toArray($stmt, $do_close = true, int $count = 0)
+       public function toArray($stmt, bool $do_close = true, int $count = 0): array
        {
                if (is_bool($stmt)) {
                        return [];
@@ -1506,7 +1593,8 @@ class Database
         * @param array  $fields
         * @return array casted fields
         */
-       public function castFields(string $table, array $fields) {
+       public function castFields(string $table, array $fields): array
+       {
                // When there is no data, we don't need to do something
                if (empty($fields)) {
                        return $fields;
@@ -1524,15 +1612,15 @@ class Database
 
                $types = [];
 
-               $tables = DBStructure::definition('', false);
+               $tables = $this->dbaDefinition->getAll();
                if (empty($tables[$table])) {
                        // When a matching table wasn't found we check if it is a view
-                       $views = View::definition('', false);
+                       $views = $this->viewDefinition->getAll();
                        if (empty($views[$table])) {
                                return $fields;
                        }
 
-                       foreach(array_keys($fields) as $field) {
+                       foreach (array_keys($fields) as $field) {
                                if (!empty($views[$table]['fields'][$field])) {
                                        $viewdef = $views[$table]['fields'][$field];
                                        if (!empty($tables[$viewdef[0]]['fields'][$viewdef[1]]['type'])) {
@@ -1561,15 +1649,15 @@ class Database
                        }
                }
 
-               return $fields; 
+               return $fields;
        }
-       
+
        /**
         * Returns the error number of the last query
         *
         * @return string Error number (0 if no error)
         */
-       public function errorNo()
+       public function errorNo(): int
        {
                return $this->errorno;
        }
@@ -1579,7 +1667,7 @@ class Database
         *
         * @return string Error message ('' if no error)
         */
-       public function errorMessage()
+       public function errorMessage(): string
        {
                return $this->error;
        }
@@ -1591,7 +1679,7 @@ class Database
         *
         * @return boolean was the close successful?
         */
-       public function close($stmt)
+       public function close($stmt): bool
        {
 
                $this->profiler->startRecording('database');
@@ -1633,38 +1721,39 @@ class Database
         *      'amount' => Number of concurrent database processes
         * @throws \Exception
         */
-       public function processlist()
+       public function processlist(): array
        {
-               $ret  = $this->p("SHOW PROCESSLIST");
+               $ret  = $this->p('SHOW PROCESSLIST');
                $data = $this->toArray($ret);
 
                $processes = 0;
                $states    = [];
                foreach ($data as $process) {
-                       $state = trim($process["State"]);
+                       $state = trim($process['State']);
 
                        // Filter out all non blocking processes
-                       if (!in_array($state, ["", "init", "statistics", "updating"])) {
+                       if (!in_array($state, ['', 'init', 'statistics', 'updating'])) {
                                ++$states[$state];
                                ++$processes;
                        }
                }
 
-               $statelist = "";
+               $statelist = '';
                foreach ($states as $state => $usage) {
-                       if ($statelist != "") {
-                               $statelist .= ", ";
+                       if ($statelist != '') {
+                               $statelist .= ', ';
                        }
-                       $statelist .= $state . ": " . $usage;
+                       $statelist .= $state . ': ' . $usage;
                }
-               return (["list" => $statelist, "amount" => $processes]);
+               return (['list' => $statelist, 'amount' => $processes]);
        }
 
        /**
         * Fetch a database variable
         *
         * @param string $name
-        * @return string content
+        * @return string|null content or null if inexistent
+        * @throws \Exception
         */
        public function getVariable(string $name)
        {
@@ -1676,10 +1765,9 @@ class Database
         * Checks if $array is a filled array with at least one entry.
         *
         * @param mixed $array A filled array with at least one entry
-        *
         * @return boolean Whether $array is a filled array or an object with rows
         */
-       public function isResult($array)
+       public function isResult($array): bool
        {
                // It could be a return value from an update statement
                if (is_bool($array)) {
@@ -1699,10 +1787,9 @@ class Database
         * @param mixed   $value         Array value
         * @param string  $key           Array key
         * @param boolean $add_quotation add quotation marks for string values
-        *
         * @return void
         */
-       private function escapeArrayCallback(&$value, $key, $add_quotation)
+       private function escapeArrayCallback(&$value, string $key, bool $add_quotation)
        {
                if (!$add_quotation) {
                        if (is_bool($value)) {
@@ -1727,11 +1814,40 @@ class Database
         *
         * @param mixed   $arr           Array with values to be escaped
         * @param boolean $add_quotation add quotation marks for string values
-        *
         * @return void
         */
-       public function escapeArray(&$arr, $add_quotation = false)
+       public function escapeArray(&$arr, bool $add_quotation = false)
        {
                array_walk($arr, [$this, 'escapeArrayCallback'], $add_quotation);
        }
+
+       /**
+        * Replaces a string in the provided fields of the provided table
+        *
+        * @param string $table  Table name
+        * @param array  $fields List of field names in the provided table
+        * @param string $search String to search for
+        * @param string $replace String to replace with
+        * @return void
+        * @throws \Exception
+        */
+       public function replaceInTableFields(string $table, array $fields, string $search, string $replace)
+       {
+               $search = $this->escape($search);
+               $replace = $this->escape($replace);
+
+               $upd = [];
+               foreach ($fields as $field) {
+                       $field = DBA::quoteIdentifier($field);
+                       $upd[] = "$field = REPLACE($field, '$search', '$replace')";
+               }
+
+               $upds = implode(', ', $upd);
+
+               $r = $this->e(sprintf("UPDATE %s SET %s;", DBA::quoteIdentifier($table), $upds));
+
+               if (!$this->isResult($r)) {
+                       throw new \RuntimeException("Failed updating `$table`: " . $this->errorMessage());
+               }
+       }
 }