use Friendica\Database\DBA;
use Friendica\DI;
use Friendica\Model\Item;
-use Friendica\Network\HTTPClient\Client\HttpClientAccept;
use Friendica\Network\HTTPException;
use Friendica\Network\Probe;
use Friendica\Protocol\ActivityNamespace;
return $data;
}
- $data = ['addr' => $addr];
- $template = 'https://' . $addr_parts[1] . '/.well-known/webfinger?resource=acct:' . urlencode($addr);
- $webfinger = Probe::webfinger(str_replace('{uri}', urlencode($addr), $template), HttpClientAccept::JRD_JSON);
- if (empty($webfinger['links'])) {
- $template = 'http://' . $addr_parts[1] . '/.well-known/webfinger?resource=acct:' . urlencode($addr);
- $webfinger = Probe::webfinger(str_replace('{uri}', urlencode($addr), $template), HttpClientAccept::JRD_JSON);
- if (empty($webfinger['links'])) {
- return [];
- }
- $data['baseurl'] = 'http://' . $addr_parts[1];
- } else {
- $data['baseurl'] = 'https://' . $addr_parts[1];
+ $webfinger = Probe::getWebfingerArray($addr);
+ if (empty($webfinger['webfinger']['links'])) {
+ return [];
}
- foreach ($webfinger['links'] as $link) {
+ $data['baseurl'] = $webfinger['baseurl'];
+
+ foreach ($webfinger['webfinger']['links'] as $link) {
if (empty($link['rel'])) {
continue;
}
return [];
}
+ if (!Network::isValidHttpUrl($url) && !filter_var($url, FILTER_VALIDATE_EMAIL)) {
+ Logger::info('Invalid URL', ['url' => $url]);
+ return [];
+ }
+
$fetched_contact = [];
if (empty($update)) {
$apcontact = [];
- $webfinger = empty(parse_url($url, PHP_URL_SCHEME));
+ // Mastodon profile short-form URL https://domain.tld/@user doesn't return AP data when queried
+ // with HTTPSignature::fetchRaw, but returns the correct data when provided to WebFinger
+ // @see https://github.com/friendica/friendica/issues/13359
+ $webfinger = empty(parse_url($url, PHP_URL_SCHEME)) || strpos($url, '@') !== false;
if ($webfinger) {
$apcontact = self::fetchWebfingerData($url);
if (empty($apcontact['url'])) {
$cachekey = 'apcontact:' . ItemURI::getIdByURI($url);
$result = DI::cache()->get($cachekey);
if (!is_null($result)) {
- Logger::notice('Multiple requests for the address', ['url' => $url, 'update' => $update, 'callstack' => System::callstack(20), 'result' => $result]);
+ Logger::info('Multiple requests for the address', ['url' => $url, 'update' => $update, 'result' => $result]);
if (!empty($fetched_contact)) {
return $fetched_contact;
}
if (empty($data)) {
$local_owner = [];
- $curlResult = HTTPSignature::fetchRaw($url);
- $failed = empty($curlResult) || empty($curlResult->getBody()) ||
- (!$curlResult->isSuccess() && ($curlResult->getReturnCode() != 410));
+ try {
+ $curlResult = HTTPSignature::fetchRaw($url);
+ $failed = empty($curlResult) || empty($curlResult->getBody()) ||
+ (!$curlResult->isSuccess() && ($curlResult->getReturnCode() != 410));
- if (!$failed) {
- $data = json_decode($curlResult->getBody(), true);
- $failed = empty($data) || !is_array($data);
- }
+ if (!$failed) {
+ $data = json_decode($curlResult->getBody(), true);
+ $failed = empty($data) || !is_array($data);
+ }
- if (!$failed && ($curlResult->getReturnCode() == 410)) {
- $data = ['@context' => ActivityPub::CONTEXT, 'id' => $url, 'type' => 'Tombstone'];
+ if (!$failed && ($curlResult->getReturnCode() == 410)) {
+ $data = ['@context' => ActivityPub::CONTEXT, 'id' => $url, 'type' => 'Tombstone'];
+ }
+ } catch (\Exception $exception) {
+ Logger::notice('Error fetching url', ['url' => $url, 'exception' => $exception]);
+ $failed = true;
}
if ($failed) {
$apcontact['photo'] = JsonLD::fetchElement($compacted, 'as:icon', '@id');
if (is_array($apcontact['photo']) || !empty($compacted['as:icon']['as:url']['@id'])) {
$apcontact['photo'] = JsonLD::fetchElement($compacted['as:icon'], 'as:url', '@id');
+ } elseif (empty($apcontact['photo'])) {
+ $photo = JsonLD::fetchElementArray($compacted, 'as:icon', 'as:url');
+ if (!empty($photo[0]['@id'])) {
+ $apcontact['photo'] = $photo[0]['@id'];
+ }
}
$apcontact['header'] = JsonLD::fetchElement($compacted, 'as:image', '@id');
if (!empty($local_owner)) {
$following = ActivityPub\Transmitter::getContacts($local_owner, [Contact::SHARING, Contact::FRIEND], 'following');
} else {
- $following = ActivityPub::fetchContent($apcontact['following']);
+ $following = HTTPSignature::fetch($apcontact['following']);
}
if (!empty($following['totalItems'])) {
// Mastodon seriously allows for this condition?
if (!empty($local_owner)) {
$followers = ActivityPub\Transmitter::getContacts($local_owner, [Contact::FOLLOWER, Contact::FRIEND], 'followers');
} else {
- $followers = ActivityPub::fetchContent($apcontact['followers']);
+ $followers = HTTPSignature::fetch($apcontact['followers']);
}
if (!empty($followers['totalItems'])) {
// Mastodon seriously allows for this condition?
if (!empty($local_owner)) {
$statuses_count = self::getStatusesCount($local_owner);
} else {
- $outbox = ActivityPub::fetchContent($apcontact['outbox']);
+ $outbox = HTTPSignature::fetch($apcontact['outbox']);
$statuses_count = $outbox['totalItems'] ?? 0;
}
if (!empty($statuses_count)) {
$apcontact['discoverable'] = JsonLD::fetchElement($compacted, 'toot:discoverable', '@value');
- // To-Do
-
- // Unhandled
- // tag, attachment, image, nomadicLocations, signature, movedTo, liked
-
- // Unhandled from Misskey
- // sharedInbox, isCat
-
- // Unhandled from Kroeg
- // kroeg:blocks, updated
+ if (!empty($apcontact['photo'])) {
+ $apcontact['photo'] = Network::addBasePath($apcontact['photo'], $apcontact['url']);
- if (!empty($apcontact['photo']) && !Network::isValidHttpUrl($apcontact['photo'])) {
- Logger::info('Invalid URL for photo', ['url' => $apcontact['url'], 'photo' => $apcontact['photo']]);
- $apcontact['photo'] = null;
+ if (!Network::isValidHttpUrl($apcontact['photo'])) {
+ Logger::warning('Invalid URL for photo', ['url' => $apcontact['url'], 'photo' => $apcontact['photo']]);
+ $apcontact['photo'] = '';
+ }
}
// When the photo is too large, try to shorten it by removing parts
if (strlen($apcontact['photo'] ?? '') > 255) {
$parts = parse_url($apcontact['photo']);
unset($parts['fragment']);
- $apcontact['photo'] = (string)Uri::fromParts($parts);
+ $apcontact['photo'] = (string)Uri::fromParts((array)$parts);
if (strlen($apcontact['photo']) > 255) {
unset($parts['query']);
- $apcontact['photo'] = (string)Uri::fromParts($parts);
+ $apcontact['photo'] = (string)Uri::fromParts((array)$parts);
}
if (strlen($apcontact['photo']) > 255) {
*/
public static function isRelay(array $apcontact): bool
{
- if (empty($apcontact['nick']) || $apcontact['nick'] != 'relay') {
+ if (!in_array($apcontact['type'] ?? '', ['Application', 'Group', 'Service'])) {
return false;
}
- if (!empty($apcontact['type']) && $apcontact['type'] == 'Application') {
+ $path = parse_url($apcontact['url'], PHP_URL_PATH);
+ if (($apcontact['type'] == 'Group') && !empty($apcontact['followers']) && ($apcontact['nick'] == 'relay') && ($path == '/actor')) {
+ return true;
+ }
+
+ if (in_array($apcontact['type'], ['Application', 'Service']) && empty($apcontact['following']) && empty($apcontact['followers'])) {
return true;
}
- if (!empty($apcontact['type']) && in_array($apcontact['type'], ['Group', 'Service']) && is_null($apcontact['outbox'])) {
+ if (($apcontact['type'] == 'Application') && ($apcontact['nick'] == 'relay') && in_array($path, ['/actor', '/relay'])) {
return true;
}
projects / friendica.git / blobdiff