]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Contact/Relation.php
Don't fetch sugestions for the system user / catch error on contact timeline
[friendica.git] / src / Model / Contact / Relation.php
index 3c95973238e1e9d43aae474927db3c2e35519529..5616148fa0183e2d774d3c70f585c80218faced9 100644 (file)
@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (C) 2020, Friendica
+ * @copyright Copyright (C) 2010-2022, the Friendica project
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -24,6 +24,7 @@ namespace Friendica\Model\Contact;
 use Exception;
 use Friendica\Core\Logger;
 use Friendica\Core\Protocol;
+use Friendica\Database\Database;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\APContact;
@@ -64,7 +65,7 @@ class Relation
                        return;
                }
 
-               DBA::update('contact-relation', ['last-interaction' => $interaction_date], ['cid' => $target, 'relation-cid' => $actor], true);
+               DBA::insert('contact-relation', ['last-interaction' => $interaction_date, 'cid' => $target, 'relation-cid' => $actor], Database::INSERT_UPDATE);
        }
 
        /**
@@ -77,19 +78,22 @@ class Relation
        {
                $contact = Contact::getByURL($url);
                if (empty($contact)) {
+                       Logger::info('Contact not found', ['url' => $url]);
                        return;
                }
 
                if (!self::isDiscoverable($url, $contact)) {
+                       Logger::info('Contact is not discoverable', ['url' => $url]);
                        return;
                }
 
                $uid = User::getIdForURL($url);
                if (!empty($uid)) {
-                       // Fetch the followers/followings locally
+                       Logger::info('Fetch the followers/followings locally', ['url' => $url]);
                        $followers = self::getContacts($uid, [Contact::FOLLOWER, Contact::FRIEND]);
                        $followings = self::getContacts($uid, [Contact::SHARING, Contact::FRIEND]);
-               } else {
+               } elseif (!Contact::isLocal($url)) {
+                       Logger::info('Fetch the followers/followings by polling the endpoints', ['url' => $url]);
                        $apcontact = APContact::getByURL($url, false);
 
                        if (!empty($apcontact['followers']) && is_string($apcontact['followers'])) {
@@ -103,10 +107,14 @@ class Relation
                        } else {
                                $followings = [];
                        }
+               } else {
+                       Logger::warning('Contact seems to be local but could not be found here', ['url' => $url]);
+                       $followers = [];
+                       $followings = [];
                }
 
                if (empty($followers) && empty($followings)) {
-                       DBA::update('contact', ['last-discovery' => DateTimeFormat::utcNow()], ['id' => $contact['id']]);
+                       Contact::update(['last-discovery' => DateTimeFormat::utcNow()], ['id' => $contact['id']]);
                        Logger::info('The contact does not offer discoverable data', ['id' => $contact['id'], 'url' => $url, 'network' => $contact['network']]);
                        return;
                }
@@ -136,14 +144,14 @@ class Relation
                        $actor = Contact::getIdForURL($contact);
                        if (!empty($actor)) {
                                if (in_array($contact, $followers)) {
-                                       $fields = ['cid' => $target, 'relation-cid' => $actor];
-                                       DBA::update('contact-relation', ['follows' => true, 'follow-updated' => DateTimeFormat::utcNow()], $fields, true);
+                                       $fields = ['cid' => $target, 'relation-cid' => $actor, 'follows' => true, 'follow-updated' => DateTimeFormat::utcNow()];
+                                       DBA::insert('contact-relation', $fields, Database::INSERT_UPDATE);
                                        $follower_counter++;
                                }
 
                                if (in_array($contact, $followings)) {
-                                       $fields = ['cid' => $actor, 'relation-cid' => $target];
-                                       DBA::update('contact-relation', ['follows' => true, 'follow-updated' => DateTimeFormat::utcNow()], $fields, true);
+                                       $fields = ['cid' => $actor, 'relation-cid' => $target, 'follows' => true, 'follow-updated' => DateTimeFormat::utcNow()];
+                                       DBA::insert('contact-relation', $fields, Database::INSERT_UPDATE);
                                        $following_counter++;
                                }
                        }
@@ -154,7 +162,7 @@ class Relation
                        DBA::delete('contact-relation', ['cid' => $target, 'follows' => false, 'last-interaction' => DBA::NULL_DATETIME]);
                }
 
-               DBA::update('contact', ['last-discovery' => DateTimeFormat::utcNow()], ['id' => $target]);
+               Contact::update(['last-discovery' => DateTimeFormat::utcNow()], ['id' => $target]);
                Logger::info('Contacts discovery finished', ['id' => $target, 'url' => $url, 'follower' => $follower_counter, 'following' => $following_counter]);
                return;
        }
@@ -166,7 +174,7 @@ class Relation
         * @param array $rel
         * @return array contact list
         */
-       private static function getContacts(int $uid, array $rel)
+       private static function getContacts(int $uid, array $rel): array
        {
                $list = [];
                $profile = Profile::getByUID($uid);
@@ -174,8 +182,15 @@ class Relation
                        return $list;
                }
 
-               $condition = ['rel' => $rel, 'uid' => $uid, 'self' => false, 'deleted' => false,
-                       'hidden' => false, 'archive' => false, 'pending' => false];
+               $condition = [
+                       'rel' => $rel,
+                       'uid' => $uid,
+                       'self' => false,
+                       'deleted' => false,
+                       'hidden' => false,
+                       'archive' => false,
+                       'pending' => false,
+               ];
                $condition = DBA::mergeConditions($condition, ["`url` IN (SELECT `url` FROM `apcontact`)"]);
                $contacts = DBA::select('contact', ['url'], $condition);
                while ($contact = DBA::fetch($contacts)) {
@@ -193,7 +208,7 @@ class Relation
         * @param array  $contact Contact array
         * @return boolean True if contact is discoverable
         */
-       public static function isDiscoverable(string $url, array $contact = [])
+       public static function isDiscoverable(string $url, array $contact = []): bool
        {
                $contact_discovery = DI::config()->get('system', 'contact_discovery');
 
@@ -246,13 +261,72 @@ class Relation
        }
 
        /**
-        * @param int $uid   user
+        * Check if the cached suggestion is outdated
+        *
+        * @param integer $uid
+        * @return boolean
+        */
+       static public function areSuggestionsOutdated(int $uid): bool
+       {
+               return DI::pConfig()->get($uid, 'suggestion', 'last_update') + 3600 < time();
+       }
+
+       /**
+        * Update contact suggestions for a given user
+        *
+        * @param integer $uid
+        * @return void
+        */
+       static public function updateCachedSuggestions(int $uid)
+       {
+               if (!self::areSuggestionsOutdated($uid)) {
+                       return;
+               }
+
+               DBA::delete('account-suggestion', ['uid' => $uid, 'ignore' => false]);
+
+               foreach (self::getSuggestions($uid) as $contact) {
+                       DBA::insert('account-suggestion', ['uri-id' => $contact['uri-id'], 'uid' => $uid, 'level' => 1], Database::INSERT_IGNORE);
+               }
+
+               DI::pConfig()->set($uid, 'suggestion', 'last_update', time());
+       }
+
+       /**
+        * Returns a cached array of suggested contacts for given user id
+        *
+        * @param int $uid   User id
+        * @param int $start optional, default 0
+        * @param int $limit optional, default 80
+        * @return array
+        */
+       static public function getCachedSuggestions(int $uid, int $start = 0, int $limit = 80): array
+       {
+               $condition = ["`uid` = ? AND `uri-id` IN (SELECT `uri-id` FROM `account-suggestion` WHERE NOT `ignore` AND `uid` = ?)", 0, $uid];
+               $params = ['limit' => [$start, $limit]];
+               $cached = DBA::selectToArray('contact', [], $condition, $params);
+
+               if (!empty($cached)) {
+                       return $cached;
+               } else {
+                       return self::getSuggestions($uid, $start, $limit);
+               }
+       }
+
+       /**
+        * Returns an array of suggested contacts for given user id
+        *
+        * @param int $uid   User id
         * @param int $start optional, default 0
         * @param int $limit optional, default 80
         * @return array
         */
-       static public function getSuggestions(int $uid, int $start = 0, int $limit = 80)
+       static public function getSuggestions(int $uid, int $start = 0, int $limit = 80): array
        {
+               if ($uid == 0) {
+                       return [];
+               }
+
                $cid = Contact::getPublicIdByUserId($uid);
                $totallimit = $start + $limit;
                $contacts = [];
@@ -264,20 +338,26 @@ class Relation
 
                // The query returns contacts where contacts interacted with whom the given user follows.
                // Contacts who already are in the user's contact table are ignored.
-               $results = DBA::select('contact', [],
-                       ["`id` IN (SELECT `cid` FROM `contact-relation` WHERE `relation-cid` IN
+               $results = DBA::select('contact', [], ["`id` IN (SELECT `cid` FROM `contact-relation` WHERE `relation-cid` IN
                                (SELECT `cid` FROM `contact-relation` WHERE `relation-cid` = ?)
                                        AND NOT `cid` IN (SELECT `id` FROM `contact` WHERE `uid` = ? AND `nurl` IN
-                                               (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?))))
-                       AND NOT `hidden` AND `network` IN (?, ?, ?, ?)",
-                       $cid, 0, $uid, Contact::FRIEND, Contact::SHARING,
-                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus],
-                       ['order' => ['last-item' => true], 'limit' => $totallimit]
+                                               (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?))) AND `id` = `cid`)
+                       AND NOT `hidden` AND `network` IN (?, ?, ?, ?)
+                       AND NOT `uri-id` IN (SELECT `uri-id` FROM `account-suggestion` WHERE `uri-id` = `contact`.`uri-id` AND `uid` = ?)",
+                       $cid,
+                       0,
+                       $uid, Contact::FRIEND, Contact::SHARING,
+                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus, $uid
+                       ], [
+                               'order' => ['last-item' => true],
+                               'limit' => $totallimit,
+                       ]
                );
 
                while ($contact = DBA::fetch($results)) {
                        $contacts[$contact['id']] = $contact;
                }
+
                DBA::close($results);
 
                Logger::info('Contacts of contacts who are followed by the given user', ['uid' => $uid, 'cid' => $cid, 'count' => count($contacts)]);
@@ -292,10 +372,11 @@ class Relation
                        ["`id` IN (SELECT `cid` FROM `contact-relation` WHERE `relation-cid` IN
                                (SELECT `relation-cid` FROM `contact-relation` WHERE `cid` = ?)
                                        AND NOT `cid` IN (SELECT `id` FROM `contact` WHERE `uid` = ? AND `nurl` IN
-                                               (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?))))
-                       AND NOT `hidden` AND `network` IN (?, ?, ?, ?)",
+                                               (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?))) AND `id` = `cid`)
+                       AND NOT `hidden` AND `network` IN (?, ?, ?, ?)
+                       AND NOT `uri-id` IN (SELECT `uri-id` FROM `account-suggestion` WHERE `uri-id` = `contact`.`uri-id` AND `uid` = ?)",
                        $cid, 0, $uid, Contact::FRIEND, Contact::SHARING,
-                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus],
+                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus, $uid],
                        ['order' => ['last-item' => true], 'limit' => $totallimit]
                );
 
@@ -313,9 +394,10 @@ class Relation
                // The query returns contacts that follow the given user but aren't followed by that user.
                $results = DBA::select('contact', [],
                        ["`nurl` IN (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` = ?)
-                       AND NOT `hidden` AND `uid` = ? AND `network` IN (?, ?, ?, ?)",
+                       AND NOT `hidden` AND `uid` = ? AND `network` IN (?, ?, ?, ?)
+                       AND NOT `uri-id` IN (SELECT `uri-id` FROM `account-suggestion` WHERE `uri-id` = `contact`.`uri-id` AND `uid` = ?)",
                        $uid, Contact::FOLLOWER, 0, 
-                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus],
+                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus, $uid],
                        ['order' => ['last-item' => true], 'limit' => $totallimit]
                );
 
@@ -332,10 +414,11 @@ class Relation
 
                // The query returns any contact that isn't followed by that user.
                $results = DBA::select('contact', [],
-                       ["NOT `nurl` IN (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?))
-                       AND NOT `hidden` AND `uid` = ? AND `network` IN (?, ?, ?, ?)",
+                       ["NOT `nurl` IN (SELECT `nurl` FROM `contact` WHERE `uid` = ? AND `rel` IN (?, ?) AND `nurl` = `nurl`)
+                       AND NOT `hidden` AND `uid` = ? AND `network` IN (?, ?, ?, ?)
+                       AND NOT `uri-id` IN (SELECT `uri-id` FROM `account-suggestion` WHERE `uri-id` = `contact`.`uri-id` AND `uid` = ?)",
                        $uid, Contact::FRIEND, Contact::SHARING, 0, 
-                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus],
+                       Protocol::ACTIVITYPUB, Protocol::DFRN, $diaspora, $ostatus, $uid],
                        ['order' => ['last-item' => true], 'limit' => $totallimit]
                );
 
@@ -357,12 +440,12 @@ class Relation
         * @return int
         * @throws Exception
         */
-       public static function countFollows(int $cid, array $condition = [])
+       public static function countFollows(int $cid, array $condition = []): int
        {
-               $condition = DBA::mergeConditions($condition,
-                       ['`id` IN (SELECT `relation-cid` FROM `contact-relation` WHERE `cid` = ? AND `follows`)', 
-                       $cid]
-               );
+               $condition = DBA::mergeConditions($condition, [
+                       '`id` IN (SELECT `relation-cid` FROM `contact-relation` WHERE `cid` = ? AND `follows`)', 
+                       $cid,
+               ]);
 
                return DI::dba()->count('contact', $condition);
        }
@@ -548,7 +631,7 @@ class Relation
         * @param int   $count
         * @param int   $offset
         * @param bool  $shuffle
-        * @return array
+        * @return array|bool Array on success, false on failure
         * @throws Exception
         */
        public static function listCommon(int $sourceId, int $targetId, array $condition = [], int $count = 30, int $offset = 0, bool $shuffle = false)
@@ -573,7 +656,7 @@ class Relation
         * @return int
         * @throws Exception
         */
-       public static function countCommonFollows(int $sourceId, int $targetId, array $condition = [])
+       public static function countCommonFollows(int $sourceId, int $targetId, array $condition = []): int
        {
                $condition = DBA::mergeConditions($condition,
                        ['`id` IN (SELECT `relation-cid` FROM `contact-relation` WHERE `cid` = ? AND `follows`) 
@@ -593,7 +676,7 @@ class Relation
         * @param int   $count
         * @param int   $offset
         * @param bool  $shuffle
-        * @return array
+        * @return array|bool Array on success, false on failure
         * @throws Exception
         */
        public static function listCommonFollows(int $sourceId, int $targetId, array $condition = [], int $count = 30, int $offset = 0, bool $shuffle = false)
@@ -618,7 +701,7 @@ class Relation
         * @return int
         * @throws Exception
         */
-       public static function countCommonFollowers(int $sourceId, int $targetId, array $condition = [])
+       public static function countCommonFollowers(int $sourceId, int $targetId, array $condition = []): int
        {
                $condition = DBA::mergeConditions($condition,
                        ["`id` IN (SELECT `cid` FROM `contact-relation` WHERE `relation-cid` = ? AND `follows`) 
@@ -638,7 +721,7 @@ class Relation
         * @param int   $count
         * @param int   $offset
         * @param bool  $shuffle
-        * @return array
+        * @return array|bool Array on success, false on failure
         * @throws Exception
         */
        public static function listCommonFollowers(int $sourceId, int $targetId, array $condition = [], int $count = 30, int $offset = 0, bool $shuffle = false)