]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Contact.php
Merge remote-tracking branch 'upstream/develop' into contact-update
[friendica.git] / src / Model / Contact.php
index 5a5701f09a61c9d84a75d15b03977343e77df007..17506a7d31dc6a5e256390cbdd2b0b6bd1ab626e 100644 (file)
@@ -111,13 +111,42 @@ class Contact extends BaseObject
         */
 
        /**
-        * @param  integer       $id
+        * @param array $fields    Array of selected fields, empty for all
+        * @param array $condition Array of fields for condition
+        * @param array $params    Array of several parameters
+        * @return array
+        * @throws \Exception
+        */
+       public static function select(array $fields = [], array $condition = [], array $params = [])
+       {
+               $statement = DBA::select('contact', $fields, $condition, $params);
+
+               return DBA::toArray($statement);
+       }
+
+       /**
+        * @param array $fields    Array of selected fields, empty for all
+        * @param array $condition Array of fields for condition
+        * @param array $params    Array of several parameters
+        * @return array
+        * @throws \Exception
+        */
+       public static function selectFirst(array $fields = [], array $condition = [], array $params = [])
+       {
+               $contact = DBA::selectFirst('contact', $fields, $condition, $params);
+
+               return $contact;
+       }
+
+       /**
+        * @param integer $id     Contact ID
+        * @param array   $fields Array of selected fields, empty for all
         * @return array|boolean Contact record if it exists, false otherwise
         * @throws \Exception
         */
-       public static function getById($id)
+       public static function getById($id, $fields = [])
        {
-               return DBA::selectFirst('contact', [], ['id' => $id]);
+               return DBA::selectFirst('contact', $fields, ['id' => $id]);
        }
 
        /**
@@ -147,7 +176,6 @@ class Contact extends BaseObject
 
        /**
         * @brief Get the basepath for a given contact link
-        * @todo  Add functionality to store this value in the contact table
         *
         * @param string $url The contact link
         *
@@ -157,13 +185,19 @@ class Contact extends BaseObject
         */
        public static function getBasepath($url)
        {
-               $data = Probe::uri($url);
-               if (!empty($data['baseurl'])) {
-                       return $data['baseurl'];
+               $contact = DBA::selectFirst('contact', ['baseurl'], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]);
+               if (!empty($contact['baseurl'])) {
+                       return $contact['baseurl'];
+               }
+
+               self::updateFromProbeByURL($url, true);
+
+               $contact = DBA::selectFirst('contact', ['baseurl'], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]);
+               if (!empty($contact['baseurl'])) {
+                       return $contact['baseurl'];
                }
 
-               // When we can't probe the server, we use some ugly function that does some pattern matching
-               return PortableContact::detectServer($url);
+               return '';
        }
 
        /**
@@ -223,6 +257,28 @@ class Contact extends BaseObject
                return ['public' => $pcid, 'user' => $ucid];
        }
 
+       /**
+        * Returns contact details for a given contact id in combination with a user id
+        *
+        * @param int $cid A contact ID
+        * @param int $uid The User ID
+        * @param array $fields The selected fields for the contact
+        *
+        * @return array The contact details
+        *
+        * @throws \Exception
+        */
+       public static function getContactForUser($cid, $uid, array $fields = [])
+       {
+               $contact = DBA::selectFirst('contact', $fields, ['id' => $cid, 'uid' => $uid]);
+
+               if (!DBA::isResult($contact)) {
+                       return [];
+               } else {
+                       return $contact;
+               }
+       }
+
        /**
         * @brief Block contact id for user id
         *
@@ -542,11 +598,13 @@ class Contact extends BaseObject
                        return;
                }
 
+               $file_suffix = 'jpg';
+
                $fields = ['name' => $profile['name'], 'nick' => $user['nickname'],
                        'avatar-date' => $self['avatar-date'], 'location' => Profile::formatLocation($profile),
                        'about' => $profile['about'], 'keywords' => $profile['pub_keywords'],
-                       'gender' => $profile['gender'], 'avatar' => $profile['photo'],
-                       'contact-type' => $user['account-type'], 'xmpp' => $profile['xmpp']];
+                       'gender' => $profile['gender'], 'contact-type' => $user['account-type'],
+                       'xmpp' => $profile['xmpp']];
 
                $avatar = Photo::selectFirst(['resource-id', 'type'], ['uid' => $uid, 'profile' => true]);
                if (DBA::isResult($avatar)) {
@@ -558,8 +616,6 @@ class Contact extends BaseObject
                        $types = Image::supportedTypes();
                        if (isset($types[$avatar['type']])) {
                                $file_suffix = $types[$avatar['type']];
-                       } else {
-                               $file_suffix = 'jpg';
                        }
 
                        // We are adding a timestamp value so that other systems won't use cached content
@@ -578,6 +634,7 @@ class Contact extends BaseObject
                        $fields['micro'] = System::baseUrl() . '/images/person-48.jpg';
                }
 
+               $fields['avatar'] = System::baseUrl() . '/photo/profile/' .$uid . '.' . $file_suffix;
                $fields['forum'] = $user['page-flags'] == User::PAGE_FLAGS_COMMUNITY;
                $fields['prv'] = $user['page-flags'] == User::PAGE_FLAGS_PRVGROUP;
 
@@ -610,8 +667,8 @@ class Contact extends BaseObject
                        DBA::update('contact', $fields, ['uid' => 0, 'nurl' => $self['nurl']]);
 
                        // Update the profile
-                       $fields = ['photo' => System::baseUrl() . '/photo/profile/' .$uid . '.jpg',
-                               'thumb' => System::baseUrl() . '/photo/avatar/' . $uid .'.jpg'];
+                       $fields = ['photo' => System::baseUrl() . '/photo/profile/' .$uid . '.' . $file_suffix,
+                               'thumb' => System::baseUrl() . '/photo/avatar/' . $uid .'.' . $file_suffix];
                        DBA::update('profile', $fields, ['uid' => $uid, 'is-default' => true]);
                }
        }
@@ -740,6 +797,7 @@ class Contact extends BaseObject
                                 */
                                DBA::update('contact', ['archive' => 1], ['id' => $contact['id']]);
                                DBA::update('contact', ['archive' => 1], ['nurl' => Strings::normaliseLink($contact['url']), 'self' => false]);
+                               GContact::updateFromPublicContactURL($contact['url']);
                        }
                }
        }
@@ -777,6 +835,7 @@ class Contact extends BaseObject
                $fields = ['term-date' => DBA::NULL_DATETIME, 'archive' => false];
                DBA::update('contact', $fields, ['id' => $contact['id']]);
                DBA::update('contact', $fields, ['nurl' => Strings::normaliseLink($contact['url'])]);
+               GContact::updateFromPublicContactURL($contact['url']);
 
                if (!empty($contact['batch'])) {
                        $condition = ['batch' => $contact['batch'], 'contact-type' => self::TYPE_RELAY];
@@ -857,7 +916,7 @@ class Contact extends BaseObject
                        // If there is more than one entry we filter out the connector networks
                        if (count($r) > 1) {
                                foreach ($r as $id => $result) {
-                                       if ($result["network"] == Protocol::STATUSNET) {
+                                       if (!in_array($result["network"], Protocol::NATIVE_SUPPORT)) {
                                                unset($r[$id]);
                                        }
                                }
@@ -911,9 +970,9 @@ class Contact extends BaseObject
                }
 
                if ((empty($profile["addr"]) || empty($profile["name"])) && (defaults($profile, "gid", 0) != 0)
-                       && in_array($profile["network"], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS])
+                       && in_array($profile["network"], Protocol::FEDERATED)
                ) {
-                       Worker::add(PRIORITY_LOW, "UpdateGContact", $profile["gid"]);
+                       Worker::add(PRIORITY_LOW, "UpdateGContact", $url);
                }
 
                // Show contact details of Diaspora contacts only if connected
@@ -1041,7 +1100,7 @@ class Contact extends BaseObject
                        $profile_link = $profile_link . '?tab=profile';
                }
 
-               if (in_array($contact['network'], [Protocol::DFRN, Protocol::DIASPORA]) && !$contact['self']) {
+               if (self::canReceivePrivateMessages($contact)) {
                        $pm_url = System::baseUrl() . '/message/new/' . $contact['id'];
                }
 
@@ -1133,12 +1192,12 @@ class Contact extends BaseObject
         *
         * @return array Contact array in the "probe" structure
        */
-       private static function getProbeDataFromDatabase($url, $cid)
+       private static function getProbeDataFromDatabase($url, $cid = null)
        {
                // The link could be provided as http although we stored it as https
                $ssl_url = str_replace('http://', 'https://', $url);
 
-               $fields = ['url', 'addr', 'alias', 'notify', 'poll', 'name', 'nick',
+               $fields = ['id', 'uid', 'url', 'addr', 'alias', 'notify', 'poll', 'name', 'nick',
                        'photo', 'keywords', 'location', 'about', 'network',
                        'priority', 'batch', 'request', 'confirm', 'poco'];
 
@@ -1248,11 +1307,13 @@ class Contact extends BaseObject
 
                /// @todo Verify if we can't use Contact::getDetailsByUrl instead of the following
                // We first try the nurl (http://server.tld/nick), most common case
-               $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false]);
+               $fields = ['id', 'avatar', 'updated', 'network'];
+               $options = ['order' => ['id']];
+               $contact = DBA::selectFirst('contact', $fields, ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false], $options);
 
                // Then the addr (nick@server.tld)
                if (!DBA::isResult($contact)) {
-                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['addr' => $url, 'uid' => $uid, 'deleted' => false]);
+                       $contact = DBA::selectFirst('contact', $fields, ['addr' => $url, 'uid' => $uid, 'deleted' => false], $options);
                }
 
                // Then the alias (which could be anything)
@@ -1260,7 +1321,7 @@ class Contact extends BaseObject
                        // The link could be provided as http although we stored it as https
                        $ssl_url = str_replace('http://', 'https://', $url);
                        $condition = ['`alias` IN (?, ?, ?) AND `uid` = ? AND NOT `deleted`', $url, Strings::normaliseLink($url), $ssl_url, $uid];
-                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], $condition);
+                       $contact = DBA::selectFirst('contact', $fields, $condition, $options);
                }
 
                if (DBA::isResult($contact)) {
@@ -1276,7 +1337,7 @@ class Contact extends BaseObject
 
                        // Update the contact in the background if needed but it is called by the frontend
                        if ($update_contact && $no_update && in_array($contact['network'], Protocol::NATIVE_SUPPORT)) {
-                               Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id);
+                               Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id, ($uid == 0 ? 'force' : ''));
                        }
 
                        if (!$update_contact || $no_update) {
@@ -1287,10 +1348,14 @@ class Contact extends BaseObject
                        return 0;
                }
 
-               // When we don't want to update, we look if we know this contact in any way
                if ($no_update && empty($default)) {
+                       // When we don't want to update, we look if we know this contact in any way
                        $data = self::getProbeDataFromDatabase($url, $contact_id);
                        $background_update = true;
+               } elseif ($no_update && !empty($default)) {
+                       // If there are default values, take these
+                       $data = $default;
+                       $background_update = false;
                } else {
                        $data = [];
                        $background_update = false;
@@ -1305,18 +1370,9 @@ class Contact extends BaseObject
                        }
                }
 
-               // Last try in gcontact for unsupported networks
-               if (!in_array($data["network"], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::OSTATUS, Protocol::DIASPORA, Protocol::PUMPIO, Protocol::MAIL, Protocol::FEED])) {
-                       if ($uid != 0) {
-                               return 0;
-                       }
-
-                       $contact = array_merge(self::getProbeDataFromDatabase($url, $contact_id), $default);
-                       if (empty($contact)) {
-                               return 0;
-                       }
-
-                       $data = array_merge($data, $contact);
+               // Take the default values when probing failed
+               if (!empty($default) && !in_array($data["network"], array_merge(Protocol::NATIVE_SUPPORT, [Protocol::PUMPIO]))) {
+                       $data = array_merge($data, $default);
                }
 
                if (empty($data)) {
@@ -1344,7 +1400,6 @@ class Contact extends BaseObject
                                'location'  => defaults($data, 'location', ''),
                                'about'     => defaults($data, 'about', ''),
                                'network'   => $data['network'],
-                               'protocol'  => self::getProtocol($data['url'], $data['network']),
                                'pubkey'    => defaults($data, 'pubkey', ''),
                                'rel'       => self::SHARING,
                                'priority'  => defaults($data, 'priority', 0),
@@ -1352,6 +1407,7 @@ class Contact extends BaseObject
                                'request'   => defaults($data, 'request', ''),
                                'confirm'   => defaults($data, 'confirm', ''),
                                'poco'      => defaults($data, 'poco', ''),
+                               'baseurl'   => defaults($data, 'baseurl', ''),
                                'name-date' => DateTimeFormat::utcNow(),
                                'uri-date'  => DateTimeFormat::utcNow(),
                                'avatar-date' => DateTimeFormat::utcNow(),
@@ -1374,7 +1430,7 @@ class Contact extends BaseObject
 
                        // Update in the background when we fetched the data solely from the database
                        if ($background_update) {
-                               Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id);
+                               Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id, ($uid == 0 ? 'force' : ''));
                        }
 
                        // Update the newly created contact from data in the gcontact table
@@ -1401,11 +1457,11 @@ class Contact extends BaseObject
                        }
                }
 
-               if (!empty($data['photo'])) {
+               if (!empty($data['photo']) && ($data['network'] != Protocol::FEED)) {
                        self::updateAvatar($data['photo'], $uid, $contact_id);
                }
 
-               $fields = ['url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date', 'pubkey', 'protocol'];
+               $fields = ['url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date', 'pubkey', 'baseurl'];
                $contact = DBA::selectFirst('contact', $fields, ['id' => $contact_id]);
 
                // This condition should always be true
@@ -1413,14 +1469,18 @@ class Contact extends BaseObject
                        return $contact_id;
                }
 
-               $updated = ['addr' => $data['addr'],
+               $updated = [
+                       'addr' => $data['addr'] ?? '',
                        'alias' => defaults($data, 'alias', ''),
                        'url' => $data['url'],
                        'nurl' => Strings::normaliseLink($data['url']),
                        'name' => $data['name'],
-                       'nick' => $data['nick'],
-                       'protocol' => self::getProtocol($data['url'], $data['network'])];
+                       'nick' => $data['nick']
+               ];
 
+               if (!empty($data['baseurl'])) {
+                       $updated['baseurl'] = $data['baseurl'];
+               }
                if (!empty($data['keywords'])) {
                        $updated['keywords'] = $data['keywords'];
                }
@@ -1449,11 +1509,11 @@ class Contact extends BaseObject
                }
 
                // Only fill the pubkey if it had been empty before. We have to prevent identity theft.
-               if (empty($contact['pubkey'])) {
+               if (empty($contact['pubkey']) && !empty($data['pubkey'])) {
                        $updated['pubkey'] = $data['pubkey'];
                }
 
-               if (($data['addr'] != $contact['addr']) || (!empty($data['alias']) && ($data['alias'] != $contact['alias']))) {
+               if (($updated['addr'] != $contact['addr']) || (!empty($data['alias']) && ($data['alias'] != $contact['alias']))) {
                        $updated['uri-date'] = DateTimeFormat::utcNow();
                }
                if (($data["name"] != $contact["name"]) || ($data["nick"] != $contact["nick"])) {
@@ -1464,6 +1524,11 @@ class Contact extends BaseObject
 
                DBA::update('contact', $updated, ['id' => $contact_id], $contact);
 
+               if (!$background_update && ($uid == 0)) {
+                       // Update the gcontact entry
+                       GContact::updateFromPublicContactID($contact_id);
+               }
+
                return $contact_id;
        }
 
@@ -1535,7 +1600,7 @@ class Contact extends BaseObject
                        return '';
                }
 
-               if (in_array($contact["network"], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""])) {
+               if (empty($contact["network"]) || in_array($contact["network"], Protocol::FEDERATED)) {
                        $sql = "(`item`.`uid` = 0 OR (`item`.`uid` = ? AND NOT `item`.`global`))";
                } else {
                        $sql = "`item`.`uid` = ?";
@@ -1553,7 +1618,7 @@ class Contact extends BaseObject
 
                $pager = new Pager($a->query_string);
 
-               $params = ['order' => ['created' => true],
+               $params = ['order' => ['received' => true],
                        'limit' => [$pager->getStart(), $pager->getItemsPerPage()]];
 
                if ($thread_mode) {
@@ -1635,13 +1700,13 @@ class Contact extends BaseObject
        /**
         * @brief Blocks a contact
         *
-        * @param int $uid
+        * @param int $cid
         * @return bool
         * @throws \Exception
         */
-       public static function block($uid)
+       public static function block($cid, $reason = null)
        {
-               $return = DBA::update('contact', ['blocked' => true], ['id' => $uid]);
+               $return = DBA::update('contact', ['blocked' => true, 'block_reason' => $reason], ['id' => $cid]);
 
                return $return;
        }
@@ -1649,13 +1714,13 @@ class Contact extends BaseObject
        /**
         * @brief Unblocks a contact
         *
-        * @param int $uid
+        * @param int $cid
         * @return bool
         * @throws \Exception
         */
-       public static function unblock($uid)
+       public static function unblock($cid)
        {
-               $return = DBA::update('contact', ['blocked' => false], ['id' => $uid]);
+               $return = DBA::update('contact', ['blocked' => false, 'block_reason' => null], ['id' => $cid]);
 
                return $return;
        }
@@ -1674,7 +1739,7 @@ class Contact extends BaseObject
         */
        public static function updateAvatar($avatar, $uid, $cid, $force = false)
        {
-               $contact = DBA::selectFirst('contact', ['avatar', 'photo', 'thumb', 'micro', 'nurl'], ['id' => $cid]);
+               $contact = DBA::selectFirst('contact', ['avatar', 'photo', 'thumb', 'micro', 'nurl'], ['id' => $cid, 'self' => false]);
                if (!DBA::isResult($contact)) {
                        return false;
                } else {
@@ -1685,17 +1750,14 @@ class Contact extends BaseObject
                        $photos = Photo::importProfilePhoto($avatar, $uid, $cid, true);
 
                        if ($photos) {
-                               DBA::update(
-                                       'contact',
-                                       ['avatar' => $avatar, 'photo' => $photos[0], 'thumb' => $photos[1], 'micro' => $photos[2], 'avatar-date' => DateTimeFormat::utcNow()],
-                                       ['id' => $cid]
-                               );
+                               $fields = ['avatar' => $avatar, 'photo' => $photos[0], 'thumb' => $photos[1], 'micro' => $photos[2], 'avatar-date' => DateTimeFormat::utcNow()];
+                               DBA::update('contact', $fields, ['id' => $cid]);
 
                                // Update the public contact (contact id = 0)
                                if ($uid != 0) {
                                        $pcontact = DBA::selectFirst('contact', ['id'], ['nurl' => $contact['nurl'], 'uid' => 0]);
                                        if (DBA::isResult($pcontact)) {
-                                               self::updateAvatar($avatar, 0, $pcontact['id'], $force);
+                                               DBA::update('contact', $fields, ['id' => $pcontact['id']]);
                                        }
                                }
 
@@ -1706,6 +1768,103 @@ class Contact extends BaseObject
                return $data;
        }
 
+        /**
+        * @brief Helper function for "updateFromProbe". Updates personal and public contact
+        *
+        * @param array $contact The personal contact entry
+        * @param array $fields  The fields that are updated
+        * @throws \Exception
+        */
+       private static function updateContact($id, $uid, $url, array $fields)
+       {
+               DBA::update('contact', $fields, ['id' => $id]);
+
+               // Search for duplicated contacts and get rid of them
+               if (self::handleDuplicates(Strings::normaliseLink($url), $uid, $id) || ($uid != 0)) {
+                       return;
+               }
+
+               // Update the corresponding gcontact entry
+               GContact::updateFromPublicContactID($id);
+
+               // Archive or unarchive the contact. We only need to do this for the public contact.
+               // The archive/unarchive function will update the personal contacts by themselves.
+               $contact = DBA::selectFirst('contact', [], ['id' => $id]);
+               if (!empty($fields['success_update'])) {
+                       self::unmarkForArchival($contact);
+               } elseif (!empty($fields['failure_update'])) {
+                       self::markForArchival($contact);
+               }
+
+               $condition = ['self' => false, 'nurl' => Strings::normaliseLink($url), 'network' => Protocol::FEDERATED];
+
+               // These contacts are sharing with us, we don't poll them.
+               // This means that we don't set the update fields in "OnePoll.php".
+               $condition['rel'] = self::SHARING;
+               DBA::update('contact', $fields, $condition);
+
+               unset($fields['last-update']);
+               unset($fields['success_update']);
+               unset($fields['failure_update']);
+
+               if (empty($fields)) {
+                       return;
+               }
+
+               // We are polling these contacts, so we mustn't set the update fields here.
+               $condition['rel'] = [self::FOLLOWER, self::FRIEND];
+               DBA::update('contact', $fields, $condition);
+       }
+
+        /**
+        * @brief Helper function for "updateFromProbe". Remove duplicated contacts
+        *
+        * @param string  $nurl  Normalised contact url
+        * @param integer $uid   User id
+        * @param integer $id    Contact id of a duplicate
+        * @throws \Exception
+        */
+       private static function handleDuplicates($nurl, $uid, $id)
+       {
+               $condition = ['nurl' => $nurl, 'uid' => $uid, 'deleted' => false];
+               $count = DBA::count('contact', $condition);
+               if ($count <= 1) {
+                       return false;
+               }
+
+               $first_contact = DBA::selectFirst('contact', ['id'], $condition, ['order' => ['id']]);
+               if (!DBA::isResult($first_contact)) {
+                       // Shouldn't happen - so we handle it
+                       return false;
+               }
+
+               $first = $first_contact['id'];
+               Logger::info('Found duplicates', ['count' => $count, 'id' => $id, 'first' => $first, 'uid' => $uid, 'nurl' => $nurl, 'callstack' => System::callstack(20)]);
+               if ($uid != 0) {
+                       // Don't handle non public duplicates by now
+                       Logger::info('Not handling non public duplicate', ['uid' => $uid, 'nurl' => $nurl]);
+                       return false;
+               }
+
+               // Find all duplicates
+               $condition = ["`nurl` = ? AND `uid` = ? AND `id` != ? AND NOT `self` AND NOT `deleted`", $nurl, $uid, $first];
+               $duplicates = DBA::select('contact', ['id'], $condition);
+               while ($duplicate = DBA::fetch($duplicates)) {
+                       $dup_id = $duplicate['id'];
+                       Logger::info('Handling duplicate', ['search' => $dup_id, 'replace' => $first]);
+
+                       // Search and replace
+                       DBA::update('item',['author-id' => $first], ['author-id' => $dup_id]);
+                       DBA::update('item',['owner-id' => $first], ['owner-id' => $dup_id]);
+                       DBA::update('item',['contact-id' => $first], ['contact-id' => $dup_id]);
+
+                       // Remove the duplicate
+                       DBA::delete('contact', ['id' => $dup_id]);
+               }
+               Logger::info('Duplicates handled', ['uid' => $uid, 'nurl' => $nurl]);
+               return true;
+       }
+
        /**
         * @param integer $id      contact id
         * @param string  $network Optional network we are probing for
@@ -1718,11 +1877,15 @@ class Contact extends BaseObject
        {
                /*
                  Warning: Never ever fetch the public key via Probe::uri and write it into the contacts.
-                 This will reliably kill your communication with Friendica contacts.
+                 This will reliably kill your communication with old Friendica contacts.
                 */
 
-               $fields = ['avatar', 'uid', 'name', 'nick', 'url', 'addr', 'batch', 'notify',
-                       'poll', 'request', 'confirm', 'poco', 'network', 'alias'];
+               // These fields aren't updated by this routine:
+               // 'xmpp', 'sensitive'
+
+               $fields = ['uid', 'avatar', 'name', 'nick', 'location', 'keywords', 'about', 'gender',
+                       'unsearchable', 'url', 'addr', 'batch', 'notify', 'poll', 'request', 'confirm', 'poco',
+                       'network', 'alias', 'baseurl', 'forum', 'prv', 'contact-type'];
                $contact = DBA::selectFirst('contact', $fields, ['id' => $id]);
                if (!DBA::isResult($contact)) {
                        return false;
@@ -1736,46 +1899,87 @@ class Contact extends BaseObject
 
                $ret = Probe::uri($contact['url'], $network, $uid, !$force);
 
+               $updated = DateTimeFormat::utcNow();
+
                // If Probe::uri fails the network code will be different (mostly "feed" or "unkn")
-               if (in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM]) && ($ret['network'] != $contact['network'])) {
+               if (!in_array($ret['network'], Protocol::NATIVE_SUPPORT) ||
+                       (in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM]) && ($ret['network'] != $contact['network']))) {
+                       if ($force && ($uid == 0)) {
+                               self::updateContact($id, $uid, $ret['url'], ['last-update' => $updated, 'failure_update' => $updated]);
+                       }
                        return false;
                }
 
-               if (!in_array($ret['network'], Protocol::NATIVE_SUPPORT)) {
-                       return false;
+               if (isset($ret['hide']) && is_bool($ret['hide'])) {
+                       $ret['unsearchable'] = $ret['hide'];
+               }
+
+               if (isset($ret['account-type']) && is_int($ret['account-type'])) {
+                       $ret['forum'] = false;
+                       $ret['prv'] = false;
+                       $ret['contact-type'] = $ret['account-type'];
+                       if ($ret['contact-type'] == User::ACCOUNT_TYPE_COMMUNITY) {
+                               $apcontact = APContact::getByURL($ret['url'], false);
+                               if (isset($apcontact['manually-approve'])) {
+                                       $ret['forum'] = (bool)!$apcontact['manually-approve'];
+                                       $ret['prv'] = (bool)!$ret['forum'];
+                               }
+                       }
                }
 
                $update = false;
 
-               // make sure to not overwrite existing values with blank entries
+               // make sure to not overwrite existing values with blank entries except some technical fields
+               $keep = ['batch', 'notify', 'poll', 'request', 'confirm', 'poco', 'baseurl'];
                foreach ($ret as $key => $val) {
-                       if (!isset($contact[$key])) {
+                       if (!array_key_exists($key, $contact)) {
                                unset($ret[$key]);
-                       } elseif (($contact[$key] != '') && ($val == '')) {
+                       } elseif (($contact[$key] != '') && ($val == '') && !is_bool($ret[$key]) && !in_array($key, $keep)) {
                                $ret[$key] = $contact[$key];
                        } elseif ($ret[$key] != $contact[$key]) {
                                $update = true;
                        }
                }
 
+               if ($ret['network'] != Protocol::FEED) {
+                       self::updateAvatar($ret['photo'], $uid, $id, $update || $force);
+               }
+
                if (!$update) {
+                       if ($force && ($uid == 0)) {
+                               self::updateContact($id, $uid, $ret['url'], ['last-update' => $updated, 'success_update' => $updated]);
+                       }
                        return true;
                }
 
                $ret['nurl'] = Strings::normaliseLink($ret['url']);
-               $ret['updated'] = DateTimeFormat::utcNow();
+               $ret['updated'] = $updated;
 
-               self::updateAvatar($ret['photo'], $uid, $id, true);
+               if ($force && ($uid == 0)) {
+                       $ret['last-update'] = $updated;
+                       $ret['success_update'] = $updated;
+               }
 
                unset($ret['photo']);
-               DBA::update('contact', $ret, ['id' => $id]);
 
-               // Update the corresponding gcontact entry
-               PortableContact::lastUpdated($ret["url"]);
+               self::updateContact($id, $uid, $ret['url'], $ret);
 
                return true;
        }
 
+       public static function updateFromProbeByURL($url, $force = false)
+       {
+               $id = self::getIdForURL($url);
+
+               if (empty($id)) {
+                       return $id;
+               }
+
+               self::updateFromProbe($id, '', $force);
+
+               return $id;
+       }
+
        /**
         * Detects if a given contact array belongs to a legacy DFRN connection
         *
@@ -1974,6 +2178,7 @@ class Contact extends BaseObject
                                'name'    => $ret['name'],
                                'nick'    => $ret['nick'],
                                'network' => $ret['network'],
+                               'baseurl' => $ret['baseurl'],
                                'protocol' => $protocol,
                                'pubkey'  => $ret['pubkey'],
                                'rel'     => $new_relation,
@@ -2085,61 +2290,81 @@ class Contact extends BaseObject
                return $contact;
        }
 
-       public static function addRelationship($importer, $contact, $datarray, $item = '', $sharing = false) {
+       /**
+        * @param array  $importer Owner (local user) data
+        * @param array  $contact  Existing owner-specific contact data we want to expand the relationship with. Optional.
+        * @param array  $datarray An item-like array with at least the 'author-id' and 'author-url' keys for the contact. Mandatory.
+        * @param bool   $sharing  True: Contact is now sharing with Owner; False: Contact is now following Owner (default)
+        * @param string $note     Introduction additional message
+        * @return bool|null True: follow request is accepted; False: relationship is rejected; Null: relationship is pending
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
+        */
+       public static function addRelationship(array $importer, array $contact, array $datarray, $sharing = false, $note = '')
+       {
                // Should always be set
                if (empty($datarray['author-id'])) {
-                       return;
+                       return false;
                }
 
-               $fields = ['url', 'name', 'nick', 'photo', 'network'];
+               $fields = ['url', 'name', 'nick', 'avatar', 'photo', 'network', 'blocked'];
                $pub_contact = DBA::selectFirst('contact', $fields, ['id' => $datarray['author-id']]);
                if (!DBA::isResult($pub_contact)) {
                        // Should never happen
-                       return;
+                       return false;
+               }
+
+               // Contact is blocked at node-level
+               if (self::isBlocked($datarray['author-id'])) {
+                       return false;
                }
 
                $url = defaults($datarray, 'author-link', $pub_contact['url']);
                $name = $pub_contact['name'];
-               $photo = $pub_contact['photo'];
+               $photo = defaults($pub_contact, 'avatar', $pub_contact["photo"]);
                $nick = $pub_contact['nick'];
                $network = $pub_contact['network'];
 
-               if (is_array($contact)) {
-                       $protocol = self::getProtocol($url, $contact['network']);
+               if (!empty($contact)) {
+                       // Contact is blocked at user-level
+                       if (!empty($contact['id']) && !empty($importer['id']) &&
+                               self::isBlockedByUser($contact['id'], $importer['id'])) {
+                               return false;
+                       }
+
+                       // Make sure that the existing contact isn't archived
+                       self::unmarkForArchival($contact);
 
                        if (($contact['rel'] == self::SHARING)
                                || ($sharing && $contact['rel'] == self::FOLLOWER)) {
-                               DBA::update('contact', ['rel' => self::FRIEND, 'writable' => true],
+                               DBA::update('contact', ['rel' => self::FRIEND, 'writable' => true, 'pending' => false],
                                                ['id' => $contact['id'], 'uid' => $importer['uid']]);
                        }
 
-                       if ($protocol == Protocol::ACTIVITYPUB) {
-                               ActivityPub\Transmitter::sendContactAccept($contact['url'], $contact['hub-verify'], $importer['uid']);
-                       }
-
-                       // send email notification to owner?
+                       return true;
                } else {
-                       $protocol = self::getProtocol($url, $network);
-
+                       // send email notification to owner?
                        if (DBA::exists('contact', ['nurl' => Strings::normaliseLink($url), 'uid' => $importer['uid'], 'pending' => true])) {
                                Logger::log('ignoring duplicated connection request from pending contact ' . $url);
-                               return;
+                               return null;
                        }
+
                        // create contact record
-                       q("INSERT INTO `contact` (`uid`, `created`, `url`, `nurl`, `name`, `nick`, `photo`, `network`, `protocol`, `rel`,
-                               `blocked`, `readonly`, `pending`, `writable`)
-                               VALUES (%d, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', %d, 0, 0, 1, 1)",
-                               intval($importer['uid']),
-                               DBA::escape(DateTimeFormat::utcNow()),
-                               DBA::escape($url),
-                               DBA::escape(Strings::normaliseLink($url)),
-                               DBA::escape($name),
-                               DBA::escape($nick),
-                               DBA::escape($photo),
-                               DBA::escape($protocol),
-                               DBA::escape($network),
-                               intval(self::FOLLOWER)
-                       );
+                       DBA::insert('contact', [
+                               'uid'      => $importer['uid'],
+                               'created'  => DateTimeFormat::utcNow(),
+                               'url'      => $url,
+                               'nurl'     => Strings::normaliseLink($url),
+                               'name'     => $name,
+                               'nick'     => $nick,
+                               'photo'    => $photo,
+                               'network'  => $network,
+                               'rel'      => self::FOLLOWER,
+                               'blocked'  => 0,
+                               'readonly' => 0,
+                               'pending'  => 1,
+                               'writable' => 1,
+                       ]);
 
                        $contact_record = [
                                'id' => DBA::lastInsertId(),
@@ -2160,7 +2385,7 @@ class Contact extends BaseObject
 
                                if (is_array($contact_record)) {
                                        DBA::insert('intro', ['uid' => $importer['uid'], 'contact-id' => $contact_record['id'],
-                                                               'blocked' => false, 'knowyou' => false,
+                                                               'blocked' => false, 'knowyou' => false, 'note' => $note,
                                                                'hash' => $hash, 'datetime' => DateTimeFormat::utcNow()]);
                                }
 
@@ -2183,20 +2408,16 @@ class Contact extends BaseObject
                                                'verb'         => ($sharing ? ACTIVITY_FRIEND : ACTIVITY_FOLLOW),
                                                'otype'        => 'intro'
                                        ]);
-
                                }
                        } elseif (DBA::isResult($user) && in_array($user['page-flags'], [User::PAGE_FLAGS_SOAPBOX, User::PAGE_FLAGS_FREELOVE, User::PAGE_FLAGS_COMMUNITY])) {
                                $condition = ['uid' => $importer['uid'], 'url' => $url, 'pending' => true];
                                DBA::update('contact', ['pending' => false], $condition);
 
-                               $contact = DBA::selectFirst('contact', ['url', 'network', 'hub-verify'], ['id' => $contact_record['id']]);
-                               $protocol = self::getProtocol($contact['url'], $contact['network']);
-
-                               if ($protocol == Protocol::ACTIVITYPUB) {
-                                       ActivityPub\Transmitter::sendContactAccept($contact['url'], $contact['hub-verify'], $importer['uid']);
-                               }
+                               return true;
                        }
                }
+
+               return null;
        }
 
        public static function removeFollower($importer, $contact, array $datarray = [], $item = "")
@@ -2300,12 +2521,15 @@ class Contact extends BaseObject
                        return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url;
                }
 
-               $cid = self::getIdForURL($contact_url, 0, true);
-               if (empty($cid)) {
+               $data = self::getProbeDataFromDatabase($contact_url);
+               if (empty($data)) {
                        return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url;
                }
 
-               return self::magicLinkbyId($cid, $url);
+               // Prevents endless loop in case only a non-public contact exists for the contact URL
+               unset($data['uid']);
+
+               return self::magicLinkByContact($data, $contact_url);
        }
 
        /**
@@ -2346,10 +2570,14 @@ class Contact extends BaseObject
                        return $url;
                }
 
-               if ($contact['uid'] != 0) {
+               if (!empty($contact['uid'])) {
                        return self::magicLink($contact['url'], $url);
                }
 
+               if (empty($contact['id'])) {
+                       return $url ?: $contact['url'];
+               }
+
                $redirect = 'redir/' . $contact['id'];
 
                if ($url != '') {
@@ -2390,4 +2618,18 @@ class Contact extends BaseObject
                // Is it a forum?
                return ($contact['forum'] || $contact['prv']);
        }
+
+       /**
+        * Can the remote contact receive private messages?
+        *
+        * @param array $contact
+        * @return bool
+        */
+       public static function canReceivePrivateMessages(array $contact)
+       {
+               $protocol = $contact['network'] ?? $contact['protocol'] ?? Protocol::PHANTOM;
+               $self = $contact['self'] ?? false;
+
+               return in_array($protocol, [Protocol::DFRN, Protocol::DIASPORA, Protocol::ACTIVITYPUB]) && !$self;
+       }
 }