]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Contact.php
Delete removed contacts
[friendica.git] / src / Model / Contact.php
index 67b9c903831f04abb46f2fbb71add565aefd85d8..2908385f583e06430ebe775a754740c652bf9db6 100644 (file)
@@ -31,6 +31,7 @@ use Friendica\Core\Renderer;
 use Friendica\Core\Session;
 use Friendica\Core\System;
 use Friendica\Core\Worker;
+use Friendica\Database\Database;
 use Friendica\Database\DBA;
 use Friendica\DI;
 use Friendica\Model\Notify\Type;
@@ -138,7 +139,12 @@ class Contact
         * @}
         */
 
-       /**
+        const MIRROR_DEACTIVATED = 0;
+        const MIRROR_FORWARDED = 1;
+        const MIRROR_OWN_POST = 2;
+        const MIRROR_NATIVE_RESHARE = 3;
+
+        /**
         * @param array $fields    Array of selected fields, empty for all
         * @param array $condition Array of fields for condition
         * @param array $params    Array of several parameters
@@ -168,15 +174,23 @@ class Contact
         * Insert a row into the contact table
         * Important: You can't use DBA::lastInsertId() after this call since it will be set to 0.
         *
-        * @param array        $fields              field array
-        * @param bool         $on_duplicate_update Do an update on a duplicate entry
+        * @param array $fields         field array
+        * @param int   $duplicate_mode Do an update on a duplicate entry
         *
         * @return boolean was the insert successful?
         * @throws \Exception
         */
-       public static function insert(array $fields, bool $on_duplicate_update = false)
+       public static function insert(array $fields, int $duplicate_mode = Database::INSERT_DEFAULT)
        {
-               $ret = DBA::insert('contact', $fields, $on_duplicate_update);
+               if (!empty($fields['baseurl']) && empty($fields['gsid'])) {
+                       $fields['gsid'] = GServer::getID($fields['baseurl'], true);
+               }
+
+               if (empty($fields['created'])) {
+                       $fields['created'] = DateTimeFormat::utcNow();
+               }
+
+               $ret = DBA::insert('contact', $fields, $duplicate_mode);
                $contact = DBA::selectFirst('contact', ['nurl', 'uid'], ['id' => DBA::lastInsertId()]);
                if (!DBA::isResult($contact)) {
                        // Shouldn't happen
@@ -509,14 +523,14 @@ class Contact
                }
 
                if ($contact['uid'] != 0) {
-                       $pcid = Contact::getIdForURL($contact['url'], 0, false, ['url' => $contact['url']]);
+                       $pcid = self::getIdForURL($contact['url'], 0, false, ['url' => $contact['url']]);
                        if (empty($pcid)) {
                                return [];
                        }
                        $ucid = $contact['id'];
                } else {
                        $pcid = $contact['id'];
-                       $ucid = Contact::getIdForURL($contact['url'], $uid);
+                       $ucid = self::getIdForURL($contact['url'], $uid);
                }
 
                return ['public' => $pcid, 'user' => $ucid];
@@ -631,6 +645,16 @@ class Contact
                        'contact-type' => $user['account-type'], 'prvkey' => $user['prvkey'],
                        'pubkey' => $user['pubkey'], 'xmpp' => $profile['xmpp']];
 
+               // it seems as if ported accounts can have wrong values, so we make sure that now everything is fine.
+               $fields['url'] = DI::baseUrl() . '/profile/' . $user['nickname'];
+               $fields['nurl'] = Strings::normaliseLink($fields['url']);
+               $fields['addr'] = $user['nickname'] . '@' . substr(DI::baseUrl(), strpos(DI::baseUrl(), '://') + 3);
+               $fields['request'] = DI::baseUrl() . '/dfrn_request/' . $user['nickname'];
+               $fields['notify'] = DI::baseUrl() . '/dfrn_notify/' . $user['nickname'];
+               $fields['poll'] = DI::baseUrl() . '/dfrn_poll/'. $user['nickname'];
+               $fields['confirm'] = DI::baseUrl() . '/dfrn_confirm/' . $user['nickname'];
+               $fields['poco'] = DI::baseUrl() . '/poco/' . $user['nickname'];
+
                $avatar = Photo::selectFirst(['resource-id', 'type'], ['uid' => $uid, 'profile' => true]);
                if (DBA::isResult($avatar)) {
                        if ($update_avatar) {
@@ -654,9 +678,9 @@ class Contact
                        $fields['micro'] = $prefix . '6' . $suffix;
                } else {
                        // We hadn't found a photo entry, so we use the default avatar
-                       $fields['photo'] = DI::baseUrl() . self::DEFAULT_AVATAR_PHOTO;
-                       $fields['thumb'] = DI::baseUrl() . self::DEFAULT_AVATAR_THUMB;
-                       $fields['micro'] = DI::baseUrl() . self::DEFAULT_AVATAR_MICRO;
+                       $fields['photo'] = self::getDefaultAvatar($fields, Proxy::SIZE_SMALL);
+                       $fields['thumb'] = self::getDefaultAvatar($fields, Proxy::SIZE_THUMB);
+                       $fields['micro'] = self::getDefaultAvatar($fields, Proxy::SIZE_MICRO);
                }
 
                $fields['avatar'] = DI::baseUrl() . '/photo/profile/' .$uid . '.' . $file_suffix;
@@ -664,16 +688,6 @@ class Contact
                $fields['prv'] = $user['page-flags'] == User::PAGE_FLAGS_PRVGROUP;
                $fields['unsearchable'] = !$profile['net-publish'];
 
-               // it seems as if ported accounts can have wrong values, so we make sure that now everything is fine.
-               $fields['url'] = DI::baseUrl() . '/profile/' . $user['nickname'];
-               $fields['nurl'] = Strings::normaliseLink($fields['url']);
-               $fields['addr'] = $user['nickname'] . '@' . substr(DI::baseUrl(), strpos(DI::baseUrl(), '://') + 3);
-               $fields['request'] = DI::baseUrl() . '/dfrn_request/' . $user['nickname'];
-               $fields['notify'] = DI::baseUrl() . '/dfrn_notify/' . $user['nickname'];
-               $fields['poll'] = DI::baseUrl() . '/dfrn_poll/'. $user['nickname'];
-               $fields['confirm'] = DI::baseUrl() . '/dfrn_confirm/' . $user['nickname'];
-               $fields['poco'] = DI::baseUrl() . '/poco/' . $user['nickname'];
-
                $update = false;
 
                foreach ($fields as $field => $content) {
@@ -710,7 +724,7 @@ class Contact
        {
                // We want just to make sure that we don't delete our "self" contact
                $contact = DBA::selectFirst('contact', ['uid'], ['id' => $id, 'self' => false]);
-               if (!DBA::isResult($contact) || !intval($contact['uid'])) {
+               if (!DBA::isResult($contact)) {
                        return;
                }
 
@@ -795,7 +809,7 @@ class Contact
                        Logger::info('Empty contact', ['contact' => $contact, 'callstack' => System::callstack(20)]);
                }
 
-               Logger::info('Contact is marked for archival', ['id' => $contact['id']]);
+               Logger::info('Contact is marked for archival', ['id' => $contact['id'], 'term-date' => $contact['term-date']]);
 
                // Contact already archived or "self" contact? => nothing to do
                if ($contact['archive'] || $contact['self']) {
@@ -853,7 +867,7 @@ class Contact
                        return;
                }
 
-               Logger::info('Contact is marked as vital again', ['id' => $contact['id']]);
+               Logger::info('Contact is marked as vital again', ['id' => $contact['id'], 'term-date' => $contact['term-date']]);
 
                if (!isset($contact['url']) && !empty($contact['id'])) {
                        $fields = ['id', 'url', 'batch'];
@@ -1105,7 +1119,7 @@ class Contact
                        $contact = self::selectFirst(['id'], ['nurl' => $urls, 'uid' => $uid]);
                        if (!empty($contact['id'])) {
                                $contact_id = $contact['id'];
-                               Logger::info('Fetched id by url', ['cid' => $contact_id, 'uid' => $uid, 'url' => $url, 'probed_url' => $data['url'], 'alias' => $data['alias'], 'addr' => $data['addr']]);
+                               Logger::info('Fetched id by url', ['cid' => $contact_id, 'uid' => $uid, 'url' => $url, 'data' => $data]);
                        }
                }
 
@@ -1282,7 +1296,7 @@ class Contact
                }
 
                if (empty($contact["network"]) || in_array($contact["network"], Protocol::FEDERATED)) {
-                       $sql = "`item`.`uid` IN (0, ?)";
+                       $sql = "(`item`.`uid` = 0 OR (`item`.`uid` = ? AND NOT `item`.`global`))";
                } else {
                        $sql = "`item`.`uid` = ?";
                }
@@ -1290,8 +1304,8 @@ class Contact
                $contact_field = ((($contact["contact-type"] == self::TYPE_COMMUNITY) || ($contact['network'] == Protocol::MAIL)) ? 'owner-id' : 'author-id');
 
                if ($thread_mode) {
-                       $condition = ["(`$contact_field` = ? OR (`causer-id` = ? AND `post-type` = ?)) AND `gravity` = ? AND " . $sql,
-                               $cid, $cid, Item::PT_ANNOUNCEMENT, GRAVITY_PARENT, local_user()];
+                       $condition = ["((`$contact_field` = ? AND `gravity` = ?) OR (`author-id` = ? AND `gravity` = ? AND `vid` = ?)) AND " . $sql,
+                               $cid, GRAVITY_PARENT, $cid, GRAVITY_ACTIVITY, Verb::getID(Activity::ANNOUNCE), local_user()];
                } else {
                        $condition = ["`$contact_field` = ? AND `gravity` IN (?, ?) AND " . $sql,
                                $cid, GRAVITY_PARENT, GRAVITY_COMMENT, local_user()];
@@ -1316,8 +1330,7 @@ class Contact
 
                $pager = new Pager(DI::l10n(), DI::args()->getQueryString(), $itemsPerPage);
 
-               $params = ['order' => ['received' => true], 'group_by' => ['uri-id'],
-                       'limit' => [$pager->getStart(), $pager->getItemsPerPage()]];
+               $params = ['order' => ['received' => true], 'limit' => [$pager->getStart(), $pager->getItemsPerPage()]];
 
                if (DI::pConfig()->get(local_user(), 'system', 'infinite_scroll')) {
                        $tpl = Renderer::getMarkupTemplate('infinite_scroll_head.tpl');
@@ -1327,15 +1340,9 @@ class Contact
                }
 
                if ($thread_mode) {             
-                       $r = Item::selectForUser(local_user(), ['uri', 'gravity', 'parent-uri'], $condition, $params);
+                       $r = Item::selectForUser(local_user(), ['uri', 'gravity', 'parent-uri', 'thr-parent-id', 'author-id'], $condition, $params);
                        $items = [];
                        while ($item = DBA::fetch($r)) {
-                               if ($item['gravity'] != GRAVITY_PARENT) {
-                                       $item['uri'] = $item['parent-uri'];
-                               }
-                               unset($item['parent-uri']);
-                               unset($item['gravity']);
-                               
                                $items[] = $item;
                        }
                        DBA::close($r);
@@ -1468,12 +1475,11 @@ class Contact
         *
         * @param array $contact  contact array
         * @param string $field   Fieldname of the photo in the contact array
-        * @param string $default Default path when no picture had been found
         * @param string $size    Size of the avatar picture
         * @param string $avatar  Avatar path that is displayed when no photo had been found
         * @return string photo path
         */
-       private static function getAvatarPath(array $contact, string $field, string $default, string $size, string $avatar)
+       private static function getAvatarPath(array $contact, string $field, string $size, string $avatar)
        {
                if (!empty($contact)) {
                        $contact = self::checkAvatarCacheByArray($contact);
@@ -1483,7 +1489,7 @@ class Contact
                }
 
                if (empty($avatar)) {
-                       return $default;
+                       $avatar = self::getDefaultAvatar([], $size);
                }
 
                if (Proxy::isLocalImage($avatar)) {
@@ -1502,7 +1508,7 @@ class Contact
         */
        public static function getPhoto(array $contact, string $avatar = '')
        {
-               return self::getAvatarPath($contact, 'photo', DI::baseUrl() . self::DEFAULT_AVATAR_PHOTO, Proxy::SIZE_SMALL, $avatar);
+               return self::getAvatarPath($contact, 'photo', Proxy::SIZE_SMALL, $avatar);
        }
 
        /**
@@ -1514,7 +1520,7 @@ class Contact
         */
        public static function getThumb(array $contact, string $avatar = '')
        {
-               return self::getAvatarPath($contact, 'thumb', DI::baseUrl() . self::DEFAULT_AVATAR_THUMB, Proxy::SIZE_THUMB, $avatar);
+               return self::getAvatarPath($contact, 'thumb', Proxy::SIZE_THUMB, $avatar);
        }
 
        /**
@@ -1526,7 +1532,7 @@ class Contact
         */
        public static function getMicro(array $contact, string $avatar = '')
        {
-               return self::getAvatarPath($contact, 'micro', DI::baseUrl() . self::DEFAULT_AVATAR_MICRO, Proxy::SIZE_MICRO, $avatar);
+               return self::getAvatarPath($contact, 'micro', Proxy::SIZE_MICRO, $avatar);
        }
 
        /**
@@ -1565,18 +1571,71 @@ class Contact
 
                /// add the default avatars if the fields aren't filled
                if (isset($contact['photo']) && empty($contact['photo'])) {
-                       $contact['photo'] = DI::baseUrl() . self::DEFAULT_AVATAR_PHOTO;
+                       $contact['photo'] = self::getDefaultAvatar($contact, Proxy::SIZE_SMALL);
                }
                if (isset($contact['thumb']) && empty($contact['thumb'])) {
-                       $contact['thumb'] = DI::baseUrl() . self::DEFAULT_AVATAR_THUMB;
+                       $contact['thumb'] = self::getDefaultAvatar($contact, Proxy::SIZE_THUMB);
                }
                if (isset($contact['micro']) && empty($contact['micro'])) {
-                       $contact['micro'] = DI::baseUrl() . self::DEFAULT_AVATAR_MICRO;
+                       $contact['micro'] = self::getDefaultAvatar($contact, Proxy::SIZE_MICRO);
                }
 
                return $contact;
        }
 
+       /**
+        * Fetch the default avatar for the given contact and size
+        *
+        * @param array $contact  contact array
+        * @param string $size    Size of the avatar picture
+        * @return void
+        */
+       public static function getDefaultAvatar(array $contact, string $size)
+       {
+               switch ($size) {
+                       case Proxy::SIZE_MICRO:
+                               $avatar['size'] = 48;
+                               $default = self::DEFAULT_AVATAR_MICRO;
+                               break;
+       
+                       case Proxy::SIZE_THUMB:
+                               $avatar['size'] = 80;
+                               $default = self::DEFAULT_AVATAR_THUMB;
+                               break;
+       
+                       case Proxy::SIZE_SMALL:
+                       default:
+                               $avatar['size'] = 300;
+                               $default = self::DEFAULT_AVATAR_PHOTO;
+                               break;
+               }
+
+               if (!DI::config()->get('system', 'remote_avatar_lookup')) {
+                       return DI::baseUrl() . $default;
+               }
+
+               if (!empty($contact['xmpp'])) {
+                       $avatar['email'] = $contact['xmpp'];
+               } elseif (!empty($contact['addr'])) {
+                       $avatar['email'] = $contact['addr'];
+               } elseif (!empty($contact['url'])) {
+                       $avatar['email'] = $contact['url'];
+               } else {
+                       return DI::baseUrl() . $default;
+               }
+
+               $avatar['url'] = '';
+               $avatar['success'] = false;
+
+               Hook::callAll('avatar_lookup', $avatar);
+
+               if ($avatar['success'] && !empty($avatar['url'])) {
+                       return $avatar['url'];
+               }
+
+               return DI::baseUrl() . $default;
+       }
+
        /**
         * Updates the avatar links in a contact only if needed
         *
@@ -1592,7 +1651,8 @@ class Contact
         */
        public static function updateAvatar(int $cid, string $avatar, bool $force = false, bool $create_cache = false)
        {
-               $contact = DBA::selectFirst('contact', ['uid', 'avatar', 'photo', 'thumb', 'micro', 'nurl', 'url', 'network'], ['id' => $cid, 'self' => false]);
+               $contact = DBA::selectFirst('contact', ['uid', 'avatar', 'photo', 'thumb', 'micro', 'xmpp', 'addr', 'nurl', 'url', 'network'],
+                       ['id' => $cid, 'self' => false]);
                if (!DBA::isResult($contact)) {
                        return;
                }
@@ -1617,13 +1677,18 @@ class Contact
                                return;
                        }
                }
-               
-               // Replace cached avatar pictures from the default avatar with the default avatars in different sizes
-               if (strpos($avatar, self::DEFAULT_AVATAR_PHOTO)) {
+
+               $default_avatar = empty($avatar) || strpos($avatar, self::DEFAULT_AVATAR_PHOTO);
+
+               if ($default_avatar) {
+                       $avatar = self::getDefaultAvatar($contact, Proxy::SIZE_SMALL);
+               }
+
+               if ($default_avatar && Proxy::isLocalImage($avatar)) {
                        $fields = ['avatar' => $avatar, 'avatar-date' => DateTimeFormat::utcNow(),
-                               'photo' => DI::baseUrl() . self::DEFAULT_AVATAR_PHOTO,
-                               'thumb' => DI::baseUrl() . self::DEFAULT_AVATAR_THUMB,
-                               'micro' => DI::baseUrl() . self::DEFAULT_AVATAR_MICRO];
+                               'photo' => $avatar,
+                               'thumb' => self::getDefaultAvatar($contact, Proxy::SIZE_THUMB),
+                               'micro' => self::getDefaultAvatar($contact, Proxy::SIZE_MICRO)];
                        Logger::debug('Use default avatar', ['id' => $cid, 'uid' => $uid]);
                }
 
@@ -1697,6 +1762,17 @@ class Contact
                DBA::update('contact', $fields, ['id' => $cids]);
        }
 
+       public static function deleteContactByUrl(string $url)
+       {
+               // Update contact data for all users
+               $condition = ['self' => false, 'nurl' => Strings::normaliseLink($url)];
+               $contacts = DBA::select('contact', ['id', 'uid'], $condition);
+               while ($contact = DBA::fetch($contacts)) {
+                       Logger::info('Deleting contact', ['id' => $contact['id'], 'uid' => $contact['uid'], 'url' => $url]);
+                       self::remove($contact['id']);
+               }
+       }
+
        /**
         * Helper function for "updateFromProbe". Updates personal and public contact
         *
@@ -1715,41 +1791,49 @@ class Contact
                }
 
                // Search for duplicated contacts and get rid of them
-               if (self::removeDuplicates(Strings::normaliseLink($url), $uid) || ($uid != 0)) {
+               if (self::removeDuplicates(Strings::normaliseLink($url), $uid)) {
                        return;
                }
 
-               // Archive or unarchive the contact. We only need to do this for the public contact.
-               // The archive/unarchive function will update the personal contacts by themselves.
+               // Archive or unarchive the contact.
                $contact = DBA::selectFirst('contact', [], ['id' => $id]);
                if (!DBA::isResult($contact)) {
                        Logger::info('Couldn\'t select contact for archival.', ['id' => $id]);
                        return;
                }
 
-               if (!empty($fields['success_update'])) {
-                       self::unmarkForArchival($contact);
-               } elseif (!empty($fields['failure_update'])) {
-                       self::markForArchival($contact);
+               if (isset($fields['failed'])) {
+                       if ($fields['failed']) {
+                               self::markForArchival($contact);
+                       } else {
+                               self::unmarkForArchival($contact);
+                       }
+               }
+
+               if ($contact['uid'] != 0) {
+                       return;
                }
 
-               $condition = ['self' => false, 'nurl' => Strings::normaliseLink($url), 'network' => Protocol::FEDERATED];
+               // Update contact data for all users
+               $condition = ['self' => false, 'nurl' => Strings::normaliseLink($url)];
 
-               // These contacts are sharing with us, we don't poll them.
-               // This means that we don't set the update fields in "OnePoll.php".
-               $condition['rel'] = self::SHARING;
+               $condition['network'] = [Protocol::DFRN, Protocol::DIASPORA, Protocol::ACTIVITYPUB];
                DBA::update('contact', $fields, $condition);
 
-               unset($fields['last-update']);
-               unset($fields['success_update']);
-               unset($fields['failure_update']);
+               // We mustn't set the update fields for OStatus contacts since they are updated in OnePoll
+               $condition['network'] = Protocol::OSTATUS;
+
+               // If the contact failed, propagate the update fields to all contacts
+               if (empty($fields['failed'])) {
+                       unset($fields['last-update']);
+                       unset($fields['success_update']);
+                       unset($fields['failure_update']);
+               }
 
                if (empty($fields)) {
                        return;
                }
 
-               // We are polling these contacts, so we mustn't set the update fields here.
-               $condition['rel'] = [self::FOLLOWER, self::FRIEND];
                DBA::update('contact', $fields, $condition);
        }
 
@@ -1841,6 +1925,15 @@ class Contact
                        return false;
                }
 
+               if (!empty($ret['account-type']) && $ret['account-type'] == User::ACCOUNT_TYPE_DELETED) {
+                       Logger::info('Deleted account', ['id' => $id, 'url' => $ret['url'], 'ret' => $ret]);
+                       self::remove($id);
+
+                       // Delete all contacts with the same URL
+                       self::deleteContactByUrl($ret['url']);
+                       return true;
+               }
+
                $uid = $contact['uid'];
                unset($contact['uid']);
 
@@ -1863,9 +1956,7 @@ class Contact
 
                // If Probe::uri fails the network code will be different ("feed" or "unkn")
                if (in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM]) && ($ret['network'] != $contact['network'])) {
-                       if ($uid == 0) {
-                               self::updateContact($id, $uid, $ret['url'], ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated]);
-                       }
+                       self::updateContact($id, $uid, $ret['url'], ['failed' => true, 'last-update' => $updated, 'failure_update' => $updated]);
                        return false;
                }
 
@@ -1934,6 +2025,7 @@ class Contact
 
                $ret['nurl'] = Strings::normaliseLink($ret['url']);
                $ret['updated'] = $updated;
+               $ret['failed'] = false;
 
                // Only fill the pubkey if it had been empty before. We have to prevent identity theft.
                if (empty($pubkey) && !empty($new_pubkey)) {
@@ -1948,10 +2040,9 @@ class Contact
                        $ret['name-date'] = $updated;
                }
 
-               if ($uid == 0) {
+               if (($uid == 0) || in_array($ret['network'], [Protocol::DFRN, Protocol::DIASPORA, Protocol::ACTIVITYPUB])) {
                        $ret['last-update'] = $updated;
                        $ret['success_update'] = $updated;
-                       $ret['failed'] = false;
                }
 
                unset($ret['photo']);
@@ -2216,8 +2307,11 @@ class Contact
                self::updateAvatar($contact_id, $ret['photo']);
 
                // pull feed and consume it, which should subscribe to the hub.
-
-               Worker::add(PRIORITY_HIGH, "OnePoll", $contact_id, "force");
+               if ($contact['network'] == Protocol::OSTATUS) {
+                       Worker::add(PRIORITY_HIGH, 'OnePoll', $contact_id, 'force');
+               } else {
+                       Worker::add(PRIORITY_HIGH, 'UpdateContact', $contact_id);
+               }
 
                $owner = User::getOwnerDataById($user['uid']);
 
@@ -2416,18 +2510,12 @@ class Contact
                                        in_array($user['page-flags'], [User::PAGE_FLAGS_NORMAL])) {
 
                                        notification([
-                                               'type'         => Type::INTRO,
-                                               'notify_flags' => $user['notify-flags'],
-                                               'language'     => $user['language'],
-                                               'to_name'      => $user['username'],
-                                               'to_email'     => $user['email'],
-                                               'uid'          => $user['uid'],
-                                               'link'         => DI::baseUrl() . '/notifications/intros',
-                                               'source_name'  => ((strlen(stripslashes($contact_record['name']))) ? stripslashes($contact_record['name']) : DI::l10n()->t('[Name Withheld]')),
-                                               'source_link'  => $contact_record['url'],
-                                               'source_photo' => $contact_record['photo'],
-                                               'verb'         => ($sharing ? Activity::FRIEND : Activity::FOLLOW),
-                                               'otype'        => 'intro'
+                                               'type'  => Type::INTRO,
+                                               'otype' => Notify\ObjectType::INTRO,
+                                               'verb'  => ($sharing ? Activity::FRIEND : Activity::FOLLOW),
+                                               'uid'   => $user['uid'],
+                                               'cid'   => $contact_record['id'],
+                                               'link'  => DI::baseUrl() . '/notifications/intros',
                                        ]);
                                }
                        } elseif (DBA::isResult($user) && in_array($user['page-flags'], [User::PAGE_FLAGS_SOAPBOX, User::PAGE_FLAGS_FREELOVE, User::PAGE_FLAGS_COMMUNITY])) {
@@ -2438,7 +2526,7 @@ class Contact
                                $condition = ['uid' => $importer['uid'], 'url' => $url, 'pending' => true];
                                $fields = ['pending' => false];
                                if ($user['page-flags'] == User::PAGE_FLAGS_FREELOVE) {
-                                       $fields['rel'] = Contact::FRIEND;
+                                       $fields['rel'] = self::FRIEND;
                                }
 
                                DBA::update('contact', $fields, $condition);
@@ -2455,7 +2543,7 @@ class Contact
                if (($contact['rel'] == self::FRIEND) || ($contact['rel'] == self::SHARING)) {
                        DBA::update('contact', ['rel' => self::SHARING], ['id' => $contact['id']]);
                } else {
-                       Contact::remove($contact['id']);
+                       self::remove($contact['id']);
                }
        }
 
@@ -2464,7 +2552,7 @@ class Contact
                if (($contact['rel'] == self::FRIEND) || ($contact['rel'] == self::FOLLOWER)) {
                        DBA::update('contact', ['rel' => self::FOLLOWER], ['id' => $contact['id']]);
                } else {
-                       Contact::remove($contact['id']);
+                       self::remove($contact['id']);
                }
        }
 
@@ -2485,8 +2573,8 @@ class Contact
                        AND NOT `contact`.`blocked`
                        AND NOT `contact`.`archive`
                        AND NOT `contact`.`deleted`',
-                       Contact::SHARING,
-                       Contact::FRIEND
+                       self::SHARING,
+                       self::FRIEND
                ];
 
                $contacts = DBA::select('contact', ['id', 'uid', 'name', 'url', 'bd'], $condition);
@@ -2521,7 +2609,7 @@ class Contact
                        return [];
                }
 
-               $contacts = Contact::selectToArray(['id'], [
+               $contacts = self::selectToArray(['id'], [
                        'id'      => $contact_ids,
                        'blocked' => false,
                        'pending' => false,
@@ -2689,7 +2777,7 @@ class Contact
 
                // check if we search only communities or every contact
                if ($mode === 'community') {
-                       $extra_sql = sprintf(' AND `contact-type` = %d', Contact::TYPE_COMMUNITY);
+                       $extra_sql = sprintf(' AND `contact-type` = %d', self::TYPE_COMMUNITY);
                } else {
                        $extra_sql = '';
                }
@@ -2722,7 +2810,7 @@ class Contact
                $count = 0;
 
                foreach ($urls as $url) {
-                       $contact = Contact::getByURL($url, false, ['id', 'updated']);
+                       $contact = self::getByURL($url, false, ['id', 'updated']);
                        if (empty($contact['id'])) {
                                Worker::add(PRIORITY_LOW, 'AddContact', 0, $url);
                                ++$added;