use Friendica\Protocol\OStatus;
use Friendica\Protocol\PortableContact;
use Friendica\Protocol\Salmon;
+use Friendica\Util\BaseURL;
use Friendica\Util\DateTimeFormat;
use Friendica\Util\Network;
use Friendica\Util\Strings;
/// @todo Verify if we can't use Contact::getDetailsByUrl instead of the following
// We first try the nurl (http://server.tld/nick), most common case
- $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated'], ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false]);
+ $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false]);
// Then the addr (nick@server.tld)
if (!DBA::isResult($contact)) {
- $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated'], ['addr' => $url, 'uid' => $uid, 'deleted' => false]);
+ $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['addr' => $url, 'uid' => $uid, 'deleted' => false]);
}
// Then the alias (which could be anything)
// The link could be provided as http although we stored it as https
$ssl_url = str_replace('http://', 'https://', $url);
$condition = ['`alias` IN (?, ?, ?) AND `uid` = ? AND NOT `deleted`', $url, Strings::normaliseLink($url), $ssl_url, $uid];
- $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated'], $condition);
+ $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], $condition);
}
if (DBA::isResult($contact)) {
}
// Update the contact in the background if needed but it is called by the frontend
- if ($update_contact && $no_update) {
+ if ($update_contact && $no_update && in_array($contact['network'], Protocol::NATIVE_SUPPORT)) {
Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id);
}
return 0;
}
- if (!$contact_id && ($data["alias"] != '') && ($data["alias"] != $url) && !$in_loop) {
+ if (!$contact_id && !empty($data['alias']) && ($data['alias'] != $url) && !$in_loop) {
$contact_id = self::getIdForURL($data["alias"], $uid, true, $default, true);
}
$fields = [
'uid' => $uid,
'created' => DateTimeFormat::utcNow(),
- 'url' => $data["url"],
- 'nurl' => Strings::normaliseLink($data["url"]),
- 'addr' => $data["addr"],
- 'alias' => $data["alias"],
- 'notify' => $data["notify"],
- 'poll' => $data["poll"],
- 'name' => $data["name"],
- 'nick' => $data["nick"],
- 'photo' => $data["photo"],
- 'keywords' => $data["keywords"],
- 'location' => $data["location"],
- 'about' => $data["about"],
- 'network' => $data["network"],
- 'pubkey' => $data["pubkey"],
+ 'url' => $data['url'],
+ 'nurl' => Strings::normaliseLink($data['url']),
+ 'addr' => defaults($data, 'addr', ''),
+ 'alias' => defaults($data, 'alias', ''),
+ 'notify' => defaults($data, 'notify', ''),
+ 'poll' => defaults($data, 'poll', ''),
+ 'name' => defaults($data, 'name', ''),
+ 'nick' => defaults($data, 'nick', ''),
+ 'photo' => defaults($data, 'photo', ''),
+ 'keywords' => defaults($data, 'keywords', ''),
+ 'location' => defaults($data, 'location', ''),
+ 'about' => defaults($data, 'about', ''),
+ 'network' => $data['network'],
+ 'pubkey' => defaults($data, 'pubkey', ''),
'rel' => self::SHARING,
- 'priority' => $data["priority"],
- 'batch' => $data["batch"],
- 'request' => $data["request"],
- 'confirm' => $data["confirm"],
- 'poco' => $data["poco"],
+ 'priority' => defaults($data, 'priority', 0),
+ 'batch' => defaults($data, 'batch', ''),
+ 'request' => defaults($data, 'request', ''),
+ 'confirm' => defaults($data, 'confirm', ''),
+ 'poco' => defaults($data, 'poco', ''),
'name-date' => DateTimeFormat::utcNow(),
'uri-date' => DateTimeFormat::utcNow(),
'avatar-date' => DateTimeFormat::utcNow(),
$gcontact = DBA::selectFirst('gcontact', ['location', 'about', 'keywords', 'gender'], ['nurl' => Strings::normaliseLink($data["url"])]);
if (DBA::isResult($gcontact)) {
// Only use the information when the probing hadn't fetched these values
- if ($data['keywords'] != '') {
+ if (!empty($data['keywords'])) {
unset($gcontact['keywords']);
}
- if ($data['location'] != '') {
+ if (!empty($data['location'])) {
unset($gcontact['location']);
}
- if ($data['about'] != '') {
+ if (!empty($data['about'])) {
unset($gcontact['about']);
}
DBA::update('contact', $gcontact, ['id' => $contact_id]);
}
}
- self::updateAvatar($data["photo"], $uid, $contact_id);
+ if (!empty($data['photo'])) {
+ self::updateAvatar($data['photo'], $uid, $contact_id);
+ }
$fields = ['url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date', 'pubkey'];
$contact = DBA::selectFirst('contact', $fields, ['id' => $contact_id]);
}
$updated = ['addr' => $data['addr'],
- 'alias' => $data['alias'],
+ 'alias' => defaults($data, 'alias', ''),
'url' => $data['url'],
'nurl' => Strings::normaliseLink($data['url']),
'name' => $data['name'],
'nick' => $data['nick']];
- if ($data['keywords'] != '') {
+ if (!empty($data['keywords'])) {
$updated['keywords'] = $data['keywords'];
}
- if ($data['location'] != '') {
+ if (!empty($data['location'])) {
$updated['location'] = $data['location'];
}
// Update the technical stuff as well - if filled
- if ($data['notify'] != '') {
+ if (!empty($data['notify'])) {
$updated['notify'] = $data['notify'];
}
- if ($data['poll'] != '') {
+ if (!empty($data['poll'])) {
$updated['poll'] = $data['poll'];
}
- if ($data['batch'] != '') {
+ if (!empty($data['batch'])) {
$updated['batch'] = $data['batch'];
}
- if ($data['request'] != '') {
+ if (!empty($data['request'])) {
$updated['request'] = $data['request'];
}
- if ($data['confirm'] != '') {
+ if (!empty($data['confirm'])) {
$updated['confirm'] = $data['confirm'];
}
- if ($data['poco'] != '') {
+ if (!empty($data['poco'])) {
$updated['poco'] = $data['poco'];
}
$updated['pubkey'] = $data['pubkey'];
}
- if (($data["addr"] != $contact["addr"]) || ($data["alias"] != $contact["alias"])) {
+ if (($data['addr'] != $contact['addr']) || (!empty($data['alias']) && ($data['alias'] != $contact['alias']))) {
$updated['uri-date'] = DateTimeFormat::utcNow();
}
if (($data["name"] != $contact["name"]) || ($data["nick"] != $contact["nick"])) {
$ret = Probe::uri($contact['url'], $network, $uid, !$force);
// If Probe::uri fails the network code will be different (mostly "feed" or "unkn")
- if ((in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM])) && ($ret['network'] != $contact['network'])) {
+ if (in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM]) && ($ret['network'] != $contact['network'])) {
+ return false;
+ }
+
+ if (!in_array($ret['network'], Protocol::NATIVE_SUPPORT)) {
return false;
}
public static function updateSslPolicy(array $contact, $new_policy)
{
$ssl_changed = false;
- if ((intval($new_policy) == SSL_POLICY_SELFSIGN || $new_policy === 'self') && strstr($contact['url'], 'https:')) {
+ if ((intval($new_policy) == BaseURL::SSL_POLICY_SELFSIGN || $new_policy === 'self') && strstr($contact['url'], 'https:')) {
$ssl_changed = true;
$contact['url'] = str_replace('https:', 'http:', $contact['url']);
$contact['request'] = str_replace('https:', 'http:', $contact['request']);
$contact['poco'] = str_replace('https:', 'http:', $contact['poco']);
}
- if ((intval($new_policy) == SSL_POLICY_FULL || $new_policy === 'full') && strstr($contact['url'], 'http:')) {
+ if ((intval($new_policy) == BaseURL::SSL_POLICY_FULL || $new_policy === 'full') && strstr($contact['url'], 'http:')) {
$ssl_changed = true;
$contact['url'] = str_replace('http:', 'https:', $contact['url']);
$contact['request'] = str_replace('http:', 'https:', $contact['request']);
projects / friendica.git / blobdiff