]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/Contact.php
Merge pull request #6989 from nupplaphil/task/basePath_baseUrl_fix
[friendica.git] / src / Model / Contact.php
index 47b2a8b1e614eaeee98af9070a0fa0d4135cc3f2..85d1bfe9adf0634ba313e9d02022f43ed1a8a9dd 100644 (file)
@@ -22,6 +22,7 @@ use Friendica\Protocol\Diaspora;
 use Friendica\Protocol\OStatus;
 use Friendica\Protocol\PortableContact;
 use Friendica\Protocol\Salmon;
+use Friendica\Util\BaseURL;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\Strings;
@@ -599,7 +600,10 @@ class Contact extends BaseObject
                }
 
                if ($update) {
-                       $fields['name-date'] = DateTimeFormat::utcNow();
+                       if ($fields['name'] != $self['name']) {
+                               $fields['name-date'] = DateTimeFormat::utcNow();
+                       }
+                       $fields['updated'] = DateTimeFormat::utcNow();
                        DBA::update('contact', $fields, ['id' => $self['id']]);
 
                        // Update the public contact as well
@@ -1118,11 +1122,12 @@ class Contact extends BaseObject
         * Have a look at all contact tables for a given profile url.
         * This function works as a replacement for probing the contact.
         *
-        * @param string $url Contact URL
+        * @param string  $url Contact URL
+        * @param integer $cid Contact ID
         *
         * @return array Contact array in the "probe" structure
        */
-       private static function getProbeDataFromDatabase($url)
+       private static function getProbeDataFromDatabase($url, $cid)
        {
                // The link could be provided as http although we stored it as https
                $ssl_url = str_replace('http://', 'https://', $url);
@@ -1130,9 +1135,17 @@ class Contact extends BaseObject
                $fields = ['url', 'addr', 'alias', 'notify', 'poll', 'name', 'nick',
                        'photo', 'keywords', 'location', 'about', 'network',
                        'priority', 'batch', 'request', 'confirm', 'poco'];
+
+               if (!empty($cid)) {
+                       $data = DBA::selectFirst('contact', $fields, ['id' => $cid]);
+                       if (DBA::isResult($data)) {
+                               return $data;
+                       }
+               }
+
                $data = DBA::selectFirst('contact', $fields, ['nurl' => Strings::normaliseLink($url)]);
 
-               if (!DBA::isResult($contact)) {
+               if (!DBA::isResult($data)) {
                        $condition = ['alias' => [$url, Strings::normaliseLink($url), $ssl_url]];
                        $data = DBA::selectFirst('contact', $fields, $condition);
                }
@@ -1147,7 +1160,7 @@ class Contact extends BaseObject
                        'photo', 'keywords', 'location', 'about', 'network'];
                $data = DBA::selectFirst('gcontact', $fields, ['nurl' => Strings::normaliseLink($url)]);
 
-               if (!DBA::isResult($contact)) {
+               if (!DBA::isResult($data)) {
                        $condition = ['alias' => [$url, Strings::normaliseLink($url), $ssl_url]];
                        $data = DBA::selectFirst('contact', $fields, $condition);
                }
@@ -1172,7 +1185,7 @@ class Contact extends BaseObject
                        'photo', 'network', 'priority', 'batch', 'request', 'confirm'];
                $data = DBA::selectFirst('fcontact', $fields, ['url' => $url]);
 
-               if (!DBA::isResult($contact)) {
+               if (!DBA::isResult($data)) {
                        $condition = ['alias' => [$url, Strings::normaliseLink($url), $ssl_url]];
                        $data = DBA::selectFirst('contact', $fields, $condition);
                }
@@ -1229,11 +1242,11 @@ class Contact extends BaseObject
 
                /// @todo Verify if we can't use Contact::getDetailsByUrl instead of the following
                // We first try the nurl (http://server.tld/nick), most common case
-               $contact = DBA::selectFirst('contact', ['id', 'avatar', 'avatar-date'], ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false]);
+               $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['nurl' => Strings::normaliseLink($url), 'uid' => $uid, 'deleted' => false]);
 
                // Then the addr (nick@server.tld)
                if (!DBA::isResult($contact)) {
-                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'avatar-date'], ['addr' => $url, 'uid' => $uid, 'deleted' => false]);
+                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], ['addr' => $url, 'uid' => $uid, 'deleted' => false]);
                }
 
                // Then the alias (which could be anything)
@@ -1241,20 +1254,25 @@ class Contact extends BaseObject
                        // The link could be provided as http although we stored it as https
                        $ssl_url = str_replace('http://', 'https://', $url);
                        $condition = ['`alias` IN (?, ?, ?) AND `uid` = ? AND NOT `deleted`', $url, Strings::normaliseLink($url), $ssl_url, $uid];
-                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'avatar-date'], $condition);
+                       $contact = DBA::selectFirst('contact', ['id', 'avatar', 'updated', 'network'], $condition);
                }
 
                if (DBA::isResult($contact)) {
                        $contact_id = $contact["id"];
 
                        // Update the contact every 7 days
-                       $update_contact = ($contact['avatar-date'] < DateTimeFormat::utc('now -7 days'));
+                       $update_contact = ($contact['updated'] < DateTimeFormat::utc('now -7 days'));
 
                        // We force the update if the avatar is empty
                        if (empty($contact['avatar'])) {
                                $update_contact = true;
                        }
 
+                       // Update the contact in the background if needed but it is called by the frontend
+                       if ($update_contact && $no_update && in_array($contact['network'], Protocol::NATIVE_SUPPORT)) {
+                               Worker::add(PRIORITY_LOW, "UpdateContact", $contact_id);
+                       }
+
                        if (!$update_contact || $no_update) {
                                return $contact_id;
                        }
@@ -1265,7 +1283,7 @@ class Contact extends BaseObject
 
                // When we don't want to update, we look if we know this contact in any way
                if ($no_update && empty($default)) {
-                       $data = self::getProbeDataFromDatabase($url);
+                       $data = self::getProbeDataFromDatabase($url, $contact_id);
                        $background_update = true;
                } else {
                        $data = [];
@@ -1287,20 +1305,19 @@ class Contact extends BaseObject
                                return 0;
                        }
 
-                       if (!empty($default)) {
-                               $contact = $default;
-                       } else {
-                               $contact = self::getProbeDataFromDatabase($url);
-                       }
-
-                       if (!empty($contact)) {
+                       $contact = array_merge(self::getProbeDataFromDatabase($url, $contact_id), $default);
+                       if (empty($contact)) {
                                return 0;
-                       } else {
-                               $data = array_merge($data, $contact);
                        }
+
+                       $data = array_merge($data, $contact);
+               }
+
+               if (empty($data)) {
+                       return 0;
                }
 
-               if (!$contact_id && ($data["alias"] != '') && ($data["alias"] != $url) && !$in_loop) {
+               if (!$contact_id && !empty($data['alias']) && ($data['alias'] != $url) && !$in_loop) {
                        $contact_id = self::getIdForURL($data["alias"], $uid, true, $default, true);
                }
 
@@ -1308,26 +1325,26 @@ class Contact extends BaseObject
                        $fields = [
                                'uid'       => $uid,
                                'created'   => DateTimeFormat::utcNow(),
-                               'url'       => $data["url"],
-                               'nurl'      => Strings::normaliseLink($data["url"]),
-                               'addr'      => $data["addr"],
-                               'alias'     => $data["alias"],
-                               'notify'    => $data["notify"],
-                               'poll'      => $data["poll"],
-                               'name'      => $data["name"],
-                               'nick'      => $data["nick"],
-                               'photo'     => $data["photo"],
-                               'keywords'  => $data["keywords"],
-                               'location'  => $data["location"],
-                               'about'     => $data["about"],
-                               'network'   => $data["network"],
-                               'pubkey'    => $data["pubkey"],
+                               'url'       => $data['url'],
+                               'nurl'      => Strings::normaliseLink($data['url']),
+                               'addr'      => defaults($data, 'addr', ''),
+                               'alias'     => defaults($data, 'alias', ''),
+                               'notify'    => defaults($data, 'notify', ''),
+                               'poll'      => defaults($data, 'poll', ''),
+                               'name'      => defaults($data, 'name', ''),
+                               'nick'      => defaults($data, 'nick', ''),
+                               'photo'     => defaults($data, 'photo', ''),
+                               'keywords'  => defaults($data, 'keywords', ''),
+                               'location'  => defaults($data, 'location', ''),
+                               'about'     => defaults($data, 'about', ''),
+                               'network'   => $data['network'],
+                               'pubkey'    => defaults($data, 'pubkey', ''),
                                'rel'       => self::SHARING,
-                               'priority'  => $data["priority"],
-                               'batch'     => $data["batch"],
-                               'request'   => $data["request"],
-                               'confirm'   => $data["confirm"],
-                               'poco'      => $data["poco"],
+                               'priority'  => defaults($data, 'priority', 0),
+                               'batch'     => defaults($data, 'batch', ''),
+                               'request'   => defaults($data, 'request', ''),
+                               'confirm'   => defaults($data, 'confirm', ''),
+                               'poco'      => defaults($data, 'poco', ''),
                                'name-date' => DateTimeFormat::utcNow(),
                                'uri-date'  => DateTimeFormat::utcNow(),
                                'avatar-date' => DateTimeFormat::utcNow(),
@@ -1357,13 +1374,13 @@ class Contact extends BaseObject
                        $gcontact = DBA::selectFirst('gcontact', ['location', 'about', 'keywords', 'gender'], ['nurl' => Strings::normaliseLink($data["url"])]);
                        if (DBA::isResult($gcontact)) {
                                // Only use the information when the probing hadn't fetched these values
-                               if ($data['keywords'] != '') {
+                               if (!empty($data['keywords'])) {
                                        unset($gcontact['keywords']);
                                }
-                               if ($data['location'] != '') {
+                               if (!empty($data['location'])) {
                                        unset($gcontact['location']);
                                }
-                               if ($data['about'] != '') {
+                               if (!empty($data['about'])) {
                                        unset($gcontact['about']);
                                }
                                DBA::update('contact', $gcontact, ['id' => $contact_id]);
@@ -1377,7 +1394,9 @@ class Contact extends BaseObject
                        }
                }
 
-               self::updateAvatar($data["photo"], $uid, $contact_id);
+               if (!empty($data['photo'])) {
+                       self::updateAvatar($data['photo'], $uid, $contact_id);
+               }
 
                $fields = ['url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date', 'pubkey'];
                $contact = DBA::selectFirst('contact', $fields, ['id' => $contact_id]);
@@ -1388,36 +1407,36 @@ class Contact extends BaseObject
                }
 
                $updated = ['addr' => $data['addr'],
-                       'alias' => $data['alias'],
+                       'alias' => defaults($data, 'alias', ''),
                        'url' => $data['url'],
                        'nurl' => Strings::normaliseLink($data['url']),
                        'name' => $data['name'],
                        'nick' => $data['nick']];
 
-               if ($data['keywords'] != '') {
+               if (!empty($data['keywords'])) {
                        $updated['keywords'] = $data['keywords'];
                }
-               if ($data['location'] != '') {
+               if (!empty($data['location'])) {
                        $updated['location'] = $data['location'];
                }
 
                // Update the technical stuff as well - if filled
-               if ($data['notify'] != '') {
+               if (!empty($data['notify'])) {
                        $updated['notify'] = $data['notify'];
                }
-               if ($data['poll'] != '') {
+               if (!empty($data['poll'])) {
                        $updated['poll'] = $data['poll'];
                }
-               if ($data['batch'] != '') {
+               if (!empty($data['batch'])) {
                        $updated['batch'] = $data['batch'];
                }
-               if ($data['request'] != '') {
+               if (!empty($data['request'])) {
                        $updated['request'] = $data['request'];
                }
-               if ($data['confirm'] != '') {
+               if (!empty($data['confirm'])) {
                        $updated['confirm'] = $data['confirm'];
                }
-               if ($data['poco'] != '') {
+               if (!empty($data['poco'])) {
                        $updated['poco'] = $data['poco'];
                }
 
@@ -1426,14 +1445,14 @@ class Contact extends BaseObject
                        $updated['pubkey'] = $data['pubkey'];
                }
 
-               if (($data["addr"] != $contact["addr"]) || ($data["alias"] != $contact["alias"])) {
+               if (($data['addr'] != $contact['addr']) || (!empty($data['alias']) && ($data['alias'] != $contact['alias']))) {
                        $updated['uri-date'] = DateTimeFormat::utcNow();
                }
                if (($data["name"] != $contact["name"]) || ($data["nick"] != $contact["nick"])) {
                        $updated['name-date'] = DateTimeFormat::utcNow();
                }
 
-               $updated['avatar-date'] = DateTimeFormat::utcNow();
+               $updated['updated'] = DateTimeFormat::utcNow();
 
                DBA::update('contact', $updated, ['id' => $contact_id], $contact);
 
@@ -1710,7 +1729,11 @@ class Contact extends BaseObject
                $ret = Probe::uri($contact['url'], $network, $uid, !$force);
 
                // If Probe::uri fails the network code will be different (mostly "feed" or "unkn")
-               if ((in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM])) && ($ret['network'] != $contact['network'])) {
+               if (in_array($ret['network'], [Protocol::FEED, Protocol::PHANTOM]) && ($ret['network'] != $contact['network'])) {
+                       return false;
+               }
+
+               if (!in_array($ret['network'], Protocol::NATIVE_SUPPORT)) {
                        return false;
                }
 
@@ -1732,6 +1755,7 @@ class Contact extends BaseObject
                }
 
                $ret['nurl'] = Strings::normaliseLink($ret['url']);
+               $ret['updated'] = DateTimeFormat::utcNow();
 
                self::updateAvatar($ret['photo'], $uid, $id, true);
 
@@ -1986,7 +2010,7 @@ class Contact extends BaseObject
        public static function updateSslPolicy(array $contact, $new_policy)
        {
                $ssl_changed = false;
-               if ((intval($new_policy) == SSL_POLICY_SELFSIGN || $new_policy === 'self') && strstr($contact['url'], 'https:')) {
+               if ((intval($new_policy) == BaseURL::SSL_POLICY_SELFSIGN || $new_policy === 'self') && strstr($contact['url'], 'https:')) {
                        $ssl_changed = true;
                        $contact['url']     =   str_replace('https:', 'http:', $contact['url']);
                        $contact['request'] =   str_replace('https:', 'http:', $contact['request']);
@@ -1996,7 +2020,7 @@ class Contact extends BaseObject
                        $contact['poco']    =   str_replace('https:', 'http:', $contact['poco']);
                }
 
-               if ((intval($new_policy) == SSL_POLICY_FULL || $new_policy === 'full') && strstr($contact['url'], 'http:')) {
+               if ((intval($new_policy) == BaseURL::SSL_POLICY_FULL || $new_policy === 'full') && strstr($contact['url'], 'http:')) {
                        $ssl_changed = true;
                        $contact['url']     =   str_replace('http:', 'https:', $contact['url']);
                        $contact['request'] =   str_replace('http:', 'https:', $contact['request']);