]> git.mxchange.org Git - friendica.git/blobdiff - src/Model/GContact.php
Added documentation
[friendica.git] / src / Model / GContact.php
index 44d1edecd78c5dcdf2cec638600e7e8993ee4178..23415d1078671192b6ae1faba750a3bd3e1c0d3c 100644 (file)
@@ -19,8 +19,6 @@ use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\Strings;
 
-require_once 'include/dba.php';
-
 /**
  * @brief This class handles GlobalContact related functions
  */
@@ -33,6 +31,7 @@ class GContact
         * @param string $mode   Search mode (e.g. "community")
         *
         * @return array with search results
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function searchByName($search, $mode = '')
        {
@@ -93,6 +92,7 @@ class GContact
         * @param integer $cid  Contact ID
         * @param integer $zcid Global Contact ID
         * @return void
+        * @throws Exception
         */
        public static function link($gcid, $uid = 0, $cid = 0, $zcid = 0)
        {
@@ -107,16 +107,16 @@ class GContact
        /**
         * @brief Sanitize the given gcontact data
         *
-        * @param array $gcontact array with gcontact data
-        * @throw Exception
-        *
         * Generation:
         *  0: No definition
         *  1: Profiles on this server
         *  2: Contacts of profiles on this server
         *  3: Contacts of contacts of profiles on this server
         *  4: ...
+        *
+        * @param array $gcontact array with gcontact data
         * @return array $gcontact
+        * @throws Exception
         */
        public static function sanitize($gcontact)
        {
@@ -140,7 +140,7 @@ class GContact
                }
 
                // Assure that there are no parameter fragments in the profile url
-               if (in_array($gcontact['network'], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, ""])) {
+               if (empty($gcontact["network"]) || in_array($gcontact["network"], Protocol::FEDERATED)) {
                        $gcontact['url'] = self::cleanContactUrl($gcontact['url']);
                }
 
@@ -216,13 +216,13 @@ class GContact
                        throw new Exception('No name and photo for URL '.$gcontact['url']);
                }
 
-               if (!in_array($gcontact['network'], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::OSTATUS, Protocol::DIASPORA])) {
+               if (!in_array($gcontact['network'], Protocol::FEDERATED)) {
                        throw new Exception('No federated network ('.$gcontact['network'].') detected for URL '.$gcontact['url']);
                }
 
                if (!isset($gcontact['server_url'])) {
                        // We check the server url to be sure that it is a real one
-                       $server_url = PortableContact::detectServer($gcontact['url']);
+                       $server_url = Contact::getBasepath($gcontact['url']);
 
                        // We are now sure that it is a correct URL. So we use it in the future
                        if ($server_url != "") {
@@ -231,7 +231,7 @@ class GContact
                }
 
                // The server URL doesn't seem to be valid, so we don't store it.
-               if (!PortableContact::checkServer($gcontact['server_url'], $gcontact['network'])) {
+               if (!GServer::check($gcontact['server_url'], $gcontact['network'])) {
                        $gcontact['server_url'] = "";
                }
 
@@ -242,6 +242,7 @@ class GContact
         * @param integer $uid id
         * @param integer $cid id
         * @return integer
+        * @throws Exception
         */
        public static function countCommonFriends($uid, $cid)
        {
@@ -269,6 +270,7 @@ class GContact
         * @param integer $uid  id
         * @param integer $zcid zcid
         * @return integer
+        * @throws Exception
         */
        public static function countCommonFriendsZcid($uid, $zcid)
        {
@@ -295,6 +297,7 @@ class GContact
         * @param integer $limit   optional, default 9999
         * @param boolean $shuffle optional, default false
         * @return object
+        * @throws Exception
         */
        public static function commonFriends($uid, $cid, $start = 0, $limit = 9999, $shuffle = false)
        {
@@ -333,6 +336,7 @@ class GContact
         * @param integer $limit   optional, default 9999
         * @param boolean $shuffle optional, default false
         * @return object
+        * @throws Exception
         */
        public static function commonFriendsZcid($uid, $zcid, $start = 0, $limit = 9999, $shuffle = false)
        {
@@ -362,6 +366,7 @@ class GContact
         * @param integer $uid user
         * @param integer $cid cid
         * @return integer
+        * @throws Exception
         */
        public static function countAllFriends($uid, $cid)
        {
@@ -387,6 +392,7 @@ class GContact
         * @param integer $start optional, default 0
         * @param integer $limit optional, default 80
         * @return array
+        * @throws Exception
         */
        public static function allFriends($uid, $cid, $start = 0, $limit = 80)
        {
@@ -410,10 +416,11 @@ class GContact
        }
 
        /**
-        * @param object  $uid   user
+        * @param int     $uid   user
         * @param integer $start optional, default 0
         * @param integer $limit optional, default 80
         * @return array
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function suggestionQuery($uid, $start = 0, $limit = 80)
        {
@@ -517,11 +524,10 @@ class GContact
 
        /**
         * @return void
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
         */
        public static function updateSuggestions()
        {
-               $a = get_app();
-
                $done = [];
 
                /// @TODO Check if it is really neccessary to poll the own server
@@ -535,7 +541,7 @@ class GContact
                                $j = json_decode($x);
                                if (!empty($j->entries)) {
                                        foreach ($j->entries as $entry) {
-                                               PortableContact::checkServer($entry->url);
+                                               GServer::check($entry->url);
 
                                                $url = $entry->url . '/poco';
                                                if (!in_array($url, $done)) {
@@ -570,6 +576,7 @@ class GContact
         * @param string $url Contact url
         *
         * @return string Contact url with the wanted parts
+        * @throws Exception
         */
        public static function cleanContactUrl($url)
        {
@@ -601,6 +608,8 @@ class GContact
         *
         * @param array $contact contact array (called by reference)
         * @return void
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function fixAlternateContactAddress(&$contact)
        {
@@ -622,6 +631,8 @@ class GContact
         * @param array $contact contact array
         *
         * @return bool|int Returns false if not found, integer if contact was found
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function getId($contact)
        {
@@ -653,7 +664,7 @@ class GContact
                self::fixAlternateContactAddress($contact);
 
                // Remove unwanted parts from the contact url (e.g. "?zrl=...")
-               if (in_array($contact["network"], [Protocol::ACTIVITYPUB, Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS])) {
+               if (in_array($contact["network"], Protocol::FEDERATED)) {
                        $contact["url"] = self::cleanContactUrl($contact["url"]);
                }
 
@@ -717,6 +728,8 @@ class GContact
         * @param array $contact contact array
         *
         * @return bool|int Returns false if not found, integer if contact was found
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function update($contact)
        {
@@ -733,158 +746,243 @@ class GContact
                        return false;
                }
 
-               $public_contact = q(
-                       "SELECT `name`, `nick`, `photo`, `location`, `about`, `addr`, `generation`, `birthday`, `gender`, `keywords`,
-                               `contact-type`, `hide`, `nsfw`, `network`, `alias`, `notify`, `server_url`, `connect`, `updated`, `url`
-                       FROM `gcontact` WHERE `id` = %d LIMIT 1",
-                       intval($gcontact_id)
-               );
+               $public_contact = DBA::selectFirst('gcontact', [
+                       'name', 'nick', 'photo', 'location', 'about', 'addr', 'generation', 'birthday', 'gender', 'keywords',
+                       'contact-type', 'hide', 'nsfw', 'network', 'alias', 'notify', 'server_url', 'connect', 'updated', 'url'
+               ], ['id' => $gcontact_id]);
+
+               if (!DBA::isResult($public_contact)) {
+                       return false;
+               }
 
                // Get all field names
                $fields = [];
-               foreach ($public_contact[0] as $field => $data) {
+               foreach ($public_contact as $field => $data) {
                        $fields[$field] = $data;
                }
 
-               unset($fields["url"]);
-               unset($fields["updated"]);
-               unset($fields["hide"]);
+               unset($fields['url']);
+               unset($fields['updated']);
+               unset($fields['hide']);
 
                // Bugfix: We had an error in the storing of keywords which lead to the "0"
                // This value is still transmitted via poco.
-               if (!empty($contact["keywords"]) && ($contact["keywords"] == "0")) {
-                       unset($contact["keywords"]);
+               if (isset($contact['keywords']) && ($contact['keywords'] == '0')) {
+                       unset($contact['keywords']);
                }
 
-               if (!empty($public_contact[0]["keywords"]) && ($public_contact[0]["keywords"] == "0")) {
-                       $public_contact[0]["keywords"] = "";
+               if (isset($public_contact['keywords']) && ($public_contact['keywords'] == '0')) {
+                       $public_contact['keywords'] = '';
                }
 
                // assign all unassigned fields from the database entry
                foreach ($fields as $field => $data) {
-                       if (!isset($contact[$field]) || ($contact[$field] == "")) {
-                               $contact[$field] = $public_contact[0][$field];
+                       if (empty($contact[$field])) {
+                               $contact[$field] = $public_contact[$field];
                        }
                }
 
-               if (!isset($contact["hide"])) {
-                       $contact["hide"] = $public_contact[0]["hide"];
+               if (!isset($contact['hide'])) {
+                       $contact['hide'] = $public_contact['hide'];
                }
 
-               $fields["hide"] = $public_contact[0]["hide"];
+               $fields['hide'] = $public_contact['hide'];
 
-               if ($contact["network"] == Protocol::STATUSNET) {
-                       $contact["network"] = Protocol::OSTATUS;
+               if ($contact['network'] == Protocol::STATUSNET) {
+                       $contact['network'] = Protocol::OSTATUS;
                }
 
                // Replace alternate OStatus user format with the primary one
                self::fixAlternateContactAddress($contact);
 
-               if (!isset($contact["updated"])) {
-                       $contact["updated"] = DateTimeFormat::utcNow();
+               if (!isset($contact['updated'])) {
+                       $contact['updated'] = DateTimeFormat::utcNow();
                }
 
-               if ($contact["network"] == Protocol::TWITTER) {
-                       $contact["server_url"] = 'http://twitter.com';
+               if ($contact['network'] == Protocol::TWITTER) {
+                       $contact['server_url'] = 'http://twitter.com';
                }
 
-               if ($contact["server_url"] == "") {
-                       $data = Probe::uri($contact["url"]);
-                       if ($data["network"] != Protocol::PHANTOM) {
-                               $contact["server_url"] = $data['baseurl'];
+               if (empty($contact['server_url'])) {
+                       $data = Probe::uri($contact['url']);
+                       if ($data['network'] != Protocol::PHANTOM) {
+                               $contact['server_url'] = $data['baseurl'];
                        }
                } else {
-                       $contact["server_url"] = Strings::normaliseLink($contact["server_url"]);
+                       $contact['server_url'] = Strings::normaliseLink($contact['server_url']);
                }
 
-               if (($contact["addr"] == "") && ($contact["server_url"] != "") && ($contact["nick"] != "")) {
-                       $hostname = str_replace("http://", "", $contact["server_url"]);
-                       $contact["addr"] = $contact["nick"]."@".$hostname;
+               if (empty($contact['addr']) && !empty($contact['server_url']) && !empty($contact['nick'])) {
+                       $hostname = str_replace('http://', '', $contact['server_url']);
+                       $contact['addr'] = $contact['nick'] . '@' . $hostname;
                }
 
                // Check if any field changed
                $update = false;
-               unset($fields["generation"]);
+               unset($fields['generation']);
 
-               if ((($contact["generation"] > 0) && ($contact["generation"] <= $public_contact[0]["generation"])) || ($public_contact[0]["generation"] == 0)) {
+               if ((($contact['generation'] > 0) && ($contact['generation'] <= $public_contact['generation'])) || ($public_contact['generation'] == 0)) {
                        foreach ($fields as $field => $data) {
-                               if ($contact[$field] != $public_contact[0][$field]) {
-                                       Logger::log("Difference for contact ".$contact["url"]." in field '".$field."'. New value: '".$contact[$field]."', old value '".$public_contact[0][$field]."'", Logger::DEBUG);
+                               if ($contact[$field] != $public_contact[$field]) {
+                                       Logger::debug('Difference found.', ['contact' => $contact["url"], 'field' => $field, 'new' => $contact[$field], 'old' => $public_contact[$field]]);
                                        $update = true;
                                }
                        }
 
-                       if ($contact["generation"] < $public_contact[0]["generation"]) {
-                               Logger::log("Difference for contact ".$contact["url"]." in field 'generation'. new value: '".$contact["generation"]."', old value '".$public_contact[0]["generation"]."'", Logger::DEBUG);
+                       if ($contact['generation'] < $public_contact['generation']) {
+                               Logger::debug('Difference found.', ['contact' => $contact["url"], 'field' => 'generation', 'new' => $contact['generation'], 'old' => $public_contact['generation']]);
                                $update = true;
                        }
                }
 
                if ($update) {
-                       Logger::log("Update gcontact for ".$contact["url"], Logger::DEBUG);
+                       Logger::debug('Update gcontact.', ['contact' => $contact['url']]);
                        $condition = ['`nurl` = ? AND (`generation` = 0 OR `generation` >= ?)',
                                        Strings::normaliseLink($contact["url"]), $contact["generation"]];
                        $contact["updated"] = DateTimeFormat::utc($contact["updated"]);
 
-                       $updated = ['photo' => $contact['photo'], 'name' => $contact['name'],
-                                       'nick' => $contact['nick'], 'addr' => $contact['addr'],
-                                       'network' => $contact['network'], 'birthday' => $contact['birthday'],
-                                       'gender' => $contact['gender'], 'keywords' => $contact['keywords'],
-                                       'hide' => $contact['hide'], 'nsfw' => $contact['nsfw'],
-                                       'contact-type' => $contact['contact-type'], 'alias' => $contact['alias'],
-                                       'notify' => $contact['notify'], 'url' => $contact['url'],
-                                       'location' => $contact['location'], 'about' => $contact['about'],
-                                       'generation' => $contact['generation'], 'updated' => $contact['updated'],
-                                       'server_url' => $contact['server_url'], 'connect' => $contact['connect']];
+                       $updated = [
+                               'photo' => $contact['photo'], 'name' => $contact['name'],
+                               'nick' => $contact['nick'], 'addr' => $contact['addr'],
+                               'network' => $contact['network'], 'birthday' => $contact['birthday'],
+                               'gender' => $contact['gender'], 'keywords' => $contact['keywords'],
+                               'hide' => $contact['hide'], 'nsfw' => $contact['nsfw'],
+                               'contact-type' => $contact['contact-type'], 'alias' => $contact['alias'],
+                               'notify' => $contact['notify'], 'url' => $contact['url'],
+                               'location' => $contact['location'], 'about' => $contact['about'],
+                               'generation' => $contact['generation'], 'updated' => $contact['updated'],
+                               'server_url' => $contact['server_url'], 'connect' => $contact['connect']
+                       ];
 
                        DBA::update('gcontact', $updated, $condition, $fields);
+               }
 
-                       // Now update the contact entry with the user id "0" as well.
-                       // This is used for the shadow copies of public items.
-                       /// @todo Check if we really should do this.
-                       // The quality of the gcontact table is mostly lower than the public contact
-                       $public_contact = DBA::selectFirst('contact', ['id'], ['nurl' => Strings::normaliseLink($contact["url"]), 'uid' => 0]);
-                       if (DBA::isResult($public_contact)) {
-                               Logger::log("Update public contact ".$public_contact["id"], Logger::DEBUG);
-
-                               Contact::updateAvatar($contact["photo"], 0, $public_contact["id"]);
-
-                               $fields = ['name', 'nick', 'addr',
-                                               'network', 'bd', 'gender',
-                                               'keywords', 'alias', 'contact-type',
-                                               'url', 'location', 'about'];
-                               $old_contact = DBA::selectFirst('contact', $fields, ['id' => $public_contact["id"]]);
-
-                               // Update it with the current values
-                               $fields = ['name' => $contact['name'], 'nick' => $contact['nick'],
-                                               'addr' => $contact['addr'], 'network' => $contact['network'],
-                                               'bd' => $contact['birthday'], 'gender' => $contact['gender'],
-                                               'keywords' => $contact['keywords'], 'alias' => $contact['alias'],
-                                               'contact-type' => $contact['contact-type'], 'url' => $contact['url'],
-                                               'location' => $contact['location'], 'about' => $contact['about']];
-
-                               // Don't update the birthday field if not set or invalid
-                               if (empty($contact['birthday']) || ($contact['birthday'] <= DBA::NULL_DATE)) {
-                                       unset($fields['bd']);
-                               }
+               return $gcontact_id;
+       }
+
+       /**
+        * @brief Updates the gcontact entry from a given public contact id
+        *
+        * @param integer $cid contact id
+        * @return void
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
+        */
+       public static function updateFromPublicContactID($cid)
+       {
+               self::updateFromPublicContact(['id' => $cid]);
+       }
+
+       /**
+        * @brief Updates the gcontact entry from a given public contact url
+        *
+        * @param string $url contact url
+        * @return integer gcontact id
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
+        */
+       public static function updateFromPublicContactURL($url)
+       {
+               return self::updateFromPublicContact(['nurl' => Strings::normaliseLink($url)]);
+       }
 
+       /**
+        * @brief Helper function for updateFromPublicContactID and updateFromPublicContactURL
+        *
+        * @param array $condition contact condition
+        * @return integer gcontact id
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
+        */
+       private static function updateFromPublicContact($condition)
+       {
+               $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender',
+                       'bd', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archive', 'term-date',
+                       'created', 'updated', 'avatar', 'success_update', 'failure_update', 'forum', 'prv',
+                       'baseurl', 'sensitive', 'unsearchable'];
+
+               $contact = DBA::selectFirst('contact', $fields, array_merge($condition, ['uid' => 0, 'network' => Protocol::FEDERATED]));
+               if (!DBA::isResult($contact)) {
+                       return 0;
+               }
+
+               $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender', 'generation',
+                       'birthday', 'contact-type', 'network', 'addr', 'notify', 'alias', 'archived', 'archive_date',
+                       'created', 'updated', 'photo', 'last_contact', 'last_failure', 'community', 'connect',
+                       'server_url', 'nsfw', 'hide', 'id'];
+
+               $old_gcontact = DBA::selectFirst('gcontact', $fields, ['nurl' => $contact['nurl']]);
+               $do_insert = !DBA::isResult($old_gcontact);
+               if ($do_insert) {
+                       $old_gcontact = [];
+               }
+
+               $gcontact = [];
+
+               // These fields are identical in both contact and gcontact
+               $fields = ['name', 'nick', 'url', 'nurl', 'location', 'about', 'keywords', 'gender',
+                       'contact-type', 'network', 'addr', 'notify', 'alias', 'created', 'updated'];
+
+               foreach ($fields as $field) {
+                       $gcontact[$field] = $contact[$field];
+               }
+
+               // These fields are having different names but the same content
+               $gcontact['server_url'] = $contact['baseurl'] ?? ''; // "baseurl" can be null, "server_url" not
+               $gcontact['nsfw'] = $contact['sensitive'];
+               $gcontact['hide'] = $contact['unsearchable'];
+               $gcontact['archived'] = $contact['archive'];
+               $gcontact['archive_date'] = $contact['term-date'];
+               $gcontact['birthday'] = $contact['bd'];
+               $gcontact['photo'] = $contact['avatar'];
+               $gcontact['last_contact'] = $contact['success_update'];
+               $gcontact['last_failure'] = $contact['failure_update'];
+               $gcontact['community'] = ($contact['forum'] || $contact['prv']);
 
-                               DBA::update('contact', $fields, ['id' => $public_contact["id"]], $old_contact);
+               foreach (['last_contact', 'last_failure', 'updated'] as $field) {
+                       if (!empty($old_gcontact[$field]) && ($old_gcontact[$field] >= $gcontact[$field])) {
+                               unset($gcontact[$field]);
                        }
                }
 
-               return $gcontact_id;
+               if (!$gcontact['archived']) {
+                       $gcontact['archive_date'] = DBA::NULL_DATETIME;
+               }
+
+               if (!empty($old_gcontact['created']) && ($old_gcontact['created'] > DBA::NULL_DATETIME)
+                       && ($old_gcontact['created'] <= $gcontact['created'])) {
+                       unset($gcontact['created']);
+               }
+
+               if (empty($gcontact['birthday']) && ($gcontact['birthday'] <= DBA::NULL_DATETIME)) {
+                       unset($gcontact['birthday']);
+               }
+
+               if (empty($old_gcontact['generation']) || ($old_gcontact['generation'] > 2)) {
+                       $gcontact['generation'] = 2; // We fetched the data directly from the other server
+               }
+
+               if (!$do_insert) {
+                       DBA::update('gcontact', $gcontact, ['nurl' => $contact['nurl']], $old_gcontact);
+                       return $old_gcontact['id'];
+               } elseif (!$gcontact['archived']) {
+                       DBA::insert('gcontact', $gcontact);
+                       return DBA::lastInsertId();
+               }
        }
 
        /**
         * @brief Updates the gcontact entry from probe
         *
-        * @param string $url profile link
+        * @param string  $url   profile link
+        * @param boolean $force Optional forcing of network probing (otherwise we use the cached data)
         * @return void
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
-       public static function updateFromProbe($url)
+       public static function updateFromProbe($url, $force = false)
        {
-               $data = Probe::uri($url);
+               $data = Probe::uri($url, $force);
 
                if (in_array($data["network"], [Protocol::PHANTOM])) {
                        Logger::log("Invalid network for contact url ".$data["url"]." - Called by: ".System::callstack(), Logger::DEBUG);
@@ -900,7 +998,9 @@ class GContact
         * @brief Update the gcontact entry for a given user id
         *
         * @param int $uid User ID
-        * @return void
+        * @return bool
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function updateForUser($uid)
        {
@@ -951,7 +1051,9 @@ class GContact
         * If the "Statistics" addon is enabled (See http://gstools.org/ for details) we query user data with this.
         *
         * @param string $server Server address
-        * @return void
+        * @return bool
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function fetchGsUsers($server)
        {
@@ -1011,6 +1113,8 @@ class GContact
        /**
         * @brief Asking GNU Social server on a regular base for their user data
         * @return void
+        * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+        * @throws \ImagickException
         */
        public static function discoverGsUsers()
        {
@@ -1018,11 +1122,16 @@ class GContact
 
                $last_update = date("c", time() - (60 * 60 * 24 * $requery_days));
 
-               $r = q(
-                       "SELECT `nurl`, `url` FROM `gserver` WHERE `last_contact` >= `last_failure` AND `network` = '%s' AND `last_poco_query` < '%s' ORDER BY RAND() LIMIT 5",
-                       DBA::escape(Protocol::OSTATUS),
-                       DBA::escape($last_update)
-               );
+               $r = DBA::select('gserver', ['nurl', 'url'], [
+                       '`network` = ?
+                       AND `last_contact` >= `last_failure`
+                       AND `last_poco_query` < ?',
+                       Protocol::OSTATUS,
+                       $last_update
+               ], [
+                       'limit' => 5,
+                       'order' => ['RAND()']
+               ]);
 
                if (!DBA::isResult($r)) {
                        return;
@@ -1035,20 +1144,23 @@ class GContact
        }
 
        /**
-        * @return string
+        * Returns a random, global contact of the current node
+        *
+        * @return string The profile URL
+        * @throws Exception
         */
        public static function getRandomUrl()
        {
-               $r = q(
-                       "SELECT `url` FROM `gcontact` WHERE `network` = '%s'
-                                       AND `last_contact` >= `last_failure`
-                                       AND `updated` > UTC_TIMESTAMP - INTERVAL 1 MONTH
-                               ORDER BY rand() LIMIT 1",
-                       DBA::escape(Protocol::DFRN)
-               );
+               $r = DBA::selectFirst('gcontact', ['url'], [
+                       '`network` = ? 
+                       AND `last_contact` >= `last_failure`  
+                       AND `updated` > ?',
+                       Protocol::DFRN,
+                       DateTimeFormat::utc('now - 1 month'),
+               ], ['order' => ['RAND()']]);
 
                if (DBA::isResult($r)) {
-                       return dirname($r[0]['url']);
+                       return $r['url'];
                }
 
                return '';